On Jun 1, 2022, at 2:25 AM, Raffaello Giulietti
mailto:d...@openjdk.java.net>> wrote:
On Tue, 31 May 2022 21:57:44 GMT, Brian Burkhalter
mailto:b...@openjdk.org>> wrote:
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
On Tue, 31 May 2022 22:34:11 GMT, Naoto Sato wrote:
>> Gaurav Chaudhari has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285838: Corrected month comparison check for TZ DST
>
> I tried out your patch on my local Linux machine, but the
On Mon, 7 Mar 2022 15:11:50 GMT, Сергей Цыпанов wrote:
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()`
On Wed, 1 Jun 2022 07:50:58 GMT, Сергей Цыпанов wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
>> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
>> called with vararg of size 0, 1, 2.
>>
>> In general replacement of
> This fix ensures that when a lookup for a custom TZ code fails, and an
> attempt is made to find the GMT offset in order to get the current time,
> Daylight savings rules are applied correctly.
Gaurav Chaudhari has updated the pull request incrementally with two additional
commits since the
> When generating `MethodHandle`-based concatenation expressions in
> `StringConcatFactory` we can reduce the number of classes generated at
> runtime by creating small batches of prependers and mixers before binding
> them into the root expression tree.
>
> Improvements on one-off tests are
On Fri, 27 May 2022 15:24:46 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
On Wed, 1 Jun 2022 13:03:38 GMT, Claes Redestad wrote:
>> When generating `MethodHandle`-based concatenation expressions in
>> `StringConcatFactory` we can reduce the number of classes generated at
>> runtime by creating small batches of prependers and mixers before binding
>> them into the
> When generating `MethodHandle`-based concatenation expressions in
> `StringConcatFactory` we can reduce the number of classes generated at
> runtime by creating small batches of prependers and mixers before binding
> them into the root expression tree.
>
> Improvements on one-off tests are
On Fri, 27 May 2022 15:24:46 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
The change
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi-line (block) comments. Nothing in the code proper has
On Tue, 31 May 2022 22:11:54 GMT, Brian Burkhalter wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
>
On Tue, 31 May 2022 21:55:16 GMT, Brian Burkhalter wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
>
On Wed, 1 Jun 2022 09:21:43 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java line 118:
>>
>>> 116: private int index;
>>> 117:
>>> 118: private DoubleToDecimal() {
>>
>> Maybe add a comment like
>>
>> /**
>> * Prevent
On Fri, 6 May 2022 22:05:35 GMT, liach wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>>
Please review this cleanup change in the cgroup subsystem which used to use
hard-coded stack allocated
buffers for concatenating strings in memory. We can use `stringStream` instead
which doesn't have the issue
of hard-coding maximum lengths (and related checks) and makes the code, thus,
easier
On Tue, 31 May 2022 21:57:44 GMT, Brian Burkhalter wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
>
On Tue, 31 May 2022 21:35:08 GMT, Brian Burkhalter wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
>
On Wed, 1 Jun 2022 08:56:38 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/jdk/internal/math/MathUtils.java line 38:
>>
>>> 36: *
>>> 37: * Giulietti, "The Schubfach way to render doubles",
>>> 38: *
>>>
On Wed, 1 Jun 2022 02:05:40 GMT, Joe Darcy wrote:
>> Generally add apiNote's to map from Java library methods to particular IEEE
>> 754 operations. For now, I only added such notes to java.lang.Math and not
>> java.lang.StrictMath.
>
> Joe Darcy has updated the pull request with a new target
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()` with `List.of()` is dubious as
> the latter is
On Wed, 1 Jun 2022 06:04:14 GMT, Alan Bateman wrote:
>> This patch adds an alternative virtual thread implementation where each
>> virtual thread is backed by an OS thread. It doesn't scale but it can be
>> used by ports that don't have continuations support in the VM. Aside from
>>
On Tue, 31 May 2022 08:37:19 GMT, Adam Sotona wrote:
> This is continuation of PR #4256
>
> The patch simply rounds up the specified stack size to multiple of the system
> page size, on systems where necessary.
> The patch is based on the original PR/branch, with reflected remaining
>
On Mon, 30 May 2022 13:20:17 GMT, Aleksey Shipilev wrote:
> [JDK-8287137](https://bugs.openjdk.java.net/browse/JDK-8287137) added a bunch
> of tests into problemlist. Those lists basically exclude every test that runs
> with --enable-preview.
>
> This patch adds an alternative virtual thread implementation where each
> virtual thread is backed by an OS thread. It doesn't scale but it can be used
> by ports that don't have continuations support in the VM. Aside from
> scalability, the lack of continuations support means:
>
> 1. JVM TI
On Wed, 1 Jun 2022 05:01:33 GMT, ExE Boss wrote:
>> src/java.base/share/classes/java/lang/reflect/Member.java line 96:
>>
>>> 94: */
>>> 95: public default Set accessFlags() {
>>> 96: return Set.of();
>>
>> Is is not better to throw a NoSuchMethodError instead of Set.of() if
On Tue, 31 May 2022 17:26:35 GMT, Rémi Forax wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 32 additional commits
>> since
On Tue, 31 May 2022 15:10:38 GMT, Adam Sotona wrote:
>> This is continuation of PR #4256
>>
>> The patch simply rounds up the specified stack size to multiple of the
>> system page size, on systems where necessary.
>> The patch is based on the original PR/branch, with reflected remaining
>>
On Wed, 1 Jun 2022 03:18:44 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull
On Tue, 31 May 2022 17:46:18 GMT, Naoto Sato wrote:
> Refactoring some old code in locale providers. The test case data have also
> been modified due to:
> - There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not
> handle the case for `no-NO-NY`.
> - `Locale.toLanguageTag()`
On Tue, 31 May 2022 20:32:13 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull
> Time to start getting ready for JDK 20...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 38 additional commits since the
last revision:
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
> a test module with some resources in it for the actual tests that occur at
> the native level. The native part was switched to c++ instead of c to make it
> easier to create helper objects that reduce the redundant
On Wed, 1 Jun 2022 02:45:24 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>>
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
> a test module with some resources in it for the actual tests that occur at
> the native level. The native part was switched to c++ instead of c to make it
> easier to create helper objects that reduce the redundant
On Wed, 1 Jun 2022 00:59:33 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>>
On Wed, 25 May 2022 08:56:27 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains four additional
On Tue, 31 May 2022 15:10:38 GMT, Adam Sotona wrote:
>> This is continuation of PR #4256
>>
>> The patch simply rounds up the specified stack size to multiple of the
>> system page size, on systems where necessary.
>> The patch is based on the original PR/branch, with reflected remaining
>>
On Wed, 1 Jun 2022 02:05:40 GMT, Joe Darcy wrote:
>> Generally add apiNote's to map from Java library methods to particular IEEE
>> 754 operations. For now, I only added such notes to java.lang.Math and not
>> java.lang.StrictMath.
>
> Joe Darcy has updated the pull request with a new target
> Generally add apiNote's to map from Java library methods to particular IEEE
> 754 operations. For now, I only added such notes to java.lang.Math and not
> java.lang.StrictMath.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev
On Mon, 30 May 2022 01:17:00 GMT, Xiaohong Gong wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrap the offset check into a static method
>
> @PaulSandoz, could you please help to check whether the current
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
> a test module with some resources in it for the actual tests that occur at
> the native level. The native part was switched to c++ instead of c to make it
> easier to create helper objects that reduce the redundant
On Tue, 31 May 2022 15:39:39 GMT, Alan Bateman wrote:
>> This patch adds an alternative virtual thread implementation where each
>> virtual thread is backed by an OS thread. It doesn't scale but it can be
>> used by ports that don't have continuations support in the VM. Aside from
>>
On Tue, 31 May 2022 20:10:44 GMT, Gaurav Chaudhari
wrote:
>> This fix ensures that when a lookup for a custom TZ code fails, and an
>> attempt is made to find the GMT offset in order to get the current time,
>> Daylight savings rules are applied correctly.
>
> Gaurav Chaudhari has updated the
On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Thu, 21 Apr 2022 00:48:00 GMT, Stuart Marks wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>>
On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Tue, 31 May 2022 20:32:13 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull
On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
Reviewers, could I get a review for CSR
On Sun, 29 May 2022 21:57:46 GMT, Andrey Turbanov wrote:
> StringBuffer is a legacy synchronized class. StringBuilder is a direct
> replacement to StringBuffer which generally have better performance.
> There are some code that still uses StringBuffer in java.naming which could
> be migrated
On Tue, 31 May 2022 19:30:07 GMT, Сергей Цыпанов wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
>> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
>> called with vararg of size 0, 1, 2.
>>
>> In general replacement of
On Tue, 31 May 2022 19:33:15 GMT, Roger Riggs wrote:
>> Сергей Цыпанов has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>>
On Tue, 31 May 2022 17:46:18 GMT, Naoto Sato wrote:
> Refactoring some old code in locale providers. The test case data have also
> been modified due to:
> - There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not
> handle the case for `no-NO-NY`.
> - `Locale.toLanguageTag()`
> Time to start getting ready for JDK 20...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 36 additional commits since the
last revision:
On Tue, 31 May 2022 19:33:49 GMT, Mandy Chung wrote:
>> liach has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Fixes suggested by mandy
>
> Looks good. Thanks.
@mlchung Would you mind sponsoring this patch?
-
PR:
> This fix ensures that when a lookup for a custom TZ code fails, and an
> attempt is made to find the GMT offset in order to get the current time,
> Daylight savings rules are applied correctly.
Gaurav Chaudhari has updated the pull request incrementally with one additional
commit since the
On Tue, 31 May 2022 17:46:18 GMT, Naoto Sato wrote:
> Refactoring some old code in locale providers. The test case data have also
> been modified due to:
> - There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not
> handle the case for `no-NO-NY`.
> - `Locale.toLanguageTag()`
On Tue, 31 May 2022 17:21:50 GMT, Naoto Sato wrote:
>> Gaurav Chaudhari has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Merge branch '8285838' of github.com:Deigue/jdk into 8285838
>> - Merge branch '8285838' of github.com:Deigue/jdk
On Thu, 26 May 2022 23:20:27 GMT, liach wrote:
>> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass,
>> the interfaces are iterated twice. The two passes can be merged into one,
>> yielding the whole proxy definition context (module, package, whether
>> there's
On Tue, 31 May 2022 19:30:07 GMT, Сергей Цыпанов wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
>> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
>> called with vararg of size 0, 1, 2.
>>
>> In general replacement of
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()` with `List.of()` is dubious as
> the latter is
On Fri, 20 May 2022 00:10:01 GMT, Mandy Chung wrote:
>> liach has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains four additional commits since
>>
On Fri, 20 May 2022 03:50:58 GMT, liach wrote:
> Simplify calls `Class.forName(String, boolean, ClassLoader)` instead of
> `Class.forName(String)`. `make test
> TEST="jtreg:test/jdk/java/lang/reflect/Proxy"` passes, with the new
> `LazyInitializationTest` failing the eager initialization
On Fri, 20 May 2022 04:55:37 GMT, liach wrote:
> Simplify opcode handling, use `final` in `PrimitiveTypeInfo`, and replace the
> hash map with a simple lookup, similar to what's done in
> [JDK-8284880](https://bugs.openjdk.java.net/browse/JDK-8284880) (#8242)
This pull request has now been
On Mon, 30 May 2022 00:10:50 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>>
On Mon, 30 May 2022 05:37:16 GMT, Alan Bateman wrote:
> I don't think jdk/nullCaller is right location for this. Maybe jni/nullCaller
> could work. You'll probably need to add the location to an appropriate
> group/tier in test/jdk/TEST.groups, otherwise it won't be run.
I also think
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
Sorry, I was working on a history webpage while submit the PR and did
On Tue, 31 May 2022 17:41:08 GMT, Mandy Chung wrote:
> Hmm... one benefit of Cleaner is the ease of use to avoid the need of
> managing the reference queue. If the performance of the Cleaner API is a
> concern, perhaps we should look into reducing its overhead?
The code using a Cleaner here
Refactoring some old code in locale providers. The test case data have also
been modified due to:
- There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not
handle the case for `no-NO-NY`.
- `Locale.toLanguageTag()` won't handle legacy Java locales, e.g., `ja_JP_JP`
and falls
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
This pull request has now been integrated.
Changeset: d5b6c7bd
Author:
On Tue, 31 May 2022 15:39:39 GMT, Alan Bateman wrote:
>> This patch adds an alternative virtual thread implementation where each
>> virtual thread is backed by an OS thread. It doesn't scale but it can be
>> used by ports that don't have continuations support in the VM. Aside from
>>
On Thu, 26 May 2022 21:40:42 GMT, Xue-Lei Andrew Fan wrote:
> > Even using a Cleaner is a more overhead than necessary. I would have
> > skipped the overhead of a cleaner and Atomic classes with something more
> > self contained as a static method:
>
> I agreed that the using of Cleaner is
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
Marked as reviewed by mchung (Reviewer).
-
PR:
On Thu, 26 May 2022 21:40:42 GMT, Xue-Lei Andrew Fan wrote:
> Even using a Cleaner is a more overhead than necessary.
> I would have skipped the overhead of a cleaner and Atomic classes with
> something more self contained as a static method:
Hmm... one benefit of Cleaner is the ease of use to
On Tue, 31 May 2022 13:26:17 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> May I have this test update reviewed?
>>
>> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
>> cleaner.
>>
>> Thanks,
>> Xuelei
>
> test/lib/jdk/test/lib/util/ForceGC.java line 50:
>
>> 48:
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Tue, 15 Feb 2022 21:05:08 GMT, Joe Darcy wrote:
>> Note that the presence or absence of `ACC_SUPER` has no effect since **Java
>> 8**, which always treats it as set regardless of the actual contents of the
>> binary class file.
>
> For completeness, I think including SUPER is reasonable,
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Mon, 30 May 2022 15:40:37 GMT, Gaurav Chaudhari
wrote:
>> This fix ensures that when a lookup for a custom TZ code fails, and an
>> attempt is made to find the GMT offset in order to get the current time,
>> Daylight savings rules are applied correctly.
>
> Gaurav Chaudhari has updated the
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Tue, 31 May 2022 17:03:54 GMT, Aleksey Shipilev wrote:
> I expected this change to fix the broken ARM32 port, but it doesn't work.
There is work required to get the arm32 port working again, currently tracked
as JDK-828636 but there may be further issues beyond that.
-
PR:
> [JDK-8287137](https://bugs.openjdk.java.net/browse/JDK-8287137) added a bunch
> of tests into problemlist. Those lists basically exclude every test that runs
> with --enable-preview.
> [JDK-8287437](https://bugs.openjdk.java.net/browse/JDK-8287437) makes it
> better: it only disables Loom
On Tue, 31 May 2022 16:54:41 GMT, Boris Ulasevich
wrote:
> I expected this change to fix the broken ARM32 port, but it doesn't work.
It would not fix ARM32, because the interpreter stubs need to be predicated on
`Continuations::enabled()`. Also, as my ARM32 experiments show
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi-line (block) comments. Nothing in the code proper has
On Tue, 31 May 2022 15:39:39 GMT, Alan Bateman wrote:
>> This patch adds an alternative virtual thread implementation where each
>> virtual thread is backed by an OS thread. It doesn't scale but it can be
>> used by ports that don't have continuations support in the VM. Aside from
>>
On Mon, 30 May 2022 01:17:00 GMT, Xiaohong Gong wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrap the offset check into a static method
>
> @PaulSandoz, could you please help to check whether the current
On Sun, 29 May 2022 21:57:46 GMT, Andrey Turbanov wrote:
> StringBuffer is a legacy synchronized class. StringBuilder is a direct
> replacement to StringBuffer which generally have better performance.
> There are some code that still uses StringBuffer in java.naming which could
> be migrated
On Sun, 29 May 2022 21:57:46 GMT, Andrey Turbanov wrote:
> StringBuffer is a legacy synchronized class. StringBuilder is a direct
> replacement to StringBuffer which generally have better performance.
> There are some code that still uses StringBuffer in java.naming which could
> be migrated
On Wed, 27 Apr 2022 11:03:48 GMT, Jatin Bhateja wrote:
> Hi All,
>
> Patch adds the planned support for new vector operations and APIs targeted
> for [JEP 426: Vector API (Fourth
> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
>
> Following is the brief summary of changes:-
On Wed, 25 May 2022 06:29:23 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> Patch adds the planned support for new vector operations and APIs targeted
>> for [JEP 426: Vector API (Fourth
>> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
>>
>> Following is the brief summary of
> This patch adds an alternative virtual thread implementation where each
> virtual thread is backed by an OS thread. It doesn't scale but it can be used
> by ports that don't have continuations support in the VM. Aside from
> scalability, the lack of continuations support means:
>
> 1. JVM TI
On Tue, 31 May 2022 13:28:30 GMT, David Holmes wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated Java mannpage
>
> src/java.base/share/classes/sun/launcher/resources/launcher.properties line
> 176:
>
>>
> This is continuation of PR #4256
>
> The patch simply rounds up the specified stack size to multiple of the system
> page size, on systems where necessary.
> The patch is based on the original PR/branch, with reflected remaining
> recommendations.
>
> Please review.
>
> Thank you,
> Adam
On Tue, 31 May 2022 11:44:27 GMT, Alan Bateman wrote:
>> [JDK-8287137](https://bugs.openjdk.java.net/browse/JDK-8287137) added a
>> bunch of tests into problemlist. Those lists basically exclude every test
>> that runs with --enable-preview.
>>
On Fri, 27 May 2022 20:21:12 GMT, Mandy Chung wrote:
> With the `AccessFlag` API, what is the role of the `Modifier` API going
> forward? [Value Objects JEP](https://openjdk.java.net/jeps/8277163) defines
> the new `identity` and `value` modifiers. [PR
>
On Tue, 31 May 2022 08:37:19 GMT, Adam Sotona wrote:
> This is continuation of PR #4256
>
> The patch simply rounds up the specified stack size to multiple of the system
> page size, on systems where necessary.
> The patch is based on the original PR/branch, with reflected remaining
>
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
LGTM - but it may be good to have an other reviewer (@mlchung ?)
501 - 600 of 84465 matches
Mail list logo