not worth
the overhead.
Roger
On 2/13/20 10:34 AM, Patrick Zhang OS wrote:
> Hi,
>
> A quick question,
> I read the code snippets of indexOf(String str), found indexOfUnsafe [1] and
> indexOfLatin1Unsafe [2] have different access control, but it looks both
> should be priva
Hi,
A quick question,
I read the code snippets of indexOf(String str), found indexOfUnsafe [1] and
indexOfLatin1Unsafe [2] have different access control, but it looks both should
be private. Did I miss any outer caller or any other restriction? Thanks for
your comment.
[1] private static int
-libs-dev@openjdk.java.net
Subject: Re: RFR: JDK-8238380: java.base/unix/native/libjava/childproc.c
"multiple definition" link errors with GCC10
+1,
One is enough, but additional eyes are good too.
On 2/5/20 10:35 PM, Patrick Zhang OS wrote:
> Does this require one more “yes” f
Does this require one more “yes” from any other reviewer?
And may I ask for any committer’s help to sponsor and push it (once approved)?
Thanks in advance.
Regards
Patrick
From: Thomas Stüfe
Sent: Wednesday, February 5, 2020 11:16 PM
To: Patrick Zhang OS
Cc: core-libs-dev
Subject: Re: RFR
the change a bit (the header comments):
http://cr.openjdk.java.net/~qpzhang/8238380/webrev.02/
Regards
Patrick
From: Thomas Stüfe
Sent: Wednesday, February 5, 2020 2:30 PM
To: Patrick Zhang OS
Cc: core-libs-dev
Subject: Re: RFR: JDK-8238380: java.base/unix/native/libjava/childproc.c
"mul
...@google.com>>
Sent: Monday, December 16, 2019 10:44 AM
To: Patrick Zhang OS
mailto:patr...@os.amperecomputing.com>>;
net-dev mailto:net-...@openjdk.java.net>>; OpenJDK
mailto:security-...@openjdk.java.net>>
Cc: core-libs-dev
mailto:core-libs-dev@openjdk.java.net>>
://bugs.openjdk.java.net/browse/JDK-8235903
Webrev: http://cr.openjdk.java.net/~qpzhang/8235903/webrev.01/
Regards
Patrick
From: Martin Buchholz
Sent: Monday, December 16, 2019 10:44 AM
To: Patrick Zhang OS ; net-dev
; OpenJDK
Cc: core-libs-dev
Subject: Re: RFR: JDK-8235903: GCC default -fno-common exposes
Hi
Please review this patch, if it should be reviewed by any group other than
core-libs, please help forward it. Thanks.
JBS: https://bugs.openjdk.java.net/browse/JDK-8235903
Webrev: http://cr.openjdk.java.net/~qpzhang/8235903/webrev.01/
A recent GCC patch (supposed to be in GCC 10) exposes
level javadoc for modCount, or for "fail fast".
Regards
Patrick
-Original Message-
From: Stuart Marks
Sent: Thursday, May 9, 2019 5:01 AM
To: Patrick Zhang OS
Cc: core-libs-dev
Subject: Re: RFR(trivial): 8222394: HashMap.compute() throws CME on an empty
Map if clear() called concurre
d (or unreliable) operation, perhaps I should drop all
of them. Lastly, a suggestion would be: adding more comments for this in case
anyone else would revisit it with similar confusions, e.g. HashMap.clear.
Regards
Patrick
-Original Message-
From: Stuart Marks
Sent: Thursday, May 2
esting. Clear, compute, and computeIfAbsent are more special
as I described.
Regards
Patrick
-Original Message-
From: Stuart Marks
Sent: Thursday, April 25, 2019 7:48 AM
To: Patrick Zhang OS
Cc: core-libs-dev ; Martin Buchholz
Subject: Re: RFR(trivial): 8222394: HashMap.compute() thro
Done. http://cr.openjdk.java.net/~qpzhang/8222334/webrev.05
Regards
Patrick
-Original Message-
From: David Holmes
Sent: Tuesday, April 16, 2019 6:34 PM
To: Patrick Zhang OS
Cc: core-libs-dev
Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError
Hi Patrick,
On 16/04
16, 2019 4:17 PM
To: Patrick Zhang OS
Cc: Alan Bateman ; core-libs-dev
Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError
Patrick,
Sorry should have picked up on this earlier. Can you please update the
following two tests to add a test for '0' as appropriate:
./jdk/tools
Sure I will add this, and fix the intention mentioned by Alan.
Regards
Patrick
-Original Message-
From: David Holmes
Sent: Tuesday, April 16, 2019 4:17 PM
To: Patrick Zhang OS
Cc: Alan Bateman ; core-libs-dev
Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError
Patrick
might need this:
http://cr.openjdk.java.net/~qpzhang/8222394/webrev.02 for
compute()/computeIfAbsent(). Centainly I know it has to afford the risk of
missing bugs.
Regards
Patrick
-Original Message-
From: Stuart Marks
Sent: Saturday, April 13, 2019 4:15 AM
To: Patrick Zhang OS
Cc: core-libs-de
Removed it. http://cr.openjdk.java.net/~qpzhang/8222334/webrev.03/jdk.changeset
By the way, could you please sponsor to push it once approved? thanks in
advance.
Regards
Patrick
-Original Message-
From: David Holmes
Sent: Monday, April 15, 2019 2:33 PM
To: Patrick Zhang OS ; core
rick
-Original Message-
From: David Holmes
Sent: Monday, April 15, 2019 6:55 AM
To: Patrick Zhang OS ; core-libs-dev
Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError
Hi Patrick,
Please see:
http://cr.openjdk.java.net/~dholmes/8222334/webrev/
for my suggested updates to the
Created a ticket to track it, welcome any comments. Thanks.
JBS https://bugs.openjdk.java.net/browse/JDK-8222394
Webrev: http://cr.openjdk.java.net/~qpzhang/map.clear/webrev.01
Regards
Patrick
-Original Message-
From: core-libs-dev On Behalf Of
Patrick Zhang OS
Sent: Saturday, March
Moved this to core-libs-dev for review, thanks.
Dropped and bcc'ed jdk-dev and jdk-updates-dev.
Regards
Patrick
-Original Message-
From: David Holmes
Sent: Friday, April 12, 2019 3:43 PM
To: Patrick Zhang OS ; jdk-...@openjdk.java.net
Cc: jdk-updates-...@openjdk.java.net
Subject: Re
Hi,
Here I have a case simplified from a practical issue that throws
ConcurrentModificationException (CME) unexpectedly (I think). [0] creates a
HashMap, keeps it empty, and calls m.computeIfAbsent() or m.compute(), in which
a "sneaky" m.clear() occurs, some of the test cases throw CME although
20 matches
Mail list logo
