On Sat, 28 May 2022 12:00:00 GMT, Andrey Turbanov wrote:
> Hashtable doesn't allow `null` values. So, instead of pair
> `containsKey`/`remove` calls, we can directly call `remove` and then compare
> result with `null`.
> https://github.com/openjdk/jdk/blob/2c461acfebd28fe5ef62805cbb004f91a3b18f
On Wed, 8 Jun 2022 14:51:59 GMT, Thiago Henrique Hüpner
wrote:
>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
>> flags is used
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix
On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285405?
>
> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing
> `test/jdk/java/util/LinkedHashMap/Basic.java`
On Fri, 3 Jun 2022 23:56:31 GMT, Joe Wang wrote:
>> Adjust how XPath operators are counted to improve accuracy. This change does
>> not affect how XPath works.
>>
>> Test:
>> Tier2 passed;
>> JCK XML tests passed.
>
> Joe Wang has updated the pull request incrementally with one add
On Fri, 3 Jun 2022 16:48:46 GMT, Naoto Sato wrote:
> The code path calls `String.getBytesNoRepl()`, but it blindly replaces
> unmappable characters with replacements if the encoder is an `ArrayEncoder`.
> Changed only to do so if `doReplace` is `true` in
> `String.encodeWithEncoder()`.
Marked
On Fri, 27 May 2022 17:17:28 GMT, Joe Wang wrote:
>> Addresses an insufficiency of error handling in the XPath implementation.
>> Some cleanup where appropriate, without attempting to do too much as this is
>> a component that hasn't had much changes for 15 years, a fairly stable
>> applicatio
On Fri, 27 May 2022 01:12:18 GMT, Joe Wang wrote:
> Addresses an insufficiency of error handling in the XPath implementation.
> Some cleanup where appropriate, without attempting to do too much as this is
> a component that hasn't had much changes for 15 years, a fairly stable
> application.
>
On Mon, 23 May 2022 19:47:33 GMT, Lance Andersen wrote:
> Hi all,
>
> This PR addresses the performance issue that is described in JDK-8287162.
>
> With this fix, the ZipFileSystem methods: initOwner, initGroup, and
> initPermissions will not be invoked unless enablePosixF
On Tue, 24 May 2022 09:52:29 GMT, Alexey Ivanov wrote:
>> Replaces usages of articles that follow each other in all combinations:
>> a/the, an?/an?, the/the…
>>
>> It's the last issue in the series, and it still touches different areas of
>> the code.
>
> Alexey Ivanov has updated the pull req
Hi all,
This PR addresses the performance issue that is described in JDK-8287162.
With this fix, the ZipFileSystem methods: initOwner, initGroup, and
initPermissions will not be invoked unless enablePosixFileAttributes=true.
Mach5 tiers1-3 are currently running and have not encountered any
On Sun, 22 May 2022 05:58:25 GMT, Christian Stein wrote:
> Commit
> https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640
> for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654)
> added an optional description accessor on the `ToolProvider` interfac
On Mon, 23 May 2022 08:49:27 GMT, Christian Stein wrote:
> This commit adds an API note to ToolProvider about being reusable/reentrant.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8833
On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote:
> This PR adds an optional description accessor on `ToolProvider` interface.
>
> This PR also adds short description for each of the listed tool:
> - `jar`
> - `javac`
> - `javadoc`
> - `javap` and `jdeps`
> - `jlink` and `jmod`
> - `jpack
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by lancea (Reviewer).
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> I tried to avoid changing external libraries, there are quite a few such
> typos.
> Let me know if I should revert any files.
Marked
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net
On Tue, 17 May 2022 00:39:37 GMT, Joe Wang wrote:
>> Update to Xerces 2.12.2.
>>
>> The update also fixes JDK-8144117. Added a test.
>>
>> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
>> update. See related issue report.
>
> Joe Wang has updated the pull request
On Mon, 16 May 2022 19:34:11 GMT, Joe Wang wrote:
> Update to Xerces 2.12.2.
>
> The update also fixes JDK-8144117. Added a test.
>
> Tests: local XML tests passed. Tier2 running. Two JCK tests failed with this
> update. See related issue report.
Hi Joe,
I think your changes are ok
Are you
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as s
On Wed, 30 Mar 2022 10:26:56 GMT, Lance Andersen wrote:
>>> Hello Volker, An additional thing that we might have to consider here is
>>> whether adding this javadoc change to `InflaterInputStream` is ever going
>>> to "show up" to end user applicat
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conversions in java.rmi
>
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several mont
On Wed, 11 May 2022 22:03:38 GMT, Magnus Ihse Bursie wrote:
> It would not make sense to set the disabled warning in the configure script,
> no. The current code looks perfectly fine. Disabled warnings per module are
> set in the makefiles.
OK, that you for your feedback regarding the makefile
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1, tier2 and
On Wed, 11 May 2022 20:40:30 GMT, Joe Darcy wrote:
> While doing a CSR review of another issue, I noticed some cases in
> InputStream and OutputStream what would benefit from being upgraded to
> implSpec and related javadoc tags.
>
> The "A subclass must provide an implementation of this metho
On Wed, 11 May 2022 15:32:38 GMT, Christoph Langer wrote:
> This augments the ZipException upon rejecting a Zip File containing entry
> names with "." or ".." elements.
>
> It furthermore tries to clean up & compact the logic for detecting "." and
> ".." and it adds a method IndexNode::nameAsS
On Wed, 11 May 2022 15:03:56 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - copyright years
>> - disable format-nonliteral warning when building LIBSPLA
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1, tier2 and
On Wed, 11 May 2022 14:25:39 GMT, Jaikiran Pai wrote:
>> I agree with Magnus and try to avoid changing the imported zlib code.
>
>> I did these changes locally but for some reason this format-nonliteral is
>> not getting picked up while building that library.
>
> Turns out that was slightly in
On Wed, 11 May 2022 09:00:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change that addresses
> https://bugs.openjdk.java.net/browse/JDK-8286559?
>
> The commit here removes the `synchronized` on `mark` and `reset` methods of
> `InflaterInputStream`. The `mark` method is a n
On Tue, 10 May 2022 16:58:03 GMT, Lance Andersen wrote:
>>> I think this would be OK, but would get to get someone from our security
>>> team to bless it.
>>
>> It's print the entry name, I don't think it is leaking the file path to the
>> zip fi
On Tue, 10 May 2022 16:51:35 GMT, Alan Bateman wrote:
> > I think this would be OK, but would get to get someone from our security
> > team to bless it.
>
> It's print the entry name, I don't think it is leaking the file path to the
> zip file.
I think you are probably right I am probably bei
On Tue, 10 May 2022 16:30:01 GMT, Lance Andersen wrote:
>>> @LanceAndersen @AlanBateman do you think adding the entry name in the
>>> exception in ZipFileSystem is ok? If so, should it maybe go into a
>>> different patch?
>>
>> It should be okay as this
On Tue, 10 May 2022 14:58:15 GMT, Aleksey Shipilev wrote:
>> There are plenty of tests failing on many architectures due to
>> `--enable-preview` VM code introduced by Loom. This improvement eliminates
>> some of the redundant `--enable-preview` clauses from the Sealed Classes
>> tests, since
On Tue, 10 May 2022 14:02:14 GMT, Alan Bateman wrote:
> > @LanceAndersen @AlanBateman do you think adding the entry name in the
> > exception in ZipFileSystem is ok? If so, should it maybe go into a
> > different patch?
>
> It should be okay as this is the name of an entry in the zip file. It
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> co
On Thu, 5 May 2022 14:33:51 GMT, Roger Riggs wrote:
> Add a failing test library test to the ProblemList.
>
> test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8552
On Mon, 2 May 2022 12:32:25 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream` spe
On Fri, 29 Apr 2022 12:29:35 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285452: updated to use lines()
test/jdk/j
On Wed, 27 Apr 2022 17:02:40 GMT, Pavel Rappo wrote:
>> I ran `codespell` on modules owned by core-libs, and accepted those changes
>> where it indeed discovered real typos.
>>
>> I will update copyright years using a script before pushing (otherwise like
>> every second change would be a copy
On Fri, 22 Apr 2022 15:08:51 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by core-libs, and accepted those changes
> where it indeed discovered real typos.
>
> I will update copyright years using a script before pushing (otherwise like
> every second change would be a co
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Mon, 25 Apr 2022 22:22:29 GMT, Joe Darcy wrote:
> Fix typo introduced in JDK-8261123.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8390
On Thu, 21 Apr 2022 11:35:57 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Mon, 25 Apr 2022 13:19:49 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Thu, 21 Apr 2022 22:19:32 GMT, Stuart Marks wrote:
>> Adds `othervm` and `-Xmx2g` options to this test, because the default heap
>> of 768m isn't enough.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add bug id.
Mark
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Wed, 20 Apr 2022 21:53:46 GMT, Joe Wang wrote:
>> Patch note:
>>
>> A previous patch had a bug that missed the boundary check, that will cause
>> StringIndexOutOfBoundsException to be thrown instead of
>> XPathExpressionException as expected.
>>
>> Fix: the fix is to check the boundari
On Wed, 20 Apr 2022 18:28:19 GMT, Joe Wang wrote:
>> Patch note:
>>
>> The previous patch changed all literal tokens to use constants. However,
>> replacing "." with Token.DOT introduced this bug.
>> While tokens with a single char are inherently of type char, due to the
>> different implemen
On Tue, 19 Apr 2022 16:50:12 GMT, Magnus Ihse Bursie wrote:
>> I ran `codespell` on the `src/java.base` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> (Due to false positives this can unfortunately not be run automatically)
>>
>> The majority of fixes ar
On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in:
> src/java.desktop
> src/java.management
> src/jdk
On Wed, 13 Apr 2022 17:42:57 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream` sp
On Tue, 12 Apr 2022 20:09:31 GMT, Ravi Reddy wrote:
> CloseInflaterDeflaterTest.java is failing intermittently(Observed once in
> macOS and Linux), testInflaterOutputStream() is added as an extra test as
> part of https://bugs.openjdk.java.net/browse/JDK-8278794. Disabling this test
> for now
On Tue, 12 Apr 2022 15:00:29 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream` sp
On Wed, 6 Apr 2022 01:23:15 GMT, Joe Wang wrote:
>> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
>> classes where the checks were really about equality or whether they were the
>> exact class types. It was why they worked nonetheless even though some of
>> them were
On Wed, 30 Mar 2022 02:56:41 GMT, Vicente Romero wrote:
>> Please review this PR which is updating the ASM included in the JDK to ASM
>> 9.2. This version should be included in JDK19. There are basically two
>> commits here, one that was automatically generated and that mostly changes
>> file
On Wed, 30 Mar 2022 16:28:16 GMT, Brian Burkhalter wrote:
>> Minimal version of possible fixes: make the bulk read `@return` verbiage
>> consistent in the `java.io` package.
>
> Brian Burkhalter has refreshed the contents of this pull request, and
> previous commits have been removed. The incre
On Tue, 29 Mar 2022 12:45:51 GMT, Volker Simonis wrote:
> > Hello Volker, An additional thing that we might have to consider here is
> > whether adding this javadoc change to `InflaterInputStream` is ever going
> > to "show up" to end user applications. What I mean is, I think in many
> > case
On Tue, 29 Mar 2022 16:39:50 GMT, Joe Wang wrote:
> Resets state of a Catalog instance on each matching call so that it can be
> reused. Adjusts CatalogResolver's resolve routine so that it continues to
> observes the PREFER feature in a resolution process. Without the adjustment,
> PreferFeat
On Tue, 29 Mar 2022 18:23:31 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial fix which addresses a typo in
> src/java.sql/share/classes/java/sql/package-info.java
>
> make docs is clean and I am also running mach5 tier1 as an extra sanity check
> so t
Hi all,
Please review this trivial fix which addresses a typo in
src/java.sql/share/classes/java/sql/package-info.java
make docs is clean and I am also running mach5 tier1 as an extra sanity check
so there are no surprises when the patch is pushed
Best
Lance
-
Commit messages:
-
On Mon, 28 Mar 2022 18:51:30 GMT, Naoto Sato wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to creat
On Mon, 28 Mar 2022 17:21:40 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/util/zip/InflaterInputStream.java line 133:
>>
>>> 131: * Unlike the {@link InputStream#read(byte[],int,int) overridden
>>> method}
>>> 132: * of {@code InputStream}, this method might write more
On Mon, 28 Mar 2022 17:02:33 GMT, Naoto Sato wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to creat
On Mon, 28 Mar 2022 16:49:58 GMT, Vicente Romero wrote:
> Please review this PR which is updating the ASM included in the JDK to ASM
> 9.2. This version should be included in JDK19. There are basically two
> commits here, one that was automatically generated and that mostly changes
> file head
On Mon, 28 Mar 2022 09:37:58 GMT, Volker Simonis wrote:
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to
> highlight that it might write more bytes than the returned number of
> inflated bytes into the buffer `b`.
>
> The superclass `java.io.InputStream` specifi
On Fri, 25 Mar 2022 22:51:23 GMT, Naoto Sato wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to creat
On Thu, 24 Mar 2022 20:59:20 GMT, Brent Christian wrote:
>> Please review this change to the java/util/prefs/AddNodeChangeListener.jar
>> test.
>>
>> Although the test specifies "-Djava.util.prefs.userRoot=." to ensure a fresh
>> Preferences on each test run, MacOS does not seem to honor this,
On Thu, 24 Mar 2022 18:21:05 GMT, Joe Wang wrote:
> The issue was caused by the difference on handling control characters between
> the parser and serializer. The parser rejected control characters while the
> serializer converted them to NCRs. The fix is for the later to be aligned
> with the
On Mar 22, 2022, at 12:28 PM, Volker Simonis
mailto:volker.simo...@gmail.com>> wrote:
On Mon, Mar 21, 2022 at 8:24 PM Lance Andersen
mailto:lance.ander...@oracle.com>> wrote:
Hi Lance,
Thanks for looking into this issue. Please find my answers inline:
Hi Volker,
I have read
ut
buffer. I think we all agree that this is only a theoretic option
because of its unacceptable performance regression.
I personally favor option 1 but I'm interested in your opinions?
Thank you and best regards,
Volker
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Princip
On Sun, 20 Mar 2022 04:24:07 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which handles
> https://bugs.openjdk.java.net/browse/JDK-8283411?
>
> The commit here moves the temporary byte array from being a member of the
> class to a local variable within the `skip` method
On Thu, 17 Mar 2022 16:56:15 GMT, Ravi Reddy wrote:
>> Hi All,
>>
>> This review request contains fix for infinite loop issue in
>> DeflaterOutputStream.finish() in an exception scenario.
>> 1. The issue is with 'finished' flag not getting set to correct value when
>> there is an IOException i
On Wed, 16 Mar 2022 16:34:37 GMT, Ravi Reddy wrote:
>> Hi All,
>>
>> This review request contains fix for infinite loop issue in
>> DeflaterOutputStream.finish() in an exception scenario.
>> 1. The issue is with 'finished' flag not getting set to correct value when
>> there is an IOException i
On Fri, 11 Mar 2022 22:20:38 GMT, Naoto Sato wrote:
>> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary
>> decimal/grouping separator symbols. Fix is straightforward to use the
>> correct symbols depending on the formatter type.
>
> Naoto Sato has updated the pull request incr
On Thu, 10 Mar 2022 02:30:35 GMT, Brian Burkhalter wrote:
> Add a statement to the `java.io` package documentation clarifying how a
> `String` representing a _pathname string_ is interpreted in the package.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.ne
On Thu, 10 Mar 2022 16:17:16 GMT, Ian Graves wrote:
>> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
>> metacharacters
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adding description of word
On Wed, 9 Mar 2022 01:33:43 GMT, Ian Graves wrote:
>> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
>> metacharacters
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updating with additional de
On Tue, 8 Mar 2022 17:19:14 GMT, Ian Graves wrote:
>> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
>> metacharacters
>
> Ian Graves has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains six commits:
>
>
On Tue, 8 Mar 2022 11:45:13 GMT, Athijegannathan Sundararajan
wrote:
> Do we need a CSR as a public class is changed from non-sealed to sealed?
>
> (Although the constructor has been package-private and hence it will not
> affect any non-dk code as noted by Jaikiran via private conversation. O
On Fri, 18 Feb 2022 19:47:09 GMT, Ian Graves wrote:
> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
> metacharacters
Have not gone through the javadoc changes in detail yet but plan to, only
scanned it just now
On a quick skim of the test, it could use some TLC
On Tue, 8 Mar 2022 04:23:43 GMT, Ian Graves wrote:
>> Fixing a bug in `NFCCharProperty` where code falling through an if-statement
>> can prematurely set the matcher's `hitEnd` field to true.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last r
On Mon, 7 Mar 2022 22:29:29 GMT, Ian Graves wrote:
>> Fixing a bug in `NFCCharProperty` where code falling through an if-statement
>> can prematurely set the matcher's `hitEnd` field to true.
>
> Ian Graves has updated the pull request with a new target base due to a merge
> or a rebase. The pu
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
What problem are you having editing the PR header? You should be able to do
so as the author of the PR
-
PR: ht
On Thu, 3 Mar 2022 11:19:12 GMT, Lance Andersen wrote:
> Hi all,
>
> This PR addresses an issue where an unexpected exception is thrown when the
> CEN file entry comment length is not correct.
>
> Mach5 tiers 1 - 3 run clean with this change.
This pull request has n
On Sun, 6 Mar 2022 17:28:42 GMT, Joe Darcy wrote:
>> Occasionally in core-libs we've discussed whether or not to do a pass over
>> the exception classes and proactively add any of four missing convention
>> constructors per java.lang.Throwable (no-arg, string, cause, cause and
>> string). Last
On Sat, 5 Mar 2022 03:29:44 GMT, Joe Darcy wrote:
>> Occasionally in core-libs we've discussed whether or not to do a pass over
>> the exception classes and proactively add any of four missing convention
>> constructors per java.lang.Throwable (no-arg, string, cause, cause and
>> string). Last
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
The changes look OK. The copyright year probably should be updated as part of
this PR
-
Marked as reviewed by la
On Thu, 3 Mar 2022 22:34:43 GMT, Joe Wang wrote:
>> Update BCEL md to include the copyright notice.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove the section that's no longer in the notice file
Marked as reviewed by l
On Thu, 3 Mar 2022 18:35:05 GMT, Joe Wang wrote:
> Yes, it's 2020. The latest release, 6.5.0, was released in 2020. The text
> comes from the NOTICE.txt file in the BCEL 6.5.0 release.
Thank you for the confirmation Joe!
-
PR: https://git.openjdk.java.net/jdk/pull/7681
On Thu, 3 Mar 2022 17:51:31 GMT, Joe Wang wrote:
> Update BCEL md to include the copyright notice.
Looks fine. I assume the 2020 vs 2022 is intentional?
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7681
> Hi all,
>
> This PR addresses an issue where an unexpected exception is thrown when the
> CEN file entry comment length is not correct.
>
> Mach5 tiers 1 - 3 run clean with this change.
Lance Andersen has updated the pull request incrementally with one additional
com
Hi all,
This PR addresses an issue where an unexpected exception is thrown when the CEN
file entry comment length is not correct.
Mach5 tiers 1 - 3 run clean with this change.
-
Commit messages:
- Correct bug number in test
- Validate comment if it exists when processing the CEN
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote:
> Fixing the definition and implementation of the pattern symbol `F`. Although
> it is an incompatible change, I believe it is worth the fix. For that, a CSR
> has been drafted.
I think the change makes sense.
Are there any TCK tests that ne
On Fri, 25 Feb 2022 19:02:55 GMT, Naoto Sato wrote:
> Refactoring `java.time.ZoneId` class to be a sealed class. A CSR has also
> been drafted.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7625
On Fri, 4 Feb 2022 12:42:39 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review the attached patch to address
>
> - That JarFile::getInputStream did not check for a null ZipEntry passed as a
> parameter
> - Have Zip/JarFile::getInputStream throw a ZipException
On Thu, 17 Feb 2022 16:02:42 GMT, Volker Simonis wrote:
>> Currently, `InflaterInputStream::read()` first does a native call to the
>> underlying zlib `inflate()` function and only afterwards checks if the
>> inflater requires input (i.e. `Inflater::needsInput()`) or has finished
>> inflating
On Sat, 19 Feb 2022 10:59:56 GMT, Alan Bateman wrote:
> > Ok, thank you for the feedback. I just pushed a change with additional
> > comments on the jar creation which hopefully will address your input above.
>
> It's a bit better but I think it needs a clear step-by-step instructions in a
> c
Mach5 tiers1-3 runs are clean as are the TCK java.util.zip and java.util.jar
> test runs
>
> Best
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Modified and clarified test comments
-
Changes:
On Mon, 21 Feb 2022 10:06:40 GMT, Volker Simonis wrote:
> > The change looks innocuous so it is probably OK. I would like to kick of
> > our Mach5 runs to see if it shakes out any potential issues.
>
> @LanceAndersen , did you manage to get any Mach5 results? Did you find any
> issues?
Tests
1 - 100 of 1001 matches
Mail list logo