---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52478/#review151369
---
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 3, 2016, 4:39
/AtlasGraphManagement.java
(line 111)
<https://reviews.apache.org/r/47810/#comment219710>
Does the index here refer to the edgeLabel we are trying to create an idex
for? Do we have everything we need in this interface to index an edge label?
- Suma Shivaprasad
On Oct. 4, 2016, 1:
> On Sept. 23, 2016, 8:36 p.m., Suma Shivaprasad wrote:
> > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Database.java,
> > line 188
> > <https://reviews.apache.org/r/47810/diff/13/?file=1508908#file1508908line188>
> >
> >
/AtlasGraphManagement.java
(line 78)
<https://reviews.apache.org/r/47810/#comment219713>
can we change the vararg to a List everywhee to keep it consistent?
- Suma Shivaprasad
On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg
> On Oct. 4, 2016, 9 p.m., Suma Shivaprasad wrote:
> > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java,
> > line 130
> > <https://reviews.apache.org/r/47810/diff/13-14/?file=150#file150line130>
> >
> &g
/DefaultMetadataService.java
(line 295)
<https://reviews.apache.org/r/47810/#comment219716>
why is this needed? We fixed this earlier by allowing keywords which are
escaped by quotes ``
- Suma Shivaprasad
On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg
/GraphBackedSearchIndexer.java
(line 356)
<https://reviews.apache.org/r/47810/#comment219718>
can remove propertyname and get it from PropertyKey everywhere?
- Suma Shivaprasad
On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/#review152059
---
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 7, 2016, 9:28
> On Oct. 4, 2016, 9 p.m., Suma Shivaprasad wrote:
> > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java,
> > line 130
> > <https://reviews.apache.org/r/47810/diff/13-14/?file=150#file150line130>
> >
> &g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review152199
---
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 11, 2016, 6:40
search with escape quotes
Thanks,
Suma Shivaprasad
+1. Agreed
The community is really vibrant/active with many companies involved in
shaping the roadmap and features.
It has also grown a lot from past year with a lot of interest from users
and this is a great time to propose for graduation
I volunteer to start working on the graduation and take
t; > Is this called?
Its not .. added a function but wasnt used later. Can remove if needed
- Suma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58750/#review173322
--
0689line67>
> >
> > I suggest logging the real Exception here.
will fix
- Suma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58750/#review173322
--
.testing search with escape quotes
Thanks,
Suma Shivaprasad
/ExportService.java
Line 84 (original)
<https://reviews.apache.org/r/56724/#comment247006>
why was this removed?
- Suma Shivaprasad
On March 2, 2017, 10:17 p.m., Jeff Hagelberg wrote:
>
> ---
> This is an automatically generated e
/ExportService.java
Line 84 (original)
<https://reviews.apache.org/r/56724/#comment247081>
But we should still set the attribute which affects memory usage for
compiled query cache.
- Suma Shivaprasad
On March 2, 2017, 10:17 p.m., Jeff Hagelberg
hiraj mad...@apache.org <mailto:mad...@apache.org>
Mitch Schussler mschuss...@apache.org <mailto:mschuss...@apache.org>
Neeru Gupta guptane...@us.ibm.com <mailto:guptane...@us.ibm.com>
Nixon Rodrigues ni...@apache.org <mailto:ni...@apache.org>
Sarath Subramanian sar...@apache.org
Done.
Suma
On Thu, Jun 1, 2017 at 5:07 AM, qinglin Xia wrote:
> Hi, I raised some issues in Jira, and want to assign them to my colleague
> or myself, can you please also add me to the JIRA group? My JIRA ID is
> “qinglin,xia”
>
> Thanks so much!
>
> Qinglin.
>
> On Mon, May 22, 2017 at 6:17 PM
The community vote to graduate Apache Atlas from incubator to TLP has
passed successfully with
*12* binding vote and *0* -1s
Thanks
Suma
)
<https://reviews.apache.org/r/59799/#comment250643>
why is auto commit set to true. This will cause issues when there is a
transient failure on Atlas server and no retries will be attempted
- Suma Shivaprasad
On June 5, 2017, 8:30 a.m., Nixon Rodrigues
/AtlasKafkaConsumer.java
Lines 70 (patched)
<https://reviews.apache.org/r/59799/#comment250644>
disable auto commit in config and commit manually here
- Suma Shivaprasad
On June 5, 2017, 8:30 a.m., Nixon Rodrigues wrote:
>
> ---
/KafkaNotification.java
Line 129 (original), 133 (patched)
<https://reviews.apache.org/r/59799/#comment250755>
any reason this was removed?
- Suma Shivaprasad
On June 5, 2017, 8:30 a.m., Nixon Rodrigues wrote:
>
> ---
> This is a
I see that its already added.
Suma
On Tue, Jun 6, 2017 at 11:04 PM, XinZhi Luo wrote:
> Hi, I am now at the atlas Jira group, can you please add me as a
> contributor in Atlas?
> Thanks so much!
>
> Xinzhi.
>
/TypeDefChangeListener.java
(line 24)
<https://reviews.apache.org/r/52585/#comment221100>
any reason why we need a different Exception type here ? - AtlasException
already exists?
- Suma Shivaprasad
On Oct. 12, 2016, midnight, Apoorv Naik
/v1/AtlasTypeDefGraphStoreV1.java
(line 68)
<https://reviews.apache.org/r/52585/#comment221125>
are all the queries going through indexes or throwing a warning fora full
scan? Can we make sure that indexes are being used.
- Suma Shivaprasad
On Oct. 12, 2016, 12:09 a.m., Apoorv Naik
> On Oct. 12, 2016, 12:56 a.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java,
> > line 68
> > <https://reviews.apache.org/r/52585/diff/17/?file=1531875#file1531875line68>
> >
lse is missing from
current typesystem which needs to be mapped.
- Suma Shivaprasad
On Oct. 12, 2016, 4:24 p.m., Apoorv Naik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/AtlasClassification.java
(line 46)
<https://reviews.apache.org/r/52585/#comment221369>
add javadocs for all the intg classes
- Suma Shivaprasad
On Oct. 12, 2016, 4:24 p.m., Apoorv Naik wrote:
>
> ---
> This is an automatically g
I debug the usual way by starting ATLAS server with the remote debugger
options in atlas_start.py and then attaching to that with the IDE and then
either firing a REST request directly or have a hook like HiveHook etc send
a request to ATLAS server. However I havent used it with Eclipse and done
it
s ,David.
>
>
>
>
>
> From: Suma Shivaprasad
> To: dev@atlas.incubator.apache.org
> Date: 14/10/2016 00:38
> Subject:Re: Atlas debugging tips?
>
>
>
> I debug the usual way by starting ATLAS server with the remote debugger
> options in atla
(line 119)
<https://reviews.apache.org/r/52895/#comment221839>
when would typeDef be null and still a valid case?
- Suma Shivaprasad
On Oct. 14, 2016, 7:40 p.m., Madhan Neethiraj wrote:
>
> ---
> This is an automatica
(line 145)
<https://reviews.apache.org/r/52895/#comment221840>
currently I dont see any beaviour diff between the currenty method and
above one . Is this still WIP?
- Suma Shivaprasad
On Oct. 14, 2016, 7:40 p.m., Madhan Neethiraj
> On Oct. 14, 2016, 9:45 p.m., Suma Shivaprasad wrote:
> > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java, line 154
> > <https://reviews.apache.org/r/52895/diff/1/?file=1538478#file1538478line154>
> >
> > currently I dont see any beaviour dif
/AtlasStructDef.java (line 486)
<https://reviews.apache.org/r/52954/#comment222143>
comment needs to be changed for supported type from foreignKeyRef to
mappedFromRef
- Suma Shivaprasad
On Oct. 17, 2016, 7:24 p.m., Madhan Neethiraj
(line 359)
<https://reviews.apache.org/r/52954/#comment222144>
need to handle case where foreign key is set independently with onDelete =
null which translates to reverseAttributeName like we discussed
- Suma Shivaprasad
On Oct. 17, 2016, 7:24 p.m., Madhan Neethiraj
/v1/AtlasStructDefStoreV1.java
(line 420)
<https://reviews.apache.org/r/52954/#comment222409>
should we flag this as an error since the user might expect an error or the
reference to be associated at this stage?
- Suma Shivaprasad
On Oct. 18, 2016, 2:52 a.m., Madhan Neethiraj
/v1/AtlasStructDefStoreV1.java
(line 491)
<https://reviews.apache.org/r/52954/#comment222417>
can we explicitly throw an error for map types not being handled for
foreign key/mappedfromref and reverseAttributeName and isComposite?
- Suma Shivaprasad
On Oct. 18, 2016, 6:27 p.m.,
/v1/AtlasStructDefStoreV1.java
(line 527)
<https://reviews.apache.org/r/52954/#comment222425>
can you pls add comments for this block and the cases it handles. Would be
easier to understand later
- Suma Shivaprasad
On Oct. 18, 2016, 6:27 p.m., Madhan Neethiraj
/v1/AtlasStructDefStoreV1.java
(line 452)
<https://reviews.apache.org/r/52954/#comment222427>
if reverserAttributeName is null, why do we need to set isComposite to
true? Then it translates only to foreign key being true, correct?
- Suma Shivaprasad
On Oct. 18, 2016, 6:27 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52954/#review153172
---
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 18, 2016, 8:38
/v1/AtlasClassificationDefStoreV1.java
(line 47)
<https://reviews.apache.org/r/53007/#comment222518>
we should inject here
- Suma Shivaprasad
On Oct. 19, 2016, 12:17 a.m., Madhan Neethiraj wrote:
>
> ---
> This is a
/v1/AtlasClassificationDefStoreV1.java
(line 32)
<https://reviews.apache.org/r/53007/#comment222519>
we are importing from wrong TYpeCategory here - it should be
AtlasTYpe.TypeCategory
- Suma Shivaprasad
On Oct. 19, 2016, 12:17 a.m., Madhan Neethiraj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53007/#review153236
---
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 19, 2016, 12
(line 642)
<https://reviews.apache.org/r/53029/#comment222593>
should we update typCache here?
- Suma Shivaprasad
On Oct. 19, 2016, 7:20 p.m., Madhan Neethiraj wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53029/#review153323
---
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 19, 2016, 11
(line 511)
<https://reviews.apache.org/r/53029/#comment222604>
can we mark this as experimental until we fully support it with instance
existence checks
- Suma Shivaprasad
On Oct. 19, 2016, 7:20 p.m., Madhan Neethiraj
Hi All,
The Apache Atlas PPMC has asked Madhan Neethiraj to become a committer and
we
are pleased to announce that he has accepted.
Madhan has been quite active in Apache Atlas community and has contributed
towards the high-level v2 Atlas APIs, stabilizing the 0.7 release and
other bug fixes.
C
Hi All,
The Apache Atlas PPMC has asked Jeffrey Hagelberg to become a committer and
we
are pleased to announce that he has accepted.
Jeffrey has deep knowledge of Atlas core with consistent contributions
towards abstracting out the the ATLAS graph database interactions and
other bug fixes.
Con
Hi All,
The Apache Atlas PPMC has asked Jeffrey Hagelberg to become a committer and
we
are pleased to announce that he has accepted.
Jeffrey has deep knowledge of Atlas core with consistent contributions
towards abstracting out the the ATLAS graph database interactions and
other bug fixes.
Con
Hi All,
The Apache Atlas PPMC has asked Jeffrey Hagelberg to become a committer and
we
are pleased to announce that he has accepted.
Jeffrey has deep knowledge of Atlas core with consistent contributions
towards abstracting out the the ATLAS graph database interactions and
other bug fixes.
Con
Hi All,
The Apache Atlas PPMC has asked Vimal Sharma to become a committer and we
are pleased to announce that he has accepted.
Vimal has been a consistent contributor to Atlas and has contributed has
contributed towards Hive, Storm Hooks and some critical ATLAS bug fixes for
0.7 release.
Congra
Please ignore this mail with subject as VOTE. It was a typo.
Thanks
Suma
On Thu, Oct 20, 2016 at 10:39 AM, Suma Shivaprasad <
sumasai.shivapra...@gmail.com> wrote:
> Hi All,
>
> The Apache Atlas PPMC has asked Jeffrey Hagelberg to become a committer and
> we
> are please
/v1/AtlasStructDefStoreV1.java
(line 407)
<https://reviews.apache.org/r/53080/#comment222996>
also need to allow only addition of optional attributes
- Suma Shivaprasad
On Oct. 20, 2016, 11:24 p.m., Madhan Neethiraj
/v1/AtlasStructDefStoreV1.java
(line 405)
<https://reviews.apache.org/r/53080/#comment222995>
we will disallow removal of required attributes for now and see hot to fix
that later?
- Suma Shivaprasad
On Oct. 20, 2016, 11:24 p.m., Madhan Neethiraj
(line 58)
<https://reviews.apache.org/r/53073/#comment223001>
rename to inputs, outputs for paths and both to /complete ?
- Suma Shivaprasad
On Oct. 20, 2016, 6:03 p.m., Sarath Subramanian wrote:
>
> ---
> This is a
codes to those as well and
set the REST error code to 500 in that case
- Suma Shivaprasad
On Oct. 21, 2016, 5:04 a.m., Apoorv Naik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On Oct. 21, 2016, 10:31 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java,
> > line 23
> > <https://reviews.apache.org/r/52995/diff/7/?file=1542874#file1542874line23>
> >
>
> On Oct. 21, 2016, 10:31 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java,
> > line 23
> > <https://reviews.apache.org/r/52995/diff/7/?file=1542874#file1542874line23>
> >
>
> On Oct. 21, 2016, 10:31 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java,
> > line 23
> > <https://reviews.apache.org/r/52995/diff/7/?file=1542874#file1542874line23>
> >
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53080/#review153720
---
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 22, 2016, 6:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review153729
---
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 17, 2016, 11
/AllExceptionMapper.java (line
36)
<https://reviews.apache.org/r/52995/#comment223149>
should be AllExceptionMapper.class
- Suma Shivaprasad
On Oct. 24, 2016, 4:21 p.m., Apoorv Naik wrote:
>
> ---
> This is an automatically gener
/AllExceptionMapper.java (line
36)
<https://reviews.apache.org/r/52995/#comment223150>
also add @Singleton
- Suma Shivaprasad
On Oct. 24, 2016, 8:56 p.m., Apoorv Naik wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153744
---
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 24, 2016, 9:29
/GraphBackedSearchIndexer.java
(line 137)
<https://reviews.apache.org/r/52257/#comment223163>
The Index should be of String type..not Long here?
- Suma Shivaprasad
On Oct. 17, 2016, 11:44 a.m., Vimal Sharma wrote:
>
> ---
> On Oct. 24, 2016, 8:10 p.m., Suma Shivaprasad wrote:
> > Ship It!
Pls fix below comments
- Suma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#rev
/store/graph/AtlasEntityStore.java
PRE-CREATION
Diff: https://reviews.apache.org/r/53153/diff/
Testing
---
Thanks,
Suma Shivaprasad
/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION
Diff: https://reviews.apache.org/r/53156/diff/
Testing
---
Thanks,
Suma Shivaprasad
/GraphBackedSearchIndexer.java
(line 133)
<https://reviews.apache.org/r/52257/#comment223168>
why do we need a composite index only on the attribute. Would recommend
creating by typeName + modifiedTime since DSK always adds the typeName . If
needed we will add the individual index later
/GraphBackedDiscoveryServiceTest.java
(line 188)
<https://reviews.apache.org/r/52257/#comment223169>
can you add test for querying by these system attributes as well?
- Suma Shivaprasad
On Oct. 17, 2016, 11:44 a.m., Vimal Sharma
/rest/EntitiesREST.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION
Diff: https://reviews.apache.org/r/53156/diff/
Testing
---
Thanks,
Suma Shivaprasad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53133/#review153947
---
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 24, 2016, 9:58
/InstanceLineageService.java
(line 61)
<https://reviews.apache.org/r/53073/#comment223645>
can you add tests for Service and REST API?
- Suma Shivaprasad
On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian wrote:
>
> ---
> This is a
/InstanceLineageService.java
(line 163)
<https://reviews.apache.org/r/53073/#comment223646>
replace all stacktrace with change to log, exception
- Suma Shivaprasad
On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian wrote:
>
> ---
/GraphBackedSearchIndexer.java
(line 281)
<https://reviews.apache.org/r/53207/#comment223647>
Do checks by TypeCategory rather another constant
- Suma Shivaprasad
On Oct. 28, 2016, 2:18 a.m., Apoorv Naik wrote:
>
> ---
(line 75)
<https://reviews.apache.org/r/53207/#comment223648>
TypeCategory is already added as part of respective AtlasType. Why is this
needed?
- Suma Shivaprasad
On Oct. 28, 2016, 2:18 a.m., Apoorv Naik wrote:
>
> ---
/GraphBackedSearchIndexer.java
(line 631)
<https://reviews.apache.org/r/53207/#comment223650>
log exception if its not getting logged upstream
- Suma Shivaprasad
On Oct. 28, 2016, 2:18 a.m., Apoorv Naik wrote:
>
> ---
/GraphBackedSearchIndexer.java
(line 274)
<https://reviews.apache.org/r/53207/#comment223652>
log attribname
- Suma Shivaprasad
On Oct. 28, 2016, 2:18 a.m., Apoorv Naik wrote:
>
> ---
> This is an automatically generated e
/AtlasLineageInfo.java (line
45)
<https://reviews.apache.org/r/53073/#comment223653>
is this a map of guids vs headers . can you pls add javadoc
- Suma Shivaprasad
On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian wrote:
>
> ---
(line 80)
<https://reviews.apache.org/r/53073/#comment223655>
inline ret=null and assignment into into one line
- Suma Shivaprasad
On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian wrote:
>
> ---
> This is an automatica
(line 64)
<https://reviews.apache.org/r/53073/#comment223656>
validate query params passed here and then pass to service layer
- Suma Shivaprasad
On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian wrote:
>
> ---
/InstanceLineageService.java
(line 122)
<https://reviews.apache.org/r/53073/#comment223657>
set right error codes
- Suma Shivaprasad
On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian wrote:
>
> ---
> This is an automatically gener
/InstanceLineageService.java
(line 252)
<https://reviews.apache.org/r/53073/#comment223658>
use AtlasClient for the string constants.
- Suma Shivaprasad
On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian wrote:
>
> ---
> This is a
/InstanceLineageService.java
(line 180)
<https://reviews.apache.org/r/53073/#comment223659>
looks like depth is not being pushed to the closure query? we should
ideally push it to the query
- Suma Shivaprasad
On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian
/InstanceLineageService.java
(line 117)
<https://reviews.apache.org/r/53073/#comment223654>
remove stacktrace
- Suma Shivaprasad
On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian wrote:
>
> ---
> This is an automatically generated e
/InstanceLineageService.java
(line 183)
<https://reviews.apache.org/r/53073/#comment223660>
can you explore how we can merge inputs and outputs at closure query layer?
- Suma Shivaprasad
On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian
19)
<https://reviews.apache.org/r/53039/#comment223681>
reuse typesystem/src/test/resources...any reasons why we need another one?
- Suma Shivaprasad
On Oct. 20, 2016, 1:23 a.m., Apoorv Naik wrote:
>
> ---
> This is a
/AtlasTypeDefGraphStoreTest.java
(line 181)
<https://reviews.apache.org/r/53039/#comment223682>
not needed since its in mem and we have graph cleanup?
- Suma Shivaprasad
On Oct. 20, 2016, 1:23 a.m., Apoorv Naik wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53272/#review154200
---
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 28, 2016, 11
492)
<https://reviews.apache.org/r/53039/#comment223685>
remove if not needed?
- Suma Shivaprasad
On Oct. 20, 2016, 1:23 a.m., Apoorv Naik wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
57)
<https://reviews.apache.org/r/53039/#comment223691>
can you move this to intg test . Would be useful for tests down the stream
as well. The graph part could be moved out
- Suma Shivaprasad
On Oct. 20, 2016, 1:23 a.m., Apoorv Naik
/InstanceLineageService.java
(line 117)
<https://reviews.apache.org/r/53073/#comment223782>
also map to right error code
- Suma Shivaprasad
On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian wrote:
>
> ---
> This is an automatica
/DefaultMetadataServiceTest.java
(line 1139)
<https://reviews.apache.org/r/53207/#comment223802>
do we need to check for changed entities here? What does onChange(null)
mean?
- Suma Shivaprasad
On Oct. 29, 2016, 12:09 a.m., Apoorv Naik
/DefaultMetadataServiceTest.java
(line 1139)
<https://reviews.apache.org/r/53207/#comment223804>
I understood from the DMS code that we are trying to restore types fro, the
store here. In this we should probably check that the number of types restored
is the same as expected?
- Suma Shivaprasad
/53316/diff/
Testing
---
Pending - UTS in progress
REST layer testing is also pending
Thanks,
Suma Shivaprasad
/DefaultMetadataServiceTest.java
(line 1150)
<https://reviews.apache.org/r/53207/#comment223830>
add exception in fail
- Suma Shivaprasad
On Oct. 31, 2016, 9:41 p.m., Apoorv Naik wrote:
>
> ---
> This is an automatically generated e
/AtlasTypeDefGraphStore.java
(line 311)
<https://reviews.apache.org/r/53207/#comment223832>
replace empty list with incoming list
- Suma Shivaprasad
On Oct. 31, 2016, 9:59 p.m., Apoorv Naik wrote:
>
> ---
> This is a
/GraphBackedSearchIndexer.java
(line 268)
<https://reviews.apache.org/r/53207/#comment223833>
replace with graphHelper.getQualifiedName to compute the propertyName
- Suma Shivaprasad
On Oct. 31, 2016, 10:09 p.m., Apoorv Naik
webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION
Diff: https://reviews.apache.org/r/53156/diff/
Testing
---
Thanks,
Suma Shivaprasad
201 - 300 of 1928 matches
Mail list logo
