Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1846
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1844
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1838
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1833
Why this is a bug? Most of ACS searches using name field work exactly this
way to bring list of VMs, templates etc when partial name is specified. If
exact name match is expected it needs to be
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1828
LGTM on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@rhtyd @jburwell @karuturi What is the easiest way to resolve this merge
conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@milamberspace Can you check if file
/usr/share/cloudstack-management/setup/db/schema-481to490.sql in your
installation has the SQL alter image_store_details table line ?
---
If your project
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@milamberspace Column details is supposed to be added during 4.8 to 4.9
schema upgrade. Most likely when you upgraded to 4.9 this PR hadn't been merged
yet. You can simply apply this stat
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1754
@rhtyd We seem to have consistently more tests failing lately
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1807
@syed @rhtyd @abhinandanprateek Why cant we simply rename all install paths
in DB for existing snapshots instead. It can be as simple as adding this query
to schema upgrade path
UPDATE
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1807
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/828
LGTM. This patch has been working well in production for over a year now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner Thanks a lot. I totally agree that resetting hosts
doesn't really need to be a part of transaction and should be extracted to a
new method. The same is for lines 527-546
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1753
@rhtyd Only 2 PRs were merged in the interval between last successful run
and failure: PR1766 and PR1545
1766 was merged to 4.8 and was hypervisor agnostic so all points at PR1545
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1753
@rhtyd 4.10 tests started failing after 11/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1753
@rhtyd Both 4.9 and 4.10 now fail as well as PR based on 4.9 e.g. PR 1659
with 13 tests on KVM but PRs based on 4.8 succeed e.g. PR1710 and PR1753. Might
be some interference from one of the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner I might be wrong but 2d came from
findAndUpdateDirectAgentToLoad in HostDaoImpl which also creates a large
transaction.
---
If your project is set up for it, you can reply
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner You might be right that pod_vlan_map should be in the
join. May be I didn't find the correct methods after all. @jburwell @rhtyd What
do you think?
I was able to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1753
@rhtyd All the new failures are due to inability to SSH to VMs. Can we
re-run this to filter environmental issue or recent PR merge?
---
If your project is set up for it, you can reply to this
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1738
LGTM as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner Tried tracing where deadlock 5 originated. It seems
both transactions are part of the same method fetchNewPublicIp in
IpAddressManagerImpl . Transactions are executed on
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner Looks like the deadlocks 2 and 3 are the same. I
scanned our production log and since last December we had 6400 deadlocks. Out
of them close to 6000 were Deadlock 1
20
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
Here it is few samples of deadlocks we observe in high transaction volume
environment with multiple management servers. As you can see most of them are
concurrent operations from different
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner @swill @wido @koushik-das @karuturi @rhtyd @jburwell
Let's ask a different question. If we are to try to implement a general way of
dealing with deadlocks in ACS how cou
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1754
@rhtyd I quickly checked. test_06_download_detached_volume failed only on
last run due to
errorcode : 530, errortext : u'Unable to create a link for entity at
volumes/76/141/e19cdd3c
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1686
I am -1 in the current form
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
What about if the author can figure out a way to identify all part of
transaction being cancelled and retry all parts? Or retry the whole
transaction? It would be nice to open a path for the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@jburwell We've been running this fix as a part of proprietary CS for
several weeks now. We are observing elimination of deadlocks and no DB
corruption. Retry seems to be the only realisti
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@nvazquez @koushik-das If we go this route we might want to change update
API to behave consistently. It would make sense to allow overriding any
details.
---
If your project is set up for it
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@koushik-das No I don't. I tend to agree with you but obviously the
implementation will be messier since configs are random. @nvazquez Do you think
it can be changes so that modificatio
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@koushik-das Good catch. Thanks. I think there are 2 options. Either not
allow changing service offering for VM with VM snapshot if current offering is
Custom. Or save custom offering details to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@koushik-das @ustcweizhou Just want to add on the use case. There is
growing need to change template/VM details for after the deployment e.g. to
switch root disk controller or change ratio of
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhytd @jburwell @karuturi test_nested_virtualization_vmware
Success 305.03
The other tests fail due to environmental issues e.g. below. I think it is
ready for merging
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell @rhtyd Looks like blueorangutain vmware side has issues on
hypervisor. Can you take a look and then re-kick the tests? Some errors were
due to that.
530, errortext : u'U
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1676
@jburwell @rhtyd @karuturi This PR also seems to be ready for merging
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@karuturi @jburwell As per @rhtyd we can run additional tests with
blueorangutan . Can we execute them and merge this PR since it passes the
standard test suite just fine?
---
If your
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1677
@rhtyd @karuturi All LGTM are in order. Can we merge this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@jburwell I concur but if @yvsubhash verified that those methods don't
participate in complex DML transactions this might be still a good start. If so
this approach might be expanded lat
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@jburwell @yvsubhash I might be wrong but this PR will retry on deadlock
for only 2 DAO methods searchIncludingRemoved and
customSearchIncludingRemoved. No update methods are set with this
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@jburwell I thought that most if not all of ACS interaction through DAO is
rather atomic transactions. Do we have cases of multiple DML statements as a
part of the same transaction? We have been
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@jburwell @yvsubhash My understanding that all roll back statements will
receive MYSQL_DEADLOCK_ERROR_CODE and will be retired as a part of this patch.
---
If your project is set up for it
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
LGTM. Finally !!! We have been seeing occasional deadlocks in environments
with high level transaction rate. @rhtyd @jburwell This could be a good add to
4.8/4.9.
---
If your project is set
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1749
@rhtyd @PaulAngus Can we re-run test again to see if it was one time issue?
On a general note it would be extremely helpful that during blueorangutain runs
we rotate management server log before
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1749
Trillian failures might be environmental. As if NFS share lost proper
permissions. E.g template test failed due to that:
Exception: Job failed: {jobprocstatus : 0, created :
u'2016-11-
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1735
@ustcweizhou Not necessary. The issue affects removal of primary storage DS
where there are snapshot copies. After that the snapshot could remain on
secondary storage.
---
If your project is
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1735
@rhtyd @jburwell The tests didn't kick in last time. Can we fire matrix
again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1676
@jburwell Non-VPC tests on VmWare passed this time. This one seems to be
ready for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1676
@jburwell PR1560. At this point it might be make sense to leave it for 4.10
and not to forward merge it. I checked blueorangutan log and without
management server log it is impossible to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1676
@blueorangutan test vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1676
@jburwell This is most likely blueorangutan issue. This code is already
merged into Master via PR1560. We can even cancel this PR and leave it in 4.10
only.
---
If your project is set up for
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1677
LGTM for testing
```
2016-10-24 20:52:55 47 test files ro run
2016-10-24 20:52:55 Running test file:
test/integration/smoke/test_affinity_groups_projects.py
2016-10-24 20:56:07
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1677
@rhtyd @murali-reddy @PaulAngus @jburwell Thanks for fixing all outstanding
Marvin test issues. We have now 100% passing score on Marvin integration tests
on RHEL 6 management server , advanced
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1686
@rhtyd This clearly a bug. os_type_id was always supposed to be a OS type
as per:
@SerializedName(ApiConstants.OS_TYPE_ID)
@Param(description = "OS type id of the vm&qu
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
Thanks @rhtyd It didi it. Now two of them still fail but the rest are
successful
```
Tests out-of-band management ownership expiry across multi-mgmt server ...
=== TestName
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
@rhtyd We run marvin tests on management server. Do we need any special
configuration in test data for out-of-band-managment ?
The errors seem to point at missing methods in
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1703
The same results as 1692. Overall much better state. We have still failure
in execution of the following tests:
test_privategw_acl
test_routers_network_ops
test_vpc_redundant
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
Failed tests
```
test_02_vpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_02_vpc_privategw_static_routes | Status : FAILED
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
Successful tests. RHEL 6 management server, advanced networking, Vmware
5.5/6 hypervisors
```
test DeployVM in anti-affinity groups for project ... === TestName
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
We finished testing on vmware 5.5 and 6. Overall much better state. We have
still failure in execution of the following tests:
test_privategw_acl
test_routers_network_ops
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
We will post results later today for Vmware 5.5/6 tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
Yes +1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
@rhtyd Yes I totally agree. It could take a while to flash out the
remaining issues and we should complete the release and allow merging
outstanding PRs in the meantime.
---
If your project is
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/872
@swill Can you try changing in ipsec.conf
plutostart=no
keyexchange=ikev2
and adding
ike=aes256-sha1-modp1024!
esp=aes256-sha1!
From: Will Stevens
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1702
Testing LGTM. Vmware 5.5. and 6.0 , advanced networking, RHEL 6 management
servers
```
test DeployVM in anti-affinity groups for project ... === TestName
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
@rhtyd Vmsnapshot tests fail on vmware 6.0 due to issue resolved in PR1677.
1677 is targeted for 4.9 so I agree on removing that test for ACS 4.8
---
If your project is set up for it, you
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/872
@swill The default way is using integrated VPN client in Windows. For
windows 8.1 the guide is here
https://blogs.technet.microsoft.com/networking/2014/01/13/configuring-native-vpn-client
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1698
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd @jburwell Please don't forget to close loop on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1698
On Vmware they are Windows 10 is supported only starting ESX 6 so only 3
extra lines would be needed. I will help with testing on vmware:
INSERT IGNORE INTO `cloud`.`guest_os_hypervisor
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
@NuxRo Then 'Other Linux (64-bit)' will be appropriate. It works for the
time being as PV with current vmware but could fail at some point. For example
when we were testing @rhtyd tin
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
@jburwell @rhtyd @borisstoyanov Do you have to do anything to make
test_lb_internal to pass on Vmware? No matter what we try we get 3 exceptions
2016-10-04 07:18:24,897 - CRITICAL
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
I suggest also to change OS type in test_internal_lb.py and test_vpc_vpn
for
"macchinina vmware"
from
"ostype": "Other PV (64-bit)",
to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
@jburwell Sorry my bad. It is PR 871 . The reason the test fails is:
```
After running test_vm_snapshots.py we're getting exception on
test_01_test_vm_volume_snapshot as it was exp
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
BTW failure of test_01_test_vm_volume_snapshot is due to PR571 which
modified marvin test to succeed against incorrect functionality.
---
If your project is set up for it, you can reply to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
I am LGTM on this now. Thanks @NuxRo @PaulAngus @rhtyd for fixing maccinina
template. VPN_VPC and INTERNAL_LB test work for Vmware
---
If your project is set up for it, you can reply to this
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd @jburwell Actually ESX 6 mapping are here schema-461to470.sql
INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` values
(25,UUID(),'VMware','6.0',128,0,13
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1698
@karuturi Can we add mappings for Windows 10 for Vmware hypervisors as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@jburwell @rhtyd I apologies. The issue in our environment was due to using
ESX v6. Once I added new mapping for it Vmware properly assigned Os type. It
would be nice to officially certify ESX6
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@jburwell @rhtyd Sorry for a flood of messages. I checked and we do have
mapping for all OS for Vmware 6 in ACS. It was introduced in 4.7 so that means
this PR needs to have those 2 lines added
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1696
@rhtyd @jburwell @karuturi I confirm the same issue with this PR as with
'CLOUDSTACK-5922:Incorrect handling RHEL guests for 5.5 to 5.9
When Os type is specified as Ubuntu 16.04
