Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1692
Thanks @rhtyd It didi it. Now two of them still fail but the rest are
successful
```
Tests out-of-band management ownership expiry across multi-mgmt server ...
=== TestName
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1686
@rhtyd This clearly a bug. os_type_id was always supposed to be a OS type
as per:
@SerializedName(ApiConstants.OS_TYPE_ID)
@Param(description = "OS type id of the vm&qu
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1677
@rhtyd @murali-reddy @PaulAngus @jburwell Thanks for fixing all outstanding
Marvin test issues. We have now 100% passing score on Marvin integration tests
on RHEL 6 management server , advanced
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1677
LGTM for testing
```
2016-10-24 20:52:55 47 test files ro run
2016-10-24 20:52:55 Running test file:
test/integration/smoke/test_affinity_groups_projects.py
2016-10-24 20:56:07
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1676
@jburwell This is most likely blueorangutan issue. This code is already
merged into Master via PR1560. We can even cancel this PR and leave it in 4.10
only.
---
If your project is set up for
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1676
@blueorangutan test vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1676
@jburwell PR1560. At this point it might be make sense to leave it for 4.10
and not to forward merge it. I checked blueorangutan log and without
management server log it is impossible to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1676
@jburwell Non-VPC tests on VmWare passed this time. This one seems to be
ready for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1735
@rhtyd @jburwell The tests didn't kick in last time. Can we fire matrix
again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1735
@ustcweizhou Not necessary. The issue affects removal of primary storage DS
where there are snapshot copies. After that the snapshot could remain on
secondary storage.
---
If your project is
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1749
Trillian failures might be environmental. As if NFS share lost proper
permissions. E.g template test failed due to that:
Exception: Job failed: {jobprocstatus : 0, created :
u'2016-11-
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1749
@rhtyd @PaulAngus Can we re-run test again to see if it was one time issue?
On a general note it would be extremely helpful that during blueorangutain runs
we rotate management server log before
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
LGTM. Finally !!! We have been seeing occasional deadlocks in environments
with high level transaction rate. @rhtyd @jburwell This could be a good add to
4.8/4.9.
---
If your project is set
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@jburwell @yvsubhash My understanding that all roll back statements will
receive MYSQL_DEADLOCK_ERROR_CODE and will be retired as a part of this patch.
---
If your project is set up for it
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@jburwell I thought that most if not all of ACS interaction through DAO is
rather atomic transactions. Do we have cases of multiple DML statements as a
part of the same transaction? We have been
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@jburwell @yvsubhash I might be wrong but this PR will retry on deadlock
for only 2 DAO methods searchIncludingRemoved and
customSearchIncludingRemoved. No update methods are set with this
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@jburwell I concur but if @yvsubhash verified that those methods don't
participate in complex DML transactions this might be still a good start. If so
this approach might be expanded lat
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1677
@rhtyd @karuturi All LGTM are in order. Can we merge this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@karuturi @jburwell As per @rhtyd we can run additional tests with
blueorangutan . Can we execute them and merge this PR since it passes the
standard test suite just fine?
---
If your
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1676
@jburwell @rhtyd @karuturi This PR also seems to be ready for merging
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@jburwell @rhtyd Looks like blueorangutain vmware side has issues on
hypervisor. Can you take a look and then re-kick the tests? Some errors were
due to that.
530, errortext : u'U
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rhytd @jburwell @karuturi test_nested_virtualization_vmware
Success 305.03
The other tests fail due to environmental issues e.g. below. I think it is
ready for merging
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1542
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@koushik-das @ustcweizhou Just want to add on the use case. There is
growing need to change template/VM details for after the deployment e.g. to
switch root disk controller or change ratio of
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@koushik-das Good catch. Thanks. I think there are 2 options. Either not
allow changing service offering for VM with VM snapshot if current offering is
Custom. Or save custom offering details to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@koushik-das No I don't. I tend to agree with you but obviously the
implementation will be messier since configs are random. @nvazquez Do you think
it can be changes so that modificatio
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@nvazquez @koushik-das If we go this route we might want to change update
API to behave consistently. It would make sense to allow overriding any
details.
---
If your project is set up for it
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@jburwell We've been running this fix as a part of proprietary CS for
several weeks now. We are observing elimination of deadlocks and no DB
corruption. Retry seems to be the only realisti
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
What about if the author can figure out a way to identify all part of
transaction being cancelled and retry all parts? Or retry the whole
transaction? It would be nice to open a path for the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1686
I am -1 in the current form
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1754
@rhtyd I quickly checked. test_06_download_detached_volume failed only on
last run due to
errorcode : 530, errortext : u'Unable to create a link for entity at
volumes/76/141/e19cdd3c
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner @swill @wido @koushik-das @karuturi @rhtyd @jburwell
Let's ask a different question. If we are to try to implement a general way of
dealing with deadlocks in ACS how cou
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
Here it is few samples of deadlocks we observe in high transaction volume
environment with multiple management servers. As you can see most of them are
concurrent operations from different
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner Looks like the deadlocks 2 and 3 are the same. I
scanned our production log and since last December we had 6400 deadlocks. Out
of them close to 6000 were Deadlock 1
20
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner Tried tracing where deadlock 5 originated. It seems
both transactions are part of the same method fetchNewPublicIp in
IpAddressManagerImpl . Transactions are executed on
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1738
LGTM as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1753
@rhtyd All the new failures are due to inability to SSH to VMs. Can we
re-run this to filter environmental issue or recent PR merge?
---
If your project is set up for it, you can reply to this
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner You might be right that pod_vlan_map should be in the
join. May be I didn't find the correct methods after all. @jburwell @rhtyd What
do you think?
I was able to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner I might be wrong but 2d came from
findAndUpdateDirectAgentToLoad in HostDaoImpl which also creates a large
transaction.
---
If your project is set up for it, you can reply
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1753
@rhtyd Both 4.9 and 4.10 now fail as well as PR based on 4.9 e.g. PR 1659
with 13 tests on KVM but PRs based on 4.8 succeed e.g. PR1710 and PR1753. Might
be some interference from one of the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1753
@rhtyd 4.10 tests started failing after 11/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1753
@rhtyd Only 2 PRs were merged in the interval between last successful run
and failure: PR1766 and PR1545
1766 was merged to 4.8 and was hypervisor agnostic so all points at PR1545
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@rafaelweingartner Thanks a lot. I totally agree that resetting hosts
doesn't really need to be a part of transaction and should be extracted to a
new method. The same is for lines 527-546
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/828
LGTM. This patch has been working well in production for over a year now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1807
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1807
@syed @rhtyd @abhinandanprateek Why cant we simply rename all install paths
in DB for existing snapshots instead. It can be as simple as adding this query
to schema upgrade path
UPDATE
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1754
@rhtyd We seem to have consistently more tests failing lately
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@milamberspace Column details is supposed to be added during 4.8 to 4.9
schema upgrade. Most likely when you upgraded to 4.9 this PR hadn't been merged
yet. You can simply apply this stat
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@milamberspace Can you check if file
/usr/share/cloudstack-management/setup/db/schema-481to490.sql in your
installation has the SQL alter image_store_details table line ?
---
If your project
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@rhtyd @jburwell @karuturi What is the easiest way to resolve this merge
conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1828
LGTM on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1833
Why this is a bug? Most of ACS searches using name field work exactly this
way to bring list of VMs, templates etc when partial name is specified. If
exact name match is expected it needs to be
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1838
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1844
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1846
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user serg38 opened a pull request:
https://github.com/apache/cloudstack-www/pull/30
Added Sergey and Nicolas to committers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/serg38/cloudstack-www patch-1
Alternatively you
GitHub user serg38 opened a pull request:
https://github.com/apache/cloudstack-www/pull/31
Addingn Sergey and Nicolas to committers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/serg38/cloudstack-www patch-2
Alternatively you
GitHub user serg38 opened a pull request:
https://github.com/apache/cloudstack-www/pull/32
Adding Sergey and Nicolas to commiters
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/serg38/cloudstack-www master
Alternatively you
Github user serg38 closed the pull request at:
https://github.com/apache/cloudstack-www/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user serg38 closed the pull request at:
https://github.com/apache/cloudstack-www/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user serg38 closed the pull request at:
https://github.com/apache/cloudstack-www/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1876
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1847
@mike-tutkowski @anshul-gangwar @nvazquez I believe the same issue is
addressed in PR1735 but in a more consistent fashion
---
If your project is set up for it, you can reply to this email and
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/977
@rhtyd @ustcweizhou We need to enable smoke tests for vmsnaphsots for KVM
in test_vm_snapshots.py
if cls.hypervisor.lower() in (KVM.lower(), "hyperv&q
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1899
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@koushik-das @rhtyd This PR now supports custom service offerings. Can you
review and kick off tests?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1735
@mike-tutkowski @anshul1886 @rhtyd We had enough LGTM and successful test
results for this PR. Are there any concern before merging it?
---
If your project is set up for it, you can reply to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@rhtyd Can you kick off tests for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1747
@rhtyd Can you kick off tests fro this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1735
@mike-tutkowski The only comments in this PR are about deletion of PS with
a snapshot copy. I am 100% agree with your statement. This PR excludes
destroyed snapshot copies including ones on the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1901
Thanks @ustcweizhou . We have been planning to address this for a while.
Should we create a smoke test to verify validity of the modified listDomain
call?
---
If your project is set up for it
Github user serg38 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1901#discussion_r95828294
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java ---
@@ -53,6 +59,12 @@
description = "If s
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1901
Thanks @ustcweizhou LGTM for code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1888
We need to change one more setting for noredist build to work with updated
iControl version
in install-non-oss.sh
mvn install:install-file -Dfile=cloud-iControl.jar  Â
-DgroupId
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@nvazquez Since 4.9.2 is already released and this is not a bugfix the DB
changes should go to schema-490to4910.sql
---
If your project is set up for it, you can reply to this email and have
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1711
Yes it is in 4.9.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1833
@pdumbre I confirm your observation. LGTM on code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rhtyd @karuturi Can we run tests on this PR and merge on success ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1747
@rhtyd @karuturi Can we run tests on this PR and merge on success ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@karuturi Can we merge this one ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@rhtyd @karuturi Can we run tests on this PR and merge on success ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@rhtyd @karuturi Can we run vmware tests on this PR and merge on success ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@koushik-das @rhtyd @rafaelweingartner Can you review changes @nvazquez
put in place? CI tests are good.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1747
@rafaelweingartner Can you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1767
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1747
@rafaelweingartner This PR is two fold.
1. This is something that was done a long ago for hosts and was never
implemented for storage. It transitions location of of storage tags over to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1747
@rafaelweingartner Do we get you LGTM?
@DaanHoogland @rhtyd Can we kick off tests for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1747
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1747
@karuturi Test passed. Two LGTM received. Looks like it is ready for merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@DaanHoogland @borisstoyanov @rhtyd Guys can you kick off tests for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@borisstoyanov @DaanHoogland @rhtyd KVM tests passed but key smoke test is
skipped
test_change_service_offering_for_vm_with_snapshots Skipped
To be on the safe side can we test it on
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/927
@karuturi
Smoke test test_internal_lb.py uses a value of
network.loadbalancer.haproxy.stats.auth which is encrypted for haproxy checks.
settings["username"]
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@karuturi This one is ready for merging. Two LGTMs + tests passing on all 3
hypervisors
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1813
@borisstoyanov Looks like some environmental issues with backend NFS. Can
you kick it again for vmware ?
u'2017-02-15T20:21:38+', jobresult : {errorcode : 530, errortext :
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1813
@priyankparihar You need to adjust smoke test test_deploy_vm_root_resize.py
to support vmware root resize. Otherwise it will keep failing
2017-02-15 12:48:59,150 - CRITICAL - FAILED
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1913
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@karuturi This one is ready for merging. LGTM and test results are positive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
201 - 298 of 298 matches
Mail list logo
