GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-lib/pull/154
CB-6973 enable JSHint for spec-cordova
This change enables jshint for spec-cordova meaning that `npm run jshint`
will not only check `src` folder but `spec-cordova` too. I've also fixed all
th
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/153#issuecomment-71296437
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-71294157
it's a merge issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-71293539
Tests are passing locally, so is jshint. I don't know why travis isn't
picking up my changes.
---
If your project is set up for it, you can reply to this email and
Right, an automation test would avoid future breaks, it can be done by
recreating those steps or verifying that an url such as "about:blank"
doesn't get loaded or go through the conditions in line 457 of
cordovawebview class.
I can get some test for it, sure thing.
On 23 Jan 2015 6:08 PM, "Joe B
OK, now how do you automate that? I don't think anyone is going to remember
to do this to test for regressions.
On Fri Jan 23 2015 at 4:06:07 PM Martin Gonzalez <
martin.c.glez.g...@gmail.com> wrote:
> It's pretty easy, create a project, add platform android taken from master
> branch, run it, th
It's pretty easy, create a project, add platform android taken from master
branch, run it, then once the app is launched, minimize it, go to settings,
select another language, and then resume the app, by using the home button.
You'll see the crash at that point.
On 23 Jan 2015 5:42 PM, "Joe Bowser
I re-opened the initial issue. Is it possible to test this?
On Fri Jan 23 2015 at 3:24:54 PM Martin Gonzalez <
martin.c.glez.g...@gmail.com> wrote:
> Hello team,
>
> Recently tested cordova-android, master branch, and I found out that this
> commit:
> ccceaeaca
> Link:
> https://git-wip-us.apach
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23488733
--- Diff: cordova-lib/spec-cordova/lazy_load.spec.js ---
@@ -26,7 +26,8 @@ var lazy_load = require('../src/cordova/lazy_load'),
request = require
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23488149
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -55,6 +61,8 @@ exports.preProcessOptions = preProcessOptions;
exports.addModuleProperty = addModuleP
Hello team,
Recently tested cordova-android, master branch, and I found out that this
commit:
ccceaeaca
Link:
https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=ccceaeaca2d72fb9708100ab2f70adb903a27d66
brings back the issue about app crash after language is changed, by
allow
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23488114
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -262,3 +270,81 @@ function addModuleProperty(module, symbol, modulePath,
opt_wrap, opt_obj) {
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-medic/pull/23
[INFRA-8588] Fixed a bug for ASF Buildbot, and a bug for Windows.
Fixed a bug causing errors in Apache Buildbot. Improved cleanup method to
work on Windows.
You can merge this pull request i
Odd. There appears to be an issue with how these files were checked in.
Normally only text files have this issue, which is corrected by
setting: git config core.autocrlf true
on windows machines.
We may need to check in the corrected version.
@purplecabbage
risingj.com
On Fri, Jan 23, 2015 at
Hello community
I'm cloning a repository in Apache Cordova (cordova-docs) and as soon as I
check out the repo in my laptop, I check the status of the repo with *git
status*. Oddly, I get some image files as modified (the ones under
cordova-docs/templates folder).
Looking around in internet I foun
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-lib/pull/153
CB-6973 Improving JSHint for src folder
Enforcing better JSHint coverage for src\* :
- Move base rules to src\.jshintrc
- Fix previously un-jshinted files
- Remove base rules from in
Marcel posted it a few days ago. I haven't seen anything come out of it
yet, but this is a big deal.
https://community.rapid7.com/community/metasploit/blog/2015/01/11/google-no-longer-provides-patches-for-webview-jelly-bean-and-prior
On Fri Jan 23 2015 at 11:32:48 AM Andrew Grieve
wrote:
> Not
Not sure what the JB fiasco is, but merging SGTM. We can always work off of
3.7.x if we end up needing another 3.x release.
On Fri, Jan 23, 2015 at 1:51 PM, Joe Bowser wrote:
> Hey
>
> So, now that 3.7.0 is mostly out the door (dealing with npm stuff now), I
> think we should talk about getting
Hey Axel,
It would be really helpful if you could file this as an issue and we can
bring it to the attention of our ffos committers.
Cheers,
-Steve
On Fri, Jan 23, 2015 at 5:43 AM, wrote:
> Hi,
>
>
>
> I am using inappbrowser (0.5.5-dev) in a project on ios, android and
> firefoxos.
>
> https:
Hey
So, now that 3.7.0 is mostly out the door (dealing with npm stuff now), I
think we should talk about getting 4.0.x merged into master and out the
door.
I know there's that CookeManager thing that breaks the File Transfer plugin
that we have to deal with, and I'm wondering if we can actually g
GitHub user sosahvictor opened a pull request:
https://github.com/apache/cordova-docs/pull/262
CB-8243 cordova-docs documentation translation: cordova-docs
CB-8243 cordova-docs documentation translation: cordova-docs
You can merge this pull request into a Git repository by running:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
The vote has now closed. The results are:
Positive Binding Votes: 7
Joe Bowser
Sergey Grebnov
Parashuram N
Brian LeRoux
Marcel Kinard
Jesse MacFadyen
Andrew Grieve
Negative Binding Votes: 0
The vote has passed.
I will publish to dist and npm.
On Thu Jan 22 2015 at 5:32:28 PM Andrew Grieve wro
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-browser/pull/9#issuecomment-71231461
Why can't you just make `cordova serve` work with
`cordova-browser`/`cordova run`? I really don't want to have a fork of `cordova
serve`.
---
If your project is s
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-browser/pull/9#issuecomment-71231047
Note that your commit messages should be of the form:
`CB-8182 Add ...` or `CB-8182 Port ...`
instead of `CB-8182 - add ...`
Please use backticks aro
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-browser/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-71228160
@jsoref Updated the commit message. Please review and help merge to master.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-71222792
ok, one last final thing:
* Please amend the commit message to not have the `:` after the `CB-8206`
(I'm fairly confident this is documented in our instructions)
Andrea,
Some folks in the developer division may be able to help out here. I'll
connect you with our Cordova contributors.
-Chuck
From: Andrea Tino [mailto:andrea.t...@microsoft.com]
Sent: Friday, January 23, 2015 12:10 AM
To: dev@cordova.apache.org
Cc: Vincent Nicolas; Michael Helligsø Svinth
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-71211172
(Josh I'll let you have the last word on landing, you have been running
this)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-71210993
..Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-71210975
I reviewed this in a previous iteration, and the latest changes look fine.
Since this feature does not exist yet anyway, and I'm not too concerned
about inl
Thanks Parashuram for coordinating.
On Thu, Jan 22, 2015 at 8:04 PM, Parashuram N (MS OPEN TECH) <
panar...@microsoft.com> wrote:
>
> Wanted to bump up the thread about the Cordova hangouts. A lot of people
> have responded, and looks like the following times are candidates.
>
> - Monday 26 Jan 2
Hello
My name is Andrea Tino. I am a Microsoft Developer in the Microsoft Dynamics
NAV Team.
Recently we started using Cordova for building our apps.
All our tests fail
We moved to Cordova 3.6.3 from 3.4.0 and from there all our tests (more than
200) started failing. After investigating on poss
Hi,
I am using inappbrowser (0.5.5-dev) in a project on ios, android and firefoxos.
https://github.com/apache/cordova-plugin-inappbrowser
The firefoxos version of the app reports two errors in the console log.
Cordova.js:466 getElementByID called with empty id (or similar)
Cordova.js:1171
39 matches
Mail list logo
