Github user spiritax closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user spiritax commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/55#issuecomment-128699962
sorry, wrong branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user spiritax opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/55
Fix for screen not fading
Just a small fixe for Splash screen fading in iOS.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user spiritax commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-128665519
Thanks for the code.
The property FadeSplashScreenDuration (float, defaults to 2): is a float,
so you should probably read a Double then
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/54
CB-9467 SplashScreen does not show any image in hosted app on Windows 10
[Jira issue](https://issues.apache.org/jira/browse/CB-9467)
You can merge this pull request into a Git
GitHub user trancee opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53
Implementing FadeSplashScreen for Android
FadeSplashScreen is supported by using AlphaAnimation to fade out the
ImageView.
You can merge this pull request into a Git repository
GitHub user trancee opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/52
Set scale type to CENTER_INSIDE.
Before the scale type was set to CENTER_CROP which centered the image but
stretched it outside the width of the view. By using CENTER_INSIDE the
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/34#issuecomment-128268479
Got it, thanks. Yes, I did misunderstand your post the first time around.
Your 'unofficial solution' is sufficient.
---
If yo
Github user Treer commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/34#issuecomment-128245919
Those changes are included in the 3.7.0-dev file I linked to as a solution.
We might have a miscommunication. The release version 5.1.1 of
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/34#issuecomment-128242744
@Treer, you are missing the cordova.js changes here:
https://github.com/apache/cordova-browser/pull/7/files
---
If your project is set up
Github user Treer commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/34#issuecomment-128228076
My unofficial solution:
It looks like splashscreen browser support was accepted in 5.1.1, but the
configHelper module it depends on didn&#
Github user jensljungblad commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/34#issuecomment-124511377
Also getting this error on 5.1.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-119727865
@stevengill @infil00p Any possibility of reviewing this before the next
release?
---
If your project is set up for it, you can reply to this email
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/51
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/51
CB-9324 remove travis-ci
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-plugin-splashscreen
Github user racekarl commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/34#issuecomment-117759253
I am also getting the same exception as SunboX under 5.1.1, with the
browser platform reporting as 3.5.2
I have tried both cordova run
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user Deathspike opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/50
WP8: Avoid config `value` of a wrong element.
If you have an element that shares the `name`, like , then the `value` attribute was read of that
instead (since it can
Github user SunboX commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/34#issuecomment-113439475
I'm getting `10:53:31.345 uncaught exception: module cordova/confighelper
not found1 ` using Cordova 5.1.1
---
If your project is set up f
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-107997719
Thanks Daniel!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user danielreuterwall commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-107930682
Shouldn't the `SYSTEM_UI_FLAG_FULLSCREEN` flag be based on the
`SplashHideStatusBar` preference instead of `SplashHideNavigati
Github user miqmago commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-106736212
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-106625709
@infil00p Would you be able to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49
CB-9094: Smarter autohide logic on Android
When the plugin is initialized, the splash screen is shown with an
auto-hide delay. If a subsequent call to show() comes in while
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#discussion_r31235221
--- Diff: src/android/SplashScreen.java ---
@@ -91,7 +91,9 @@ protected void pluginInitialize() {
firstShow = false
GitHub user tfitschen opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48
CB-8396 - Read property "AutoHideSplashScreen" on android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-101761529
Hi @shazron: I'm still getting the same crash from users after applied the
latest fix. Any ideas? Thanks.
---
If your project is set up for it
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/47#issuecomment-100306319
Thanks for the PR Dan -- I'm away, will take a look Monday.
---
If your project is set up for it, you can reply to this email and have your
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/46#issuecomment-100305790
Thanks for the PR Dan -- I'm away, will take a look Monday.
---
If your project is set up for it, you can reply to this email and have your
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/47
CB-3562: Disable screen rotation for iPhone when splash screen is shown
(updated)
This is an updated port of emarashliev's fix for CB-3562, as this bug still
exists
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/46#issuecomment-100047179
@shazron Can you please review & merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/46
CB-8988: Fix rotation on iOS/iPad
The viewController.interfaceOrientation passed to getImageName has not
yet been updated with the new orientation, even when the frame/bounds
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-95968778
The options are not the same as those options change the whole project
while these only affect the splash screen. We have a client that's requ
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045956
--- Diff: src/android/SplashScreen.java ---
@@ -254,8 +262,12 @@ public void run
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045852
--- Diff: README.md ---
@@ -54,12 +54,18 @@ In your `config.xml`, you need to add the following
preferences
GitHub user TheBosZ opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45
Add fullscreen options
This change adds settings to hide the navigation and status bars while the
splash screen is displayed. Full-screen apps aren't affected.
You can
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-94884712
@purplecabbage Is that strictly necessary, given the code is quite
straightforward and fairly common? I'd love to get this merged in if pos
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/42#issuecomment-94884271
@stevengill @purplecabbage @sgrebnov Is it possible to get someone to
review and merge this?
---
If your project is set up for it, you can reply to
GitHub user chrskrchr opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/44
CB-8875 execute entire call to [UIView transitionWithView] on the main t...
...hread so that view fades as expected
You can merge this pull request into a Git repository by
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/40#issuecomment-92456682
I have added specific text to the readme if you need to install this plugin
directly from this repo
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/40#issuecomment-92240487
Just use the old org.apache.cordova.splashscreen name for now, that will
work even within the deprecation period (6 months long).
---
If your
Github user BrunoMarchesson commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/40#issuecomment-92078418
Well, 3 weeks after, still not working ?!
What are we supposed to do to add this plugin since the official
instruction does not work
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91347597
Filed a new issue: https://issues.apache.org/jira/browse/CB-8836
---
If your project is set up for it, you can reply to this email and have your
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91346209
No, thank you for the reports, that has helped solve the issue.
I'll pull the changes in anyway. Admittedly this is sloppy work on our
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91344385
Sounds good. I'm having trouble repro'ing the crashes; I've only personally
seen it twice after a zillion attempts. But I'm de
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91343883
Yes, definitely. I'll let you try it out for bit?
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91343025
Are you planning to commit this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91342982
Great thanks @shazron !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91339823
Yes it definitely can not crash every time -- but it's a certainty that it
would eventually.
---
If your project is set up for it, you can
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91339236
Hmm. Can it be that it would not crash every time? AutoHideSplashScreen is
false, and navigator.splashscreen.hide is called in javascript
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91338139
Actually, this needs to be wrapped as well:
https://gist.github.com/shazron/e45705f76bef4448139a/daddb1f1fefc6171589b2c79bb9333efe6603ed6#file
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91337249
I've updated my gist with a fix:
https://gist.github.com/shazron/e45705f76bef4448139a/daddb1f1fefc6171589b2c79bb9333efe6603ed6
---
If
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91335908
Ugh - it's related.
Basically, when calling this:
https://gist.github.com/shazron/e45705f76bef4448139a#file-gistfile1-m-L15
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91333840
I just got the following new crash group. Do you think it's the same issue?
```
Incident Identifier: DD4D6021-EC75-4FFC-949E-2156E43
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#issuecomment-90766537
@AlexTalis please include a missing import on [this
line](https://github.com/apache/cordova-plugin-splashscreen/commit
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-90591245
This was merged. Will be applicable for cordova-android@4.0.0
---
If your project is set up for it, you can reply to this email and have your
reply
Github user agrieve closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89891961
Thanks so much @shazron. I will try your patch.
Here is a raw crash log:
```
Incident Identifier: FF007664-79D7-4895-99C8
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89458111
This could be it:
1.
https://github.com/apache/cordova-plugin-splashscreen/blob/d2e62a551c950041cb4c9683624a04d931f4bee3/src/ios
Github user AlexTalis commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#issuecomment-89449833
@agrieve, I believe I implemented all the changes we discussed. Can you
accept the pull request?
---
If your project is set up for it, you can
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89449427
@jacobg not too sure what's going on here. Post the full crash log
somewhere? (shot in the dark). I'll review the code again.
---
If yo
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-88049413
Ever since I added the splashscreen plugin to my app, I (and customers)
have been getting this crash occasionally:
```
1
Some devices have had a flicker issue, not sure which it was.
Joe might remember.
@purplecabbage
risingj.com
On Mon, Mar 30, 2015 at 6:17 PM, AlexTalis wrote:
> Github user AlexTalis commented on a diff in the pull request:
>
>
> https://github.com/apache/cordova-plugin-splashsc
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27446641
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27446516
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27445114
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27444623
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27444238
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27444149
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27442565
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27424716
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27423375
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27416895
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27416639
--- Diff: src/android/SplashScreen.java ---
@@ -37,6 +39,19 @@ Licensed to the Apache Software Foundation (ASF) under
one
import
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#issuecomment-87767088
Good stuff! A few minor comments then we're good to go I think!
---
If your project is set up for it, you can reply to this email and have
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27413370
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27413236
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27413145
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27412851
--- Diff: src/android/SplashScreen.java ---
@@ -37,6 +39,19 @@ Licensed to the Apache Software Foundation (ASF) under
one
import
GitHub user AlexTalis opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43
CB-8753 Maintain splash screen aspect ratio
- Added "SplashMaintainAspectRatioâ preference to maintain SplashScreen
aspect ratio instead of scaling it to d
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-87028196
I'll rewrite it, since I haven't looked at it. Just so we're clear.
---
If your project is set up for it, you can reply to this
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-87015745
I should also point out that the ResolutionHelper.cs file is taken from
MSDN sample code:
https://msdn.microsoft.com/library/windows/apps/jj206974(v
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-86878586
lgtm :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/42
CB-8758 [wp8]: UnauthorizedAccessException on hide()
When calling hide() from JS, the attempt to access Popup could happen on
a background thread, which ends up throwing an
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41
CB-8750 [wp8]: Allow resolution-specific splashscreen images
There are two aspect ratios for Windows Phone devices: 15:9 and 16:9. At
the moment, though, there is only one
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/40#issuecomment-85662478
The next version of the plugin will be installable by this name, it's just
not working yet.
---
If your project is set up for it, you can rep
GitHub user gtczap opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/40
Fixed installation instructions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gtczap/cordova-plugin-splashscreen master
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/39#issuecomment-82766632
Thanks, but... This was intentional. Plugins are being hosted on npm and we
are adopting npm style package ids
---
If your project is set up
GitHub user adamsc64 opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/39
Fixed plugin name in the readme.
While I was installing this on a small project, I noticed that the
reference to the plugin name was wrong in the README. Here is a quick pull
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26150136
--- Diff: src/wp/SplashScreen.cs ---
@@ -40,26 +40,35 @@ namespace WPCordovaClassLib.Cordova.Commands
///
public
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#issuecomment-78152746
Thanks for the contribution.
I did some cleanup in general of this code, some per comments from
@robpaveza
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Alexandrov; dev
Cc: agri...@chromium.org
Subject: Re: Pull Request Review Request [apache/cordova-plugin-splashscreen]
Thanks Georgi!
Bouncing you to the mailing-list though, as I don't do any Windows development.
On Mon, Mar 9, 2015 at 8:15 AM, Georgi Alexandrov
mailto:georgi.alexand...@teleri
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26149994
--- Diff: src/wp/SplashScreen.cs ---
@@ -68,27 +77,52 @@ public override void OnInit()
if (!WasShown
501 - 600 of 715 matches
Mail list logo
