Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/ --- (Updated Feb. 27, 2015, 1:48 a.m.) Review request for hive. Changes ---

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review74365 --- This looks great to me! We can do the check in more places in a foll

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/ --- (Updated Feb. 26, 2015, 8:51 a.m.) Review request for hive. Changes ---

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

> On Feb. 12, 2015, 8:42 a.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java, line 45 > > > > > > Why do we need to store the method name of the HMS method we are timing >

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

> On Feb. 12, 2015, 8:42 a.m., Mohit Sabharwal wrote: > > LGTM. Had a few questions. Thank you so much for you feedbacks! Mohit. I will update the patch based on your commnets after holiday. Thanks! - Dong --- This is an automatically g

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review72119 --- LGTM. Had a few questions. common/src/java/org/apache/hadoop/hive/

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review70527 --- Ship it! Ship It! - Lefty Leverenz On Jan. 28, 2015, 12:58 a.m.,

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

> On Jan. 20, 2015, 10:43 p.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 372-374 > > > > > > Shouldn't "long" & "LONG" be included in the names > > "hive.metastore.ser

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/ --- (Updated Jan. 28, 2015, 8:58 a.m.) Review request for hive. Changes ---

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

> On Jan. 21, 2015, 6:43 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 372-374 > > > > > > Shouldn't "long" & "LONG" be included in the names > > "hive.metastore.serv

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

> On Jan. 27, 2015, 6:20 a.m., Brock Noland wrote: > > Hi Dong, > > > > This looks great!! > > > > Can we rename "RuntimeTimeout" to "Deadline" so it's more clear what this > > is? Also it appears we are taking the timeout configuration from local > > config. Do you plan on having the client

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review69751 --- Hi Dong, This looks great!! Can we rename "RuntimeTimeout" to "Dea

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/ --- (Updated Jan. 22, 2015, 8:22 a.m.) Review request for hive. Changes ---

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/ --- (Updated Jan. 21, 2015, 6:47 a.m.) Review request for hive. Summary (updated)