Re: Solaris sed based apache filtering module (mod_sed)

2008-04-17 Thread Basant . Kukreja
On Sat, Apr 12, 2008 at 10:27:40AM -0700, Chris Elving wrote: > sed is an inherently line-oriented editor. It seems wrong to buffer > multiple lines within libsed. Consider, for example, how adding such > multi-line buffering to libsed would complicate implementing an > interactive sed like sed(

patch for flood to deal with gcc 4

2008-04-17 Thread Guy Ferraiolo
Folks Here's the patch to get this to compile correctly with gcc 4. It's actually only 3 lines. This has been tested with the following versions: gcc version 3.4.6 20060404 (Red Hat 3.4.6-8), (RHEL4 32-bit) gcc version 4.1.1 20070105 (Red Hat 4.1.1-52) (RHEL4 64-bit) Thanks, Guy -- Guy Fer

Re: svn commit: r649239 - in /httpd/httpd/trunk/modules/proxy: mod_proxy_ajp.c mod_proxy_http.c

2008-04-17 Thread Ruediger Pluem
On 04/17/2008 10:10 PM, Ruediger Pluem wrote: I am frankly open here: The old code already looked ugly in respect of this and the new code IMHO even looks uglier. What about the following patch Of course I forgot a :-) here. Regards Rüdiger

Re: trunk build broken...

2008-04-17 Thread Ruediger Pluem
Trunk should now build again. Regards Rüdiger On 04/17/2008 07:25 PM, Jim Jagielski wrote: Hmmm httpd-trunk, apr-trunk and apr-util-trunk up to date, and yet: mod_session_crypto.c:20:66: error: apr_ssl.h: No such file or directory mod_session_crypto.c:60: error: syntax error before 'a

Re: svn commit: r649228 - in /httpd/httpd/trunk/modules/cache: cache_util.c mod_cache.c

2008-04-17 Thread Ruediger Pluem
On 04/17/2008 09:39 PM, Dirk-Willem van Gulik wrote: On Thu, 17 Apr 2008 [EMAIL PROTECTED] wrote: * Style police. No functional changes. Are you using .indent.pro ? If so - which one ? No, I am using the following .vimrc settings which I took over from Justin: syntax enable " Added ent

Re: svn commit: r649239 - in /httpd/httpd/trunk/modules/proxy: mod_proxy_ajp.c mod_proxy_http.c

2008-04-17 Thread Ruediger Pluem
On 04/17/2008 09:20 PM, [EMAIL PROTECTED] wrote: Author: jim Date: Thu Apr 17 12:20:16 2008 New Revision: 649239 URL: http://svn.apache.org/viewvc?rev=649239&view=rev Log: handle ? in cases where nocanon is in effect Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_ajp.c httpd/http

Re: svn commit: r649228 - in /httpd/httpd/trunk/modules/cache: cache_util.c mod_cache.c

2008-04-17 Thread Dirk-Willem van Gulik
On Thu, 17 Apr 2008 [EMAIL PROTECTED] wrote: > * Style police. No functional changes. Are you using .indent.pro ? If so - which one ? Thanks, Dw

Re: svn commit: r649239 - in /httpd/httpd/trunk/modules/proxy: mod_proxy_ajp.c mod_proxy_http.c

2008-04-17 Thread Dirk-Willem van Gulik
On Thu, 17 Apr 2008 [EMAIL PROTECTED] wrote: > Log: > handle ? in cases where nocanon is in effect Lovely - this fixes one of my ajp problems as well (which I thus wrongly was blaming on the cache). Is this now hooked in everywhere ? Or do we still need to do a scan throughout everything ? Dw

Re: caching - merge&clear errors prior to hop by hop removal ?

2008-04-17 Thread Ruediger Pluem
On 04/17/2008 06:48 PM, Dirk-Willem van Gulik wrote: I *think* that the patch below is the right thing to do throughout (rather than just in mod_cache itself): -always merge in any error headers *prior* to removing hop-by-hop. -always clearing the errors. When you are passing ou

Re: svn commit: r649170 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

2008-04-17 Thread Jim Jagielski
These just make noncanon available for knowledge use... How that is actually handled is additional stuff (see other thread :) ) On Apr 17, 2008, at 3:04 PM, Ruediger Pluem wrote: On 04/17/2008 06:24 PM, [EMAIL PROTECTED] wrote: Author: jim Date: Thu Apr 17 09:24:16 2008 New Revision: 649170

Re: svn commit: r649170 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

2008-04-17 Thread Ruediger Pluem
On 04/17/2008 06:24 PM, [EMAIL PROTECTED] wrote: Author: jim Date: Thu Apr 17 09:24:16 2008 New Revision: 649170 URL: http://svn.apache.org/viewvc?rev=649170&view=rev Log: and make mod_proxy_fcgi also nocanon aware Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c Modified: http

trunk build broken...

2008-04-17 Thread Jim Jagielski
Hmmm httpd-trunk, apr-trunk and apr-util-trunk up to date, and yet: mod_session_crypto.c:20:66: error: apr_ssl.h: No such file or directory mod_session_crypto.c:60: error: syntax error before 'apr_evp_factory_t' mod_session_crypto.c:61: warning: function declaration isn't a protot

caching - merge&clear errors prior to hop by hop removal ?

2008-04-17 Thread Dirk-Willem van Gulik
I *think* that the patch below is the right thing to do throughout (rather than just in mod_cache itself): - always merge in any error headers *prior* to removing hop-by-hop. - always clearing the errors. When you are passing out a cached header set. But would love to have

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jim Jagielski
On Apr 17, 2008, at 10:25 AM, Jim Jagielski wrote: On Apr 17, 2008, at 10:04 AM, Plüm, Rüdiger, VF-Group wrote: But sure this could be also fixed in the appropriate canon_handler hooks of mod_proxy_http and mod_proxy_ajp. That's what I'm wondering... Treating this "special" inside of mod_

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jess Holle
Jim Jagielski wrote: This section is the same as that in the bug report (make mod_proxy_ajp aware of the nocanon EnvVar), but the attached patch also includes a workaround for the doubling of any query strings. This 2nd part needs to be addressed but the real fix may not be done by this patch. If

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jim Jagielski
On Apr 17, 2008, at 10:48 AM, Jess Holle wrote: Jim Jagielski wrote: Can you try: Index: modules/proxy/mod_proxy_ajp.c === --- modules/proxy/mod_proxy_ajp.c(revision 648735) +++ modules/proxy/mod_proxy_ajp.c(working copy)

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: Jess Holle > Gesendet: Donnerstag, 17. April 2008 16:50 > An: dev@httpd.apache.org > Betreff: Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases) > > Jess Holle wrote: > > Jim Jagielski wrote: > >> Can you try: > >> > >> Index: modules/proxy/mod_prox

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jess Holle
Jess Holle wrote: Jim Jagielski wrote: Can you try: Index: modules/proxy/mod_proxy_ajp.c === --- modules/proxy/mod_proxy_ajp.c(revision 648735) +++ modules/proxy/mod_proxy_ajp.c(working copy) @@ -72,8 +72,13 @@ sea

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jess Holle
Jim Jagielski wrote: Can you try: Index: modules/proxy/mod_proxy_ajp.c === --- modules/proxy/mod_proxy_ajp.c(revision 648735) +++ modules/proxy/mod_proxy_ajp.c(working copy) @@ -72,8 +72,13 @@ search = r->args;

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jim Jagielski
On Apr 17, 2008, at 10:04 AM, Plüm, Rüdiger, VF-Group wrote: But sure this could be also fixed in the appropriate canon_handler hooks of mod_proxy_http and mod_proxy_ajp. That's what I'm wondering... Treating this "special" inside of mod_proxy itself, when it's really a protocol issue (and w

Re: Getting httpd to dump core on RHEL5

2008-04-17 Thread Niklas Edmundsson
On Thu, 17 Apr 2008, Graham Leggett wrote: Hi all, I am trying to get a core dump out of an RHEL5 system, and I am struggling to do so. Following the instructions at http://httpd.apache.org/dev/debugging.html#crashes, I have set "ulimit -c unlimited", and I set CoreDumpDirectory to /tmp, b

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: Jim Jagielski > Gesendet: Donnerstag, 17. April 2008 15:16 > An: dev@httpd.apache.org > Betreff: Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases) > > > On Apr 17, 2008, at 8:46 AM, Plüm, Rüdiger, VF-Group wrote: > > But the patch I just attached t

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jim Jagielski
On Apr 17, 2008, at 8:46 AM, Plüm, Rüdiger, VF-Group wrote: But the patch I just attached to PR44803 should fix this: https://issues.apache.org/bugzilla/attachment.cgi?id=21826 :) Obviously, +1 on the mod_proxy_ajp patch (within minutes we had the same idea). Mulling over the impacts of the

Re: low hanging fruit in proxy_balancer

2008-04-17 Thread Mladen Turk
Jim Jagielski wrote: On Apr 17, 2008, at 8:56 AM, Plüm, Rüdiger, VF-Group wrote: Yeah, but we *should* differentiate between the 2. There are (well, should be) administrative status and "runtime" status. It worked initially, but someone added PROXY_WORKER_STOPPED to PROXY_WORKER_IS_USABLE

Re: Centralizing http-proxy knowledge in cache_util.c

2008-04-17 Thread Dirk-Willem van Gulik
On Apr 17, 2008, at 2:49 PM, Plüm, Rüdiger, VF-Group wrote: -Ursprüngliche Nachricht- Von: Dirk-Willem van Gulik Gesendet: Donnerstag, 17. April 2008 14:19 An: dev@httpd.apache.org Betreff: Re: Centralizing http-proxy knowledge in cache_util.c On Apr 17, 2008, at 1:50 PM, Plüm, Rüdi

Re: perform a redirect in output filter

2008-04-17 Thread Joe Lewis
John Zhang wrote: I am using apache 2.0/2.2, in my output filter, I would like to have the ability to redirect. Some tests indicated that I can redirect to a page on the same site, but not to an external site. Here is my code for redirect: char* location = apr_table_get(r->headers_out, "Lo

Re: low hanging fruit in proxy_balancer

2008-04-17 Thread Jim Jagielski
On Apr 17, 2008, at 8:56 AM, Plüm, Rüdiger, VF-Group wrote: -Ursprüngliche Nachricht- Von: William A. Rowe, Jr. Gesendet: Donnerstag, 17. April 2008 14:49 An: dev@httpd.apache.org Betreff: low hanging fruit in proxy_balancer One of our class attendees this week had an interesting sug

Re: Analyze mod_rewrite log in browser

2008-04-17 Thread Dirk-Willem van Gulik
On Apr 16, 2008, at 9:57 PM, Christoph Dorn wrote: I was wondering if it would be useful for a lot of mod_rewrite users to be able to view the rewrite log in their Firebug console instead of ... There could be a new configuration directive for mod_rewrite that enables the sending of the rewri

Re: low hanging fruit in proxy_balancer

2008-04-17 Thread Jim Jagielski
On Apr 17, 2008, at 8:49 AM, William A. Rowe, Jr. wrote: One of our class attendees this week had an interesting suggesting for a balancer-manager feature. Right now each member is a 2-state, either enabled or disabled. For session stickiness, he suggested a tristate third option to bleed o

Re: low hanging fruit in proxy_balancer

2008-04-17 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: William A. Rowe, Jr. > Gesendet: Donnerstag, 17. April 2008 14:49 > An: dev@httpd.apache.org > Betreff: low hanging fruit in proxy_balancer > > One of our class attendees this week had an interesting suggesting for > a balancer-manager feature. Right

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jim Jagielski
On Apr 17, 2008, at 7:59 AM, Jess Holle wrote: jean-frederic clere wrote: IMHO we already forward them escaped. The problem is that things get unescaped first and for reserved characters like ';' this process cannot be reverted. So if the original URL contained an escaped ';' the forwarded one

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jim Jagielski
On Apr 17, 2008, at 7:59 AM, Jess Holle wrote: jean-frederic clere wrote: IMHO we already forward them escaped. The problem is that things get unescaped first and for reserved characters like ';' this process cannot be reverted. So if the original URL contained an escaped ';' the forwarded one

Re: Centralizing http-proxy knowledge in cache_util.c

2008-04-17 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: Dirk-Willem van Gulik > Gesendet: Donnerstag, 17. April 2008 14:19 > An: dev@httpd.apache.org > Betreff: Re: Centralizing http-proxy knowledge in cache_util.c > > > On Apr 17, 2008, at 1:50 PM, Plüm, Rüdiger, VF-Group wrote: > > > What is this func

low hanging fruit in proxy_balancer

2008-04-17 Thread William A. Rowe, Jr.
One of our class attendees this week had an interesting suggesting for a balancer-manager feature. Right now each member is a 2-state, either enabled or disabled. For session stickiness, he suggested a tristate third option to bleed out the remaining sessions, dispatching no /new/ sessions into

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: Jess Holle > Gesendet: Donnerstag, 17. April 2008 13:59 > An: dev@httpd.apache.org > Betreff: Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases) > > jean-frederic clere wrote: > >> IMHO we already forward them escaped. The problem is that > things g

Re: Centralizing http-proxy knowledge in cache_util.c

2008-04-17 Thread Dirk-Willem van Gulik
On Apr 17, 2008, at 1:50 PM, Plüm, Rüdiger, VF-Group wrote: What is this function (ap_cache_cacheable_hdrs)? I am trying to get confused by all these functions which sound very similar :-). Basically I try to rationalize it to: 1) ap_cache_cacheable_hdrs Understands the gene

Getting httpd to dump core on RHEL5

2008-04-17 Thread Graham Leggett
Hi all, I am trying to get a core dump out of an RHEL5 system, and I am struggling to do so. Following the instructions at http://httpd.apache.org/dev/debugging.html#crashes, I have set "ulimit -c unlimited", and I set CoreDumpDirectory to /tmp, but with no luck. Is there some further magi

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: jean-frederic clere > Gesendet: Donnerstag, 17. April 2008 13:39 > An: dev@httpd.apache.org > Betreff: Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases) > > Plüm wrote: > > > > > >> -Ursprüngliche Nachricht- > >> Von: jean-frederic clere

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jess Holle
jean-frederic clere wrote: IMHO we already forward them escaped. The problem is that things get unescaped first and for reserved characters like ';' this process cannot be reverted. So if the original URL contained an escaped ';' the forwarded one will contain a literal ';'. With mod_proxy or bet

Re: Centralizing http-proxy knowledge in cache_util.c

2008-04-17 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: Dirk-Willem van Gulik > Gesendet: Donnerstag, 17. April 2008 13:05 > An: dev@httpd.apache.org > Betreff: Centralizing http-proxy knowledge in cache_util.c > > Before I give the other modules a pass over -- does below strawman > address everyones > c

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread jean-frederic clere
Plüm wrote: -Ursprüngliche Nachricht- Von: jean-frederic clere [mailto:[EMAIL PROTECTED] Gesendet: Donnerstag, 17. April 2008 11:02 An: dev@httpd.apache.org Betreff: Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases) Jim Jagielski wrote: On Apr 14, 2008, at 10:15 AM, Jim Jagielski

Re: Centralizing http-proxy knowledge in cache_util.c (resend with fix)

2008-04-17 Thread Dirk-Willem van Gulik
(Resent - previous patch also contained the module changes). Before I give the other modules a pass over -- does below strawman address everyones concerns w.r. to the API changes ? To recap: - ap_cache_cacheable_hdrs_out gets depricated. And the repliced code is to be removed f

Centralizing http-proxy knowledge in cache_util.c

2008-04-17 Thread Dirk-Willem van Gulik
Before I give the other modules a pass over -- does below strawman address everyones concerns w.r. to the API changes ? To recap: - ap_cache_cacheable_hdrs_out gets depricated. And the repliced code is to be removed from mod_*_cache. - a ap_cache_cacheable_hdrs_in() and ap

changes in cache, but not in proxy

2008-04-17 Thread Dirk-Willem van Gulik
A while ago - the build-more changes to cache where committed - but the similar changes to proxy where not. Any objections to do so ? Or is there a worry I've missed ? Dw Index: modules/proxy/config.m4 === --- modules/proxy/config.

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: Jess Holle [mailto:[EMAIL PROTECTED] > Gesendet: Donnerstag, 17. April 2008 12:36 > An: dev@httpd.apache.org > Betreff: Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases) > > Plüm wrote: > > IMHO we already forward them escaped. The problem is that t

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jess Holle
Plüm wrote: IMHO we already forward them escaped. The problem is that things get unescaped first and for reserved characters like ';' this process cannot be reverted. So if the original URL contained an escaped ';' the forwarded one will contain a literal ';'. With mod_proxy or better ProxyPass y

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Jess Holle
jean-frederic clere wrote: I have looked to #44803 in fact we need something like JkOptions +ForwardURIEscaped which means something that requires changes in both mod_rewrite and mod_proxy. I will propose a patch soon. Thank you! -- Jess Holle

Crush (libketama improved)

2008-04-17 Thread Dirk-Willem van Gulik
Steve Yen posted this link on the memcached mailing list the other day: http://www.ssrc.ucsc.edu/Papers/weil-sc06.pdf well worth a read - and seems to take out most downsides of (lib)ketama its method. This may well be the (one) generic hasher apr/mod_*_cache needs. Thanks, Dw

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: jean-frederic clere [mailto:[EMAIL PROTECTED] > Gesendet: Donnerstag, 17. April 2008 11:02 > An: dev@httpd.apache.org > Betreff: Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases) > > Jim Jagielski wrote: > > > > On Apr 14, 2008, at 10:15 AM, Jim Ja

Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases)

2008-04-17 Thread jean-frederic clere
Jim Jagielski wrote: On Apr 14, 2008, at 10:15 AM, Jim Jagielski wrote: On Apr 14, 2008, at 10:00 AM, Jess Holle wrote: Jim Jagielski wrote: Plus, every 3 months would coincide with the report-to-board cycle, making it easier for everyone to follow :) Next is due in May, so if we release thi

Re: AuthzMergeRules directive

2008-04-17 Thread Justin Erenkrantz
On Wed, Apr 16, 2008 at 9:31 PM, Brad Nicholes <[EMAIL PROTECTED]> wrote: > I could go along with switching the default merging rule from OR to AND, > even within a dir block. The reason why it is OR today was basically for > backward compatibility. Since there really wasn't any kind of logic