Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-18 Thread Graham Dumpleton
2009/6/18 Rich Bowen : > > On Jun 16, 2009, at 18:43, William A. Rowe, Jr. wrote: > >> William A. Rowe, Jr. wrote: >>> >>> This might be NotFoundHandler or for dir-not-file, ListingHandler. >> >> Sorry; not ListingHandler, but IndexHandler. >> >> But there is no point to a NotFoundHandler; the exis

Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-18 Thread Akins, Brian
On 6/18/09 12:57 PM, "Bob Ionescu" wrote: > DefaultMapping /index.php > AddHandler php_handler .php Of course, though, php is only supported in fastcgi mode now. Unrelated to the discussion, but, yes, I will keep saying this over and over again until I quit seeing references to mod_php/libphp i

Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-18 Thread Nick Kew
On Thu, 18 Jun 2009 18:57:54 +0200 Bob Ionescu wrote: > 2009/6/17 Dan Poirier > > It seems to me that "Default" is right - it implies what should be > > done when no more explicit configuration applies. E.g. DefaultType, > > DefaultIcon, etc. > > > > Whether this is a "Handler" I'm not so sure

Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-18 Thread Bob Ionescu
2009/6/17 Dan Poirier > It seems to me that "Default" is right - it implies what should be done > when no more explicit configuration applies. E.g. DefaultType, > DefaultIcon, etc. > > Whether this is a "Handler" I'm not so sure of. I'd call it DefaultMapping or so to avoid confusion with SetHan

Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-17 Thread Ruediger Pluem
On 06/16/2009 11:57 PM, n...@apache.org wrote: > Author: niq > Date: Tue Jun 16 21:57:25 2009 > New Revision: 785425 > > URL: http://svn.apache.org/viewvc?rev=785425&view=rev > Log: > Add DefaultHandler directive to mod_dir. > PR 47184 > > Modified: > httpd/httpd/trunk/CHANGES > httpd/h

Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-17 Thread Rich Bowen
On Jun 16, 2009, at 18:43, William A. Rowe, Jr. wrote: William A. Rowe, Jr. wrote: This might be NotFoundHandler or for dir-not-file, ListingHandler. Sorry; not ListingHandler, but IndexHandler. But there is no point to a NotFoundHandler; the existing mechanics in ScriptAlias combined with

Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-17 Thread Rich Bowen
On Jun 17, 2009, at 08:10, Dan Poirier wrote: "William A. Rowe, Jr." writes: DefaultHandler implies handling all content; not no-match content. It seems to me that "Default" is right - it implies what should be done when no more explicit configuration applies. E.g. DefaultType, Default

Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-17 Thread Dan Poirier
"William A. Rowe, Jr." writes: > DefaultHandler implies handling all content; not no-match content. It seems to me that "Default" is right - it implies what should be done when no more explicit configuration applies. E.g. DefaultType, DefaultIcon, etc. Whether this is a "Handler" I'm not so su

Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-16 Thread Nick Kew
On 16 Jun 2009, at 23:21, André Malo wrote: * n...@apache.org wrote: static void register_hooks(apr_pool_t *p) { ap_hook_fixups(fixup_dir,NULL,NULL,APR_HOOK_LAST); +ap_hook_fixups(fixup_dflt,NULL,NULL,APR_HOOK_LAST); } module AP_MODULE_DECLARE_DATA dir_module = { Without furth

Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-16 Thread William A. Rowe, Jr.
William A. Rowe, Jr. wrote: > > This might be NotFoundHandler or for dir-not-file, ListingHandler. Sorry; not ListingHandler, but IndexHandler. But there is no point to a NotFoundHandler; the existing mechanics in ScriptAlias combined with PATH_INFO solve that problem already. I think the inter

Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-16 Thread William A. Rowe, Jr.
> > + *) mod_dir: add DefaultHandler directive, to enable admin to specify > + an action to happen when a URL maps to no file, without resorting > + to ErrorDocument or mod_rewrite. PR 47184 [Nick Kew] > + Ixnay on the irectiveday abuseway. DefaultHandler implies handling all content;

Re: svn commit: r785425 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2009-06-16 Thread André Malo
* n...@apache.org wrote: > static void register_hooks(apr_pool_t *p) > { > ap_hook_fixups(fixup_dir,NULL,NULL,APR_HOOK_LAST); > +ap_hook_fixups(fixup_dflt,NULL,NULL,APR_HOOK_LAST); > } > > module AP_MODULE_DECLARE_DATA dir_module = { Without further checking: should we ensure the fix