Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-22 Thread Vinod Kone
On Sept. 21, 2014, 9:20 a.m., Adam B wrote: src/master/master.hpp, lines 947-950 https://reviews.apache.org/r/25866/diff/2/?file=699118#file699118line947 Comment here should be for the Slave. 'active' is set to false if resources from this slave should not be offered. This

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-22 Thread Vinod Kone
On Sept. 20, 2014, 2:26 p.m., Dominic Hamon wrote: src/master/master.cpp, line 4649 https://reviews.apache.org/r/25866/diff/1/?file=698461#file698461line4649 consider adding gauges for connected/disconnected slaves done. added for frameworks too. - Vinod

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54094 --- Ship it! Beautiful. Love the changes. Just a few questions about

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-20 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54078 --- src/master/master.cpp

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- (Updated Sept. 20, 2014, 6:46 p.m.) Review request for mesos, Adam B and Ben

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54085 --- Bad patch! Reviews applied: [25866] Failed command:

Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- Review request for mesos, Adam B and Ben Mahler. Bugs: MESOS-1081 and

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54072 --- Bad patch! Reviews applied: [25866] Failed command: git apply