----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54085 -----------------------------------------------------------
Bad patch! Reviews applied: [25866] Failed command: ./support/mesos-style.py Error: Checking 507 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo src/master/master.cpp:3684: Too many spaces before TODO [whitespace/todo] [2] Total errors found: 1 - Mesos ReviewBot On Sept. 20, 2014, 6:46 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25866/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 6:46 p.m.) > > > Review request for mesos, Adam B and Ben Mahler. > > > Bugs: MESOS-1081 and MESOS-1811 > https://issues.apache.org/jira/browse/MESOS-1081 > https://issues.apache.org/jira/browse/MESOS-1811 > > > Repository: mesos-git > > > Description > ------- > > Made consistent what connected and active frameworks/slaves means. > > Fixed MESOS-1811 along the way. > > > Diffs > ----- > > src/master/http.cpp 3f5a01dfddca9cea73563100d88e0c03f600d6b1 > src/master/master.hpp f5d74aef185fad861139186be1cab089f8005a94 > src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 > src/tests/fault_tolerance_tests.cpp > 154386044d0247b39d84719d7ff14250682a0695 > > Diff: https://reviews.apache.org/r/25866/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
