----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54094 -----------------------------------------------------------
Ship it! Beautiful. Love the changes. Just a few questions about comments, etc. src/master/master.hpp <https://reviews.apache.org/r/25866/#comment94051> Comment here should be for the Slave. 'active' is set to false if resources from this slave should not be offered. This happens when the slave is disconnected or the master receives a DeactivateSlaveMessage. Do we have a DeactivateSlaveMessage yet? Or does that come with the HTTP endpoint? src/master/master.cpp <https://reviews.apache.org/r/25866/#comment94052> Any reason not to just set framework->connected = true; always? It's just a boolean. src/master/master.cpp <https://reviews.apache.org/r/25866/#comment94053> Can you explain why this TODO is no longer needed? allocator->frameworkActivated calls allocator->allocate, which will sort roles/frameworks and make initial offers based on a stale notion of the newly reactivated framework's outstanding offers. If the resources were recovered first, the allocator would make fairer offers when the framework is first reactivated. src/master/master.cpp <https://reviews.apache.org/r/25866/#comment94054> Why are these CHECKs? How should the master respond if it does receive such a message from a deactivated slave? Should we perhaps be sending a Shutdown[Slave]Message, or some sort of DeactivateSlaveMessage? src/master/master.cpp <https://reviews.apache.org/r/25866/#comment94055> Ditto. Isn't this TODO still relevant? - Adam B On Sept. 20, 2014, 11:46 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25866/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 11:46 a.m.) > > > Review request for mesos, Adam B and Ben Mahler. > > > Bugs: MESOS-1081 and MESOS-1811 > https://issues.apache.org/jira/browse/MESOS-1081 > https://issues.apache.org/jira/browse/MESOS-1811 > > > Repository: mesos-git > > > Description > ------- > > Made consistent what connected and active frameworks/slaves means. > > Fixed MESOS-1811 along the way. > > > Diffs > ----- > > src/master/http.cpp 3f5a01dfddca9cea73563100d88e0c03f600d6b1 > src/master/master.hpp f5d74aef185fad861139186be1cab089f8005a94 > src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 > src/tests/fault_tolerance_tests.cpp > 154386044d0247b39d84719d7ff14250682a0695 > > Diff: https://reviews.apache.org/r/25866/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
