Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review81020 --- Ship it! Ship It! - Alexander Rukletsov On April 20, 2015, 8:01

Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/ --- (Updated April 20, 2015, 8:01 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 32505: Added SHUTDOWN scheduler call.

> On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 3475 > > > > > > How about moving this after `Master::reconcile()`? i'm keeping them close to their continuations for ease in

Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review79369 --- src/master/master.cpp

Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/ --- (Updated April 3, 2015, 11:38 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 32505: Added SHUTDOWN scheduler call.

> On April 1, 2015, 12:20 a.m., Ben Mahler wrote: > > Modulo comments. > > > > I noticed you added SlaveID on Shutdown, can you add it to Kill as well? Yup. Will send a patch for it as well. > On April 1, 2015, 12:20 a.m., Ben Mahler wrote: > > include/mesos/scheduler/scheduler.proto, line 12

Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review78415 --- Ship it! Modulo comments. I noticed you added SlaveID on Shutdown,

Re: Review Request 32505: Added SHUTDOWN scheduler call.

> On March 27, 2015, 3:22 p.m., Alexander Rojas wrote: > > src/scheduler/scheduler.cpp, lines 679-680 > > > > > > Do you mind adding a comment why an exited executor is always marked as > > a failure? It is not clear

Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/ --- (Updated March 31, 2015, 12:09 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review78050 --- src/master/master.cpp

Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-1127 and