[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r59988860 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r59988803 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http

[GitHub] nifi pull request: NIFI-1771 deprecated ObjectHolder

2016-04-14 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/351 NIFI-1771 deprecated ObjectHolder You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1771 Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1764 fixed NPE in PutKafka

2016-04-14 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/350 NIFI-1764 fixed NPE in PutKafka NIFI-1764 removed obsolete comment for MESSAGE_DELIMITER You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi

[GitHub] nifi pull request: NIFI-1296[REVIEW_ONLY] initial commit of Kafka ...

2016-04-12 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/345 NIFI-1296[REVIEW_ONLY] initial commit of Kafka processors that leverage Kafka 0.9 API This PR is not ready to be merged and is only to initiate incremental review and initial testing of a new pair of

[GitHub] nifi pull request: NIFI-1748 removed un-used test data

2016-04-11 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/344#discussion_r59292437 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/KafkaPublisherTest.java --- @@ -124,33 +112,9

[GitHub] nifi pull request: NIFI-1748 removed un-used test data

2016-04-11 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/344 NIFI-1748 removed un-used test data You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1748 Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1748 removed un-used test data

2016-04-09 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/341 NIFI-1748 removed un-used test data You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1748 Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1690 Changed MonitorMemory to use allowabl...

2016-04-05 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/328 NIFI-1690 Changed MonitorMemory to use allowable values for pool names - removed dead code from MonitorMemory - added MonitorMemoryTest - minor refactoring in MonitorMemory - initial fix for

[GitHub] nifi pull request: NIFI-1668 modified TestProcessorLifecycle to en...

2016-04-04 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/324 NIFI-1668 modified TestProcessorLifecycle to ensure FlowController is… … always shut down You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unexpected OnT...

2016-04-04 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/285#issuecomment-205353808 They were logged at DEBUG only level and that was the issue since you would not be able to see them, but now if there is an error the stack trace will be printed --- If

[GitHub] nifi pull request: NIFI-1701 fixed StreamScanner, added more tests

2016-04-04 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/314 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-04-04 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/232#discussion_r58389967 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java --- @@ -191,6 +201,14

[GitHub] nifi pull request: NIFI-1701 fixed StreamScanner, added more tests

2016-03-30 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/314 NIFI-1701 fixed StreamScanner, added more tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1701 Alternatively you can review

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-30 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-203553783 @steveyh25 @petmit Guys, thank you so much for your work and collaboration. I've reviewed and giving it +1. @steveyh25 please squash your commits so we give it one

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-29 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-202872584 @steveyh25 I am ok with NFE. Actually if you do some research it appears to behave a bit better then other approaches that may look better on the surface. I&#x

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-29 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57714484 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -141,4 +142,101 @@ private

[GitHub] nifi pull request: NIFI-1684-B fixed ZKClient connection leak

2016-03-28 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/308 NIFI-1684-B fixed ZKClient connection leak You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi tmp Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-28 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-202407396 @trkurc yep, that's the plan once we figure it out --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-28 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57563219 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-202140044 @steveyh25 yes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-202126065 @steveyh25 ping me at 'oleg at hortonworks' for the ide part. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57531950 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57531906 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-202107378 @steveyh25 Don't sweat it on the tone remark. All good here, just wanted to mention it as some may be more sensitive then others ;) --- If your project is set up f

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57531819 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57530817 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57530762 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57530736 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57530690 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57530669 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -43,16 +41,48

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-202095259 @steveyh25 Thank you so much for your contribution. AMQP support is one of the most recent additions to NiFi and it's great to see its adoption is on th

[GitHub] nifi pull request: NIFI-1684 fixed NPE, added tests

2016-03-24 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/302 NIFI-1684 fixed NPE, added tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1684 Alternatively you can review and apply these

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-24 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/257#issuecomment-200797003 @michalklempa @pvillard31 thank you both for the input. Will be reviewing and testing. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-23 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/257#issuecomment-200559586 Pierre You may want to rebase (merge conflicts) and push again since it's out of sink. Also, aside from unit tests would you mind giving some pointers on h

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-23 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/285#issuecomment-200557606 Also, you may want to amend the commit message "Unepected" unless its a new English word I haven't learned yet ;) --- If your project is set up for it, y

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-23 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/285#issuecomment-200557146 Ricky Could you please take a look at https://issues.apache.org/jira/browse/NIFI-1447 and see if it's what you are looking for? If I remember correctly we

[GitHub] nifi pull request: NIFI-1645 refactored PutKafka

2016-03-22 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/295#discussion_r57103757 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/PutKafka.java --- @@ -371,11 +371,12

[GitHub] nifi pull request: NIFI-1645 refactored PutKafka

2016-03-22 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/295#discussion_r57040700 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/Partitioners.java --- @@ -0,0 +1,87

[GitHub] nifi pull request: NIFI-1645 refactored PutKafka

2016-03-22 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/295#discussion_r57040041 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/PutKafka.java --- @@ -446,444 +336,136

[GitHub] nifi pull request: NIFI-1645 refactored PutKafka

2016-03-22 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/295#discussion_r57039809 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/KafkaPublisher.java --- @@ -0,0 +1,159

[GitHub] nifi pull request: NIFI-1665 fixed GetKafka to reset consumer in c...

2016-03-22 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/296 NIFI-1665 fixed GetKafka to reset consumer in case of timeout You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1665 Alternatively

[GitHub] nifi pull request: NIFI-1645 refactored PutKafka

2016-03-22 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/295 NIFI-1645 refactored PutKafka - used newest API available in 0.8.* version - added PutKafka integration tests - Kafka module code coverage is at 85% NIFI-1645 polishing You can merge

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-20 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56446641 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392

[GitHub] nifi pull request: NIFI-1647 fixed validators and config resolutio...

2016-03-19 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/288 NIFI-1647 fixed validators and config resolution You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1647 Alternatively you can review

[GitHub] nifi pull request: NIFI-1464 removed e.printStackTrace() from onTr...

2016-03-19 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/287 NIFI-1464 removed e.printStackTrace() from onTrigger in StandarProces… …sScheduler You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-198126662 @trkurc @joewitt final commit is in. Everything is squashed so give it a fresh look. Most importantly the validation suggestion that was floating around last night wasn&#

[GitHub] nifi pull request: NIFI-1629 downgraded Kafka back to 0.8

2016-03-19 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/282 NIFI-1629 downgraded Kafka back to 0.8 - added context.yield to PutKafka - added lifecycle hooks to defend from Kafka deadlocks You can merge this pull request into a Git repository by running

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-198126926 Also, the Camel example was added for testing here https://github.com/olegz/si-demo .@PuspenduBanerjee if/when you get a chance please check it out. --- If your project

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56445529 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392

[GitHub] nifi pull request: NIFI-1631 increased timeouts on test

2016-03-19 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/283 NIFI-1631 increased timeouts on test You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1631 Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-197621914 Sorry, aside from style check there are still few things I want to do, so WIP for the next 11 hours ;). But I mainly wanted to see if you can play around with the sample

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56446521 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56508487 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56596981 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,448

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-197434936 @trkurc you can use the simple app here: https://github.com/olegz/si-demo. It has some initial docs and is ready to be used as is after 'mvn clean install', b

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-15 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-197121747 @trkurc Without knowing how much spring experience you have it's hard to say, but I do have a sample app which I use for testing that I can push to my github an

[GitHub] nifi pull request: NIFI-901: Add QueryCassandra and PutCassandraQL...

2016-03-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/237#discussion_r56216735 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraQL.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-901: Add QueryCassandra and PutCassandraQL...

2016-03-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/237#discussion_r56216128 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/AbstractCassandraProcessor.java

[GitHub] nifi pull request: NIFI-901: Add QueryCassandra and PutCassandraQL...

2016-03-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/237#discussion_r56215391 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraQL.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-901: Add QueryCassandra and PutCassandraQL...

2016-03-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/237#discussion_r56214671 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/AbstractCassandraProcessor.java

[GitHub] nifi pull request: NIFI-1047 Added additional method to get proces...

2016-03-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/278#discussion_r56213996 --- Diff: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java --- @@ -1131,6 +1135,22 @@ public void run() { this.loggingFutures

[GitHub] nifi pull request: NIFI-1464 fixed OnScheduled invocation to pass ...

2016-03-15 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...

2016-03-15 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/222#issuecomment-196861594 Agreed and the JIRA is https://issues.apache.org/jira/browse/NIFI-1628 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...

2016-03-15 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/222#issuecomment-196855425 So the problem with Tibco and SSL is that Tibco does things differently then other providers. In other words they don't use SSLContext and instead rely on se

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-15 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-196846398 @joewitt @trkurc PR comments are addressed, please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi pull request: NIFI-1464 fixed OnScheduled invocation to pass ...

2016-03-15 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/279 NIFI-1464 fixed OnScheduled invocation to pass ProcessContext You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1464C Alternatively

[GitHub] nifi pull request: NIFI-1464 life-cycle refactoring part-2

2016-03-15 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/275 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-14 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56106623 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/bootstrap/SpringContextDelegate.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-14 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56106557 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,382

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-14 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56106464 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextFactory.java --- @@ -0,0 +1,139

[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...

2016-03-14 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/222#issuecomment-196535593 I'll look at it. I think I know what's going on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] nifi pull request: NIFI-1464 life-cycle refactoring part-2

2016-03-14 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/275 NIFI-1464 life-cycle refactoring part-2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1464B Alternatively you can review and

[GitHub] nifi pull request: NIFI-1464 Refactored Processor's life-cycle ope...

2016-03-11 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-11 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/271 NIFI-1571 initial commit of SpringContext support You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1571 Alternatively you can

[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...

2016-03-11 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/222#issuecomment-195427526 We'll be adding more docs in there in the future related to specific providers (e.g., IBM, Tibco etc), so treat it as place holder --- If your project is set up f

[GitHub] nifi pull request: Nifi 1540 - AWS Kinesis Get and Put Processors

2016-03-08 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/239#discussion_r55397257 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/consumer/GetKinesis.java --- @@ -0,0 +1,238

[GitHub] nifi pull request: Nifi 1540 - AWS Kinesis Get and Put Processors

2016-03-08 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/239#discussion_r55396633 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/AbstractBaseAWSProcessor.java --- @@ -0,0 +1,211

[GitHub] nifi pull request: Nifi 1540 - AWS Kinesis Get and Put Processors

2016-03-08 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/239#discussion_r55396443 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/AbstractBaseAWSProcessor.java --- @@ -0,0 +1,211

[GitHub] nifi pull request: NIFI-1573 Allow programmatic access to a Proces...

2016-03-08 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/251#issuecomment-193884361 While I can't see any valid reasons why would someone provide their own implementation of ProcessContext in some custom code, it is still a breaking change since it

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-08 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/257#discussion_r55371374 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/SetSNMPTest.java --- @@ -0,0 +1,411

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-08 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/257#discussion_r55369456 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/AbstractSNMPProcessor.java --- @@ -0,0 +1,414

[GitHub] nifi pull request: NIFI-1595 fixed ReflectionUtils to honor bridge...

2016-03-07 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/260#issuecomment-193430912 np --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] nifi pull request: NIFI-1595 fixed ReflectionUtils to honor bridge...

2016-03-07 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/260#issuecomment-193428093 np, most of the formatting was done to javadocs since they were too long. Is that the changes you are referring to? Just curious --- If your project is set up for it, you

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-07 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/257#issuecomment-193297602 Pierre, so the ReflectionUtils fix is in https://github.com/apache/nifi/pull/260. So watch the PR and once it is merged, rebase, update (remove that temp fix code) and test

[GitHub] nifi pull request: NIFI-1595 fixed ReflectionUtils to honor bridge...

2016-03-07 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/260 NIFI-1595 fixed ReflectionUtils to honor bridge methods Refactored and simplified ReflectionUtils while at it Added ReflectionUtilsTest You can merge this pull request into a Git repository by

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-06 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/257#discussion_r55147036 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPUtils.java --- @@ -0,0 +1,268

[GitHub] nifi pull request: NIFI-1568: Add Filter Capability to UnpackConte...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/248#discussion_r54299720 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java --- @@ -202,11

[GitHub] nifi pull request: NIFI-901: Add QueryCassandra and PutCassandraQL...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/237#discussion_r54299220 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/AbstractCassandraProcessor.java

[GitHub] nifi pull request: NIFI-1568: Add Filter Capability to UnpackConte...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/248#discussion_r54298253 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java --- @@ -202,11

[GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/224#discussion_r54297234 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/ItemKeys.java --- @@ -0,0 +1,52

[GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/224#discussion_r54296973 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/GetDynamoDB.java --- @@ -0,0 +1,180

[GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/224#discussion_r54296834 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/DeleteDynamoDB.java --- @@ -0,0 +1,152

[GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/224#discussion_r54296650 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/DeleteDynamoDB.java --- @@ -0,0 +1,152

[GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/224#discussion_r54296295 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/AbstractDynamoDBProcessor.java --- @@ -0,0

[GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/224#discussion_r54296101 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/AbstractDynamoDBProcessor.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1534 removed SupportsBatching annotation f...

2016-02-26 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/249 NIFI-1534 removed SupportsBatching annotation from PutKafka You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1534c Alternatively

[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...

2016-02-26 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/210#issuecomment-189315181 Point taken, wasn't sure what DISABLED meant in the context of Processor and thought it was some leftover that shouldn't be there. Will put it back and add te

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-02-25 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-188803549 I'll see if I can mock the existing Test stubs later on to see if we can have unit tests for it, but given the fact that SSL ControllerService is tested separately I

[GitHub] nifi pull request: NIFI-1420 Adding Splunk bundle

2016-02-25 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/233#discussion_r54099600 --- Diff: nifi-nar-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/main/java/org/apache/nifi/processors/splunk/ListenSplunkForwarder.java --- @@ -0,0

<    1   2   3   4   5   6   >