Re: Review Request 49526: SENTRY-1365

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49526/#review141303 --- Ship it! Ship It! - Anne Yu On July 5, 2016, 11:54 p.m., Hao

Re: Review Request 49738: SENTRY-1317: Implement fencing required for active/passive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49738/#review141285 --- Nice work Colin! Left some initial feedback. Seems like we need to

Re: Review Request 49526: SENTRY-1365

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49526/#review141309 --- Nice work Hao! Just one comment about the length of path. sentry

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49397/#review141307 --- Thanks Sravya! Left more comments here. sentry-binding/sentry-bi

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

> On July 1, 2016, 12:52 a.m., Hao Hao wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java, > > line 66 > > > > > > What if the notifi

Re: Review Request 49491: SENTRY-1334 test and add test for CTAS and Create View AS SELECT (cross databases cases)

> On July 1, 2016, 5:31 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java, > > line 633 > > > > > > Can you also try to add one test for Creat

Re: Review Request 49738: SENTRY-1317: Implement fencing required for active/passive

> On July 8, 2016, 6:04 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/Fencer.java, > > line 135 > > > > > > Why rollback? What

Re: Review Request 49738: SENTRY-1317: Implement fencing required for active/passive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49738/ --- (Updated July 8, 2016, 7:59 p.m.) Review request for sentry, Hao Hao, Rahul Sha

Re: Review Request 49738: SENTRY-1317: Implement fencing required for active/passive

> On July 8, 2016, 6:04 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/Fencer.java, > > line 135 > > > > > > Why rollback? What

Re: Review Request 49738: SENTRY-1317: Implement fencing required for active/passive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49738/#review141326 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

> On July 8, 2016, 6:29 p.m., Hao Hao wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java, > > line 81 > > > > > > Why 99 here? G

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49397/ --- (Updated July 8, 2016, 9:30 p.m.) Review request for sentry, Anne Yu, Colin McC

Re: Review Request 49777: SENTRY-1321: Implement HMSFollower in Sentry service which reads the NotificationLog entries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49777/ --- (Updated July 9, 2016, 2:13 a.m.) Review request for sentry and Hao Hao. Repo