Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r100089847
--- Diff: lib/go/test/tests/thrifttest_driver.go ---
@@ -162,7 +162,7 @@ func (p *ThriftTestDriver) Start() {
t.Fatal("TestStringMap
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r100088653
--- Diff: lib/go/test/tests/thrifttest_driver.go ---
@@ -162,7 +162,7 @@ func (p *ThriftTestDriver) Start() {
t.Fatal("TestStringMap
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97858435
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97843055
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97841167
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
GitHub user dcelasun opened a pull request:
https://github.com/apache/thrift/pull/1156
THRIFT-4011 Use slices for Thrift sets
As discussed in
[THRIFT-4011](https://issues.apache.org/jira/browse/THRIFT-4011), this commit
changes the Go generator to use slices, instead of maps for