Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/855
I think `computeIfAbsent()` would have been better :goat:
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/857
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/855
Well, you would do use ConcurrentHashMap ;-)
```
static Map LOADED = new ConcurrentHashMap<>();
try {
LOADED.computeIfAbsent(graphOrGraphCompute
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/844
Finally got docs building again.
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/862
After running `bin/process-docs.sh` the resulting console/server zip files
no longer contain `docs/` let alone `images`. Is there a different step that
needs to be run?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/862
I did:
1. `bin/process-docs.sh`
2. `mvn install`
3. `find . -name '*.zip'`
4. `unzip -t
./gremlin-server/target/apache-tinkerpop-gremlin-server-3.2.9-distribution.z
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/862
I walked through the actual release process and this time I do see the
correct packaging.
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/869
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/861
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/860
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/864
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/871
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/874
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/876
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/886
@spmallette any idea why the spark test is hanging in travis?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/892
I don't like this patch. If the regression tests rely on some sort order
in xml, they're doing it wrong. If it's the graph being validated, then the
test should pull it into
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/904
TINKERPOP-2016 Bumped to Jackson 2.9.6
https://issues.apache.org/jira/browse/TINKERPOP-2016
Bumped to Jackson 2.9.6 for CVE.
You can merge this pull request into a Git repository by
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/904
@spmallette Thanks.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/907
Is there a test that covers this?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/907
@RainMark Could you create an issue in Jira and describe the problem? See
also [Contributing code
changes](https://tinkerpop.apache.org/docs/current/dev/developer/#_contributing_code_changes
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/912
TINKERPOP-2023 SSL Enhancements
https://issues.apache.org/jira/browse/TINKERPOP-2023
Gremlin Server no longer supports automatically creating self-signed
certificates
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/912
Right, when it's security-related, you're given a pass to break anything!
:rage1: :rage2: :rage3: :rage4:
Seriously, the breaking change is only if you relied on
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/912
@k4rthikr That's a little deeper than I want to get into. `sslCipherSuites`
provides a whitelist. Whitelists are always preferred over blacklists. If this
one were blacklisted, ther
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/919
@otaviojava did you decompile the bytecode to make sure the compiler didn't
do that automagically? Otherwise, StringBuilder vars should be final.
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211934120
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -208,14 +208,14
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211934275
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -286,10 +286,10
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211948320
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -208,14 +208,14
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211952645
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -208,14 +208,14
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/919
@otaviojava was that locally? the travis build failed due to grapes
download.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/919
Hmm.. it happens on tp32.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/919
Nevermind, still just grapes.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/914
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/919
@dkuppitz Will do.
---
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/930
TINKERPOP-2032 bump jython-standalone 2.7.1
https://snyk.io/vuln/SNYK-JAVA-ORGPYTHON-31451
Overview
org.python:jython-standalone Affected versions of this package are
vulnerable
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/930
tp33: `docker/build.sh -i -t -n` SUCCESS
master: building...
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/930
master: `docker/build.sh -i -t -n` BUILD SUCCESS
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/931#discussion_r217732616
--- Diff: docs/src/upgrade/release-3.4.x.asciidoc ---
@@ -29,6 +29,29 @@ Please see the
link:https://github.com/apache/tinkerpop/blob/3.4.0
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/931#discussion_r217731843
--- Diff: docs/src/upgrade/release-3.4.x.asciidoc ---
@@ -29,6 +29,29 @@ Please see the
link:https://github.com/apache/tinkerpop/blob/3.4.0
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/931#discussion_r217720970
--- Diff: docs/src/upgrade/release-3.4.x.asciidoc ---
@@ -29,6 +29,29 @@ Please see the
link:https://github.com/apache/tinkerpop/blob/3.4.0
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/932#discussion_r217736025
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoSerializersV3d0.java
---
@@ -427,7 +428,12 @@ else if (1
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/930
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/931
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/932
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/930
Claiming 7-day rule :smile:
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/935
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/934
VOTE +1
---
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/939
TINKERPOP-2045 removed duplicate non-indy groovy core dep
https://issues.apache.org/jira/browse/TINKERPOP-2045
Exclude non-indy transitive dep on groovy core.
You can merge this pull
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/920
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/941
@spmallette Should have a CHANGELOG entry if not also an upgrade release
note.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/944
I would like to see `TP` renamed to `TextP`.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/941
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/942
VOTE +1
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/943#discussion_r221859065
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Settings.java
---
@@ -243,6 +243,8 @@ public static Settings from(final
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/943#discussion_r221858009
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java
---
@@ -575,6 +585,8 @@ SslContext createSSLContext() throws
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/946
TINKERPOP-2037 removed groovy-sql
Removed unused groovy-sql dependency.
https://issues.apache.org/jira/browse/TINKERPOP-2037
`sh docker/build.sh -i -t` BUILD SUCCESS
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/942
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/943
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/944
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/945
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/948
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/949
VOTE +1
---
Github user robertdale commented on the pull request:
https://github.com/apache/tinkerpop/commit/a8da47f14f731825d86b0ccaacf8e1187f6d50eb#commitcomment-19394971
Looks like cruft leftover from the leading zeroes style. And then obviously
didn't bother testing beyond 9 lines afte
Github user robertdale closed the pull request at:
https://github.com/apache/tinkerpop/pull/399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/399
okie dokie
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/439
@PommeVerte do you mind if we move the ubuntu script to a separate pull
request so this one can move forward?
---
If your project is set up for it, you can reply to this email and have your
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/439
Rebased. Retested.
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/439
@spmallette I pushed the windows changes. can you review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/482
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/496
TINKERPOP-1556 allow developers to pass options to docker
This was a much smaller change than I expected. Originally I was adding
some sysctl settings to the dockerfiles. In the end I
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/496
Technically, neither, not even for the daemon. It's specific to certain
distribution startup scripts. So there should be no overlap here.
---
If your project is set up for it, you can
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/498
TINKERPOP-1557 Improve docker build time with this one weird trick!
Total time went from just over 4 hours to 2:20m. Get back 1:40m of your
cycles!
Giraph: startup would wait 3s to
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/498
@okram The giraph improvement will help all builds inside or outside of
docker. That should save you about 1 hour. I don't know what OS you're on, but
in Linux you can get
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/498
There's probably over an hour that can be gained in giraph that's spent in
waiting for everything to shutdown in each test run (about 6s each). Looks like
it's zookeper. But
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/498
@spmallette I concur with @dkuppitz that you don't appear to be using
tmpfs. What OS, branches, etc, and how to reproduce the mkdirs issue?
---
If your project is set up for it, yo
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/498
@spmallette looks like this:
```
Step 5 : CMD sh -c docker/scripts/build.sh -t -i -n
---> Running in 3ab3e0b10487
---> 1baf7291ec3a
Removing intermediate con
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/502
I like the refactoring. But why go backwards in java version? Is this for
source or target compatibility? If it's source, I can't imagine as a dev you
don't have the abilit
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/498
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/487
VOTE: +0.01
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/504
I've seen this on master.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/504#discussion_r88893084
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionComputerTest.java
---
@@ -86,7 +97,7
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Either one appears to work cleanly. Just update first - `git fetch --all`.
Obviously, make sure you're on your branch `git checkout tp31`.
Then either `git rebase upstream/tp31` or
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/446
Can this PR be updated with Map or should it be closed and
open a new one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/446
This is interesting. I was unaware of some or didn't understand some
implementation details. Taking a step back and looking at this again, I wonder
if the original intent is more co
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/446
Thanks for the clarification @dkuppitz
`./docker/build.sh -t -i -n ` passes
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I didn't consider that your remote branch was behind. Duh. What should have
been done is a forced push `git push -f origin tp31` to replace your remote
branch with your local branch. In
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/457
@pauljackson It's all good. It's only the history here in the PR that looks
weird. Since it's just the one commit, it'll be right in git history when it's
actua
Github user robertdale commented on the pull request:
https://github.com/apache/tinkerpop/commit/4eba658bcb347679eda964c27595e5d3969a199a#commitcomment-19987601
In CHANGELOG.asciidoc:
In CHANGELOG.asciidoc on line 49:
1. Isn't it Map?
2. It should be T.id and T.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/494
I'm on Apache Maven 3.3.9 (latest). So I'm ok with downgrading :trollface:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/508
Building world `docker/build.sh -t -i -n -d ` passes.
Building docs only `docker/build.sh -d ` passes.
Skimmed reference docs through browser.
VOTE: +1
---
If your project is
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/507
`docker/build.sh -t -i -n` passes.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/508#discussion_r90632990
--- Diff: CHANGELOG.asciidoc ---
@@ -26,6 +26,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
TinkerPop
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/512
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/536
Support SSL client certificate authentication
Can be used with or without an Authenticator (authentication configuration)
Valid configs look like:
**No client cert auth
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/536
@spmallette before you say it, I know I have to update changelog and update
docs. :boom:
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/536
Just wondering if posting a comment after updating the title will trigger
JIRA to connect (or however that works).
---
If your project is set up for it, you can reply to this email and have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/536
And it does. Yay. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/536
If you can point me to a test that starts a gremlin-server with a custom
config, then I can make that happen.
---
If your project is set up for it, you can reply to this email and have your
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/536
Looks like I can copy GremlinServerIntegrateTest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/537
Isn't there a distribution verification that does tests? I know it's
post-build, but that's better than nothing.
---
If your project is set up for it, you can reply to this
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/536
Tests added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
101 - 200 of 390 matches
Mail list logo
