[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

2018-04-17 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2905 @zjffdu @felixcheung Can you take a look at this PR? I've changed the goal of this PR so that Installing a new interpreter become possible in helium/interpreter tab ---

[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

2018-04-22 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2905 @zjffdu Can you check it again? ---

[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

2018-04-22 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2905 @jongyoul I tried this PR and download the pig interpreter, and found several issues. 1. The helium.json still use plugin of 0.7.2, but my zeppelin server is on 0.9 (master). Zeppelin should di

[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

2018-04-22 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2905 @zjffdu 1. It's what we need to discuss. I, basically, make a new PR for handing version issue for it, but we need to discuss how to manage interpreters' version. Before that, we need t

[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

2018-04-23 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2905 Concerning what you mentioned the above, I've implemented the second one to check different names with same interpreters. To clarify it, if you install `zeppelin-pig` in a UI, the logic would che

[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

2018-04-23 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2905 @zjffdu I addressed all of what you commented before and test passed. https://travis-ci.org/jongyoul/zeppelin/builds/369969538 ---

[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

2018-04-23 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2905 Thanks @jongyoul LGTM, and please create apache ticket for the follow up work ---

[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

2018-04-23 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2905 - Helium menu: https://issues.apache.org/jira/browse/ZEPPELIN-3424 - Enable/Disable: https://issues.apache.org/jira/browse/ZEPPELIN-3425 ---