Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/567
---
Github user suyogmapara commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r210988903
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnLogTest.java ---
@@ -17,9 +17,13 @@
*/
package org.apache.zookeeper.
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r209526014
--- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml
---
@@ -840,6 +840,26 @@ server.3=zoo3:2888:3888
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r209484474
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnLogTest.java ---
@@ -17,9 +17,13 @@
*/
package org.apache.zookeeper.serv
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r209484281
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -127,14 +127,11 @@
Long logSize = Long.getLong(L
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r209484163
--- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml
---
@@ -840,6 +840,26 @@ server.3=zoo3:2888:3888
Github user suyogmapara commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r206338732
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapse
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205933566
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapsed f
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205933558
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapsed f
Github user suyogmapara commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205923249
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapse
Github user suyogmapara commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205922930
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -127,14 +127,11 @@
Long logSize = Long.getLo
Github user suyogmapara commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205897728
--- Diff: src/java/test/org/apache/zookeeper/test/TxnLogSizeLimitTest.java
---
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foun
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205667420
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapsed fsyn
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205667343
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapsed fsyn
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205667305
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,20 @@
/** Maximum time we allow for elapsed fsyn
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205526853
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,20 @@
/** Maximum time we allow for elapsed fs
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205525593
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -109,7 +109,7 @@
*
* The feature is disabled by
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205527457
--- Diff: src/java/test/org/apache/zookeeper/test/TxnLogSizeLimitTest.java
---
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundati
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205526028
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -127,14 +127,11 @@
Long logSize = Long.getLong(L
Github user suyogmapara commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202855015
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -110,6 +124,18 @@
if ((fsyncWarningThreshold =
Lo
Github user suyogmapara commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202854476
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -110,6 +124,18 @@
if ((fsyncWarningThreshold =
Lo
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202364176
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -347,6 +397,13 @@ public synchronized void commit() throws IOExcep
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202363134
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,20 @@
/** Maximum time we allow for elapsed f
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202364713
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -347,6 +397,13 @@ public synchronized void commit() throws IOExcep
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202363520
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -110,6 +124,18 @@
if ((fsyncWarningThreshold =
Long.
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202362761
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -110,6 +124,18 @@
if ((fsyncWarningThreshold =
Long.
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202364057
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -347,6 +397,13 @@ public synchronized void commit() throws IOExcep
GitHub user suyogmapara opened a pull request:
https://github.com/apache/zookeeper/pull/567
ZOOKEEPER-3071: Add a config parameter to control transaction log size
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/suyogmapara/zookee
28 matches
Mail list logo
