Re: [edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function

On 8/1/2024 10:18 PM, Leif Lindholm via groups.io wrote: On Thu, Aug 01, 2024 at 16:36:14 +0700, Nhi Pham via groups.io wrote: This adds the SmbusRead() function designed for SMBUS transaction to support the extraction of the data lenth byte from the initial byte of the SMBUS Block Read

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function

On 8/1/2024 10:14 PM, Leif Lindholm wrote: On Thu, Aug 01, 2024 at 16:36:14 +0700, Nhi Pham via groups.io wrote: This adds the SmbusRead() function designed for SMBUS transaction to support the extraction of the data lenth byte from the initial byte of length I will fix, thanks

Re: [edk2-devel] [edk2-platforms][PATCH 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC

On 8/1/2024 10:02 PM, Leif Lindholm via groups.io wrote: On Thu, Aug 01, 2024 at 16:36:15 +0700, Nhi Pham wrote: This introduces fixed PCDs for SMBUS and BMC as specified to Ampere. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 12 1 file

Re: [edk2-devel] Patch OvmfPkg: Use heap memory for virtio-scsi request causing regression

milar change. I am looking into why this may be failing. Regards, Sami Mujawar *From: * on behalf of "Aithal, Srikanth via groups.io" *Reply to: *"devel@edk2.groups.io" , "srikanth.ait...@amd.com" *Date: *Thursday 1 August 2024 at 12:28 *To: *"devel@edk2.gr

Re: [edk2-devel] How to optimize boot time?

> On Jul 3, 2024, at 4:52 AM, Hamit Can Karaca wrote: > > Hi, > > So I've a SBL+EDK2 customized firmware. This firmware enters the BIOS menu in > approximately 17 seconds. I haven't seen this as a problem for a long time, > but I've seen some CFL motherboards boot up the OS in 17 seconds.

Re: [edk2-devel] Can't set the boot order of the USB boot device

> On Jul 10, 2024, at 6:05 AM, Hamit Can Karaca wrote: > > Hello, > > We recently found a bug where we can't change the boot order of a USB boot > device. We are trying to set it on the top of the boot order but it keeps > going to the last place. Sometimes it works fine but most of the

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/PlatformInitLib: Detect FlashNvVarStore before validate it

> On Jul 19, 2024, at 12:35 AM, Gerd Hoffmann wrote: > > On Thu, Jul 18, 2024 at 07:57:27PM GMT, Tom Lendacky wrote: >> On 7/16/24 21:30, 韩里洋 wrote: >>> Hi Tom, >>> >>> >>> >>> >>> Thank you for your response. >>> >>> In fact, I'm unable to proceed with the development of the fix patch

Re: [edk2-devel] Map File for PEI and DXE Phases

> On Jul 19, 2024, at 6:19 AM, bagcic via groups.io > wrote: > > I need map files for all phases for debug purpose. How can I generate these > files after build? Why do you think you need map files? Lots of code does not generally execute at its linked address? The

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/ ARM AARCH64: Remove ArmPlatformLib MPCore boilerplate

For Silicon/Ampere/AmpereAltraPkg, Reviewed-by: Nhi Pham Tested-by: Nhi Pham Thanks, Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120187): https://edk2.groups.io/g/devel/message/120187 Mute This Topic:

Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf

For Silicon/Ampere/AmpereAltraPkg, Reviewed-by: Nhi Pham Tested-by: Nhi Pham Thanks, Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120186): https://edk2.groups.io/g/devel/message/120186 Mute This Topic:

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/Library/MpInitLib: fix SEV-ES AP bootinng failure

On 7/31/24 05:22, Wencheng Yang via groups.io wrote: > According to SEV-ES Guest-Hypervisor Communication Block Standardization > section 4.3 SMP Booting, the subsequent reset requires the AP enters > Reset Hold state either by AP Reset Hold NAE event or > AP Reset Hold Request

[edk2-devel] Patch OvmfPkg: Use heap memory for virtio-scsi request causing regression

Hello all, After the patches [1fc55a39, b342070c] OvmfPkg: Use heap memory for virtio-blk request/OvmfPkg: Use heap memory for virtio-scsi request got merged, this regression is spotted. AMD SVM/SEV/SEVES guest boot fails with OVMF packages [Ia3264/X64] built from today's upstream edk2

[edk2-devel] [edk2-platforms][PATCH 4/5] JadePkg: Add PlatformBmcReadyLib to support BMC ready check

This adds the PlatformBmcReadyLib library instance, which provides a function to check whether the BMC is ready for transaction or not. The function checks the GPIO pin specified by the PcdBmcReadyGpio PCD and returns TRUE if the pin is set to a logic high level, indicating that the BMC is ready.

[edk2-devel] [edk2-platforms][PATCH 5/5] Ampere/Jade: Enable IPMI SSIF

This adds the building of IPMI SSIf and associated modules. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 23 Platform/Ampere/JadePkg/Jade.dsc | 2 ++ Platform/Ampere/JadePkg/Jade.fdf | 17

[edk2-devel] [edk2-platforms][PATCH 3/5] AmpereAltraPkg: Add SmbusHc PEI and DXE drivers

This adds the implementation of SMBUS PPI and Protocol to produce SMBUS interface in both PEI and DXE phases for use by IPMI SSIF. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf | 43 +++ Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf |

[edk2-devel] [edk2-platforms][PATCH 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC

This introduces fixed PCDs for SMBUS and BMC as specified to Ampere. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 12 1 file changed, 12 insertions(+) diff --git a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec

[edk2-devel] [edk2-platforms][PATCH 0/5] Add IPMI SSIF support

This updates the I2C library and implements SMBUS PEI/DXE drivers to support IPMI SSIF in the Mt. Jade platform. Nhi Pham (5): AmpereAltraPkg/DwI2cLib: Add SmbusRead() function AmpereSiliconPkg: Define PCDs for SMBUS and BMC AmpereAltraPkg: Add SmbusHc PEI and DXE drivers JadePkg: Add

[edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function

This adds the SmbusRead() function designed for SMBUS transaction to support the extraction of the data lenth byte from the initial byte of the SMBUS Block Read, allowing the I2C master to accurately read the SMBUS response with the exact data length. This addresses the issue where the

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Ampere/JadePkg: Add secure boot default keys initialization

Pushed as 6c78047349e2..443eb9601190 -Nhi On 6/5/2024 11:10 AM, Rebecca Cran wrote: Reviewed-by: Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120137): https://edk2.groups.io/g/devel/message/120137 Mute This Topic:

Re: [edk2-devel] [PATCH RFC edk2-platforms 3/5] Platform/Ampere: Switch to unicore SEC implementation

Thanks Ard for the clean up and maintaining the platforms's updates. Reviewed-by: Nhi Pham Tested-by: Nhi Pham Regards, Nhi On 7/29/2024 7:22 PM, Ard Biesheuvel wrote: From: Ard Biesheuvel Spec adherent AArch64 systems use PSCI to manage secondary CPUs, and only enter the execution level

Re: [edk2-devel] [PATCH edk2-platforms 0/6] JadePkg and common Ampere code fixes

Pushed as 8975c5d45ea9..6c78047349e2 Thanks, Nhi On 6/7/2024 11:49 AM, Nhi Pham wrote: For this series, Reviewed-by: Nhi Pham Thanks, Nhi On 6/6/2024 10:04 AM, Rebecca Cran wrote: These are a set of bug fixes I made to the Mt Jade and common Ampere code while working on updating and

[edk2-devel] [PATCH edk2-platforms 1/1] Platform AARCH64: Drop bogus local copy of gArmMpCoreInfoPpiGuid GUID

From: Ard Biesheuvel There is a pattern that has been copy-pasted a number of times where a missing references in the INFs [Ppis] section is 'fixed' by creating a local GUID variable. Fix all of those. This is just a janitorial patch with no functional changes so fixing all of these in one go.

[edk2-devel] [PATCH RFC edk2-platforms 0/5] Phase out MPCore SEC drivers

From: Ard Biesheuvel The original EDK2 port to 32-bit ARM supported multi-core but on today's ARM systems, only a single CPU enters the non-secure firmware and the MPCore drivers are obsolete. Stop using them in edk2-platforms so we can remove them entirely from edk2. Cc: Leif Lindholm Cc:

[edk2-devel] [PATCH RFC edk2-platforms 4/5] Platform/Durian: Switch to unicore SEC implementation

From: Ard Biesheuvel Spec adherent AArch64 systems use PSCI to manage secondary CPUs, and only enter the execution level where UEFI and the OS live using a single CPU. This means using a SEC implementation of the MPCore variety is never needed, and in practice, those drivers don't work

[edk2-devel] [PATCH RFC edk2-platforms 3/5] Platform/Ampere: Switch to unicore SEC implementation

From: Ard Biesheuvel Spec adherent AArch64 systems use PSCI to manage secondary CPUs, and only enter the execution level where UEFI and the OS live using a single CPU. This means using a SEC implementation of the MPCore variety is never needed, and in practice, those drivers don't work

[edk2-devel] [PATCH RFC edk2-platforms 5/5] Platform/HiSilicon/D0x: Switch to unicore SEC implementation

From: Ard Biesheuvel Spec adherent AArch64 systems use PSCI to manage secondary CPUs, and only enter the execution level where UEFI and the OS live using a single CPU. This means using a SEC implementation of the MPCore variety is never needed, and in practice, those drivers don't work

[edk2-devel] [PATCH edk2-platforms v2 6/8] Platform/RaspberryPi/PlatformBootManagerLib: Reimplement reset hook

From: Ard Biesheuvel Duplicate the logic that is triggered on a system reset into the platform boot manager driver, and hook it up to the EDK2 platform specific reset notification driver. This is supported by generic EDK2 code in MdeModulePkg, allowing us to retire the platform-specific

[edk2-devel] [PATCH RFC edk2-platforms 1/5] Platform AARCH64: Drop leftover references to deleted timer PCD

From: Ard Biesheuvel gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz was made obsolete as AArch64 firmware runs in the non-secure world while programming the timer frequency must be done from the secure world. Drop some remaining references to the PCD. Signed-off-by: Ard Biesheuvel ---

[edk2-devel] [PATCH RFC edk2-platforms 2/5] Platform AARCH64: Remove bogus references to MPCore stack

From: Ard Biesheuvel Remove references to the MPCore stack from platforms that do not use the MPCore SEC implementations to begin with. Signed-off-by: Ard Biesheuvel --- Platform/ARM/Morello/MorelloPlatform.dsc.inc| 2 -- Platform/ARM/SgiPkg/SgiPlatform.dsc.inc

[edk2-devel] [PATCH edk2-platforms v2 7/8] Platform/RaspberryPi: Switch to generic reset runtime

From: Ard Biesheuvel Drop the reference to the special reset runtime DXE driver in EmbeddedPkg, and move to the one in MdeModulePkg shared between all architectures. This version implements reset notifications, allowing us to retire the home grown version of that functionality in a subsequent

[edk2-devel] [PATCH edk2-platforms v2 8/8] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

From: Ard Biesheuvel Drop the now unused EfiResetSystemLib implementation, which has been superseded by the generic one from EDK2. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- Platform/RaspberryPi/RaspberryPi.dec | 1 -

[edk2-devel] [PATCH edk2-platforms v2 3/8] Platform/RaspberryPi: Use depex based dispatch order for varstore

From: Ard Biesheuvel The VarBlockServiceDxe driver needs to be dispatched before the common VariableRuntimeDxe, but we are currently relying on FDF order and lack of transitive dependencies for this, which is fragile, and will break once we move to the generic reset runtime. So use the existing

[edk2-devel] [PATCH edk2-platforms v2 4/8] Platform/RaspberryPi/VarBlockServiceDxe: Refactor DumpVars event handler

From: Ard Biesheuvel The DumpVars() routine is called directly and via an event notification callback, and the latter therefore defines the function's prototype, even though the arguments are unused. We will introduce another callback into this logic, but via a reset notifier, which has yet

[edk2-devel] [PATCH edk2-platforms v2 2/8] Platform/RaspberryPi: Fix line endings in DSCs

From: Ard Biesheuvel Get rid of spurious LF-only line endings. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- Platform/RaspberryPi/RPi3/RPi3.dsc | 2 +- Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [PATCH edk2-platforms v2 5/8] Platform/RaspberryPi/VarBlockServiceDxe: Register for reset notification

From: Ard Biesheuvel In addition to setting up the home grown reset notification, register with the generic EFI protocol that does the same. This event is triggered from the reset runtime implemented in MdeModulePkg, to which we will be switching the RPi platforms in a subsequent patch.

[edk2-devel] [PATCH edk2-platforms v2 1/8] Platform/RaspberryPi: Mark RAM regions as write/execute protectable

From: Ard Biesheuvel Mark RAM ranges as write/execute protectable in the GCD memory map. This is needed to avoid issues with NonCoherentDmaLib in EmbeddedPkg, which will fail if it does not manage to set the EFI_MEMORY_XP attribute on the allocated DMA buffers. Signed-off-by: Ard Biesheuvel

[edk2-devel] [PATCH edk2-platforms v2 0/8] RPi: Drop EmbeddedPkg reset runtime

From: Ard Biesheuvel The EmbeddedPkg runtime DXE is being retired in favour of the generic one in MdeModulePkg which is actually being maintained. RPi uses this driver and the associated EfiResetSystemLib, of which it has an implementation with value-add for reset notification. So this logic

[edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

From: Ard Biesheuvel Drop the now unused EfiResetSystemLib implementation, which has been superseded by the generic one from EDK2. Signed-off-by: Ard Biesheuvel --- Platform/RaspberryPi/RaspberryPi.dec | 1 -

[edk2-devel] [PATCH edk2-platforms 4/5] Platform/RaspberryPi: Switch to generic reset runtime

From: Ard Biesheuvel Drop the reference to the special reset runtime DXE driver in EmbeddedPkg, and move to the one in MdeModulePkg shared between all architectures. This version implements reset notifications, allowing us to retire the home grown version of that functionality in a subsequent

[edk2-devel] [PATCH edk2-platforms 3/5] Platform/RaspberryPi/PlatformBootManagerLib: Reimplement reset hook

From: Ard Biesheuvel Duplicate the logic that is triggered on a system reset into the platform boot manager driver, and hook it up to the EDK2 platform specific reset notification driver. This is supported by generic EDK2 code in MdeModulePkg, allowing us to retire the platform-specific

[edk2-devel] [PATCH edk2-platforms 0/5] RPi: Drop EmbeddedPkg reset runtime

From: Ard Biesheuvel The EmbeddedPkg runtime DXE is being retired in favour of the generic one in MdeModulePkg which is actually being maintained. RPi uses this driver and the associated EfiResetSystemLib, of which it has an implementation with value-add for reset notification. So this logic

[edk2-devel] [PATCH edk2-platforms 1/5] Platform/RaspberryPi/VarBlockServiceDxe: Refactor DumpVars event handler

From: Ard Biesheuvel The DumpVars() routine is called directly and via an event notification callback, and the latter therefore defines the function's prototype, even though the arguments are unused. We will introduce another callback into this logic, but via a reset notifier, which has yet

[edk2-devel] [PATCH edk2-platforms 11/11] Silicon/Phytium: Switch to generic ArmPsciResetSystemLib

From: Ard Biesheuvel The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a slightly different way. Move this platform to the generic ArmPsciResetSystemLib, and drop the dependency on

[edk2-devel] [PATCH edk2-platforms 06/11] Platform/SynQuacer: Switch to generic ArmPsciResetSystemLib

From: Ard Biesheuvel The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a slightly different way. Move this platform to the generic ArmPsciResetSystemLib, and drop the dependency on

[edk2-devel] [PATCH edk2-platforms 07/11] Silicon/Ampere: Switch to generic ArmPsciResetSystemLib

From: Ard Biesheuvel The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a slightly different way. Move this platform to the generic ArmPsciResetSystemLib, and drop the dependency on

[edk2-devel] [PATCH edk2-platforms 09/11] Silicon/Armada7k8k: Switch to generic ArmPsciResetSystemLib

From: Ard Biesheuvel The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a slightly different way. Move this platform to the generic ArmPsciResetSystemLib, and drop the dependency on

[edk2-devel] [PATCH edk2-platforms 05/11] Platform/SbsaQemu: Switch to generic ArmPsciResetSystemLib

From: Ard Biesheuvel The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a slightly different way. Move this platform to the generic ArmPsciResetSystemLib, and drop the dependency on

[edk2-devel] [PATCH edk2-platforms 08/11] Silicon/HiSilicon: Switch to generic ArmPsciResetSystemLib

From: Ard Biesheuvel The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a slightly different way. Move this platform to the generic ArmPsciResetSystemLib, and drop the dependency on

[edk2-devel] [PATCH edk2-platforms 2/5] Platform/RaspberryPi/VarBlockServiceDxe: Register for reset notification

From: Ard Biesheuvel In addition to setting up the home grown reset notification, register with the generic EFI protocol that does the same. This event is triggered from the reset runtime implemented in MdeModulePkg, to which we will be switching the RPi platforms in a subsequent patch.

[edk2-devel] [PATCH edk2-platforms 10/11] Silicon/NxpQoriqLs: Switch to generic ArmPsciResetSystemLib

From: Ard Biesheuvel The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a slightly different way. Move this platform to the generic ArmPsciResetSystemLib, and drop the dependency on

[edk2-devel] [PATCH edk2-platforms 02/11] Silicon/SynQuacer: Fix CLANGDWARF build

From: Ard Biesheuvel Drop the CLANG3x build options, and add ones for CLANGDWARF so that SynQuacer based platforms can be built with it. Instead of copying the -no-integrated-as option that CLANG3x used, let's fix the assembler code so it can be built with Clang's integrated assembler. Also

[edk2-devel] [PATCH edk2-platforms 00/11] Phase out ArmSmcPsciResetSystemLib

From: Ard Biesheuvel ArmSmcPsciResetSystemLib is being replaced with a generic implementation that is shared between physical and virtual placement, executing at either EL2 or EL1. So update all library class resolutions for ResetSystemLib and provide additional resolutions for its dependency

[edk2-devel] [PATCH edk2-platforms 03/11] Platform/AMD/Styx: Switch to generic ArmPsciResetSystemLib

From: Ard Biesheuvel The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a slightly different way. Move this platform to the generic ArmPsciResetSystemLib, and drop the dependency on

[edk2-devel] [PATCH edk2-platforms 04/11] Platform/ARM: Switch to generic ArmPsciResetSystemLib

From: Ard Biesheuvel The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a slightly different way. Move the ARM platforms to the generic ArmPsciResetSystemLib, and drop the dependency

[edk2-devel] [PATCH edk2-platforms 01/11] Platform,Silicon: Fix line endings

From: Ard Biesheuvel Fix some instances of a lone LF in DSCs that should all be CR-LF entirely. Signed-off-by: Ard Biesheuvel --- Silicon/Hisilicon/Hisilicon.dsc.inc | 2 +- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 2 +-

Re: [edk2-devel] [PATCH RFC edk2-platforms 0/5] Phase out MPCore SEC drivers

For the series: Reviewed-by: Rebecca Cran I see this is marked as an RFC, but I think it's a change that should be committed. -- Rebecca On 7/29/24 06:22, Ard Biesheuvel wrote: From: Ard Biesheuvel The original EDK2 port to 32-bit ARM supported multi-core but on today's ARM systems, only

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Prepare for move to GitHub Pull Request workflow

On 7/26/24 11:37, Michael D Kinney via groups.io wrote: Members with more than one email address is confusing. Can we limit to single email address for TianoCore activities? Also, should Maintainer.txt be removed yet? There is a GitHub Action active in edk2 now that assigns reviews from

Re: [edk2-devel] [PATCH edk2-platforms 07/11] Silicon/Ampere: Switch to generic ArmPsciResetSystemLib

Thanks Ard for the patch. Reviewed-by: Nhi Pham Regards, Nhi On 7/25/2024 3:24 PM, Ard Biesheuvel wrote: From: Ard Biesheuvel The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a

[edk2-devel] [PATCH edk2-platforms 4/4] Platform/Phytium: Switch to generic ResetRuntime DXE driver

From: Ard Biesheuvel The reset runtime DXE driver is deprecated and will be removed soon. It is superseded by a generic implementation in MdeModulePkg, which is shared between all architectures, and implements the notification protocols that the EFI spec describes. So move the Phytium Durian

[edk2-devel] [PATCH edk2-platforms 2/4] Platform/LoongArchQemu: Drop bogus EfiResetSystemLib resolutions

From: Ard Biesheuvel The LoongArchQemuPkg platforms do not include any drivers that depend on a resolution for EfiResetSystemLib, and the provided resolutions of that library class do not refer to libraries of the correct type anyway. So just drop the bogus resolutions entirely. Signed-off-by:

[edk2-devel] [PATCH edk2-platforms 3/4] Platform/Ampere: Switch to generic ResetRuntime DXE driver

From: Ard Biesheuvel The reset runtime DXE driver is deprecated and will be removed soon. It is superseded by a generic implementation in MdeModulePkg, which is shared between all architectures, and implements the notification protocols that the EFI spec describes. So move the Ampere Jade

[edk2-devel] [PATCH edk2-platforms 0/4] Phase out ArmPsciResetSystemLib

From: Ard Biesheuvel Replace references to ArmPsciResetSystemLib, which implements the deprecated EfiResetSystemLib library class which is consumed only by the ResetRuntimeDxe in EmbeddedPkg, which should no longer be used. Cc: Leif Lindholm Cc: Oliver Smith-Denny Cc: Rebecca Cran Cc: Nhi

[edk2-devel] [PATCH edk2-platforms 1/4] Platform/*: Fix line endings in DSCs

From: Ard Biesheuvel Fix incorrect LFs in DSCs that should be CR-LF only. Signed-off-by: Ard Biesheuvel --- Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 2 +- Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [edk2-devel] [PATCH edk2-platforms 3/4] Platform/Ampere: Switch to generic ResetRuntime DXE driver

Thanks a lot for the patch. Reviewed-by: Nhi Pham Tested-by: Nhi Pham On 7/21/2024 9:51 PM, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > The reset runtime DXE driver is deprecated and will be removed soon. It > is superseded by a generic implementation in MdeModulePkg, which is > shared

Re: [edk2-devel] Serial Debug not working in JunctionCity Whitley Platform

Any thoughts on this? On Sunday, June 30th, 2024 at 10:58 AM, memristor2 via groups.io wrote: > Hello everyone, > I'm trying to get the serial debug working on my platform but I don't know > why i can't see the debug logs. > This is the library use3d for SerialPortLIb inside th

[edk2-devel] Map File for PEI and DXE Phases

I need map files for all phases for debug purpose. How can I generate these files after build? Thanks, -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119984): https://edk2.groups.io/g/devel/message/119984 Mute This Topic:

[edk2-devel] StandaloneMM fixes for x86

Hi all, Could anyone help to review this PR? https://github.com/tianocore/edk2/pull/5814 Thank you :) Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/PlatformInitLib: Detect FlashNvVarStore before validate it

On 7/16/24 21:30, 韩里洋 wrote: > Hi Tom, > > > > > Thank you for your response. > > In fact, I'm unable to proceed with the development of the fix patch locally > as I don't have a SEV-SNP hardware for experimentation. However, it has > proven to be crucial for effectively testing and

[edk2-devel] Redfish Action URI support

Hi, I wanted to confirm if the action URI like - ComputerSystem.Reset, SecureBoot.ResetKeys are supported as part of edk2 redfish solution? If not, please comment why? Thanks, Aman -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/PlatformInitLib: Detect FlashNvVarStore before validate it

On 7/15/24 09:15, Tom Lendacky wrote: > On 7/14/24 07:24, wojiaohanliy...@163.com wrote: >> From: hanliyang >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4807 >> >> The commit 4f173db8b45b ("OvmfPkg/PlatformInitLib: Add functions for >> EmuVariableNvStore") rename the function from

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/PlatformInitLib: Detect FlashNvVarStore before validate it

On 7/14/24 07:24, wojiaohanliy...@163.com wrote: > From: hanliyang > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4807 > > The commit 4f173db8b45b ("OvmfPkg/PlatformInitLib: Add functions for > EmuVariableNvStore") rename the function from TdxValidateCfv to > PlatformValidateNvVarStore.

Re: [edk2-devel] [PATCH edk2-platforms 2/2] SbsaQemu: set CPU model in SMBIOS

On 7/12/2024 5:01 PM, Ard Biesheuvel via groups.io wrote: On Fri, 12 Jul 2024 at 11:24, Marcin Juszkiewicz wrote: SbsaQemu platform have several cpu models available. Since start it reported "arm-virt" one in SMBIOS instead of real one. This change replaces it with the real cpu

Re: [edk2-devel] Error during build the Add_Shell_String

I’d start with checking if: > > c:\users\kuldeep.rana\bios\edk2\MdePkg\Library\UefiRuntimeServicesTableLib\UefiRuntimeServicesTableLib.inf Exists? Seems like it is in the repo...

Re: [edk2-devel] [edk2-platforms][PATCH v2] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

On 7/10/2024 10:12 PM, Nickle Wang wrote: Hi @Nhi Pham , I am sorry for taking so long to address your review comments. I updated pull request here: https://github.com/tianocore/edk2-platforms/pull/76

Re: [edk2-devel] [PATCH edk2-platforms v3 4/5] SbsaQemu: provide cache info per core in PPTT

On Tue, 9 Jul 2024 14:01:53 +0100 "Leif Lindholm" wrote: > On Tue, Jul 09, 2024 at 12:47:09 +0200, Marcin Juszkiewicz wrote: > > During Linaro Connect MAD24 I was asked to move cache information from > > being 'per cluster' to be 'per core'. This is a move for implementing > > MPAM support. > >

Re: [edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid?

Hi @Rebecca Cran, I create pull request here to downgrade the message level to DEBUG_INFO: https://github.com/tianocore/edk2/pull/5897 Regards, Nickle > -Original Message- > From: Rebecca Cran > Sent: Wednesday, July 10, 2024 2:48 AM > To: Nickle

Re: [edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid?

> Should the following change be made to make sure RegularExpressionDxe is > loaded before RedfishPlatformConfigDxe? It is ok that RegularExpressionDxe is loaded after RedfishPlatformConfigDxe because EfiCreateProtocolNotifyEvent() is used to get Regular expression protocol. And I don't have

Re: [edk2-devel] Starlingx Boot Problem

Yes! The strange thing about that is there is actually a hd3/gpt2 partition and hd3 device. In spite of seeing this device, it still does not boot. It is installed on network but expected to boot on its own hard drive. I dont have an opinion. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You

Re: [edk2-devel] Starlingx Boot Problem

> On Jul 5, 2024, at 1:20 AM, bagcic via groups.io > wrote: > > We are having a problem after installing Starlingx on PXE. It boots without > problem when installed from USB drive. So we want to know the root cause of > installing it on network.

[edk2-devel] The NX bit in page table is not expected for new allocated EfiBootServicesCode

Problem: The NX bit in page table is not expected for new allocated EfiBootServicesCode if bit7(EfiConventionalMemory) is zero and bit0(EfiReservedMemoryType) is one of PcdDxeNxMemoryProtectionPolicy. Flow: When bit0 of PcdDxeNxMemoryProtectionPolicy is set to 1, the EfiReservedMemoryType

[edk2-devel] Starlingx Boot Problem

We are having a problem after installing Starlingx on PXE. It boots without problem when installed from USB drive. So we want to know the root cause of installing it on network. The error message is: Welcome to GRUB! error: no such device:

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

Sunil V L ; Yuwei Chen > ; Jeremy Linton ; Marcin > Juszkiewicz ; Graeme Gregory > > Subject: Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull > Requests > > Caution: This message originated from an External Source. Use proper caution > when opening attachme

回复: [edk2-devel] [PATCH] MdePkg/Tdx.h: Fix the order of NumVcpus and MaxVcpus

Is there Pull Request for this patch? > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Xiaoyao Li > 发送时间: 2024年6月27日 9:27 > 收件人: devel@edk2.groups.io > 抄送: xiaoyao...@intel.com > 主题: [edk2-devel] [PATCH] MdePkg/Tdx.h: Fix the order of NumVcpus and > MaxVcpus > > For TDCALL leaf TDG.VP.INFO, the

Re: [edk2-devel] How do debug tianocore.PatchCheck failed?

Hi Leif, Thanks for your response! On Tue, Jul 02, 2024 at 11:32:06AM +0100, Leif Lindholm wrote: > Hi Joey, > > On 2024-07-02 07:42, joeyli via groups.io wrote: > > Hi EDK2 experts, > > > > I was filed a submit request on github for > > "[PATCH] Embedd

[edk2-devel] How do debug tianocore.PatchCheck failed?

Hi EDK2 experts, I was filed a submit request on github for "[PATCH] EmbeddedPkg/VirtualRealTimeClockLib: Support SOURCE_DATE_EPOCH". But I got a Azure Pipelines/tianocore.PatchCheck failed: https://github.com/tianocore/edk2/pull/5550/checks?check_run_id=24185647984 Check failure on

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[AMD Official Use Only - AMD Internal Distribution Only] Yes, and AMD moved to GitHub PR already. Regards, Abner > -Original Message- > From: Grimes, Paul > Sent: Tuesday, July 2, 2024 3:20 AM > To: Rebecca Cran ; devel@edk2.groups.io > Cc: Leif Lindholm ; Michael D Kinney > ; Ard

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[AMD Official Use Only - AMD Internal Distribution Only] I support this. Thanks, Paul -Original Message- From: Rebecca Cran Sent: Monday, July 1, 2024 12:17 PM To: devel@edk2.groups.io Cc: Leif Lindholm ; Michael D Kinney ; Ard Biesheuvel ; Chang, Abner ; Attar, AbdulLateef (Abdul

[edk2-devel] Serial Debug not working in JunctionCity Whitley Platform

Hello everyone, I'm trying to get the serial debug working on my platform but I don't know why i can't see the debug logs. This is the library use3d for SerialPortLIb inside the platform's dsc: SerialPortLib|WhitleyPkg/Library/SerialPortLib/SerialPortLib.inf Also these are the values of the debug

Re: [edk2-devel] [PATCH] OvmfPkg: Set PcdCpuMaxLogicalProcessorNumber in OvmfXen

On Thu Apr 25, 2024 at 2:58 PM BST, Gerd Hoffmann wrote: > Hi, > > > It's a bit more complicated than setting it at build time, but we can > > always ask Xen how many vcpu we have and set the PCD accordingly. This > > is something that can happen in OvmfPkg/XenPlatformPei module. > > Exactly.

[edk2-devel] - BasePrintLib buffer overflow (PrintLibInternal.c#L1162)

Hello, i am unsure on how to post a bug-report, forgive me if i am not in the right place. In PrintLibInternal.c at line 1162 there is the possibility of a buffer overflow, if you specify the string precision it will anyway try to count until the null terminator, if the string is not null

Re: [edk2-devel] [PATCH 0/2] AmdSev: Harden SEV Kernel hashes verifier

15 2024-06-25 03:13:23: VerifyBlob: Found GUID 97D02DD8-BD20-4C94-AA78-E7714D36AB2A in table 2024-06-25 03:13:23: VerifyBlob: Hash comparison succeeded for "cmdline"| After this patch got merged the regression is seen. Thanks, Srikanth Aithal On 5/7/2024 1:57 AM, Tob

Re: [edk2-devel] [PATCH 0/2] AmdSev: Harden SEV Kernel hashes verifier

7D02DD8-BD20-4C94-AA78-E7714D36AB2A in table 2024-06-25 03:13:23: VerifyBlob: Hash comparison succeeded for "cmdline"| After this patch got merged the regression is seen. Thanks, Srikanth Aithal On 5/7/2024 1:57 AM, Tobin Feldman-Fitzthum via groups.io wrote: The AmdSev package

Re: [edk2-devel] Adding AArch64 support to the mu_nasm package (nasm_ext_dep.yaml)

Hi Rebecca, Switching the external dependency to the below should resolve your issue: "source": "https://pkgs.dev.azure.com/projectmu/mu/_packaging/Basetools-Binary/nuget/v3/index.json; "version": "20015.5.0" Thanks, Joey -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages

Re: [edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz

Thanks for the cleanup. For Ampere Altra, Reviewed-by: Nhi Pham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119663): https://edk2.groups.io/g/devel/message/119663 Mute This Topic: https://groups.io/mt/106780877/21656 Group Owner:

[edk2-devel] [Question] What is the propose of BME DMA mitigation

Hello everyone, I was scrolling through the UEFI HII and encountered an option which i failed to find any proper explanation about it. Could you please explain point of mitigating DMA access for PCI.Thanks --- Forwarded Message --- From: memristor2 Date: On Tuesday, June 18th, 2024 at

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table

.io> mailto:devel@edk2.groups.io>> 代表 Chang, Abner via groups.io 发送时间: 2024年6月18日 10:50 收件人: Chesley, Brit mailto:brit.ches...@amd.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> 主题: Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table Hi H

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table

? Thanks Liming 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> 代表 Chang, Abner via groups.io 发送时间: 2024年6月18日 10:50 收件人: Chesley, Brit mailto:brit.ches...@amd.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> 主题: Re: [e

回复: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table

Abner: Is PR for this change? Thanks Liming 发件人: devel@edk2.groups.io 代表 Chang, Abner via groups.io 发送时间: 2024年6月18日 10:50 收件人: Chesley, Brit ; devel@edk2.groups.io 主题: Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table Hi Hao, What is your comment

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table

Hi Hao, What is your comment on the response from Brit? Hoping that I didn't miss the latest conversation of this thread. Thanks Abner -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119598):

回复: [edk2-devel] [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install MigrateTempRamPpi

Zhihao: I have no other comment for the change in MdeModulePkg. Please create pull request for it. Thanks Liming > -邮件原件- > 发件人: Li, Zhihao > 发送时间: 2024年6月11日 15:36 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: Chiu, Chasel ; Desimone, Nathaniel L > ; Duggapu, Chinni B > ; Chen, Gang

  1   2   3   4   5   6   7   8   9   10   >