Re: [edk2] [patch 2/2] BaseTool/VfrCompile: Fix potential memory leak issue

Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Tuesday, February 27, 2018 1:54 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Gao, Liming > Subject: [patch 2/2] BaseTool/VfrCompile: Fix potential memory leak issue > > REF: https://bugzilla.tianocore.org/sho

Re: [edk2] [patch 1/2] BaseTool/VfrCompile: make delete[] match with new[]

Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Tuesday, February 27, 2018 1:54 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Gao, Liming > Subject: [patch 1/2] BaseTool/VfrCompile: make delete[] match with new[] > > REF: https://bugzilla.tianocore.org/show

[edk2] [PATCH 6/6] Platform/ARM/Sgi: add initial support for ARM SGI platform

From: Vishwanatha HG Add the initial support for ARM's System Guidance for Infrastructure (SGI) platforms which can be used on a SGI-575 platform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vishwanatha HG Signed-off-by: Thomas Abraham --- Platform/ARM/SgiPkg/SgiPl

[edk2] [PATCH 5/6] Platform/ARM/Sgi: add the initial set of acpi tables

From: Daniil Egranov Add the initial version of Acpi tables required to boot the linux kernel to a busybox prompt. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov Signed-off-by: Thomas Abraham --- .../ARM/SgiPkg/AcpiTables/Sgi575/AcpiTables.inf| 50 +

[edk2] [PATCH 4/6] Platform/ARM/Sgi: add support for virtio block device

From: Daniil Egranov Add the registration of the virtio block device. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov Signed-off-by: Thomas Abraham --- .../ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 18 - .../ARM/SgiPkg/Drivers/PlatformDxe/Platf

[edk2] [PATCH 3/6] Platform/ARM/Sgi: add initial platform dxe driver implementation

From: Daniil Egranov Add a initial platform dxe driver which starts of being almost an empty implemenation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov Signed-off-by: Thomas Abraham --- .../ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 25

[edk2] [PATCH 0/6] Platform/ARM/Sgi: Add Arm's SGI platform support

Arm CoreLink System Guidance for Infrastructure is a collection of resources to provide a representative view of typical compute subsystems that can be designed and implemented using specific generations of Arm IP. These compute subsystems address the expected requirements of a specific segment of

[edk2] [PATCH 1/6] Platform/ARM/Sgi: Add Platform library implementation

Add initial SGI platform library support. This includes the virtual memory map and helper functions for platform intialization. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Abraham --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 63 .../Sgi

[edk2] [PATCH 2/6] Platform/ARM/Sgi: add NOR flash platform library implementation

From: Vishwanatha HG Add a initial NOR flash driver platform wrapper as part of the platform library. Access to NOR fash 0 is enabled in this initial implementation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vishwanatha HG Signed-off-by: Thomas Abraham --- Platfor

[edk2] [Patch] BaseTools: Fix the bug for VOID* pcd max size from component section

When the Pcd defined in components section, its value's size is larger than the value's size in [pcd] section, it cause build error, because original code use the size get in [pcd] section as max size. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTo

[edk2] [Patch] BaseTools: Fix size override issue for Void* Patchable pcd

when multiple driver link same library, and the drivers override the pcd to different value in the DSC component section, it cause the pcd size incorrect. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/GenC.py | 20

[edk2] [Patch] BaseTools: Fix a bug for Size incorrect of Void* Fixatbuild Pcd

when driver link library and there have pcd override in DSC component section, in the library autogen file, the pcd's size is incorrect, the size value is from DSC [pcd] section, but not from the override pcd value that in the [component] section. Contributed-under: TianoCore Contribution Agreemen

[edk2] [Patch] BaseTools: Fix a bug for VOID* type Fixatbuild Pcd in Library

The case is a FixedAtBuild VOID* PCD is used from a lib, but is set to a different sized value in a module INF scope section. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/GenC.py | 22 +- 1 file chang

[edk2] [patch] OvmfPkg:Fix VS2012 build failure

Initialize local variable to suppress warning C4701/C4703: potentially uninitialized local variable/pointer variable. 1.In VirtualMemory.c: Read of "PageMapLevel4Entry" in SetMemoryEncDe() is only reached when "PageMapLevel4Entry" is got correctly. 2.In VirtioBlk.c: Reads (dereferences) of "Buffe

Re: [edk2] [PATCH] MdeModulePkg/UsbKb: fix shell edit cannot read '!@#$%^&*' characters

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Friday, March 23, 2018 12:46 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [PATCH] MdeModulePkg/UsbKb: fix shell edit cannot read '!@#$%^&*' characters Commit 5563281fa2b31093a1cbd415553b9264c5136e89

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

On 3/20/2018 8:15 PM, Guo Heyi wrote: I've no idea about how to use Driver; let me spend some time to learn first :) Heyi, you could use "load xxxDriver.efi" to load the dynamic command in shell. After that, you can run "tftp" in shell just as running an internal command. Regards, Heyi

[edk2] [PATCH] MdeModulePkg/UsbKb: fix shell edit cannot read '!@#$%^&*' characters

Commit 5563281fa2b31093a1cbd415553b9264c5136e89 * ShellPkg/[hex]edit: use SimpleTextInEx to read console changes shell edit and hexedit to read input through SimpleTextInEx. It exposes a issue in UsbKeyboard driver: Per UEFI Spec, When interpreting the data from this function (ReadKeyStrokeEx), it

Re: [edk2] [Patch] BaseTool: Fixed the issue of empty PcdDB.

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF > Sent: Friday, March 23, 2018 10:24 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] BaseTool: Fixed the issue of empty PcdDB. > > If

[edk2] [Patch] BaseTool: Fixed the issue of empty PcdDB.

If there is no dynamic pcds, there should be DB header in the Pcd DataBase. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/GenPcdDb.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a

Re: [edk2] [PATCH v2] MdePkg/IndustryStandard: Add header file for SPMI ACPI table

Got it. A new version will be sent out to address this. Best Regards, Hao Wu > -Original Message- > From: Yao, Jiewen > Sent: Friday, March 23, 2018 9:34 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Younas Khan; Kinney, Michael D; Gao, Liming > Subject: RE: [PATCH v2] MdePkg/Indust

[edk2] [PATCH v3] MdePkg/IndustryStandard: Add header file for SPMI ACPI table

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=840 Add the header file for Service Processor Management Interface ACPI table definition. Cc: Younas Khan Cc: Michael Kinney Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- ...

Re: [edk2] [PATCH v2] MdePkg/IndustryStandard: Add header file for SPMI ACPI table

Sorry, I did not express my thought clearly. I mean union like below: union { struct { UINT8 SegmentGroup; UINT8 Bus; UINT8 Device; UINT8

Re: [edk2] [PATCH] MdePkg/IndustryStandard: Add header file for SPMI ACPI table

Yes, V2 patch has been sent out according to the feedback. Best Regards, Hao Wu > -Original Message- > From: Yao, Jiewen > Sent: Thursday, March 22, 2018 5:09 PM > To: Wu, Hao A > Cc: edk2-devel@lists.01.org; Kinney, Michael D; Younas Khan; Gao, Liming > Subject: Re: [edk2] [PATCH] MdeP

[edk2] [PATCH v2] MdePkg/IndustryStandard: Add header file for SPMI ACPI table

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=840 Add the header file for Service Processor Management Interface ACPI table definition. Cc: Younas Khan Cc: Michael Kinney Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- ...

Re: [edk2] MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec

I agree. Thanks, Star -Original Message- From: Guo Heyi [mailto:heyi@linaro.org] Sent: Thursday, March 22, 2018 7:43 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Ni, Ruiyu Subject: Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec +cc Maintainers of

Re: [edk2] [PATCH 00/14] rid PiSmmCpuDxeSmm of DB-encoded instructions

Laszlo, I do like this typedef idea. typedef VOID (X86_ASSEMBLY_LABEL) (VOID); Maybe change the name so it is clearer that this should never be used in a call. A comment block about the typedef can also clarify the expected usage. typedef VOID (X86_ASSEMBLY_PATCH_LABEL) (VOID); Thanks,

Re: [edk2] [Patch] BaseTools: Add the missing package include directory in PcdValueInit Makefile

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Thursday, March 22, 2018 11:22 PM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Zhu, Yonghong Subject: [Patch] BaseTools: Add the missing package include directory in PcdValueInit Makefile

Re: [edk2] [PATCH 03/14] UefiCpuPkg/PiSmmCpuDxeSmm: remove *.S and *.asm assembly files

On 02/02/18 15:39, Laszlo Ersek wrote: > All edk2 toolchains use NASM for compiling X86 assembly source code. We > plan to remove X86 *.S and *.asm files globally, in order to reduce > maintenance and confusion: > > 4A89E2EF3DFEDB4C8BFDE51014F606A14E1B9F76@SHSMSX104.ccr.corp.intel.com">http://mid.

Re: [edk2] [PATCH edk2-platforms v3 12/17] ARM/VExpressPkg: Allocate framebuffer using EfiRuntimeServicesData

On 22 March 2018 at 15:20, Evan Lloyd wrote: > Hi Ard. > >> -Original Message- >> From: edk2-devel On Behalf Of Ard >> Biesheuvel >> Sent: 21 March 2018 18:27 >> To: Girish Pathak >> Cc: nd ; edk2-devel@lists.01.org; Leif Lindholm >> ; Stephanie Hughes-Fitt > f...@arm.com>; Arvind Chauha

[edk2] [PATCH 2/5] NetworkPkg/HttpDxe: use error handler epilogue in TlsConfigCertificate()

Introduce a FreeCACert label near the end of the function, so that we can keep the FreePool(CACert) statement centralized for error and success exits. Cc: Jiaxin Wu Cc: Siyuan Fu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- NetworkPkg/HttpDxe/HttpsSup

[edk2] [PATCH 0/5] NetworkPkg: HTTP and TLS updates

Repo: https://github.com/lersek/edk2.git Branch: http_and_tls_updates Patch #4 fixes TianoCore BZ#909 . Patches #2 and #3 are cleanups / preparation for patch #4. Patch #1 fixes an independent typo that I noticed in the code while configuring

[edk2] [PATCH 5/5] NetworkPkg/TlsAuthConfigDxe: preserve TlsCaCertificate variable attributes

If the platform creates the "TlsCaCertificate" variable as volatile, then EnrollX509toVariable() shouldn't fail to extend it just because TLS_AUTH_CONFIG_VAR_BASE_ATTR contains the EFI_VARIABLE_NON_VOLATILE attribute. Thus, if the variable exists, add the EFI_VARIABLE_APPEND_WRITE attribute to the

[edk2] [PATCH 4/5] NetworkPkg/HttpDxe: sanity-check the TlsCaCertificate variable before use

In TlsConfigCertificate(), make sure that the set of EFI_SIGNATURE_LIST objects that the platform stored to "TlsCaCertificate" is well-formed. In addition, because HttpInstance->TlsConfiguration->SetData() expects X509 certificates only, ensure that the EFI_SIGNATURE_LIST objects only report X509

[edk2] [PATCH 1/5] NetworkPkg/HttpBootDxe: fix typo in DHCPv4 packet parsing

The string "HTTPClient" has 10 non-NUL characters; the value 9 is a copy-paste leftover from "PXEClient". Check for all 10 characters in the vendor-class-identifier option when determining whether the DHCP offer is an HTTP offer. Cc: Jiaxin Wu Cc: Siyuan Fu Contributed-under: TianoCore Contribut

[edk2] [PATCH 3/5] NetworkPkg/HttpDxe: drop misleading comment / status code in cert config

For TlsConfigureSession(), it makes sense to exempt EFI_NOT_FOUND from TlsConfigCipherList() / gRT->GetVariable(), because there is a default cipher list (SSL_DEFAULT_CIPHER_LIST) we can fall back to. The same is not true of TlsConfigCertificate(), because there is no default CA cert list. The pla

[edk2] [Patch] BaseTools: Add the missing package include directory in PcdValueInit Makefile

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Feng Bob C Cc: Yonghong Zhu --- BaseTools/Source/Python/Workspace/DscBuildData.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/Bas

Re: [edk2] [PATCH edk2-platforms v3 12/17] ARM/VExpressPkg: Allocate framebuffer using EfiRuntimeServicesData

Hi Ard. > -Original Message- > From: edk2-devel On Behalf Of Ard > Biesheuvel > Sent: 21 March 2018 18:27 > To: Girish Pathak > Cc: nd ; edk2-devel@lists.01.org; Leif Lindholm > ; Stephanie Hughes-Fitt f...@arm.com>; Arvind Chauhan > Subject: Re: [edk2] [PATCH edk2-platforms v3 12/17]

Re: [edk2] MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec

+cc Maintainers of MdeModulePkg. On Thu, Mar 22, 2018 at 07:39:42PM +0800, Guo Heyi wrote: > Hi folks, > > The SetAttributes() interface of generic SerialDxe driver in > MdeModulePkg/Universal does not fully follow UEFI spec. The spec requires to > use > default time out value when the input "Ti

[edk2] MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec

Hi folks, The SetAttributes() interface of generic SerialDxe driver in MdeModulePkg/Universal does not fully follow UEFI spec. The spec requires to use default time out value when the input "Timeout" is 0, but the current implementation will set timeout to 0 directly. It tries to pass "Timeout" t

[edk2] [PATCH edk2-non-osi 1/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer base

The code in SM750 driver treated the address returned from PciIo->GetBarAttributes() as device address; this should be fixed after edk2 commit dc080d3 since GetBarAttributes() returns host address from then on. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Signed

[edk2] [PATCH edk2-non-osi 0/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer

The code in SM750 driver treated the address returned from PciIo->GetBarAttributes() as device address; this should be fixed after edk2 commit dc080d3 since GetBarAttributes() returns host address from then on. Binary files can be fetched from: https://github.com/iwishguo/edk2-non-osi/tree/patch-s

Re: [edk2] internal structure of EFI_TLS_CA_CERTIFICATE_VARIABLE

On 03/22/18 03:02, Wu, Jiaxin wrote: > On 03/21/18 14:39, Laszlo Ersek wrote: >> (1) Do you agree EFI_CERT_X509_GUID is the right setting for >> "EFI_SIGNATURE_LIST.SignatureType" (even though the edk2 code >> currently ignores it)? >> >> This would also imply that we set >> "EFI_SIGNATURE_LIST.Sig

Re: [edk2] [Patch] Vlv2TbltDevicePkg: Remove DxeTcg2PhysicalPresenceLibNull

Reviewed-by: zwei4 Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael D Kinney Sent: Thursday, March 22, 2018 6:48 AM To: edk2-devel@lists.01.org Cc: Kinney, Mich

Re: [edk2] [PATCH] MdePkg/IndustryStandard: Add header file for SPMI ACPI table

Can we use union for pci or uid? thank you! Yao, Jiewen > 在 2018年3月22日，下午4:38，Hao Wu 写道： > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=840 > > Add the header file for Service Processor Management Interface ACPI table > definition. > > Cc: Younas Khan > Cc: Michael Kinney > Cc: Lim

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Change BDS module.

Change from BDS of IntelFrameworkModulePkg to BDS of MdeModulePkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../Common/Library/PlatformBootManagerLib/PlatformBootManager.c | 5 + Platform/BroxtonPlatformPkg/PlatformDsc/Components.dsc | 9 +++

Re: [edk2] [MdeModulePkg/Usb v2 1/1] MdeModulePkg/Usb: Replace macro USB_BOOT_IO_BLOCKS

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Ming Huang [mailto:ming.hu...@linaro.org] Sent: Thursday, March 22, 2018 3:44 PM To: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Kinney, Michael D ; Gao, Liming ; leif.lindh...@linaro.o

[edk2] [PATCH] MdePkg/IndustryStandard: Add header file for SPMI ACPI table

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=840 Add the header file for Service Processor Management Interface ACPI table definition. Cc: Younas Khan Cc: Michael Kinney Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- ...

[edk2] [MdeModulePkg/Usb v2 0/1] Calculating the count of blocks to transfer

Calculating the count of blocks to transfer by Evaluating block size to fix booting failed from USB issue in some platforms. Ming Huang (1): MdeModulePkg/Usb: Replace macro USB_BOOT_IO_BLOCKS MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 16 MdeModulePkg/Bus/Usb/UsbM

[edk2] [MdeModulePkg/Usb v2 1/1] MdeModulePkg/Usb: Replace macro USB_BOOT_IO_BLOCKS

Booting from USB may fail while the macro USB_BOOT_IO_BLOCKS set to 128 because the block size of some USB devices are exceeded 512, like some virtual CD-ROM from BMC, the block size is 2048. So,the count blocks to transfer should be calculated by block size of the USB devices. Contributed-under: