[gem5-dev] Review Request 3745: scons: fix how flags are passed to the compiler when more than one sanitizer at a time is enabled

2016-11-23 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3745/ --- Review request for Default and Tony Gutierrez. Repository: gem5 Description

Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

2016-11-23 Thread Brandon Potter
> On Nov. 15, 2016, 2:03 a.m., Alexandru Dutu wrote: > > src/sim/process.cc, line 148 > > > > > > Does memState need to be dynamically allocated? Yes, the memState need to be able to be dynamically created and shared

Re: [gem5-dev] Review Request 3705: dev: Fix buffer length when unserializing an eth pkt

2016-11-23 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3705/ --- (Updated Nov. 23, 2016, 5:36 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3744: cpu: Remove branch predictor function predictInOrder

2016-11-23 Thread Arthur Perais
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3744/#review9165 --- Ship it! Ship It! - Arthur Perais On nov. 23, 2016, 4:10 après-midi,

Re: [gem5-dev] Review Request 3744: cpu: Remove branch predictor function predictInOrder

2016-11-23 Thread Nathanael Premillieu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3744/#review9164 --- Ship it! Ship It! - Nathanael Premillieu On Nov. 23, 2016, 4:10

[gem5-dev] Review Request 3744: cpu: Remove branch predictor function predictInOrder

2016-11-23 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3744/ --- Review request for Default. Repository: gem5 Description --- cpu: Remove

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-23 Thread Arthur Perais
> On nov. 23, 2016, 3:17 après-midi, Jason Lowe-Power wrote: > > src/cpu/pred/BranchPredictor.py, line 100 > > > > > > Comment is now wrong. > > > > Also, does it make more sense to call this histBufferEntries (or

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-23 Thread Nathanael Premillieu
> On Nov. 23, 2016, 3:17 p.m., Jason Lowe-Power wrote: > > src/cpu/pred/BranchPredictor.py, line 100 > > > > > > Comment is now wrong. > > > > Also, does it make more sense to call this histBufferEntries (or > >

Re: [gem5-dev] Review Request 3705: dev: Fix buffer length when unserializing an eth pkt

2016-11-23 Thread Gabor Dozsa
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3705/#review9157 --- src/dev/net/dist_etherlink.cc (line 237)

Re: [gem5-dev] Review Request 3710: cpu: Resolve targets of predicted 'taken' conditional direct branches at decode (o3)

2016-11-23 Thread Jason Lowe-Power
> On Nov. 22, 2016, 5:51 p.m., Jason Lowe-Power wrote: > > The error you're seeing is because you don't have Google's protobuf library > > installed. Though it has no affect on what you're seeing. > > > > Can you run the full system linux boot regression with O3 to be sure that > > it still

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-23 Thread Nathanael Premillieu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/#review9159 --- Ship it! Ship It! - Nathanael Premillieu On Nov. 23, 2016, 2:52

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-23 Thread Arthur Perais
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/ --- (Updated nov. 23, 2016, 2:52 après-midi) Review request for Default. Changes

Re: [gem5-dev] Review Request 3710: cpu: Resolve targets of predicted 'taken' conditional direct branches at decode (o3)

2016-11-23 Thread Arthur Perais
> On nov. 22, 2016, 5:51 après-midi, Jason Lowe-Power wrote: > > The error you're seeing is because you don't have Google's protobuf library > > installed. Though it has no affect on what you're seeing. > > > > Can you run the full system linux boot regression with O3 to be sure that > > it

Re: [gem5-dev] ReviewBoard full text search

2016-11-23 Thread Fernando Endo
Hi, Without the text search it is not easy to know if someone already posted the same or similar patch. So, I'm for it, but not sure if it can be that useful. Regards, -- Fernando A. Endo, Post-doc INRIA Rennes-Bretagne Atlantique France 2016-11-21 17:34 GMT+01:00 Jason Lowe-Power

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-23 Thread Fernando Endo
Hi all, Then, considering Arthur's answer, I suppose that we can remove BPredUnit::predictInOrder() rather than updating and not testing it. Regards, -- Fernando A. Endo, Post-doc INRIA Rennes-Bretagne Atlantique France 2016-11-21 19:19 GMT+01:00 Arthur Perais : > I

Re: [gem5-dev] Review Request 3710: cpu: Resolve targets of predicted 'taken' conditional direct branches at decode (o3)

2016-11-23 Thread Fernando Endo
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3710/#review9156 --- Ship it! Ship It! - Fernando Endo On Nov. 18, 2016, 3:21 p.m.,

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2016-11-23 Thread Cron Daemon
* build/HSAIL_X86/tests/opt/quick/se/04.gpu/x86/linux/gpu-ruby-GPU_RfO: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: passed. *