Re: [gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3793/#review9345 --- Ship it! Ship It! - Sanchayan Maity On Jan. 28, 2017, 4:29 a.m., Jaso

Re: [gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3793/ --- (Updated Jan. 27, 2017, 10:59 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

> On Jan. 27, 2017, 10:37 p.m., Steve Reinhardt wrote: > > Nice! I suggest somewhat more obvious mnemonics (e.g., ld_stack/st_stack, > > if '_' is allowed), and just a couple more comments, but that's all > > optional. Feel free to submit w/o reposting on my account. Might as well do it right

Re: [gem5-dev] Ideas for sprint projects

I honestly don't know much about bazel. I heard that it has or is going to have tightly integrated support for testing and continuous integration. I only brought it up to start a conversation :). Given that bazel isn't going to be out of beta until at least Q4 2017, it's likely that we should stick

Re: [gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3793/#review9342 --- Ship it! Nice! I suggest somewhat more obvious mnemonics (e.g., ld_stack

Re: [gem5-dev] Ideas for sprint projects

Thank you for putting them together Jason! One quick question - regarding "replacing scons...". Is there a specific reason for stepping over cmake and jumping to bazel? It feels to me "replacing scons with cmake" will be more beneficial (assuming cmake is more common for gem5 developers than ba

[gem5-dev] changeset in gem5: proto: Fix warnings for protoc v3

changeset 63325e5b0a9d in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=63325e5b0a9d description: proto: Fix warnings for protoc v3 protoc v3 introduces a new syntax for proto files and warns when the syntax is not explicitly stated. protoc rel

[gem5-dev] changeset in gem5: riscv: Fix crash when syscall argument reg in...

changeset ada5603bdb1c in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=ada5603bdb1c description: riscv: Fix crash when syscall argument reg index is too high By default, doSyscall gets the values of six registers to be used for system call arguments.

[gem5-dev] changeset in gem5: mem: Refactor CommMonitor stats, add basic at...

changeset 220375a47eeb in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=220375a47eeb description: mem: Refactor CommMonitor stats, add basic atomic mode stats Signed-off-by: Jason Lowe-Power diffstat: src/mem/comm_monitor.cc | 236 -

[gem5-dev] changeset in gem5: mem: Add memory footprint probe

changeset 4f04a6593119 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=4f04a6593119 description: mem: Add memory footprint probe Signed-off-by: Jason Lowe-Power diffstat: COPYING |1 + configs/dram/lat_mem_rd.py |

Re: [gem5-dev] changeset in gem5: syscall_emul: [patch 4/22] remove redundant M...

Yes, I'm looking into this; this is priority #1 for me right now. -Brandon -Original Message- From: Andreas Sandberg [mailto:andreas.sandb...@arm.com] Sent: Friday, January 27, 2017 6:40 AM To: gem5 Developer List ; gem5-...@m5sim.org; Potter, Brandon Subject: Re: [gem5-dev] changeset

Re: [gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3793/ --- (Updated Jan. 27, 2017, 5:40 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

> On Jan. 26, 2017, 6:47 p.m., Steve Reinhardt wrote: > > src/arch/x86/isa/microops/ldstop.isa, line 382 > > > > > > why not just put 'if not implicitStack:' in front of the previous line > > (that adds the legacy.addr chec

[gem5-dev] Review Request 3795: misc: Add Python.h header to pyevents.hh

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3795/ --- Review request for Default. Repository: gem5 Description --- misc: Add Pytho

Re: [gem5-dev] Review Request 3792: misc: Update #!env calls for python to explicit version

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3792/#review9339 --- Ship it! Ship It! - Andreas Sandberg On Jan. 27, 2017, 5:32 p.m., Jas

Re: [gem5-dev] Review Request 3792: misc: Update #!env calls for python to explicit version

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3792/#review9337 --- Seems reasonable to me. Could you factor out the header change and put it

Re: [gem5-dev] Review Request 3795: misc: Add Python.h header to pyevents.hh

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3795/#review9340 --- Ship it! Ship It! - Andreas Sandberg On Jan. 27, 2017, 5:32 p.m., Jas

Re: [gem5-dev] Review Request 3792: misc: Update #!env calls for python to explicit version

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3792/ --- (Updated Jan. 27, 2017, 5:32 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3792: misc: Update #!env calls for python to explicit version

> On Jan. 27, 2017, 5:21 p.m., Andreas Sandberg wrote: > > Seems reasonable to me. Could you factor out the header change and put it > > in a separate commit? Absolutely. - Jason --- This is an automatically generated e-mail. To reply,

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

> On Jan. 27, 2017, 3 p.m., Jason Lowe-Power wrote: > > Oops. I should have included this in my description of > > http://reviews.gem5.org/r/3792/. I think another solution is to include > > Python.h in src/python/swig/pyevent.hh. See my change in > > http://reviews.gem5.org/r/3792/diff/1/#33.

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

> On Jan. 27, 2017, 3 p.m., Jason Lowe-Power wrote: > > Oops. I should have included this in my description of > > http://reviews.gem5.org/r/3792/. I think another solution is to include > > Python.h in src/python/swig/pyevent.hh. See my change in > > http://reviews.gem5.org/r/3792/diff/1/#33.

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

> On Jan. 27, 2017, 3 p.m., Jason Lowe-Power wrote: > > Oops. I should have included this in my description of > > http://reviews.gem5.org/r/3792/. I think another solution is to include > > Python.h in src/python/swig/pyevent.hh. See my change in > > http://reviews.gem5.org/r/3792/diff/1/#33.

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

> On Jan. 27, 2017, 3 p.m., Jason Lowe-Power wrote: > > Oops. I should have included this in my description of > > http://reviews.gem5.org/r/3792/. I think another solution is to include > > Python.h in src/python/swig/pyevent.hh. See my change in > > http://reviews.gem5.org/r/3792/diff/1/#33.

Re: [gem5-dev] [gem5-users] gem5 build failure

On 01/27/2017 02:42 PM, Andreas Sandberg wrote: > On 27/01/17 12:32, Pierre-Yves Péneau wrote: >> On 01/27/2017 01:20 PM, Andreas Sandberg wrote: >>> Hi Pierre, >>> >>> I send out an email to the dev list on the 12th of January (Header order >>> issues) describing a similar issue we have in our CI

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3794/#review9332 --- Ship it! Ship It! - Pierre-Yves Péneau On Jan. 27, 2017, 2:39 p.m., A

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3794/#review9331 --- Oops. I should have included this in my description of http://reviews.ge

Re: [gem5-dev] [gem5-users] gem5 build failure

On 27/01/17 12:32, Pierre-Yves Péneau wrote: On 01/27/2017 01:20 PM, Andreas Sandberg wrote: Hi Pierre, I send out an email to the dev list on the 12th of January (Header order issues) describing a similar issue we have in our CI system. I have an updated version of the style checker that enfor

[gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3794/ --- Review request for Default. Repository: gem5 Description --- Changeset 11803

[gem5-dev] changeset in gem5: python: Move native wrappers to the _m5 names...

changeset be62996c95d1 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=be62996c95d1 description: python: Move native wrappers to the _m5 namespace Swig wrappers for native objects currently share the _m5.internal name space with Python code. This is un

Re: [gem5-dev] changeset in gem5: syscall_emul: [patch 4/22] remove redundant M...

Hi Brandon, Something bad (they hang) happened with the SE-mode ALPHA and SPARC regressions the other day. A quick bisection suggest that this commit was the first bad one. Could you have a look? //Andreas On 23/01/17 21:22, Brandon Potter wrote: changeset cd7f3a1dbf55 in /z/repo/gem5 details:

Re: [gem5-dev] [gem5-users] gem5 build failure

On 01/27/2017 01:20 PM, Andreas Sandberg wrote: > Hi Pierre, > > I send out an email to the dev list on the 12th of January (Header order > issues) describing a similar issue we have in our CI system. I have an > updated version of the style checker that enforces that Python.h is > included first

Re: [gem5-dev] [gem5-users] gem5 build failure

Hi Pierre, I send out an email to the dev list on the 12th of January (Header order issues) describing a similar issue we have in our CI system. I have an updated version of the style checker that enforces that Python.h is included first and plan to post it after lunch. I would like to avoid inc

Re: [gem5-dev] [gem5-users] gem5 build failure

I think I have found why this is not working. With the new refactoring script, the header corresponding to the source file must be included first. But, when Python.h is needed, it also must be included first to avoid this error. So, I think there is two workaround: i) the refactoring script should