http://gwt-code-reviews.appspot.com/103812/diff/5/1003
File dev/core/src/com/google/gwt/dev/DevMode.java (right):
http://gwt-code-reviews.appspot.com/103812/diff/5/1003#newcode234
Line 234: public static boolean isUsingRemoteUI() {
I agree that the code should be in DevModeBase and that we
Thanks for the reviews guys! Updated patch based on both of your
comments. I've ditched the system property in favor of exposing a setter
on JettyLauncher for the base log level. While this is still not ideal,
it's less hacky than the previous solution.
http://gwt-code-reviews.appspot.com/103812
Mostly LGTM
http://gwt-code-reviews.appspot.com/103812/diff/2002/2003
File dev/core/src/com/google/gwt/dev/DevMode.java (right):
http://gwt-code-reviews.appspot.com/103812/diff/2002/2003#newcode359
Line 359: ((JettyLauncher) scl).setBaseLogLevel(getBaseLogLevelForUI());
What about GAE or other
Thanks for the review.
http://gwt-code-reviews.appspot.com/103812/diff/2002/2003
File dev/core/src/com/google/gwt/dev/DevMode.java (right):
http://gwt-code-reviews.appspot.com/103812/diff/2002/2003#newcode359
Line 359: ((JettyLauncher) scl).setBaseLogLevel(getBaseLogLevelForUI());
On 2009/11/19
Committed as tr...@r7406 and cherry-picked into releases/2.0 at r7407.
http://gwt-code-reviews.appspot.com/103812
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Updated this issue based on our face-to-face descriptions. Please
re-read the description and check out patch set #2.
http://gwt-code-reviews.appspot.com/103812
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Mostly LGTM
http://gwt-code-reviews.appspot.com/103812/diff/5/1003
File dev/core/src/com/google/gwt/dev/DevMode.java (right):
http://gwt-code-reviews.appspot.com/103812/diff/5/1003#newcode234
Line 234: public static boolean isUsingRemoteUI() {
Why isn't this in DevModeBase, since that is where
