On Wed, Jul 25, 2018 at 11:01 AM, Dmitry Stogov wrote:
>
> I tried to fix ZEND_ACC_* flags mess.
>
> https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1
>
>
> The patch specifies flags meaning, and reorder them according to meaning and
> frequency of usage (this allows generation
OK. I'll keep this for next PHP version.
There is no any performance improvement (just a bit smaller code).
The patch clarifies the meaning of all the flags, what entities use them, and
points what some of them may be eliminated completely.
Thanks. Dmitry.
Hi!
> I tried to fix ZEND_ACC_* flags mess.
>
>
> https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1
>
>
> The patch specifies flags meaning, and reorder them according to meaning
> and frequency of usage (this allows generation of shorter instructions
> on x86).
>
>
This can potentially break some cached flags somewhere, and is a BC break:
any rationale behind the change?
On Wed, 25 Jul 2018, 17:01 Dmitry Stogov, wrote:
> Hi,
>
>
> I tried to fix ZEND_ACC_* flags mess.
>
>
> https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1
>
>
> The patch
Hi,
I tried to fix ZEND_ACC_* flags mess.
https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1
The patch specifies flags meaning, and reorder them according to meaning and
frequency of usage (this allows generation of shorter instructions on x86).
Unfortunately, the patch
Hi!
On 25.07.2018 at 09:17, Jakub Zelenka wrote:
> On Wed, 25 Jul 2018, 00:15 Christoph M. Becker, wrote:
>
>> I've just stumbled upon sapi/fpm/fpm/fpm_status.c[1], which claims
>> copyright by Jerome Loyet and doesn't state any license. It seems to me
>> that we must not ship/modify this
Hi
On Wed, 25 Jul 2018, 00:15 Christoph M. Becker, wrote:
> Hi!
>
> I've just stumbled upon sapi/fpm/fpm/fpm_status.c[1], which claims
> copyright by Jerome Loyet and doesn't state any license. It seems to me
> that we must not ship/modify this file
>
Why do you think that and how is it
