[PHP-DEV] [patch] mysql_warning_count() for ext/mysql

2009-10-12 Thread Jille Timmermans
Hello all, Not sure whether this is the right place to post; but it seemed a little bit better than php...@. I have 'implemented' MySQL's mysql_warning_count() function. ( http://dev.mysql.com/doc/refman/5.1/en/mysql-warning-count.html ) mysql_warning_count() is available in MySQL's C-api in >3.

Re: [PHP-DEV] [patch] mysql_warning_count() for ext/mysql

2009-10-12 Thread Ulf Wendel
Jille Timmermans schrieb: I have 'implemented' MySQL's mysql_warning_count() function. ( http://dev.mysql.com/doc/refman/5.1/en/mysql-warning-count.html ) mysql_warning_count() is available in MySQL's C-api in >3.23, >4.1 and >5 I am not a big fan of adding anything to ext/mysql that is not sec

Re: [PHP-DEV] [patch] mysql_warning_count() for ext/mysql

2009-10-13 Thread Jille Timmermans
Ulf Wendel schreef: Jille Timmermans schrieb: I have 'implemented' MySQL's mysql_warning_count() function. ( http://dev.mysql.com/doc/refman/5.1/en/mysql-warning-count.html ) mysql_warning_count() is available in MySQL's C-api in >3.23, >4.1 and >5 I am not a big fan of adding anything to ext/

Re: [PHP-DEV] [patch] mysql_warning_count() for ext/mysql

2009-10-13 Thread Ulf Wendel
Jille Timmermans schrieb: Only ext/mysqli gives you access to all functionality of MySQL 4.1 and above, e.g. charset and prepared statements. Why would you hide functionality from people when you get a patch, and all that has to be done is commit it? I'm pretty sure it won't break anything. e

Re: [PHP-DEV] [patch] mysql_warning_count() for ext/mysql

2009-10-13 Thread Alexey Zakhlestin
On 13.10.2009, at 16:10, Jille Timmermans wrote: Why would you hide functionality from people when you get a patch, and all that has to be done is commit it? I'm pretty sure it won't break anything. Definitely +1 from me. As long as ext/mysql is bundled with php (which means "officially

Re: [PHP-DEV] [patch] mysql_warning_count() for ext/mysql

2009-10-13 Thread Ulf Wendel
Alexey Zakhlestin schrieb: On 13.10.2009, at 16:10, Jille Timmermans wrote: Why would you hide functionality from people when you get a patch, and all that has to be done is commit it? I'm pretty sure it won't break anything. Definitely +1 from me. As long as ext/mysql is bundled with php (

Re: [PHP-DEV] [patch] mysql_warning_count() for ext/mysql

2009-10-13 Thread Alexey Zakhlestin
On 13.10.2009, at 17:26, Ulf Wendel wrote: Alexey Zakhlestin schrieb: On 13.10.2009, at 16:10, Jille Timmermans wrote: Why would you hide functionality from people when you get a patch, and all that has to be done is commit it? I'm pretty sure it won't break anything. Definitely +1 from m