buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for
optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-541395902
@wucho @danny0 Thanks for your review and I've improve the code according
to most of your comments.
buptljy edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional
for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-541395902
@wuchong @danny0405 Thanks for your review and I've improve the code
according to most of your
buptljy edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional
for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-541395902
@wucho @danny0405 Thanks for your review and I've improve the code
according to most of your
[
https://issues.apache.org/jira/browse/FLINK-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiayi Liao updated FLINK-14384:
---
Description:
In ValidationMatcher we use failMsg to test exception. However the sql can be
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL]
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334266966
##
File path:
Jiayi Liao created FLINK-14384:
--
Summary: ValidationMatcher in FlinkSqlParserImplTest fails to test
negative tests
Key: FLINK-14384
URL: https://issues.apache.org/jira/browse/FLINK-14384
Project: Flink
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL]
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334265001
##
File path:
buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for
optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-541394973
@flinkbot run travis
This is an
flinkbot edited a comment on issue #9888: [hotfix][doc]fix typos in richfunction
URL: https://github.com/apache/flink/pull/9888#issuecomment-541391905
## CI report:
* b37d86b0fbc58892a68e821239b7083dffc46d75 : FAILURE
[
https://issues.apache.org/jira/browse/FLINK-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950234#comment-16950234
]
Hwanju Kim commented on FLINK-11127:
[~vicTTim], although I have not retested with 1.8 (we would
flinkbot edited a comment on issue #9888: [hotfix][doc]fix typos in richfunction
URL: https://github.com/apache/flink/pull/9888#issuecomment-541391905
## CI report:
* b37d86b0fbc58892a68e821239b7083dffc46d75 : PENDING
[
https://issues.apache.org/jira/browse/FLINK-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-14227:
---
Labels: pull-request-available (was: )
> Add Razorpay to Chinese Powered By page
>
flinkbot commented on issue #9888: [hotfix][doc]fix typos in richfunction
URL: https://github.com/apache/flink/pull/9888#issuecomment-541391905
## CI report:
* b37d86b0fbc58892a68e821239b7083dffc46d75 : UNKNOWN
Bot commands
The @flinkbot bot supports the following
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL]
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334265001
##
File path:
flinkbot commented on issue #9888: [hotfix][doc]fix typos in richfunction
URL: https://github.com/apache/flink/pull/9888#issuecomment-541391094
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will
wangxlong opened a new pull request #9888: [hotfix][doc]fix typos in
richfunction
URL: https://github.com/apache/flink/pull/9888
## What is the purpose of the change
Fix typos in RichFunction annotation. For only RichFilterFunction has open
method to extend, so we should change
101 - 116 of 116 matches
Mail list logo
