Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159227619
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -717,7 +645,26 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159226314
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -660,7 +570,25 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159224695
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -743,6 +690,142 @@ private void logAndSysout(String message
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159228367
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -717,7 +645,26 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159230885
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -743,6 +690,142 @@ private void logAndSysout(String message
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159225871
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/YarnApplicationStatusMonitor.java
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159227955
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -660,7 +570,25 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159227421
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -660,7 +570,25 @@ public int run
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5223
[FLINK-8317][flip6] Implement Triggering of Savepoints
## What is the purpose of the change
*Implement triggering of savepoints through HTTP and through command line
in FLIP-6 mode. This PR is
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5193#discussion_r159153854
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/ContentDump.java
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5193#discussion_r159154132
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/AbstractStreamOperatorTestHarness.java
---
@@ -492,6 +503,10 @@ public void close
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5216
There are some checkstyle violations:
```
[ERROR]
src/main/java/org/apache/flink/yarn/cli/YarnApplicationStatusMonitor.java:[33,8]
(imports) UnusedImports: Unused import
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5207
[FLINK-8299][flip6] Poll JobExecutionResult after job submission
## What is the purpose of the change
*Poll JobExecutionResult after job submission. This is needed, for example,
to enable
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158265225
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158264752
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/StreamingProgramTestBase.java
---
@@ -66,47 +47,34
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158261437
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/TimeAttributesITCase.scala
---
@@ -18,8 +18,8 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158260663
--- Diff:
flink-examples/flink-examples-streaming/src/test/scala/org/apache/flink/streaming/scala/examples/StreamingExamplesITCase.scala
---
@@ -23,8 +23,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158259995
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/TopSpeedWindowing.java
---
@@ -55,6 +55,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158259149
--- Diff:
flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkSecuredITCase.java
---
@@ -215,23
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158257284
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158254745
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5194#discussion_r158081176
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/JobExecutionResultDeserializer.java
---
@@ -0,0 +1,153
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5194#discussion_r158078273
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/JobExecutionResultDeserializer.java
---
@@ -0,0 +1,153
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5194
[FLINK-8233][flip6] Add JobExecutionResultHandler
## What is the purpose of the change
*Allow retrieval of the JobExecutionResult cached in Dispatcher via HTTP.
This will be needed so that
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r157963387
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java
---
@@ -405,22 +407,27 @@ private void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r157962431
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java
---
@@ -458,7 +465,14 @@ public JobExecutionResult
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157961376
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/messages/JobExecutionResultNotFoundException.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5168
New PR #5184
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157961174
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/messages/JobExecutionResultNotFoundException.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157960760
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/SerializedJobExecutionResult.java
---
@@ -55,6 +56,26 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157960722
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -357,6 +362,28 @@ public void start() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157960666
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/JobExecutionResultCache.java
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r157878862
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java
---
@@ -358,12 +360,12 @@ private DetachedFinalizer
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r157877969
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobExecutionResult.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r157877406
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java
---
@@ -458,7 +465,14 @@ public JobExecutionResult
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r157876761
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java
---
@@ -92,4 +94,42 @@
* @return Future containing the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r157876793
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java
---
@@ -92,4 +94,42 @@
* @return Future containing the
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5184
[FLINK-8234][flip6] Cache JobExecutionResult in Dispatcher
## What is the purpose of the change
Cache `JobExecutionResult` in `Dispatcher`, and add methods to
`RestfulGateway` to enable
Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/5168
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157489280
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -357,6 +362,28 @@ public void start() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4889#discussion_r157481924
--- Diff: pom.xml ---
@@ -125,6 +125,9 @@ under the License.
1.6.5
1.3
false
+
--- End diff
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4889#discussion_r157468208
--- Diff:
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/category/Flip6.java
---
@@ -0,0 +1,25
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157462859
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobExecutionResult.java
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157027881
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/JobExecutionResultCache.java
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157027633
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/messages/JobExecutionResultNotFoundException.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157027510
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/JobExecutionResultCache.java
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157027178
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/util/RestMapperUtils.java
---
@@ -33,10 +40,23 @@
objectMapper.enable
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157026590
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobExecutionResultHandler.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157026313
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/util/RestMapperUtils.java
---
@@ -33,10 +40,23 @@
objectMapper.enable
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157025791
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/JobExecutionResultCache.java
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5168
[FLINK-8234][flip6] WIP
WIP
@tillrohrmann
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink FLINK-8234
Alternatively you can
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4987#discussion_r155804733
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -757,6 +775,64 @@ public void heartbeatFromResourceManager(final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4987#discussion_r155802027
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -27,8 +27,6 @@
/**
* Interface for a metric
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4988#discussion_r155797999
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
---
@@ -0,0 +1,402 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155770364
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManagerTest.java
---
@@ -0,0 +1,502 @@
+/*
+ * Licensed to
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155770104
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManagerTest.java
---
@@ -0,0 +1,502 @@
+/*
+ * Licensed to
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155768880
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155758219
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155754738
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -266,104 +279,367 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155751694
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -266,104 +279,367 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155604499
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -266,104 +279,367 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155605251
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/LogicalSlot.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155590317
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -266,104 +279,367 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155549755
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/LogicalSlot.java
---
@@ -32,6 +34,20 @@
*/
public interface LogicalSlot
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5086
LGTM
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155519870
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155528224
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155520946
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155507607
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155507294
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155503866
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerTest.java
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155503994
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerTest.java
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155502971
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/TestingAllocatedSlotActions.java
---
@@ -0,0 +1,53
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5090#discussion_r155496482
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolTest.java
---
@@ -383,6 +386,76 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5090#discussion_r155495322
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolTest.java
---
@@ -383,6 +386,76 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155296898
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/AllocatedSlot.java
---
@@ -144,6 +144,78 @@ public TaskManagerGateway
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155279729
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java ---
@@ -312,24 +312,36 @@ public void returnAllocatedSlot(Slot slot
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155276432
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/slots/SlotContext.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155258087
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotsTestImplContext.java
---
@@ -31,7 +30,7 @@
import static
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155245759
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -507,6 +514,41 @@ public void handleError(final Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155245771
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -507,6 +514,41 @@ public void handleError(final Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155242826
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -86,122 +125,143 @@ public static void teardown
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155242900
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -86,122 +125,143 @@ public static void teardown
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155242108
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InMemorySubmittedJobGraphStore.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155240139
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InMemorySubmittedJobGraphStore.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155227397
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java
---
@@ -208,27 +209,61 @@ public void setLocality(Locality locality
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155225733
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/LogicalSlot.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155208534
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java
---
@@ -37,16 +41,18 @@
* If this slot is part of a {@link
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155207330
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -965,11 +965,20 @@ public void cancel
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155018207
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java
---
@@ -267,10 +270,77 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155016510
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java
---
@@ -267,10 +270,77 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155015331
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerIsolatedTasksTest.java
---
@@ -294,11 +297,11 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155012983
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -331,8 +334,19 @@ public void setInitialState
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r154954054
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java
---
@@ -37,16 +41,18 @@
* If this slot is part of a {@link
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154748301
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -244,7 +302,32 @@ protected JobManagerRunner
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154747386
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -534,6 +536,40 @@ public void handleError(final Exception
GitHub user GJL reopened a pull request:
https://github.com/apache/flink/pull/5107
[FLINK-8176][flip6] Start SubmittedJobGraphStore in Dispatcher
## What is the purpose of the change
The FLIP-6 dispatcher never calls `start()` on its SubmittedJobGraphStore
instance. Hence
Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/5107
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154320952
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -117,84 +135,78 @@ public void testJobSubmission() throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154320903
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -117,84 +135,78 @@ public void testJobSubmission() throws
501 - 600 of 691 matches
Mail list logo
