Apache-HBase commented on pull request #1841:
URL: https://github.com/apache/hbase/pull/1841#issuecomment-638161407
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 47s
Apache-HBase commented on pull request #1841:
URL: https://github.com/apache/hbase/pull/1841#issuecomment-638155059
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s
Apache-HBase commented on pull request #1337:
URL: https://github.com/apache/hbase/pull/1337#issuecomment-638149663
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 21
Apache-HBase commented on pull request #1840:
URL: https://github.com/apache/hbase/pull/1840#issuecomment-638144743
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44
Apache-HBase commented on pull request #1743:
URL: https://github.com/apache/hbase/pull/1743#issuecomment-638142852
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 13
VicoWu commented on pull request #1743:
URL: https://github.com/apache/hbase/pull/1743#issuecomment-638133811
@Apache9 Thanks so much.
I have fixed the checkstyle issue and also enhance the test case for my fix.
Currently everything is fine now.
Please help to re-review it. Thanks
Apache-HBase commented on pull request #1830:
URL: https://github.com/apache/hbase/pull/1830#issuecomment-638132429
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 16s
bsglz edited a comment on pull request #1337:
URL: https://github.com/apache/hbase/pull/1337#issuecomment-638122516
@wchevreuil Sorry for the delay, since it remove the checkbox and use tabs
in latest version, i add a new tab named Localities, include two metrics
Locality and LocalityForSs
bsglz commented on pull request #1337:
URL: https://github.com/apache/hbase/pull/1337#issuecomment-638122516
@wchevreuil Sorry for the delay, since it remove the checkbox and use tabs
in latest version, i add a new tab named Localities, including two metrics
Locality and LocalityForSsd.
infraio commented on a change in pull request #1840:
URL: https://github.com/apache/hbase/pull/1840#discussion_r434471121
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInfoBuilder.java
##
@@ -302,30 +283,28 @@ public void testConvert()
Apache-HBase commented on pull request #1743:
URL: https://github.com/apache/hbase/pull/1743#issuecomment-638106437
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 25
[
https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124834#comment-17124834
]
Anoop Sam John commented on HBASE-23296:
The way we can introduce that can be th
Apache9 commented on a change in pull request #1840:
URL: https://github.com/apache/hbase/pull/1840#discussion_r434450351
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
##
@@ -3355,8 +3354,10 @@ public static String
toLockJs
Apache9 commented on a change in pull request #1840:
URL: https://github.com/apache/hbase/pull/1840#discussion_r434450669
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInfoBuilder.java
##
@@ -302,30 +283,28 @@ public void testConvert()
Apache-HBase commented on pull request #1841:
URL: https://github.com/apache/hbase/pull/1841#issuecomment-638091249
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 59s
Apache-HBase commented on pull request #1764:
URL: https://github.com/apache/hbase/pull/1764#issuecomment-638083491
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 57
Apache-HBase commented on pull request #1840:
URL: https://github.com/apache/hbase/pull/1840#issuecomment-638076577
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 0
infraio commented on a change in pull request #1840:
URL: https://github.com/apache/hbase/pull/1840#discussion_r434428788
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
##
@@ -3355,8 +3354,10 @@ public static String
toLockJs
Apache-HBase commented on pull request #1830:
URL: https://github.com/apache/hbase/pull/1830#issuecomment-638074898
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s
gkanade opened a new pull request #1841:
URL: https://github.com/apache/hbase/pull/1841
removed RS entry from zk draining server znode on RS stopped
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-21406:
-
Fix Version/s: 2.4.0
> "status 'replication'" should not show SINK if the cluste
[
https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-21406:
-
Affects Version/s: 2.4.0
2.3.0
2.2.
virajjasani commented on a change in pull request #1839:
URL: https://github.com/apache/hbase/pull/1839#discussion_r434406124
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##
@@ -3521,20 +3522,33 @@ private void getProcedureRes
[
https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-24500:
--
Fix Version/s: 2.2.6
2.3.0
3.0.0-alpha-1
> The behavior of Regio
Apache9 opened a new pull request #1840:
URL: https://github.com/apache/hbase/pull/1840
…is strange
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
bsglz edited a comment on pull request #1737:
URL: https://github.com/apache/hbase/pull/1737#issuecomment-638046560
@saintstack @Apache9 Help to review it if you have time, Thanks.
This is an automated message from the Apache
bsglz commented on pull request #1737:
URL: https://github.com/apache/hbase/pull/1737#issuecomment-638046560
@saintstack @Apache9 Help review if you have time, Thanks.
This is an automated message from the Apache Git Service.
Apache-HBase commented on pull request #1743:
URL: https://github.com/apache/hbase/pull/1743#issuecomment-638046066
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30
virajjasani commented on a change in pull request #1839:
URL: https://github.com/apache/hbase/pull/1839#discussion_r434395602
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##
@@ -3521,20 +3522,33 @@ private void getProcedureRes
Apache-HBase commented on pull request #1764:
URL: https://github.com/apache/hbase/pull/1764#issuecomment-638043811
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124743#comment-17124743
]
Viraj Jasani commented on HBASE-24492:
--
Let's wait for [~stack]'s confirmation. So
virajjasani merged pull request #1831:
URL: https://github.com/apache/hbase/pull/1831
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ramkrish86 commented on a change in pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#discussion_r434376478
##
File path:
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreAggregateSource.java
##
@@ -0,0 +1,60 @@
+/**
+ * Licen
Apache-HBase commented on pull request #1837:
URL: https://github.com/apache/hbase/pull/1837#issuecomment-638023212
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 35
ramkrish86 commented on a change in pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#discussion_r434369134
##
File path:
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreAggregateSource.java
##
@@ -0,0 +1,60 @@
+/**
+ * Licen
[
https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124700#comment-17124700
]
Guanghao Zhang commented on HBASE-23296:
{quote}Do you mean BucketCache with hea
[
https://issues.apache.org/jira/browse/HBASE-24347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124709#comment-17124709
]
Guanghao Zhang commented on HBASE-24347:
{quote}I think much of the CI refactori
[
https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-24500:
-
Assignee: Duo Zhang
> The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
> ---
[
https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-24500 started by Duo Zhang.
-
> The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
> -
[
https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-24500:
--
Priority: Critical (was: Major)
> The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
Duo Zhang created HBASE-24500:
-
Summary: The behavior of RegionInfoBuilder.newBuilder(RegionInfo)
is strange
Key: HBASE-24500
URL: https://issues.apache.org/jira/browse/HBASE-24500
Project: HBase
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124695#comment-17124695
]
Viraj Jasani commented on HBASE-24492:
--
Thanks [~zhangduo]
Exactly the loop is use
[
https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-24500:
--
Component/s: read replicas
Client
> The behavior of RegionInfoBuilder.newBuilder(Regi
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-24492:
--
Component/s: wal
Replication
> ProtobufLogReader.readNext does not need looping
> ---
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124691#comment-17124691
]
Duo Zhang commented on HBASE-24492:
---
OK, checked the code, there is a 'return true' at
Apache9 commented on pull request #1830:
URL: https://github.com/apache/hbase/pull/1830#issuecomment-638006266
The failed UT is caused by a serious problem of our RegionInfo related API.
Let me open a new issue for fixing it.
-
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124667#comment-17124667
]
Viraj Jasani edited comment on HBASE-24492 at 6/3/20, 7:09 AM:
---
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124667#comment-17124667
]
Viraj Jasani commented on HBASE-24492:
--
[~zhangduo] The issue is not visible at pro
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124664#comment-17124664
]
Duo Zhang commented on HBASE-24492:
---
Do you hit this in real production? Or can you re
201 - 249 of 249 matches
Mail list logo