Re: Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722/ --- (Updated Sept. 15, 2013, 12:41 a.m.) Review request for KDE Frameworks and

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/ --- (Updated Sept. 14, 2013, 10:36 p.m.) Review request for KDE Frameworks and

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

> On Sept. 14, 2013, 10:46 a.m., David Faure wrote: > > BTW you don't have to test kio_http (requires a webdav account), but please > > port all of kdelibs awaya from the newly deprecated api Easy porting :D Anyway, that will go in separate reviewrequests per slave to port. I will only port t

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

> On Sept. 14, 2013, 10:45 a.m., David Faure wrote: > > kioslave/file/file_unix.cpp, line 336 > > > > > > seems to me that it should be indented even more? > > > > > > Anyhow, yes, commit the indenta

Re: Dependency specifications

On Sat, Sep 14, 2013 at 7:42 PM, Stephen Kelly wrote: > Aleix Pol wrote: > > > I'd say that all Qt dependencies in the module should be defined only > once > > in the root CMakeLists.txt. Actually this should be the only file with > > "find_package" calls. > > > > Why? What is the problem with ha

Fwd: Review Request 112662: Clean up CMakeLists.txt and prepare for splitting KEmoticons

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112662/ Review request for Aleix Pol Gonzalez. By David Gil Oliva. *Updated Sept. 14, 2013, 10 p.m.* Changes This patch has been reviewed by Aleix Pol and at least partially by David Faure, but I send

Re: Review Request 112681: Tests for KPluginTrader and friends

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/ --- (Updated Sept. 14, 2013, 7:35 p.m.) Review request for KDE Frameworks and

Re: Review Request 112681: Tests for KPluginTrader and friends

> On Sept. 13, 2013, 8:39 a.m., David Faure wrote: > > staging/kservice/tests/pluginlocator/CMakeLists.txt, line 12 > > > > > > Add a comment (on the same line) about why it's needed It's not actually needed, remo

Review Request 112730: Make knewstuff build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/ --- Review request for KDE Frameworks and David Faure. Description --- Th

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/ --- (Updated Sept. 14, 2013, 6:17 p.m.) Review request for KDE Frameworks and

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

> On Sept. 12, 2013, 7:39 a.m., David Faure wrote: > > staging/kservice/src/services/ktraderparsetree.cpp, line 715 > > > > > > kdelibs coding style -> no space inside (), '{' on the same line. > > > > fo

Re: Dependency specifications

Aleix Pol wrote: > I'd say that all Qt dependencies in the module should be defined only once > in the root CMakeLists.txt. Actually this should be the only file with > "find_package" calls. > Why? What is the problem with having a find_package in src? Thanks, Steve.

Re: Dependency specifications

On 12/09/2013 10:32, Aleix Pol wrote: I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt. Actually this should be the only file with "find_package" calls. At a high level, that sounds reasonable, but I don't think this is necessarily the best so

Re: Review Request 111938: Allow installing both qca2 and qca3

Sorry for the late reply, I was away last week. Are there any more steps I should perform to ensure this works fine for everyone? Thanks, Alex Am Montag, 9. September 2013, 15:21:03 schrieb Ivan Romanov: > > On Sept. 1, 2013, 11:16 p.m., David Faure wrote: > > > Looks fine to me. > > > > Ivan

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40015 --- kioslave/file/file_unix.cpp

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40016 --- BTW you don't have to test kio_http (requires a webdav account)

Re: Review Request 112716: Prepare itemviews for moving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112716/#review40014 --- Ship it! Looks ok to me (but if we're soon dropping the kcorea

Re: Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722/#review40013 --- The description is wrong because it talks about KUrlAuthorized