Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-13 Thread Thorsten Behrens
Josh Heidenreich wrote: > Also, does it update after every commit? And does a change to the > generator do an update too? > Hi Josh, nope, it's a manual process that I run every once in a while. Doxygen itself is rather heaviweight, so you really don't want to run that on a server, let alone for

Re: Master fails to compile with cclan in moz module

2012-02-13 Thread Stephan Bergmann
On 02/13/2012 09:12 PM, julien2412 wrote: You were right Michael about moz, i did a "rm -Rf unxlng*" and the errors quoted in my first post didn't appear again. (strange because i had done a make clean on root level). Now i've got these errors : In file included from ../../../xpcom/glue/nsINIPar

[REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-13 Thread Winfried Donkers
Can this patch be pushed to 3.4 and 3.5 branches as well? The patch addresses problem that go way back in time (pre-LibreOffice at least). Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listi

Re: feature/gbuild_java is finished

2012-02-13 Thread Tor Lillqvist
> I actually waited a lot longer than promised and there is still no > response from any developer using Windows. You misunderstand how this works. It's the Windows-based developers who have to make sure they don't break the Linux build, not the other way around. --tml ___

Re: feature/gbuild_java is finished

2012-02-13 Thread David Tardon
On Mon, Dec 26, 2011 at 01:33:57PM +0100, David Tardon wrote: > Hi all, > > I have converted 6 modules to gbuild on branch feature/gbuild_java: > javaunohelper, jurt, jvmaccess, jvmfwk, ridljar and unoil. It builds > fine here and smoketest finishes with status OK, but some of the modules > contai

Re: building master fails on nlpsolver

2012-02-13 Thread Jean-Baptiste Faure
Le 13/02/2012 17:33, Stephan Bergmann a écrit : > On 02/13/2012 12:34 PM, Caolán McNamara wrote: >> On Sat, 2012-02-11 at 08:47 +0100, Jean-Baptiste Faure wrote: >>> When building the master (Ubuntu 11.10, x86_64), it fails and says that >>> the problem is inside nlpsolver. If I try to build nlpsol

Re: [PATCH] Remove unused code from connectivity::odbc

2012-02-13 Thread Lionel Elie Mamane
On Mon, Feb 13, 2012 at 10:06:17PM +, Kate Goss wrote: > Please see attached. > From 099415fb77eddd7d211ae6ed547cb31b10484a37 Mon Sep 17 00:00:00 2001 > From: Kate Goss > Date: Sun, 12 Feb 2012 13:57:46 + > Subject: [PATCH 1/2] Remove unused method > ODatabaseMetaDataResultSet::openTabl

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-13 Thread Josh Heidenreich
Thorsten, > That stuff is currently generated by a little shell script - I'm not > particularly attached to it, and wouldn't mind perl or python there, > but php so far is not used throughout the build system, maybe we can > avoid it here, too? > > At any rate, rather ugly conversion of your beaut

Re: Adding Extension for Experimental Thai Spelling

2012-02-13 Thread Richard Wordingham
Thank you to every one who's offered me advice. On Mon, 13 Feb 2012 15:08:20 + Caolán McNamara wrote: > I don't think we have any way to override our breakiterators from > extensions. Ah well, I'll just have to try to get Thai spell-checking working for myself and then worry about sharing m

Re: Grammar checker development for LibreOffice

2012-02-13 Thread Cor Nouws
Hi Németh, Németh László wrote (13-02-12 16:20) Lightproof (from “lightweight proofreader”) is a Python grammar checker framework for LibreOffice. Default English, Hungarian and [...] Thanks for the info and the checker! We had some people before in Netherlands community active with spell ch

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Cor Nouws changed: What|Removed |Added Depends on||45991 --- Comment #185 from Cor Nouws 2012-

[REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

2012-02-13 Thread Matúš Kukan
On 12 February 2012 23:51, Matúš Kukan wrote: > Do not push them without improvement, make check fails for me. > Attached diff solves one problem but still there is something wrong. Well, I was fooled by smoketest/com/sun/star/comp/smoketest/makefile.mk There is javamaker involved, but the produc

[DONE] Re: wikihelp update?

2012-02-13 Thread Jan Holesovsky
Hi Korrawit, Korrawit Pruegsanusak píše v So 04. 02. 2012 v 00:36 +0700: > As the 3.5 RC3 is approaching, IMHO it's time to trigger the update of > wikihelp :-) I know that you already know that; but just for the records of the ML, done :-) The 3.4 help has been moved to a separate section toge

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-13 Thread Rene Engelhard
Hi, first of all: thanks for this effort, which should have been done when this lucene dependency was introduced in the first place in OOo times. But... On Mon, Feb 13, 2012 at 04:17:49PM +0100, Radek Doulik wrote: > > * This implementation is using the master branch of CLucene's git, > > wit

[PUSHED 3.5] Re: [REVIEW 3-5] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar

2012-02-13 Thread Jan Holesovsky
Hi Ivan, Ivan Timofeev píše v Po 13. 02. 2012 v 19:47 +0400: > > So I've pushed it now :-) > > Thanks!! Is it worth being in 3-5? :) Thanks for that! Yeah, worth having there too, the empty space is annoying ;-) - pushed. Thank you, Kendy ___ Libre

[PATCH] Remove unused code from connectivity::odbc

2012-02-13 Thread Kate Goss
Hi, Please see attached. Best Regards, Kate Goss From 099415fb77eddd7d211ae6ed547cb31b10484a37 Mon Sep 17 00:00:00 2001 From: Kate Goss Date: Sun, 12 Feb 2012 13:57:46 + Subject: [PATCH 1/2] Remove unused method ODatabaseMetaDataResultSet::openTablesTypes( ) --- .../odbcbase/ODatabaseMet

[PUSHED] Re: [PATCH]bug 44516 improved label and business card document creation

2012-02-13 Thread Jan Holesovsky
Hi Winfried, Winfried Donkers píše v Čt 09. 02. 2012 v 08:03 +0100: > The patch itself is not attached to this mail (size 1.2MB), but > attached to the bug itself. > > The patch file is so large because the file labels.xcu has almost all > lines changed. > > This patch addresses problems that w

[PATCH] Removing unused code

2012-02-13 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 193f0208edeba24a820e9fe098456f5412d5e3a4 Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Mon, 13 Feb 2012 22:31:23 +0100 Subject: [PATCH] Remove unused code. --- editeng/inc/editeng/numitem.hxx |1 - editeng/source/item

Re: Patch for Easy Hack 45033

2012-02-13 Thread Rob Snelders
Hi, Are you sure this is the correct file? When I open the file I only see OpenOffice and StarOffice entries. Maybe someone else can check what he/she sees. Greetings, Rob Snelders On 13-02-12 22:06, Italo Vignoli wrote: On 2/13/12 9:44 PM, Jan Holesovsky wrote: If you can attach the file

Re: [PUSHED] Code removal, first contribution

2012-02-13 Thread Catalin Iacob
On Mon, Feb 13, 2012 at 4:37 PM, Michael Meeks wrote: All my future contributions to LibreOffice are licensed under LGPLv3+ / MPL. I'll also add myself to the wiki. >        So it sounds like you did an excellent job; what's next ? an easy hack > perhaps ? or more unused code ? :-) It would be

Re: Patch for Easy Hack 45033

2012-02-13 Thread Italo Vignoli
On 2/13/12 9:44 PM, Jan Holesovsky wrote: > If you can attach the file, that would be most helpful. I am unable to > reasonably extract the patch from the message - sorry for that, but the > way that works for me flawlessly for text-only patches failed on this > binary one :-( No problem. You kn

[PATCH] Remove unused code

2012-02-13 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From ecde7d2545f9aff68d3b898b2722d7fd1cf2578d Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Mon, 13 Feb 2012 21:52:07 +0100 Subject: [PATCH] Remove unused code. --- svx/inc/svx/xtable.hxx|1 - svx/source/xoutdev/xta

Re: Tinderbox failure, last success: 2012-02-13 15:48:45

2012-02-13 Thread Caolán McNamara
On Mon, 2012-02-13 at 19:39 +0100, Stephan Bergmann wrote: > On 02/13/2012 06:18 PM, Ivan Timofeev wrote: > >> Noob's question: > > A function that is only used by an inline function will be treated as > > unused by callcatcher? Or is it a result of compiler's optimizations? Yeah, gcc, even in -O0

Re: Patch for Easy Hack 45033

2012-02-13 Thread Jan Holesovsky
Hi Italo, Italo Vignoli píše v Po 13. 02. 2012 v 12:27 +0100: > I have patched the biblio.odb document with LibreOffice entries (got rid > of the old OOo entries). The patch is below to be checked, but I do not > understand if I have to attach the patched document as well. Please > help. If you

Re: [REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

2012-02-13 Thread Kohei Yoshida
On Mon, 2012-02-13 at 21:16 +0100, Eike Rathke wrote: > Hi Kohei, > > On Monday, 2012-02-13 12:40:11 -0500, Kohei Yoshida wrote: > > > Attached change (not yet committed to master) will fix a crasher bug > > which is one of the bugs reported in > > > > https://bugs.freedesktop.org/show_bug.cgi?i

Re: OK to get rid of scaddins?

2012-02-13 Thread Eike Rathke
Hi Tor, On Monday, 2012-02-13 13:31:11 +0200, Tor Lillqvist wrote: > Do we really need to keep "analysis" and "date" as separate shared > libraries? Would it be OK to move their source code over to the "sc" > module, and merge their objects into the "sc" library, and their > .component files into

Re: [REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

2012-02-13 Thread Eike Rathke
Hi Kohei, On Monday, 2012-02-13 12:40:11 -0500, Kohei Yoshida wrote: > Attached change (not yet committed to master) will fix a crasher bug > which is one of the bugs reported in > > https://bugs.freedesktop.org/show_bug.cgi?id=45916 > > It originally comes from > > https://issues.apache.org/o

Re: Master fails to compile with cclan in moz module

2012-02-13 Thread julien2412
You were right Michael about moz, i did a "rm -Rf unxlng*" and the errors quoted in my first post didn't appear again. (strange because i had done a make clean on root level). Now i've got these errors : In file included from ../../../xpcom/glue/nsINIParser.cpp:41: In file included from ../../../x

Re: [PUSHED] Remove unused methods from PDFI

2012-02-13 Thread Kate Goss
Hi Michael, On 13 February 2012 15:22, Michael Meeks wrote: > Hi Kate, > > On Sat, 2012-02-11 at 17:37 +, kate goss wrote: > > Made available under the MPL/LGPLv3+ > >They look lovely - thanks for that ! :-) > >Welcome to the project. Incidentally, it'd be quite useful to ha

License Statement

2012-02-13 Thread Kate Goss
Hi all, for reference: All contributions past, present and future made by me to LibreOffice are available under the terms of the MPL / LGPLv3+. Best Regards, Kate Goss ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedes

FWD: Do You Know Having Website/Blog is Very Cheap?

2012-02-13 Thread Jeff
This email may contain privileged or confidential information and is for the sole use of the intended recipient(s). If you are not the intended recipient, any disclosure, copying, distribution, or use of the contents of this information is prohibited and may be unlawful. If you have received this

Re: Tinderbox failure, last success: 2012-02-13 15:48:45

2012-02-13 Thread Stephan Bergmann
On 02/13/2012 06:18 PM, Ivan Timofeev wrote: On 13.02.2012 21:08, nthieb...@gmail.com wrote: /Volumes/Raid0/core/solver/unxmacxi.pro/inc/svtools/ctrlbox.hxx: In member function 'void FontSizeBox::SetUserValue(sal_Int64)': /Volumes/Raid0/core/solver/unxmacxi.pro/inc/svtools/ctrlbox.hxx:563: error

Re: [PUSHED 3-5] Fix for a crasher during copy-n-paste from Excel.

2012-02-13 Thread Ivan Timofeev
On 13.02.2012 22:22, Kohei Yoshida wrote: Hi Ivan, On Mon, Feb 13, 2012 at 1:13 PM, Ivan Timofeev wrote: [...] A crash will be right here, inside Compile?.. No it does not. Oh, pardon, did not noticed one-line if - return: if ( pDocument->IsClipOrUndo() ) return; I dared to push...

Re: [REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

2012-02-13 Thread Kohei Yoshida
Hi Ivan, On Mon, Feb 13, 2012 at 1:13 PM, Ivan Timofeev wrote: > Hi Kohei, > ScFormulaCell::Compile: > >    pCode = aComp.CompileString( rFormula ); >    if ( pCodeOld ) >        delete pCodeOld; >    if( !pCode->GetCodeError() ) >    { > > A crash will be right here, inside Compile?.. No it do

Re: [REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

2012-02-13 Thread Ivan Timofeev
Hi Kohei, On 13.02.2012 21:40, Kohei Yoshida wrote: The problem happened when calc was not able to compile the formula string for whatever reason, in which case pCode would remain NULL after the Compile is called in one of its constructors. Sorry, I did not test the bug, but... ScFormulaCell:

sal / gcc conditionals ...

2012-02-13 Thread Michael Meeks
Hi there, Alexander just removed a load of gcc conditionals from master, but there were a few I dropped from his patch to get some further input from you. We've decided (I think) in https://bugs.freedesktop.org/show_bug.cgi?id=45131 that 4.0.1 * cppu/inc/cppu/macros.hxx:

Re: [REVIEW][PUSHED 3-5][PUSHED 3-4] fdo#41712 SwFlowFrm::pPrecede regression

2012-02-13 Thread Cedric Bosdonnat
On Mon, 2012-02-13 at 15:02 +0100, Cedric Bosdonnat wrote: > Hi Michael, > > On Mon, 2012-02-13 at 13:01 +0100, Michael Stahl wrote: > > apparently a SwFlowFrm::pPrecede was introduced, turning the SwFlowFrm > > list from a singly linked list to a doubly linked list, without much > > thought given

[REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

2012-02-13 Thread Kohei Yoshida
Attached change (not yet committed to master) will fix a crasher bug which is one of the bugs reported in https://bugs.freedesktop.org/show_bug.cgi?id=45916 It originally comes from https://issues.apache.org/ooo/show_bug.cgi?id=118851 There were several ways to think this as far as I could see.

Re: [PUSHED] Fix typos in comments (1)

2012-02-13 Thread Michael Meeks
On Tue, 2012-02-14 at 00:08 +0800, Elton Chung wrote: > That's the magic of OpenGrok :) Ah ! ;-) > I have sent a mail to the list before with the license > (http://lists.freedesktop.org/archives/libreoffice/2012-January/024938.html) > and I have just added my name onto the wiki list.

[PATCH] [REVIEW:3-5,3-4] fdo#43399 address data source wizard non-functional if no evolution

2012-02-13 Thread Lionel Elie Mamane
ON Unix, if evolution (the default choice for address data) SDBC driver fails to load, then the address data wizard is completely non-functional because it tries to use evolution anyway, even when the user has selected another choice (e.g. thunderbird or ldap or "other" - which should maybe be call

Re: Tinderbox failure, last success: 2012-02-13 15:48:45

2012-02-13 Thread Ivan Timofeev
On 13.02.2012 21:08, nthieb...@gmail.com wrote: Hi folks, One of you broke the build of LibreOffice with your commit :-( Please commit and push a fix ASAP! [...] /Volumes/Raid0/core/solver/unxmacxi.pro/inc/svtools/ctrlbox.hxx: In member function 'void FontSizeBox::SetUserValue(sal_Int64)': /V

Re: [PATCH] [REVIEW:3-5] PostgreSQL getColumns()

2012-02-13 Thread Radek Doulik
On Mon, 2012-02-13 at 18:08 +0100, Lionel Elie Mamane wrote: > On Mon, Feb 13, 2012 at 05:39:51PM +0100, Radek Doulik wrote: > > > looks OK to me. I have cherry-picked it from master, because the > > attached patch didn't apply. > > Oh, sorry, some difference between my work tree and pristine > l

Re: windows / cygwin build freezes using --with-lang=it [SOLVED]

2012-02-13 Thread Michael Meeks
Hi Walter, On Fri, 2012-02-10 at 15:19 +0100, walter wrote: > Using a different autogen.sh configuration all work fine and the build > process generate the following installer: Great :-) glad to hear that. > I don’t know if the problem was jobs=8, cpu=8 or not using ‘— > disable-binfilte

Re: [PATCH] [REVIEW:3-5] PostgreSQL getColumns()

2012-02-13 Thread Lionel Elie Mamane
On Mon, Feb 13, 2012 at 05:39:51PM +0100, Radek Doulik wrote: > looks OK to me. I have cherry-picked it from master, because the > attached patch didn't apply. Oh, sorry, some difference between my work tree and pristine libreoffice-3-5 must have made a mess. The "sorted by concatenation" proble

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-13 Thread Caolán McNamara
On Fri, 2012-02-10 at 23:11 +0100, Gert van Valkenhoef wrote: > The code that interfaces with Lucene to do the indexing and searching is > complete. Great. > I've also looked into where the HelpIndexerTool is currently used, and > found these: > > - xmlhelp/source/cxxhelp/provider/databases.

Re: [PATCH] [REVIEW:3-5] PostgreSQL getColumns()

2012-02-13 Thread Radek Doulik
Hi, looks OK to me. I have cherry-picked it from master, because the attached patch didn't apply. Pushed. Thanks. Cheers Radek On Thu, 2012-02-09 at 19:27 +0100, Lionel Elie Mamane wrote: > getColumns() is a XDatabaseMetadata interface function to get the list > of columns of a table and info o

Re: [PUSHED] Remove unused code (8)

2012-02-13 Thread Ivan Timofeev
Hi Elton, Michael, On 13.02.2012 20:04, Michael Meeks wrote: On Sat, 2012-02-11 at 00:50 +0800, Elton Chung wrote: This patch removes 10 unused methods. Lovely; if you 'git grep bNetLock' - I think we can remove that item from the header, and it's remaining initialization too now (cou

Re: building master fails on nlpsolver

2012-02-13 Thread Stephan Bergmann
On 02/13/2012 12:34 PM, Caolán McNamara wrote: On Sat, 2012-02-11 at 08:47 +0100, Jean-Baptiste Faure wrote: When building the master (Ubuntu 11.10, x86_64), it fails and says that the problem is inside nlpsolver. If I try to build nlpsolver by make nlpsolver I get the following error messages :

[PUSHED] Remove unused code (12)

2012-02-13 Thread Michael Meeks
On Sun, 2012-02-12 at 17:10 +0800, Elton Chung wrote: > This patch removes 3 unused methods. Pushed ! :-) and that was the last queued up patch from you I think, thanks for all the great work :-) All the best, Michael. -- michael.me...@suse.com <><, Pseudo Engi

Re: [REVIEW][3-5] Header/Footer and PageBreak indicators to be hidden in RO mode

2012-02-13 Thread Caolán McNamara
On Mon, 2012-02-13 at 19:40 +0400, Ivan Timofeev wrote: > So, my attempt: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=19d80a257b0e5c9d45985e49f33493f38c5d5f10 > > Ivan Looks good to me, pushed that to 3-5 as well C. ___ LibreOffice mail

[PUSHED] Remove unused code (11)

2012-02-13 Thread Michael Meeks
On Sun, 2012-02-12 at 17:09 +0800, Elton Chung wrote: > This patch removes 12 unused methods. Pushed with some conflicts removed, Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___

[PUSHED] Remove unused code (10)

2012-02-13 Thread Michael Meeks
On Sun, 2012-02-12 at 17:07 +0800, Elton Chung wrote: > This patch removes 8 unused methods. Thanks :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.f

Re: [PATCH] Remove unused code (9)

2012-02-13 Thread Michael Meeks
On Sat, 2012-02-11 at 12:01 +0800, Elton Chung wrote: > This patch removes 11 unused methods. Lovely, it seems our delay at reviewing caused a few conflicts with others; hopefully you'll be able to pull / re-base any bits you have on top of what I pushed here. Thanks !

Re: [PUSHED] Fix typos in comments (1)

2012-02-13 Thread Elton Chung
Hi Michael, That's the magic of OpenGrok :) I have sent a mail to the list before with the license (http://lists.freedesktop.org/archives/libreoffice/2012-January/024938.html) and I have just added my name onto the wiki list. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.la

[PUSHED] Remove unused code (8)

2012-02-13 Thread Michael Meeks
On Sat, 2012-02-11 at 00:50 +0800, Elton Chung wrote: > This patch removes 10 unused methods. Lovely; if you 'git grep bNetLock' - I think we can remove that item from the header, and it's remaining initialization too now (could you hack that up) ? :-) Similarly for bNotMasterCach

[PUSHED] Remove unused code (7)

2012-02-13 Thread Michael Meeks
On Sat, 2012-02-11 at 00:49 +0800, Elton Chung wrote: > This patch removes another 4 unused methods. Thanks :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffic

[PUSHED] Remove unused code (6)

2012-02-13 Thread Michael Meeks
On Sat, 2012-02-11 at 00:48 +0800, Elton Chung wrote: > The patch removes 4 unused methods. Pushed; thanks :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@

Re: [PUSHED] Fix typos in comments (1)

2012-02-13 Thread Noel Power
On 13/02/12 15:28, Michael Meeks wrote: Hi there, On Sat, 2012-02-11 at 16:21 +0800, Elton Chung wrote: This patch fixes some typos in comments. Lovely - you have some magic means of finding bad comments ? :-) Incidentally, it'd really help if you could send a blanket MPL/LGPL

License statement

2012-02-13 Thread Matúš Kukan
Hi all, all my past and future contributions to LibreOffice are available under the MPL / LGPLv3+ unless stated otherwise. Best, Matúš ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffi

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-13 Thread Michael Meeks
Hi there, On Fri, 2012-02-10 at 23:11 +0100, Gert van Valkenhoef wrote: > Attached are initial implementations of the HelpIndexer and HelpSearch > in C++ using CLucene, to replace the Java implementations using Lucene. Wow - this is awesome :-) Thanks so much for that; I hope it

Re: [REVIEW 3-5] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar

2012-02-13 Thread Ivan Timofeev
On 13.02.2012 18:20, Caolán McNamara wrote: So I've pushed it now :-) Thanks!! Is it worth being in 3-5? :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED][PATCH] Remove unused code

2012-02-13 Thread Caolán McNamara
On Mon, 2012-02-13 at 15:38 +, Caolán McNamara wrote: > On Mon, 2012-02-13 at 00:08 +, Björgvin Ragnarsson wrote: > > Hello, > > > > Attached is my first contribution to Libreoffice > > Looks good to me, pushed now, thanks for this. adding PUSHED tag dammit. C.

Re: [REVIEW][3-5] Header/Footer and PageBreak indicators to be hidden in RO mode

2012-02-13 Thread Ivan Timofeev
On 13.02.2012 18:26, Caolán McNamara wrote: On Mon, 2012-02-13 at 17:56 +0400, Ivan Timofeev wrote: Hi Cedric, Kendy, On 13.02.2012 14:24, Cedric Bosdonnat wrote: Could someone (kendy?) review and cherry-pick -s in -3-5 the following commit: http://cgit.freedesktop.org/libreoffice/core/commit/

Re: [PATCH] Remove unused code

2012-02-13 Thread Caolán McNamara
On Mon, 2012-02-13 at 00:08 +, Björgvin Ragnarsson wrote: > Hello, > > Attached is my first contribution to Libreoffice Looks good to me, pushed now, thanks for this. C. You should add yourself to http://wiki.documentfoundation.org/Development/Developers and link back to your last email vi

[PUSHED] Code removal, first contribution

2012-02-13 Thread Michael Meeks
Hi Catalin, On Fri, 2012-02-10 at 23:10 +0100, Catalin Iacob wrote: > Contribution under LGPLv3+ / MPL. Thanks ! :-) and welcome to the project. It'd be lovely to have a blanket license statement for all your contributions that we can link into: http://wiki.documentfoundation.org

[PUSHED] Re: [PATCH] [REVIEW:3-5] fdo#45249 cannot use aggregate functions in with PostgreSQL

2012-02-13 Thread Radek Doulik
Hi, looks OK to me. Pushed. Thanks. Cheers Radek On Thu, 2012-02-09 at 18:44 +0100, Lionel Elie Mamane wrote: > With a PostgreSQL-SDBC database, Base query design does not allow the > user to use groupings and aggregate functions. > > Change PostgreSQL-SDBC so that it declares to support Core S

Grammar checker development for LibreOffice

2012-02-13 Thread Németh László
Hi, Lightproof (from “lightweight proofreader”) is a Python grammar checker framework for LibreOffice. Default English, Hungarian and Russian grammar checkers of LibreOffice 3.5 are based on Lightproof (also the French Grammalecte: http://extensions.libreoffice.org/extension-center/grammalecte).

[PUSHED] Fix typos in comments (1)

2012-02-13 Thread Michael Meeks
Hi there, On Sat, 2012-02-11 at 16:21 +0800, Elton Chung wrote: > This patch fixes some typos in comments. Lovely - you have some magic means of finding bad comments ? :-) Incidentally, it'd really help if you could send a blanket MPL/LGPLv3+ license mail to the list, so we can l

Re: [Libreoffice][PUSHED] [PATCH] Making default tab prefix name configurable in Calc

2012-02-13 Thread Noel Power
On 13/02/12 14:52, Albert Thuswaldner wrote: Yes I vote for pushing this as you suggested. It is a cheap solution for now, and done elsewhere in the code, so at least we are consistent then. Saw the ideas from Markus and Stefan regarding the range name dialog: https://wiki.documentfoundation.o

[REVIEWED] glib needed only when enable_librsvg, gettext only when enable_librsvg or cross-compile

2012-02-13 Thread Michael Meeks
Hi there, On Sat, 2012-02-11 at 16:20 +0700, Korrawit Pruegsanusak wrote: > Now, I summarize this as, if we're cross-compiling, we need 'gettext', > but if we --disble-librsvg, we don't need neither 'gettext' nor 'glib'. Sounds sensible to me :-) > So, I'm purposing a *partial* patch (at

[PUSHED] Remove unused methods from PDFI

2012-02-13 Thread Michael Meeks
Hi Kate, On Sat, 2012-02-11 at 17:37 +, kate goss wrote: > Made available under the MPL/LGPLv3+ They look lovely - thanks for that ! :-) Welcome to the project. Incidentally, it'd be quite useful to have a blanket license mail for your contributions we can link into here:

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-13 Thread Radek Doulik
Hi Gert, thanks for looking into this. On Fri, 2012-02-10 at 23:11 +0100, Gert van Valkenhoef wrote: > Dear LibreOffice developers, > > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=44681 > > Attached are initial implementations of the HelpIndexer and HelpSearch > in C++ using CLucene, to

Re: Adding Extension for Experimental Thai Spelling

2012-02-13 Thread Caolán McNamara
On Sat, 2012-02-11 at 16:23 +, Richard Wordingham wrote: > Is it possible to create an experimental alternative to the Thai > break iterator that can be shared with other people as a LibreOffice > extension? I don't think we have any way to override our breakiterators from extensions. FWIW, i

Re: OK to get rid of scaddins?

2012-02-13 Thread Michael Stahl
On 13/02/12 15:47, Michael Meeks wrote: > > On Mon, 2012-02-13 at 12:38 +0100, Michael Stahl wrote: >> the sc, sd, sw libraries already take forever to link with full debug, > > You link with full debug ? :-) well i was actually surprised once that i do, but soon found out that somebody ha

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-02-13 Thread Gary Driggs
On Feb 13, 2012, at 4:19 AM, Michael Meeks wrote: > but never any: > >git diff > /tmp/foo.diff I was working from the latest released source. This week might be quieter so I could try grabbing the git repo... ___ LibreOffice mailing list LibreOffic

Re: Adding Extension for Experimental Thai Spelling

2012-02-13 Thread Michael Meeks
On Sat, 2012-02-11 at 16:23 +, Richard Wordingham wrote: > As I understand it, the lack of a usable Thai spell-checker for > LibreOffice (unlike, say, a Khmer spell-checker) is due to the Thai > break iterator. In common with many, I know nothing about Thai ;-) but my friend Tim does

Re: [Libreoffice-commits] .: external/gcc3_specific

2012-02-13 Thread Stephan Bergmann
On 02/13/2012 03:39 PM, Fridrich Strba wrote: New commits: commit 9a51a7ae7153fee17013867bd7bbaacedee1980a Author: Fridrich Štrba Date: Mon Feb 13 15:39:43 2012 +0100 Copy the gcc's stdlibs to solver even if not packaging them Hi Fridrich, Mid-term, once implicit --with-sytem-stdlibs h

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-02-13 Thread Albert Thuswaldner
On Mon, Feb 13, 2012 at 12:23, Noel Power wrote: > On 09/02/12 14:53, Albert Thuswaldner wrote: >>> 2) When trying to delete text in the edit box, the last character >>> sticks (can't be deleted). > > well that would seem to be because your code thinks a blank prefix is > illegal, I believe chang

Re: [Libreoffice] [PUSHED-partially][PATCH]a better about dialog

2012-02-13 Thread Petr Mladek
Kohei Yoshida píše v Pá 10. 02. 2012 v 14:33 -0500: > On Fri, 2012-02-10 at 18:23 +0100, Stefan Knorr (Astron) wrote: > > Hi Petr, > > > > > I checked other applications, e.g. pidgin, xchat, gimp, kmail, > > > evolution, firefox. They all have [Cancel] button in the about dialog. > > > It is in th

Re: OK to get rid of scaddins?

2012-02-13 Thread Michael Meeks
On Mon, 2012-02-13 at 13:31 +0200, Tor Lillqvist wrote: > Do we really need to keep "analysis" and "date" as separate shared > libraries ? Ho hum; well - they are not used at calc startup, but they are at document load - as soon as you start to enter a formula they are loaded, and if you

Re: OK to get rid of scaddins?

2012-02-13 Thread Michael Meeks
On Mon, 2012-02-13 at 12:38 +0100, Michael Stahl wrote: > the sc, sd, sw libraries already take forever to link with full debug, You link with full debug ? :-) > and adding more stuff to them would also impact startup performance for > the respective application. Not necessarily

Re: [PATCH] [PUSHED, modified] Moving misplaced Compatibility options from ScDocOptions to ScAppOptions

2012-02-13 Thread Albert Thuswaldner
Hi Kohei, On Mon, Feb 13, 2012 at 15:05, Kohei Yoshida wrote: > > Sorry, I didn't explain the goal very well. :-P Me not reading the code. :( Sorry for the noise. > You just need to move the options that are in the Formula options page, > which is to say move those that are below bFormulaRegexE

Re: [REVIEW][3-5] Header/Footer and PageBreak indicators to be hidden in RO mode

2012-02-13 Thread Caolán McNamara
On Mon, 2012-02-13 at 17:56 +0400, Ivan Timofeev wrote: > Hi Cedric, Kendy, > > On 13.02.2012 14:24, Cedric Bosdonnat wrote: > > Could someone (kendy?) review and cherry-pick -s in -3-5 the following > > commit: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=beb8a85796c78d4cdcf6497b67

[PUSHED][PATCH] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar

2012-02-13 Thread Caolán McNamara
On Thu, 2012-02-09 at 21:38 +0400, Ivan Timofeev wrote: > Hi, > > actually there was not a scrollbar appearing at the bottom, there was a > border. :) ... > so in normal mode we use IsVisible(false), that checks for > SwScrollbar::bVisible, regardless of the real visibility. The next line: >

Re: Need help (mentor) while fixing an issue

2012-02-13 Thread Jan Holesovsky
Hi Dag, Dag Wieers píše v Pá 10. 02. 2012 v 16:36 +0100: > I found a bug in LibreOffice causing style:rel-width and style:rel-height > not to accept "scale" as a possible value. In fact the behavior seems to > be to default to 100% if anything except percentages are provided. > > https://

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 sasha.libreoff...@gmail.com changed: What|Removed |Added Depends on||43399 -- Configure bugmail

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #184 from sasha.libreoff...@gmail.com 2012-02-13 06:11:27 PST --- No databases in Wisard of mailmerge (regression since 3.4.4) Bug 43399 - Address data source wizard will not allow the definition of a Spreadsheet connection setting -

Re: [PATCH] [PUSHED,modified] Moving misplaced Compatibility options from ScDocOptions to ScAppOptions

2012-02-13 Thread Kohei Yoshida
Hi Albert, On Sun, 2012-02-12 at 22:28 +0100, Albert Thuswaldner wrote: > I have worked with converting the Formula options. However, while > doing the work and looking through the code I have started to question > if this conversion is such a good idea in this case? > > Without knowing the exac

Re: [REVIEW][PUSHED 3-5][3-4] fdo#41712 SwFlowFrm::pPrecede regression

2012-02-13 Thread Cedric Bosdonnat
Hi Michael, On Mon, 2012-02-13 at 13:01 +0100, Michael Stahl wrote: > apparently a SwFlowFrm::pPrecede was introduced, turning the SwFlowFrm > list from a singly linked list to a doubly linked list, without much > thought given to the additional invariants that need to be maintained; > these patch

Re: [PUSHED][REVIEW 3-5] fix RTF import of page breaks right before text frames

2012-02-13 Thread Cedric Bosdonnat
Hi Miklos, On Fri, 2012-02-10 at 10:08 +0100, Miklos Vajna wrote: > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=63dfa72b5eca7be9df3076314055c5c74aa1f4fa > > It makes the RTF import not ignore page breaks right before text frames. > > Could somebody sign-off and push to -3-5, pl

Re: [PUSHED][REVIEW 3-5] fix RTF export table output for subtables

2012-02-13 Thread Cedric Bosdonnat
Hi Miklos, On Thu, 2012-02-09 at 09:46 +0100, Miklos Vajna wrote: > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f77a5e8d5bf8a7f1b7bd7206996d2b2efc59462 > > It makes the RTF export generate valid table output in case the original > ODT had table:is-sub-table elements. > > Could

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 sasha.libreoff...@gmail.com changed: What|Removed |Added Depends on||43318 -- Configure bugmail

Re: [REVIEW][3-5] Header/Footer and PageBreak indicators to be hidden in RO mode

2012-02-13 Thread Ivan Timofeev
Hi Cedric, Kendy, On 13.02.2012 14:24, Cedric Bosdonnat wrote: Could someone (kendy?) review and cherry-pick -s in -3-5 the following commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=beb8a85796c78d4cdcf6497b6725fce8f7141d75 What about hiding the indicators in the web layout mode

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #183 from sasha.libreoff...@gmail.com 2012-02-13 05:56:10 PST --- Bug 43318 - Draw printing: Bitmap edited object prints incorrectly from Draw (regression since 3.3.4) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi

Re: Tinderbox failure, last success: 2011-12-05 09:00:13

2012-02-13 Thread Kohei Yoshida
Hi everyone, On Sun, 2012-02-12 at 23:49 +, fridrich.st...@bluewin.ch wrote: > Hi folks, > > One of you broke the build of LibreOffice with your commit :-( > Please commit and push a fix ASAP! ... > The error is: > > build failed - error is:: log for /home/lo/master/sal/prj > [ info ALL ] L

Re: smoketest - ABORT_ON_ASSERTION needed ? + gbuild patch

2012-02-13 Thread Caolán McNamara
On Sun, 2012-02-12 at 15:41 +0100, Matúš Kukan wrote: > My guess is ABORT_ON_ASSERTION = TRUE was supposed to be in > smoketestoo_native/makefile.mk Yeah, that was where it was supposed to be, and that would tweak solenv/./inc/installationtest.mk to toggle on SAL_DIAGNOSE_ABORT and DBGSV_ERROR_OUT

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 sasha.libreoff...@gmail.com changed: What|Removed |Added Depends on||43313 -- Configure bugmail

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #182 from sasha.libreoff...@gmail.com 2012-02-13 05:36:34 PST --- Bug 43313 - Writer table: border of merged cell is misplaced (regression since 3.3.4) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email -

Re: [PUSHED][3-4,3-5][REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt

2012-02-13 Thread Caolán McNamara
On Fri, 2012-02-10 at 18:12 +0100, Jan Holesovsky wrote: > Please approve for libreoffice-3-5, and for libreoffice-3-4 too, if it > applies there. Applied to 3-4 as well, and seems sane, pushed to 3-4 as well. C. ___ LibreOffice mailing list LibreOffic

Google Summer of Code 2012: time to be ready

2012-02-13 Thread Cedric Bosdonnat
Hi all, GSoC 2012 edition has been announced a week ago at the same time than FOSDEM. We now need to be ready to apply and host cool projects for cool students and cool mentors. For this I'll need your help! What to do: * Clean up the ideas list from Gsoc/Ideas wiki page [0]. (See how to pick

  1   2   >