On Tuesday 03 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > SWDMA modes are unsupported by it821x. Attempts to tune SWDMA modes always
> > fail (due to sanity check in ->speedproc) and result in PIO being tuned.
>
> >
On Tuesday 03 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Add ATA_PIO[0-6] defines to .
>
> > * Add ->pio_mask field to ide_pci_device_t and ide_hwif_t.
>
> > * Add PIO masks to host drivers.
>
>
On Tuesday 03 July 2007, Alan Cox wrote:
> > The new improved driver is not really better than the old one because
> > the old one is broken. :)
> >
> > Old driver does identical configuration when it comes to PIO modes.
>
> No the old driver doesn't even do that. It starts up. It spuriously
> ad
On Tuesday 03 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Add ATA_PIO[0-6] defines to .
>
> > * Add ->pio_mask field to ide_pci_device_t and ide_hwif_t.
>
> > * Add PIO masks to host drivers.
>
> > Signed-off-by: B
):
ide: pdc202xx_new PLL input clock fix
Andrew Morton (1):
ide: ide_scan_pcibus(): check __pci_register_driver return value
Bartlomiej Zolnierkiewicz (2):
amd74xx: resume fix
it821x: fix incorrect SWDMA mask
Masatake YAMATO (1):
ide: never called printk statement in ide
On Tuesday 03 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Add ->host_flags to ide_hwif_t to store ide_pci_device_t.host_flags,
> > assign it in setup-pci.c:ide_pci_setup_ports().
>
> > * Add IDE_HFLAG_PIO_NO_{BLACKLIST,DOWNGRADE}
On Tuesday 03 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > http://www.linuxhq.com/kernel/v2.3/10/drivers/block/hpt343.c
>
> > Does anybody have DOS driver for HPT343? Google doesn't have it...
>
> I h
On Wednesday 04 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> >>A lot to argue about here...
>
> >>>* Add sil_tuneproc() wrapper for siimage_tuneproc() which also sets
> >>> PIO mode on the device.
On Wednesday 04 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > [PATCH] ide: ide_find_best_pio_mode() fixes (take 2)
>
> > * Check IORDY bit for PIO modes > 2.
>
> > * Some devices claim maximum PIO mode >
On Wednesday 04 July 2007, Alan Cox wrote:
> > > It doesn't need to do anything.
> >
> > Not true. It should call ide_config_drive_speed() at least, else PIO
> > autotuning won't actually work.
>
> Indeed - I forgot that old-ide doesn't do this itself but leaves it up to
> the driver to for
On Wednesday 04 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> >>> reporting PIO mode selected from ->tuneproc implementations.
>
> >>>* Rename ->tuneproc hook to ->set_pio_mode
>
> >>Well, tuneproc() went w
On Wednesday 04 July 2007, Uwe koziolek wrote:
> The SiS966 has one additional PCI-ID 1180.
> If the chipset is using this PCI-ID, the primary channel is connected to the
> first
> PATA-port. The secondary channel is connected to SATA-ports in IDE emulation
> mode.
> The legacy IO-ports are used.
Hi,
On Saturday 07 July 2007, Arnd Bergmann wrote:
> On Saturday 07 July 2007, Sergei Shtylyov wrote:
> > Arnd Bergmann wrote:
> >
> > >>This adds support for MMIO IDE device like CompactFlash
> > >>in TrueIDE mode.
> >
> > >>Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
> > >>Signed-off
Please pull from:
master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/
to receive the following updates:
drivers/ide/legacy/qd65xx.c |3 +--
drivers/ide/pci/sis5513.c |1 +
include/linux/pci_ids.h |1 +
3 files changed, 3 insertions(+), 2 deletions(-)
Bartlomiej
set on the device
* While at it remove no longer needed checks from pmac.c driver.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
This patch series goes before ide-add-ide-set-pio-take3.patch patch
("[PATCH] ide: add ide_set{_max}_pio() (take 3)") in the quilt tree
pset().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
This patch obsoletes following previous patches:
[PATCH] atiixp: ->speedproc, filter out invalid modes passed from user-space
[PATCH] alim15x3: ->speedproc, filter out invalid modes passed from user-space
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/cs5520.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/ide/pci/cs5520.c
===
--- a/drivers/ide/pci/cs5520.c
+++ b/d
the device instead of values 0x08-0x0c (XFER_PIO_[0,4]).
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/cs5535.c | 42 ++
1 file changed, 18 insertions(+), 24 deletions(-)
Index: b/drivers/ide/pci/cs
* Set transfer mode on the device in jmicron_tuneproc(),
also add pio == 255 == "auto-tune" handling.
* Use jmicron_tuneproc() in jmicron_config_drive_for_dma().
* Remove no longer needed config_jmicron_chipset_for_pio().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EM
* Don't call {piix,slc90e66}_dma_2_pio() for PIO modes in
{piix,slc90e66}_tune_chipset().
* Add PIO1 handling to {piix,slc90e66}_tune_chipset().
* Bump driver version.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/piix.c |9 +++--
ned-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/sis5513.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
Index: b/drivers/ide/pci/sis5513.c
===
--- a/drivers/ide/pci/
* Move ide_rate_filter() calls from host drivers to IDE core.
* Make ide_rate_filter() static.
* Make 'speed' argument of ->speedproc const.
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
-
option.
As a result of this patch users have now three less config options
to worry about and can just select host drivers that they need
(IDE config menu is "flatter").
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/id
* Use it8213_tuneproc() in it8213_config_drive_for_dma().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/it8213.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
Index: b/drivers/ide/p
to the new wrapper.
* Fix scc_tune_chipset() to tune PIO modes. Do a small cleanup while at it.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/scc_pata.c | 61 ++---
1 file changed, 20 insertions(+), 41 deleti
On Monday 09 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Don't call {piix,slc90e66}_dma_2_pio() for PIO modes in
> > {piix,slc90e66}_tune_chipset().
>
> XFER_PIO_* switch cases might have been be deleted from
> {piix,slc9
On Monday 09 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Rename it8213_tuneproc() to it8213_tune_pio() and add it8213_tuneproc()
> > wrapper. Move finding of the best PIO mode to the new wrapper.
>
> > * Add setting of tra
On Monday 09 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Use pio == 255 == "auto-tune" in scc_config_drive_for_dma() instead of
> > forcing PIO4 on PIO fallback. Fix comment while at it.
>
> > * Rename scc_tuneproc() t
On Monday 09 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
>
> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
added
-
To unsubscribe from this list: send the line "unsu
On Monday 09 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> Sorry, more grammar nitpicking follows (-:
>
> > * Add an extra argument to ide_max_dma_mode() for passing requested transfer
> > mode. Use it as an upper limit when finding the
On Monday 09 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
> > * Fix icside, cris-ide, au1xxx-ide, amd74xx, via82cxxx and pmac host drivers
> > to use ide_rate_filter().
>
> > This results in the following modes (from user req
On Monday 09 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Set transfer mode on the device in jmicron_tuneproc(),
> > also add pio == 255 == "auto-tune" handling.
>
> > * Use jmicron_tuneproc() in jmicron_config_drive_for_dm
On Tuesday 10 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Move ide_rate_filter() calls from host drivers to IDE core.
>
> > * Make ide_rate_filter() static.
>
> > * Make 'speed' argument of ->speedpr
[ added Kou back to cc: ]
On Tuesday 10 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Kumar Gala wrote:
> > Move to using inline function variant of eieio instead of inline assmebly.
>
> > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]>
applied
Please use host driver name ("scc_pata" in this c
On Tuesday 10 July 2007, Akira Iguchi wrote:
> Workaround for errata A308: turn down the UDMA mode and retry
> the DMA command when the data lost condition is detected.
>
> Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
> Signed-off-by: Akira Iguchi <[EMAIL PROTECTED]>
applied, thanks
-
To unsub
On Tuesday 10 July 2007, Sergei Shtylyov wrote:
> Alan Cox wrote:
>
> >>I guess it's been blindly copied over form drivers/ide/pci/siimage.c...
>
> Yet the order of events between IDE and libata drivers is different:
> the old driver's resetproc() method is called just after the twiddling
[ please always cc: linux-ide@ on ATA patches ]
^
s/ide-cd/ide-cs/ ;-)
On Tuesday 10 July 2007, Marcin Juszkiewicz wrote:
> From: Marcin Juszkiewicz <[EMAIL PROTECTED]>
>
> One card submitted by user.
>
> Signed-off-by: Marcin Juszkiewicz <[EMAIL PROTECTED]>
This patch doesn't apply because o
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/cris/ide-cris.c |2 ++
1 file changed, 2 insertions(+)
Index: b/drivers/ide/cris/ide-cris.c
===
--- a/drivers/ide/cris/ide-cris.c
+++ b/drive
icside_set_speed() happily accepts unsupported transfer modes which
results in drive->drive_data being set to the maximum value (480)
and drive->current_speed being set to the unsupported transfer mode.
Fix it.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Cc:
hy some
of the above bugs remained unfixed for so long).
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Cc: Paul Mackerras <[EMAIL PROTECTED]>
Cc: Kyle McMartin <[EMAIL PROTECTED]>
---
drivers/ide/ppc/pmac.c |
ion.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/amd74xx.c | 15 ---
drivers/ide/pci/via82cxxx.c | 15 ---
2 files changed, 8 insertions(+), 22 deletions(-)
Index: b/drivers/ide/pci/
.
* Use ide_tune_dma() in sgiioc4_ide_dma_check(), this fixes following bugs:
- DMA capability bit not being checked on the device
- DMA blacklist not being checked
- MWDMA2 mode support by device not being checked
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Cc: Jere
d of hwif->autodma (there should be no changes in
behavior as all users of config_drive_for_dma() set both ->autodma flags).
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-dma.c | 26 ++
drivers/ide/pci/ns87415.c |9 ---
Hi,
On Wednesday 11 July 2007, Russell King wrote:
> On Wed, Jul 11, 2007 at 11:07:51PM +0400, Sergei Shtylyov wrote:
> > Hello.
> >
> > Bartlomiej Zolnierkiewicz wrote:
> >
> > >icside_set_speed() happily accepts unsupported transfer modes which
> >
On Wednesday 11 July 2007, Bartlomiej Zolnierkiewicz wrote:
>
> * Add { 0, 0 } entry to {kauai,shasta}_pio_timings[] so kauai_lookup_timing()
> always returns a valid PIO timing (fixes PIO timing not being set for
> devices
> with minimum PIO cycle <= 120ns).
>
> * A
On Wednesday 11 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
>
> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
added
-
To unsubscribe from this list: send the line "unsu
On Thursday 12 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Add sis5513_ata133_udma_filter() for chipset_family >= ATA_133,
> > use it to filter UDMA6 mode if ATA133 bit is disabled.
>
> > * Remove no lon
On Friday 13 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Add DRV_NAME define and use it instead of sgiioc4_chipset.name.
>
> > * Remove no longer needed sgiioc4_chipset.
>
> > * Remove needless clearing
On Friday 13 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Fix cs5535_tuneproc() to pass PIO transfer mode value instead of PIO mode
> > number to cs5535_set_speed() (fixes random PIO timings being programmed
> > and a possible OOPS). D
On Friday 13 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Add { 0, 0 } entry to {kauai,shasta}_pio_timings[] so
> > kauai_lookup_timing()
> > always returns a valid PIO timing (fixes PIO timing not being set for
>
On Friday 13 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Use ide_tune_dma() in amd74xx/via82cxxx driver, this fixes following bugs:
> > - DMA capability bit not being checked on the device
> > - DMA blacklist not being checked
> >
On Thursday 12 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> >>Moreover, I think the patch is quite broken. If an invalid DMA mode
> >>is passed, currently the driver sets the cycle time to 480ns (stored
> >>i
* Use it8213_tuneproc() in it8213_config_drive_for_dma().
v2:
* Remove PIO modes from it8213_dma_2_pio(), they are no longer needed there
(Noticed by Sergei)
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
---
drivers/ide/pc
d-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
---
drivers/ide/pci/piix.c | 17 -
drivers/ide/pci/slc90e66.c | 15 +++
2 files changed, 15 insertions(+), 17 deletions(-)
Index: b/drive
ide_config_drive_speed() called by sc1200_set_xfer_mode() already gives
a meaningful warning message in case of failure.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/sc1200.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: b/drive
_chipset().
* Bump driver version.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/siimage.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
Index: b/drivers/ide
There is no need to do it in cs5520_tune_chipset() (->speedproc method)
since it is correctly handled by cs5520_dma_on() (->ide_dma_on method).
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/cs5520.c | 13 -
1 file changed, 4 inse
Hi,
On Tuesday 10 July 2007, Thomas Backlund wrote:
> Alan Cox skrev:
> >> If you modprobe only sis5513
> >> OR
> >> If you modprobe only sis5513 and then sata_sis/pata_sis:
> >> - you get this:
> >> (the hdb drive does not get detected/usable)
> >
> > Don't mix old and new IDE like that
Hi,
On Friday 13 July 2007, Craig Block wrote:
> > >>Craig Block wrote:
> > >>
> > >>I'm having a problem with the 80-wire/40-wire cable detection
>
> > Jeff Garzik wrote:
> > >
> > >If you signal a 40-wire cable too fast, you get trouble with a
> > >capital T.
>
> Thanks everyone for graciousl
On Friday 13 July 2007, Russell King wrote:
> On Fri, Jul 13, 2007 at 11:02:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > wee, take 3
>
> I'm probably going to drop this driver as soon as the PATA people get
> their finger(s) out and respond to the issues I ra
Hi,
Some more bsg findings...
block/Kconfig:
endif # BLOCK
Shouldn't BLK_DEV_BSG depend on BLOCK?
config BLK_DEV_BSG
bool "Block layer SG support"
depends on (SCSI=y) && EXPERIMENTAL
default y
---help---
Saying Y here will enable generic SG (SCSI gener
On Tuesday 17 July 2007, Andrew Morton wrote:
> On Tue, 17 Jul 2007 22:52:25 +0200
> Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
>
> > ide-{disk,scsi,tape} don't support REQ_TYPE_BLOCK_PC requests et all
> > (so attempts to use SG_IO, CDROM_SEND_PA
Hi,
On Wednesday 18 July 2007, Kumar Gala wrote:
> M: [EMAIL PROTECTED]
> L: linux-ide@vger.kernel.org
>
> We get the following compile error if CONFIG_BLOCK isn't enabled:
>
> CC arch/powerpc/kernel/setup_32.o
> In file included from arch/powerpc/kernel/setup_32.c:14:
> includ
On Wednesday 18 July 2007, FUJITA Tomonori wrote:
> They were fixed. Please check the latest code:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-2.6-block.git bsg
>
> We wait for Linus to pull from it.
It has been merged. Thanks for fixing the mentioned issues.
Thanks,
Bart
-
On Wednesday 18 July 2007, Kumar Gala wrote:
>
> On Jul 18, 2007, at 5:47 AM, Bartlomiej Zolnierkiewicz wrote:
>
> >
> > Hi,
> >
> > On Wednesday 18 July 2007, Kumar Gala wrote:
> >> M: [EMAIL PROTECTED]
> >> L: linux-ide@vger.kernel.
Hi,
On Wednesday 18 July 2007, James Bottomley wrote:
> On Wed, 2007-07-18 at 02:43 +0200, Bartlomiej Zolnierkiewicz wrote:
> > [ James, please remeber to cc: linux-ide on IDE patches, thanks. ]
>
> Blame Andrew ... I assumed he'd be reporting the problem to the relevant
&g
On Tuesday 17 July 2007, Akira Iguchi wrote:
> Workaround for errata A308: turn down the UDMA mode and retry
> the DMA command when the data lost condition is detected.
>
> take2:
> udma_filter() hook is used to limit ATAPI UDMA mode.
>
> Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
> Signed-o
On Saturday 14 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > ide_config_drive_speed() called by sc1200_set_xfer_mode() already gives
> > a meaningful warning message in case of failure.
>
> > Signed-off-by: Bartlomiej
On Saturday 14 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Rename it8213_tuneproc() to it8213_tune_pio() and add it8213_tuneproc()
> > wrapper. Move finding of the best PIO mode to the new wrapper.
>
> > * Add setting of tra
On Saturday 14 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Don't call {piix,slc90e66}_dma_2_pio() for PIO modes in
> > {piix,slc90e66}_tune_chipset().
>
> > * Add PIO1 handling to {piix,slc90e66}_tune_chipset().
>
>
On Saturday 14 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > There is no need to do it in cs5520_tune_chipset() (->speedproc method)
> > since it is correctly handled by cs5520_dma_on() (->ide_dma_on method).
>
> > Signed-off-by:
On Saturday 14 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > [PATCH] icside: fix ->speedproc to return on unsupported modes (take 3)
>
> > * All other implementations of ->speedproc return zero on success
> > and non-zero on fail
On Saturday 14 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Remember to select PIO data transfer (with IORDY monitored) in
> > sil_tune_pio()
> > (->set_pio_mode method) so the controller is always programmed correctly
> >
Hi,
On Saturday 14 July 2007, Craig Block wrote:
>
> --- Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
>
> >
> > Please send the output of hdparm --Istdout for this drive.
> >
> > "idex=ata66" or CONFIG_IDEDMA_IVB=y should also help
On Wednesday 18 July 2007, Bartlomiej Zolnierkiewicz wrote:
> On Tuesday 17 July 2007, Akira Iguchi wrote:
> > Workaround for errata A308: turn down the UDMA mode and retry
> > the DMA command when the data lost condition is detected.
> >
> > take2:
> > udma_fil
PROTECTED]>
> Caused-By : ?
> Handled-By : Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
> Status : unknown
Not a 2.6.22-git regression (CONFIG_BLOCK was added on September 2006) and
Kumar should have a fix really soon - could be removed from the list IMO.
Th
Use ->set_pio_mode method to program PIO modes in ide_set_xfer_rate()
(the only place which used ->speedproc to program PIO modes) and remove
handling of PIO modes from all ->speedproc implementations.
There should be no functionality changes caused by this patch.
Signed-off-by: B
n't disable UDMA bit when programming PIO modes.
* Add FIXME about DMA timings never being set.
* Bump driver version.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/alim15x3.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
Index:
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/it8213.c | 16 ++--
drivers/ide/pci/piix.c | 17 +++--
drivers/ide/pci/slc90e66.c | 17 +++--
3 files changed, 20 insertions(+), 30 deletions(-)
Index: b/drive
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/pci/sis5513.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
Index: b/drivers/ide/pci/sis5513.c
===
--- a/drivers/ide/pci/sis
a_check() then just return "-1" and
don't call icside_set_speed() (v3 got it wrong and "1" was returned instead).
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Cc: Russell King <[EMAIL PROTECTED]>
Cc: Sergei Shtylyov <[EMAIL PROTECTED]>
---
rep
pmac_ide_tune_chipset() don't set drive->init_speed.
Fix it by setting drive->{current,init}_speed in pmac_ide_do_setfeature()
and clean up pmac_ide_{tune_chipset,mdma_enable,udma_enable}().
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolni
ent to separate patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Cc: Sergei Shtylyov <[EMAIL PROTECTED]>
---
replacement patch for the one in IDE quilt tree
drivers/ide/ppc/pmac.c | 15 ++-
1 file chan
kauai_lookup_timing() should always return non-zero return value:
* BUG() in kauai_lookup_timing() if the timing info cannot be found.
* Remove code checking for zero return value from all callers.
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz &
fore the transfer mode
is set on the device - this was pointed out by Sergei). This change makes
pmac_ide_tune_chipset() behavior match this of pmac_ide_{m,u}dma_enable().
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
dr
mings always exist so remove redundant check.
* Make set_timings_mdma() void.
* Update pmac_ide_tune_chipset()'s comment.
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers
pmac_ide_do_setfeature() contains matching nIEN setting/clearing so this
Device Control register messing in pmac_ide_dma_check() is totally unnecessary.
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ppc/p
patch.
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ppc/pmac.c | 101 -
1 file changed, 2 insertions(+), 99 deletions(-)
Index: b/drivers/id
Ishizaki <[EMAIL PROTECTED]>
Cc: Akira Gouache <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
this patch is independent from the previous five ide-pmac patches
drivers/ide/ide-iops.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(
Herrenschmidt <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-iops.c | 96 ++---
include/linux/ide.h| 11 -
2 files changed, 45 insertions(+), 62 deletions(-)
Index: b/drivers/id
AIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ppc/pmac.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
Index: b/drivers/ide/ppc/pmac.c
===
--- a/drivers/ide/pp
e set for good device status).
Also remove no longer needed wait_for_ready() from ide-iops.c.
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ide-iops.c | 31 +--
drivers/ide/
Upper layers are responsible for controlling nIEN so don't clear nIEN after
command execution in pmac_ide_do_setfeature().
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/ppc/pmac.c |1 -
1 file ch
ps than
the only changes in behavior are:
* if PIO mode is set then ->dma_off_queitly is called to disable DMA
* if setting transfer mode fails ide_dump_status() is called to dump status
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTE
On Friday 20 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
>
> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
added
-
To unsubscribe from this list: send the line "unsu
On Friday 20 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
>
> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
added
> &g
On Friday 20 July 2007, Sergei Shtylyov wrote:
> Hi.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Return failure in ->speedproc method for unsupported/invalid transfer
> > modes passed from user-space (fixes theoretical OOPS in ali_tune_pio()
> > and/or s
On Sunday 22 July 2007, Benjamin Herrenschmidt wrote:
> On Sun, 2007-07-22 at 20:19 +0200, Bartlomiej Zolnierkiewicz wrote:
> > pmac_ide_tune_chipset() don't set drive->init_speed.
> >
> > Fix it by setting drive->{current,init}_speed in pmac_ide_do_setfeat
ent to separate patch.
v3:
* Use XFER_PIO_0 not XFER_PIO. (Noticed by Ben)
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Cc: Sergei Shtylyov <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
replacement patch
drivers/ide/ppc/pmac.c | 15 +++
On Sunday 22 July 2007, Benjamin Herrenschmidt wrote:
> On Sun, 2007-07-22 at 20:20 +0200, Bartlomiej Zolnierkiewicz wrote:
> > kauai_lookup_timing() should always return non-zero return value:
> >
> > * BUG() in kauai_lookup_timing() if the timing info cannot be found.
&
1101 - 1200 of 1292 matches
Mail list logo
