Re: [net-next 1/2] ipv6: sr: add a per namespace sysctl to control seg6 flowlabel

2018-04-24 Thread David Miller
From: Ahmed Abdelsalam Date: Mon, 23 Apr 2018 23:36:59 +0200 > This patch adds a per namespace sysctl, named 'seg6_flowlabel', to be used > by seg6_do_srh_encap() to control the behaviour of setting the flowlabel > value of outer IPv6. > > The currently support behaviours are as follows: > -1 se

Re: [RFC] mm: kmemleak: replace __GFP_NOFAIL to GFP_NOWAIT in gfp_kmemleak_mask

2018-04-24 Thread Dmitry Vyukov
On Tue, Apr 24, 2018 at 7:02 PM, Michal Hocko wrote: > On Tue 24-04-18 12:48:50, Chunyu Hu wrote: >> >> >> - Original Message - >> > From: "Michal Hocko" >> > To: "Chunyu Hu" >> > Cc: "Dmitry Vyukov" , "Catalin Marinas" >> > , "Chunyu Hu" >> > , "LKML" , "Linux-MM" >> > >> > Sent: Tue

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

2018-04-24 Thread Eric W. Biederman
Andrey Grodzovsky writes: > On 04/24/2018 12:23 PM, Eric W. Biederman wrote: >> Andrey Grodzovsky writes: >> >>> Avoid calling wait_event_killable when you are possibly being called >>> from get_signal routine since in that case you end up in a deadlock >>> where you are alreay blocked in singla

Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator

2018-04-24 Thread Mark Brown
On Mon, Apr 23, 2018 at 10:46:56PM +0800, Icenowy Zheng wrote: > --- /dev/null > +++ b/drivers/regulator/sy8106a-regulator.c > @@ -0,0 +1,176 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * sy8106a-regulator.c - Regulator device driver for SY8106A Just make the entire thing a C++ comment s

Re: [PATCH v4 7/8] drm/i2c: tda998x: register as a drm bridge

2018-04-24 Thread Russell King - ARM Linux
On Tue, Apr 24, 2018 at 07:04:16PM +0300, Jyri Sarha wrote: > On 24/04/18 13:14, Peter Rosin wrote: > > On 2018-04-24 10:08, Russell King - ARM Linux wrote: > >> On Tue, Apr 24, 2018 at 08:58:42AM +0200, Peter Rosin wrote: > >>> On 2018-04-23 18:08, Russell King - ARM Linux wrote: > On Mon, Ap

Re: vmalloc with GFP_NOFS

2018-04-24 Thread Mikulas Patocka
On Tue, 24 Apr 2018, Michal Hocko wrote: > On Tue 24-04-18 12:46:55, Mikulas Patocka wrote: > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > Hi, > > > it seems that we still have few vmalloc users who perform GFP_NOFS > > > allocation: > > > drivers/mtd/ubi/io.c > > > fs/ext4/xa

Re: [PATCH 7/9] Pmalloc Rare Write: modify selected pools

2018-04-24 Thread Igor Stoppa
On 24/04/18 16:33, Igor Stoppa wrote: On 24/04/18 15:50, Matthew Wilcox wrote: On Mon, Apr 23, 2018 at 04:54:56PM +0400, Igor Stoppa wrote: While the vanilla version of pmalloc provides support for permanently transitioning between writable and read-only of a memory pool, this patch seeks to

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

2018-04-24 Thread Michal Hocko
On Tue 24-04-18 13:00:11, Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > On Tue 24-04-18 11:50:30, Mikulas Patocka wrote: > > > > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > > > On Mon 23-04-18 20:06:16, Mikulas Patocka wrote: > > > > [...] > > >

Re: [RFC] mm: kmemleak: replace __GFP_NOFAIL to GFP_NOWAIT in gfp_kmemleak_mask

2018-04-24 Thread Michal Hocko
On Tue 24-04-18 12:48:50, Chunyu Hu wrote: > > > - Original Message - > > From: "Michal Hocko" > > To: "Chunyu Hu" > > Cc: "Dmitry Vyukov" , "Catalin Marinas" > > , "Chunyu Hu" > > , "LKML" , "Linux-MM" > > > > Sent: Tuesday, April 24, 2018 9:20:57 PM > > Subject: Re: [RFC] mm: kmeml

Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

2018-04-24 Thread Andy Shevchenko
On Tue, 2018-04-24 at 19:15 +0300, Andy Shevchenko wrote: > On Mon, Apr 23, 2018 at 5:48 PM, Gianfranco Costamagna > wrote: > > Hello, > > > > > Can you give your corresponding tag as well? > > > > > > we are implementing the fix right now, please follow bug > > https://bugs.launchpad.net/ubunt

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

2018-04-24 Thread Mikulas Patocka
On Tue, 24 Apr 2018, Michal Hocko wrote: > On Tue 24-04-18 11:50:30, Mikulas Patocka wrote: > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > On Mon 23-04-18 20:06:16, Mikulas Patocka wrote: > > > [...] > > > > @@ -404,6 +405,12 @@ void *kvmalloc_node(size_t size, gfp_t f > > > >

Re: vmalloc with GFP_NOFS

2018-04-24 Thread Michal Hocko
On Tue 24-04-18 12:46:55, Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > Hi, > > it seems that we still have few vmalloc users who perform GFP_NOFS > > allocation: > > drivers/mtd/ubi/io.c > > fs/ext4/xattr.c > > fs/gfs2/dir.c > > fs/gfs2/quota.c > > fs/nfs/blocklayo

[PATCH 2/7] dt-bindings: add generic gnss binding

2018-04-24 Thread Johan Hovold
Describe generic properties for GNSS receivers. Signed-off-by: Johan Hovold --- .../devicetree/bindings/gnss/gnss.txt | 36 +++ MAINTAINERS | 1 + 2 files changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/gn

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-24 Thread Florian Fainelli
On 04/19/2018 01:28 AM, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > In addition the TLK10X needs to be removed from DP83848 driver as the > power back off support is added here for this device. I would not think this i

[PATCH 3/7] gnss: add generic serial driver

2018-04-24 Thread Johan Hovold
Add a generic serial GNSS driver (library) which provides a common implementation for the gnss interface and power management (runtime and system suspend). This allows GNSS drivers for specific chip to be implemented by simply providing a set_power() callback to handle three states: ACTIVE, STANDBY

[PATCH 4/7] dt-bindings: gnss: add u-blox binding

2018-04-24 Thread Johan Hovold
Add binding for u-blox GNSS receivers. Note that the u-blox product names encodes form factor (e.g. "neo"), chipset (e.g. "8") and variant (e.g. "q"), but that only formfactor and chipset is used for the compatible strings (for now). Signed-off-by: Johan Hovold --- .../devicetree/bindings/gnss/

[PATCH 5/7] gnss: add driver for u-blox receivers

2018-04-24 Thread Johan Hovold
Add driver for serial-connected u-blox GNSS receivers. Note that the driver uses the generic GNSS serial implementation and therefore essentially only manages power abstracted into three power states: ACTIVE, STANDBY, and OFF. For u-blox receivers with a single supply and no enable-gpios, this si

[PATCH 0/7] gnss: add new GNSS subsystem

2018-04-24 Thread Johan Hovold
This series adds a new subsystem for GNSS receivers (e.g. GPS receivers). While GNSS receivers are typically accessed using a UART interface they often also support other I/O interfaces such as I2C, SPI and USB, while yet other devices use iomem or even some form of remote-processor messaging (rpm

Re: [tip:x86/urgent] x86/io: Define readq()/writeq() to use 64-bit type

2018-04-24 Thread Andy Shevchenko
On Sat, 2018-03-31 at 20:45 +0200, Ingo Molnar wrote: > * Andy Shevchenko wrote: > > > On Sat, Mar 31, 2018 at 3:06 PM, Andy Shevchenko > > wrote: > > > On Sat, Mar 31, 2018 at 1:22 PM, Ingo Molnar > > > wrote: > > > > * Ingo Molnar wrote: > > > > [tip:x86/urgent 14/14] > > > > drivers/infin

Re: [PATCH v3 02/12] KVM: arm/arm64: Document KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION

2018-04-24 Thread Peter Maydell
On 24 April 2018 at 17:46, Christoffer Dall wrote: > On Fri, Apr 13, 2018 at 10:20:48AM +0200, Eric Auger wrote: >> --- a/Documentation/virtual/kvm/devices/arm-vgic-v3.txt >> +++ b/Documentation/virtual/kvm/devices/arm-vgic-v3.txt >> @@ -27,9 +27,32 @@ Groups: >>VCPU and all of the redistr

[PATCH 6/7] dt-bindings: gnss: add sirfstar binding

2018-04-24 Thread Johan Hovold
Add binding for SiRFstar-based GNSS receivers. Note that while four compatible-strings are initially added representing devices which differ in which I/O interfaces they support, they otherwise essentially share the same feature set. Pin and supply names (and some recommended timings) vary slight

[PATCH 7/7] gnss: add driver for sirfstar-based receivers

2018-04-24 Thread Johan Hovold
Add driver for serial-connected SiRFstar-based GNSS receivers. These devices typically boot into hibernate mode from which they can be woken using a pulse on the ON_OFF (enable) input pin. Once active, a pulse on the same ON_OFF pin is used to put the device back into hibernate mode. The current s

Re: [PATCH 1/3] signals: Allow generation of SIGKILL to exiting task.

2018-04-24 Thread Andrey Grodzovsky
On 04/24/2018 12:42 PM, Eric W. Biederman wrote: Andrey Grodzovsky writes: Currently calling wait_event_killable as part of exiting process will stall forever since SIGKILL generation is suppresed by PF_EXITING. In our partilaur case AMDGPU driver wants to flush all GPU jobs in flight befor

[PATCH 1/7] gnss: add GNSS receiver subsystem

2018-04-24 Thread Johan Hovold
Add a new subsystem for GNSS (e.g. GPS) receivers. While GNSS receivers are typically accessed using a UART interface they often also support other I/O interfaces such as I2C, SPI and USB, while yet other devices use iomem or even some form of remote-processor messaging (rpmsg). The new GNSS subs

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-24 Thread Srinivas Kandagatla
Thanks for the review. On 24/04/18 17:25, Rob Herring wrote: On Wed, Apr 18, 2018 at 04:31:55PM +0100, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla Add devicetree bindings documentation file for Qualcomm apq8096 sound card. Signed-off-by: Srinivas Kandagatla --- .../dev

Re: [RFC] mm: kmemleak: replace __GFP_NOFAIL to GFP_NOWAIT in gfp_kmemleak_mask

2018-04-24 Thread Chunyu Hu
- Original Message - > From: "Michal Hocko" > To: "Chunyu Hu" > Cc: "Dmitry Vyukov" , "Catalin Marinas" > , "Chunyu Hu" > , "LKML" , "Linux-MM" > > Sent: Tuesday, April 24, 2018 9:20:57 PM > Subject: Re: [RFC] mm: kmemleak: replace __GFP_NOFAIL to GFP_NOWAIT in > gfp_kmemleak_mask >

Re: hrtimer (rdmavt RNR timer) was lost

2018-04-24 Thread Frederic Weisbecker
On Tue, Apr 24, 2018 at 04:54:58PM +0200, Thomas Gleixner wrote: > On Mon, 23 Apr 2018, Thomas Gleixner wrote: > > On Mon, 23 Apr 2018, Wan, Kaike wrote: > > > > Can you apply the following debug patch and enable the hrtimer_start > > > > trace > > > > point and send me the full trace or upload it

Re: [PATCH v5 1/2] char: sparc64: Add privileged ADI driver

2018-04-24 Thread Tom Hromatka
On 04/23/2018 11:52 AM, Greg KH wrote: On Mon, Apr 23, 2018 at 11:33:31AM -0600, Tom Hromatka wrote: SPARC M7 and newer processors utilize ADI to version and protect memory. This driver is capable of reading/writing ADI/MCD versions from privileged user space processes. Addresses in the adi f

Re: [PATCH v4 4/9] vsprintf: Consolidate handling of unknown pointer specifiers

2018-04-24 Thread Andy Shevchenko
On Wed, 2018-04-11 at 11:52 +0200, Petr Mladek wrote: > On Tue 2018-04-10 14:41:55, Andy Shevchenko wrote: > > On Mon, 2018-04-09 at 15:50 +0200, Petr Mladek wrote: > > > On Sat 2018-04-07 17:26:40, Andy Shevchenko wrote: > > I think about 1-7 and 9 that can go as is before your changes. > > And p

Re: [PATCH v3 06/12] KVM: arm/arm64: Helper to register a new redistributor region

2018-04-24 Thread Christoffer Dall
On Fri, Apr 13, 2018 at 10:20:52AM +0200, Eric Auger wrote: > We introduce a new helper that creates and inserts a new redistributor > region into the rdist region list. This helper both handles the case > where the redistributor region size is known at registration time > and the legacy case where

Re: vmalloc with GFP_NOFS

2018-04-24 Thread Mikulas Patocka
On Tue, 24 Apr 2018, Michal Hocko wrote: > Hi, > it seems that we still have few vmalloc users who perform GFP_NOFS > allocation: > drivers/mtd/ubi/io.c > fs/ext4/xattr.c > fs/gfs2/dir.c > fs/gfs2/quota.c > fs/nfs/blocklayout/extent_tree.c > fs/ubifs/debug.c > fs/ubifs/lprops.c > fs/ubifs/lpt_co

Re: [PATCH v3 02/12] KVM: arm/arm64: Document KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION

2018-04-24 Thread Christoffer Dall
On Fri, Apr 13, 2018 at 10:20:48AM +0200, Eric Auger wrote: > We introduce a new KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION attribute in > KVM_DEV_ARM_VGIC_GRP_ADDR group. It allows userspace to provide the > base address and size of a redistributor region > > Compared to KVM_VGIC_V3_ADDR_TYPE_REDIST, th

[PATCH v6] fs: dax: Adding new return type vm_fault_t

2018-04-24 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. commit 1c8f422059ae ("mm: change return type to vm_fault_t") There was an

Re: [PATCH 1/3] signals: Allow generation of SIGKILL to exiting task.

2018-04-24 Thread Eric W. Biederman
Andrey Grodzovsky writes: > Currently calling wait_event_killable as part of exiting process > will stall forever since SIGKILL generation is suppresed by PF_EXITING. > > In our partilaur case AMDGPU driver wants to flush all GPU jobs in > flight before shutting down. But if some job hangs the pi

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

2018-04-24 Thread Andrey Grodzovsky
On 04/24/2018 12:23 PM, Eric W. Biederman wrote: Andrey Grodzovsky writes: Avoid calling wait_event_killable when you are possibly being called from get_signal routine since in that case you end up in a deadlock where you are alreay blocked in singla processing any trying to wait on a new si

Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel

2018-04-24 Thread Rob Herring
On Thu, Apr 19, 2018 at 05:32:23PM +0800, Chen-Yu Tsai wrote: > This panel is marketed as Banana Pi 7" LCD display. On the back is > a sticker denoting the model name S070WV20-CT16. > > This is a 7" 800x480 panel connected through a 24-bit RGB interface. > However the panel only does 262k colors.

Re: [patch V3 00/10] rslib: Cleanup and VLA removal

2018-04-24 Thread Kees Cook
On Sun, Apr 22, 2018 at 9:23 AM, Thomas Gleixner wrote: > Kees tried to get rid of the Variable Length Arrays in the Reed-Solomon > library by replacing them with fixed length arrays on stack. Though they > are rather large and Andrew did not fall in love with that solution. > > This series addres

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Halil Pasic
On 04/24/2018 11:59 AM, Cornelia Huck wrote: On Tue, 24 Apr 2018 10:40:56 +0200 Pierre Morel wrote: On 24/04/2018 08:54, Dong Jia Shi wrote: * Pierre Morel [2018-04-19 16:48:04 +0200]: [...] @@ -94,9 +83,15 @@ static void vfio_ccw_sch_io_todo(struct work_struct *work) static void v

Re: [PATCH 1/1] tools: power/acpi, revert to LD = gcc

2018-04-24 Thread Martin Kelly
On Tue, Apr 24, 2018 at 12:43 AM, Jiri Slaby wrote: > Commit 7ed1c1901fe5 (tools: fix cross-compile var clobbering) removed > setting of LD to $(CROSS_COMPILE)gcc. This broke build of acpica > (acpidump) in power/acpi: > ld: unrecognized option '-D_LINUX' > > The tools pass CFLAGS to the linker (

Re: [PATCH 3/3] drm/amdgpu: Switch to interrupted wait to recover from ring hang.

2018-04-24 Thread Andrey Grodzovsky
On 04/24/2018 12:14 PM, Eric W. Biederman wrote: Andrey Grodzovsky writes: If the ring is hanging for some reason allow to recover the waiting by sending fatal signal. Originally-by: David Panariti Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 14 +++

Re: [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property

2018-04-24 Thread Rob Herring
On Thu, Apr 19, 2018 at 11:31:03AM +0200, Jacopo Mondi wrote: > The THC63LVD1024 LVDS to RGB bridge supports two different input mapping > modes, selectable by means of an external pin. > > Describe the LVDS mode map through a newly defined mandatory property in > device tree bindings. > > Signed

Re: [PATCH] net: phy: allow scanning busses with missing phys

2018-04-24 Thread Florian Fainelli
On 04/24/2018 09:09 AM, Alexandre Belloni wrote: > Some MDIO busses will error out when trying to read a phy address with no > phy present at that address. In that case, probing the bus will fail > because __mdiobus_register() is scanning the bus for all possible phys > addresses. > > In case MI

Re: [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type

2018-04-24 Thread Sergei Shtylyov
Hello! On 04/24/2018 04:17 PM, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signe

Re: [PATCH 2/3] ASoC: AMD: Move clk enable from hw_params/free to startup/shutdown

2018-04-24 Thread Daniel Kurtz
On Mon, Apr 23, 2018 at 9:03 PM Vijendar Mukunda wrote: > From: Akshu Agrawal > hw_param can be called multiple times and thus we can have > more clk enable. The clk may not get diabled due to refcounting. > startup/shutdown ensures single clk enable/disable call. > Signed-off-by: Akshu Agrawa

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-24 Thread Rob Herring
On Thu, Apr 19, 2018 at 10:28:16AM +0200, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > In addition the TLK10X needs to be removed from DP83848 driver as the > power back off support is added here for this device. > > Data

Re: KASAN: use-after-free Read in alloc_pid

2018-04-24 Thread Eric W. Biederman
Tetsuo Handa writes: > On 2018/04/10 23:33, Tetsuo Handa wrote: >> syzbot wrote: >>> syzbot has found reproducer for the following crash on upstream commit >>> c18bb396d3d261ebbb4efbc05129c5d354c541e4 (Tue Apr 10 00:04:10 2018 +) >>> Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/n

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-24 Thread Mikulas Patocka
On Tue, 24 Apr 2018, Michal Hocko wrote: > On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > On Mon 23-04-18 20:25:15, Mikulas Patocka wrote: > > > > > > > Fixing __vmalloc code > > > > is easy and it doesn't require cooperation

Re: [PATCH 3/3] drm/amdgpu: Switch to interrupted wait to recover from ring hang.

2018-04-24 Thread Eric W. Biederman
"Panariti, David" writes: > Andrey Grodzovsky writes: >> Kind of dma_fence_wait_killable, except that we don't have such API >> (maybe worth adding ?) > Depends on how many places it would be called, or think it might be called. > Can always factor on the 2nd time it's needed. > Factoring, IMO

[PATCH 2/3] powerpc/nohash: remove _PAGE_BUSY

2018-04-24 Thread Christophe Leroy
_PAGE_BUSY is always 0, remove it Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/64/pgtable.h | 10 +++--- arch/powerpc/include/asm/nohash/pte-book3e.h | 5 - 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/include/asm/nohash/64/pgtable.

[PATCH 3/3] powerpc/nohash: use IS_ENABLED() to simplify __set_pte_at()

2018-04-24 Thread Christophe Leroy
By using IS_ENABLED() we can simplify __set_pte_at() by removing redundant *ptep = pte Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/pgtable.h | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/arch/powerpc/include/asm/nohash/pgtabl

[PATCH 1/3] powerpc/nohash: remove hash related code from nohash headers.

2018-04-24 Thread Christophe Leroy
When nohash and book3s header were split, some hash related stuff remained in the nohash header. This patch removes them. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/32/pgtable.h | 29 +++-- arch/powerpc/include/asm/nohash/64/pgtable.h | 16 ++-- a

Re: [PATCH v2 2/2] tpm: reduce polling time to usecs for even finer granularity

2018-04-24 Thread Jarkko Sakkinen
On Tue, Apr 17, 2018 at 09:12:46AM -0400, Nayna Jain wrote: > The TPM burstcount and status commands are supposed to return very > quickly [1][2]. This patch further reduces the TPM poll sleep time to usecs > in get_burstcount() and wait_for_tpm_stat() by calling usleep_range() > directly. > > Aft

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-24 Thread Michal Hocko
On Tue 24-04-18 10:12:42, Michal Hocko wrote: > On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > On Mon 23-04-18 20:25:15, Mikulas Patocka wrote: > > > > > > > Fixing __vmalloc code > > > > is easy and it doesn't require cooperatio

Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

2018-04-24 Thread Jae Hyun Yoo
On 4/24/2018 9:01 AM, Andy Shevchenko wrote: On Tue, 2018-04-10 at 11:32 -0700, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus core into linux driver framework. All comments you got for patch 6 are applicable here. And perhaps in the rest of the series. The rule of

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

2018-04-24 Thread Michal Hocko
On Tue 24-04-18 11:50:30, Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > On Mon 23-04-18 20:06:16, Mikulas Patocka wrote: > > [...] > > > @@ -404,6 +405,12 @@ void *kvmalloc_node(size_t size, gfp_t f > > >*/ > > > WARN_ON_ONCE((flags & GFP_KERNEL) != GFP_KERNEL

Re: kernel BUG at fs/f2fs/node.c:LINE!

2018-04-24 Thread Jaegeuk Kim
On 04/24, Dmitry Vyukov wrote: > On Tue, Apr 24, 2018 at 8:42 AM, syzbot > wrote: > > Hello, > > > > syzbot tried to test the proposed patch but build/boot failed: > > > > failed to create VM pool: failed to create GCE image: failed to get create > > image operation operation-1524552040215-56a926e

Re: [PATCH v2 1/2] tpm: reduce poll sleep time in tpm_transmit()

2018-04-24 Thread Jarkko Sakkinen
On Tue, Apr 17, 2018 at 09:12:45AM -0400, Nayna Jain wrote: > The TPM polling code in tpm_transmit sleeps in each loop iteration for > 5 msecs. However, the TPM might return earlier, and thus waiting for > 5 msecs adds an unnecessary delay. This patch reduces the polling sleep > time in tpm_transmi

Re: [PATCH 1/3] dt-bindings: iio: stm32-adc: add support for STM32MP1.

2018-04-24 Thread Rob Herring
On Wed, Apr 18, 2018 at 05:37:52PM +0200, Fabrice Gasnier wrote: > Document support for STM32MP1 ADC. It's quite similar to STM32H7 ADC. > Introduce "st,stm32mp1-adc" compatible to handle variants of this > hardware such as vregready flag, interrupts, clock rate. > > Signed-off-by: Fabrice Gasnier

vmalloc with GFP_NOFS

2018-04-24 Thread Michal Hocko
Hi, it seems that we still have few vmalloc users who perform GFP_NOFS allocation: drivers/mtd/ubi/io.c fs/ext4/xattr.c fs/gfs2/dir.c fs/gfs2/quota.c fs/nfs/blocklayout/extent_tree.c fs/ubifs/debug.c fs/ubifs/lprops.c fs/ubifs/lpt_commit.c fs/ubifs/orphan.c Unfortunatelly vmalloc doesn't suppoer G

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

2018-04-24 Thread Jae Hyun Yoo
Hi Andy, Thanks a lot for your review. Please check my inline answers. On 4/24/2018 8:56 AM, Andy Shevchenko wrote: On Tue, 2018-04-10 at 11:32 -0700, Jae Hyun Yoo wrote: drivers/hwmon/peci-cputemp.c | 783 ++ drivers/hwmon/peci-dimmtemp.c | 432 +++

Re: [PATCH v4 1/3] dell-led: Change dell-led.h to dell-common.h

2018-04-24 Thread Takashi Iwai
On Fri, 20 Apr 2018 11:44:30 +0200, Kai-Heng Feng wrote: > > This header will be used for more than just led. Change it to a more > generic name. > > Cc: Mario Limonciello > Signed-off-by: Kai-Heng Feng BTW, wouldn't it be better postpone the rename? Renaming a file in a cross-tree patchset ma

Re: Regression 4.17-rc1: SSD doesnʼt properly resume causing system hang (NULL pointer dereference)

2018-04-24 Thread Bart Van Assche
On Tue, 2018-04-24 at 18:14 +0200, Paul Menzel wrote: > Since Linux 4.17-rc1, resume from ACPI on the Lenovo X60 fails because > of a NULL pointer dereference. As the drive doesn’t come back, messages > can be seen on the display, but the system cannot be controlled anymore, > and has to be forc

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-24 Thread Rob Herring
On Wed, Apr 18, 2018 at 04:31:55PM +0100, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > Add devicetree bindings documentation file for Qualcomm apq8096 sound card. > > Signed-off-by: Srinivas Kandagatla > --- > .../devicetree/bindings/sound/qcom,apq8096.txt | 76 >

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

2018-04-24 Thread Eric W. Biederman
Andrey Grodzovsky writes: > Avoid calling wait_event_killable when you are possibly being called > from get_signal routine since in that case you end up in a deadlock > where you are alreay blocked in singla processing any trying to wait > on a new signal. I am curious what the call path that is

Re: [RESEND PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

2018-04-24 Thread Andy Shevchenko
On Tue, Apr 24, 2018 at 10:44 AM, Kirill Marinushkin wrote: > In the current implementation, vchi_instance is inited during the first > call of bcm2835_audio_open_connection(), and is never freed. It causes a > memory leak when the module `snd_bcm2835` is removed. > Signed-off-by: Kirill Marinus

Re: [PATCH v2 3/5] ALSA: xen-front: Implement Xen event channel handling

2018-04-24 Thread Oleksandr Andrushchenko
On 04/24/2018 06:02 PM, Takashi Iwai wrote: On Tue, 24 Apr 2018 16:58:43 +0200, Oleksandr Andrushchenko wrote: On 04/24/2018 05:35 PM, Takashi Iwai wrote: On Tue, 24 Apr 2018 16:29:15 +0200, Oleksandr Andrushchenko wrote: On 04/24/2018 05:20 PM, Takashi Iwai wrote: On Mon, 16 Apr 2018 08:24:5

Re: [PATCH 3/3] drm/amdgpu: Switch to interrupted wait to recover from ring hang.

2018-04-24 Thread Panariti, David
> Kind of dma_fence_wait_killable, except that we don't have such API > (maybe worth adding ?) Depends on how many places it would be called, or think it might be called. Can always factor on the 2nd time it's needed. Factoring, IMO, rarely hurts. The factored function can easily be visited usi

Re: [PATCH v5 06/23] ASoC: qdsp6: dt-bindings: Add q6asm dt bindings

2018-04-24 Thread Srinivas Kandagatla
Thanks for the review comments, On 24/04/18 17:17, Rob Herring wrote: On Wed, Apr 18, 2018 at 04:31:40PM +0100, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch add DT bindings for ASM (Audio Stream Manager) DSP module. Signed-off-by: Srinivas Kandagatla Reviewed-a

[PATCH] of: overlay: Stop leaking resources on overlay removal

2018-04-24 Thread Jan Kiszka
Only the overlay notifier callbacks have a chance to potentially get hold of references to those two resources, but they do not store them. So it is safe to stop the intentional leaking. See also https://lkml.org/lkml/2018/4/23/1063 and following. Signed-off-by: Jan Kiszka --- Ideally, we sort

[PATCH] crypto: remove Speck

2018-04-24 Thread Jason A. Donenfeld
This NSA-designed cipher was rejected for inclusion in international standards by ISO/IEC. Before anyone actually starts using it by accident, let's just not ship it at all. Signed-off-by: Jason A. Donenfeld --- arch/arm/crypto/Kconfig |6 - arch/arm/crypto/Makefile|

[PATCH v2] sc16is7xx: Check for an error when the clock is enabled.

2018-04-24 Thread Stefan Potyra
When the clock is enabled, check if there is an error. Otherwise clk_get_rate() can be called without enabled clock. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 0814e8d5da2b ("sc16is7xx: enable the clock") Signed-off-by: Stefan Potyra --- drivers/tty/serial/sc16is7xx.c

Re: [net-next regression] kselftest failure in fib_nl_newrule()

2018-04-24 Thread Roopa Prabhu
On Tue, Apr 24, 2018 at 2:46 AM, Anders Roxell wrote: > Hi, > > fib-onlink-tests.sh (from kselftest) found a regression between > next-20180424 [1] (worked with tag next-20180423 [2]) > > here is tree commits that look suspicious specially this patch (sha: > f9d

Re: [PATCH v5 06/23] ASoC: qdsp6: dt-bindings: Add q6asm dt bindings

2018-04-24 Thread Rob Herring
On Wed, Apr 18, 2018 at 04:31:40PM +0100, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > This patch add DT bindings for ASM (Audio Stream Manager) DSP module. > > Signed-off-by: Srinivas Kandagatla > Reviewed-and-tested-by: Rohit kumar > --- > .../devicetree/bindings/so

[PATCH v2] spi/bcm63xx-hspi: Enable the clock before calling clk_get_rate().

2018-04-24 Thread Stefan Potyra
Enable the clock prior to calling clk_get_rate(), because clk_get_rate() should only be called if the clock is enabled. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 142168eba9dc (spi: "bcm63xx-hsspi: add bcm63xx HSSPI driver") Signed-off-by: Stefan Potyra --- drivers/sp

Re: [PATCH 3/3] drm/amdgpu: Switch to interrupted wait to recover from ring hang.

2018-04-24 Thread Eric W. Biederman
Andrey Grodzovsky writes: > If the ring is hanging for some reason allow to recover the waiting > by sending fatal signal. > > Originally-by: David Panariti > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 14 ++ > 1 file changed, 10 insertions(+

Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

2018-04-24 Thread Andy Shevchenko
On Mon, Apr 23, 2018 at 5:48 PM, Gianfranco Costamagna wrote: > Hello, > >>Can you give your corresponding tag as well? > > > we are implementing the fix right now, please follow bug > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1766054 OK, I postpone this patch until new version. -- W

Re: [PATCH v5 05/23] ASoC: qdsp6: dt-bindings: Add q6adm dt bindings

2018-04-24 Thread Rob Herring
On Wed, Apr 18, 2018 at 04:31:39PM +0100, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > This patch add DT bindings for ADM (Audio Device Manager) DSP module. > This module implements mixer controls to setup the connections between > AFE ports and ASM streams. > > Signed-o

Re: [PATCH v5 04/23] ASoC: qdsp6: dt-bindings: Add q6afe dt bindings

2018-04-24 Thread Rob Herring
On Wed, Apr 18, 2018 at 04:31:38PM +0100, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > This patch add DT bindings for AFE (Audio Frontend) DSP module. > > Signed-off-by: Srinivas Kandagatla > Reviewed-and-tested-by: Rohit kumar > --- > .../devicetree/bindings/sound/qc

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-24 Thread Michal Hocko
On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > On Mon 23-04-18 20:25:15, Mikulas Patocka wrote: > > > > > Fixing __vmalloc code > > > is easy and it doesn't require cooperation with maintainers. > > > > But it is a hack against the intent

Re: [RFC work-in-progress 5/7] !WIP ARM: davinci: convert da850 to using the davinci clocksource driver

2018-04-24 Thread Bartosz Golaszewski
2018-04-24 10:10 GMT+02:00 Sekhar Nori : > On Tuesday 24 April 2018 12:08 AM, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski >> >> Signed-off-by: Bartosz Golaszewski >> --- >> arch/arm/mach-davinci/da850.c | 15 +++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/arch

[PATCH] dma-debug: Check scatterlist segments

2018-04-24 Thread Robin Murphy
Drivers/subsystems creating scatterlists for DMA should be taking care to respect the scatter-gather limitations of the appropriate device, as described by dma_parms. A DMA API implementation cannot feasibly split a scatterlist into *more* entries than originally passed, so it is not well defined w

Re: [PATCH 1/3] signals: Allow generation of SIGKILL to exiting task.

2018-04-24 Thread Eric W. Biederman
Andrey Grodzovsky writes: > Currently calling wait_event_killable as part of exiting process > will stall forever since SIGKILL generation is suppresed by PF_EXITING. > > In our partilaur case AMDGPU driver wants to flush all GPU jobs in > flight before shutting down. But if some job hangs the pi

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

2018-04-24 Thread David Lechner
On 04/24/2018 03:28 AM, Sekhar Nori wrote: On Monday 23 April 2018 08:29 PM, David Lechner wrote: On 04/06/2018 11:46 AM, Stephen Boyd wrote: Quoting Sekhar Nori (2018-04-06 02:37:03) Can you please check that and confirm there is no issue with genpd and using CLK_OF_DECLARE() to initialize c

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

2018-04-24 Thread Rui Miguel Silva
Hi Fabio, On Tue 24 Apr 2018 at 15:53, Fabio Estevam wrote: Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: Add device tree binding documentation for the OV2680 camera sensor. Reviewed-by: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva --- ...

Re: [PATCH] kmemleak: Report if we need to tune KMEMLEAK_EARLY_LOG_SIZE

2018-04-24 Thread Jan Kiszka
On 2018-04-24 17:55, Catalin Marinas wrote: > On Tue, Apr 24, 2018 at 05:51:15PM +0200, Jan Kiszka wrote: >> ...rather than just mysteriously disabling it. >> >> Signed-off-by: Jan Kiszka >> --- >> mm/kmemleak.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/mm/kmemleak.c b/mm/kmemle

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-24 Thread Alan Tull
On Tue, Apr 24, 2018 at 12:29 AM, Jan Kiszka wrote: > On 2018-04-24 00:38, Frank Rowand wrote: >> Hi Jan, >> >> + Alan Tull for fpga perspective >> >> On 04/22/18 03:30, Jan Kiszka wrote: >>> On 2018-04-11 07:42, Jan Kiszka wrote: On 2018-04-05 23:12, Rob Herring wrote: > On Thu, Apr 5, 2

[PATCH] net: phy: allow scanning busses with missing phys

2018-04-24 Thread Alexandre Belloni
Some MDIO busses will error out when trying to read a phy address with no phy present at that address. In that case, probing the bus will fail because __mdiobus_register() is scanning the bus for all possible phys addresses. In case MII_PHYSID1 returns -EIO or -ENODEV, consider there is no phy at

Re: [PATCH] Makefile: Fix typo s/HOST_LOADLIBES/HOST_LOADLIBS

2018-04-24 Thread Masahiro Yamada
2018-04-25 0:59 GMT+09:00 Sedat Dilek : >> Masahiro Yamada hat am 24. April 2018 um >> 17:51 geschrieben: >> >> >> 2018-04-24 17:44 GMT+09:00 Sedat Dilek : >> > Signed-off-by: Sedat Dilek >> > --- >> > Makefile | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git

Re: [PATCH 37/61] perf: simplify getting .drvdata

2018-04-24 Thread Will Deacon
On Thu, Apr 19, 2018 at 04:06:07PM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang > --- > > Build tested only. buildbot is happy. Please apply individually. Thanks, W

Re: [PATCH v3 2/5] efi: Add embedded peripheral firmware support

2018-04-24 Thread Mimi Zohar
On Tue, 2018-04-24 at 17:09 +0200, Hans de Goede wrote: > Hi, > > On 23-04-18 23:11, Luis R. Rodriguez wrote: > > Hans, please see use of READING_FIRMWARE_PREALLOC_BUFFER, we'll need a new > > ID > > and security for this type of request so IMA can reject it if the policy is > > configured for it

Re: [PATCH] rave-sp: Remove VLA

2018-04-24 Thread Kees Cook
On Mon, Apr 23, 2018 at 10:43 PM, Lee Jones wrote: > On Mon, 23 Apr 2018, Kyle Spiers wrote: > >> As part of the effort to remove VLAs from the kernel[1], this creates >> constants for the checksum lengths of CCITT and 8B2C and changes >> crc_calculated to be the maximum size of a checksum. >> >>

Re: simplify procfs code for seq_file instances

2018-04-24 Thread Christoph Hellwig
On Tue, Apr 24, 2018 at 08:19:16AM -0700, Andrew Morton wrote: > > > I want to ask if it is time to start using poorman function overloading > > > with _b_c_e(). There are millions of allocation functions for example, > > > all slightly difference, and people will add more. Seeing /proc interfaces

Re: [PATCH] powerpc/signal32: Use fault_in_pages_readable() to prefault user context

2018-04-24 Thread Christophe LEROY
Le 24/04/2018 à 16:50, Mathieu Malaterre a écrit : On Tue, Apr 24, 2018 at 4:45 PM, Mathieu Malaterre wrote: On Tue, Apr 24, 2018 at 4:17 PM, Christophe Leroy wrote: Use fault_in_pages_readable() to prefault user context instead of open coding Signed-off-by: Christophe Leroy --- arch/po

Re: [PATCH v4 7/8] drm/i2c: tda998x: register as a drm bridge

2018-04-24 Thread Jyri Sarha
On 24/04/18 13:14, Peter Rosin wrote: > On 2018-04-24 10:08, Russell King - ARM Linux wrote: >> On Tue, Apr 24, 2018 at 08:58:42AM +0200, Peter Rosin wrote: >>> On 2018-04-23 18:08, Russell King - ARM Linux wrote: On Mon, Apr 23, 2018 at 09:23:00AM +0200, Peter Rosin wrote: > static int t

Re: [PATCH v5 01/23] soc: qcom dt-bindings: Add APR bus bindings

2018-04-24 Thread Srinivas Kandagatla
Thanks for the review comments, On 24/04/18 16:52, Rob Herring wrote: On Wed, Apr 18, 2018 at 04:31:35PM +0100, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch add dt bindings for Qualcomm APR (Asynchronous Packet Router) bus driver. This bus is used for communicati

[PATCH v2] powerpc/signal32: Use fault_in_pages_readable() to prefault user context

2018-04-24 Thread Christophe Leroy
Use fault_in_pages_readable() to prefault user context instead of open coding Signed-off-by: Christophe Leroy --- v2: using sizeof(*ctx) as size of ctx instead of 1 arch/powerpc/kernel/signal_32.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/ke

Re: [PATCH] tpm: tpm_crb: relinquish locality on error path.

2018-04-24 Thread Jarkko Sakkinen
On Fri, Apr 20, 2018 at 01:19:12PM +, Winkler, Tomas wrote: > > > On Tue, 2018-04-10 at 09:00 +, Winkler, Tomas wrote: > > > > > > > > > > On Sat, 2018-04-07 at 19:12 +0300, Tomas Winkler wrote: > > > > > > In crb_map_io() function, __crb_request_locality() is called > > > > > > prior to cr

Re: [PATCH 58/61] video: fbdev: omap2: omapfb: displays: simplify getting .drvdata

2018-04-24 Thread Bartlomiej Zolnierkiewicz
On Thursday, April 19, 2018 04:06:28 PM Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D

Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

2018-04-24 Thread Andy Shevchenko
On Tue, 2018-04-10 at 11:32 -0700, Jae Hyun Yoo wrote: > This commit adds driver implementation for PECI bus core into linux > driver framework. > All comments you got for patch 6 are applicable here. And perhaps in the rest of the series. The rule of thumb: when you get even single comment in

Re: [RFC v4 3/4] irqflags: Avoid unnecessary calls to trace_ if you can

2018-04-24 Thread Joel Fernandes
On Tue, Apr 24, 2018 at 8:56 AM, Paul E. McKenney wrote: > On Mon, Apr 23, 2018 at 05:22:44PM -0400, Steven Rostedt wrote: >> On Mon, 23 Apr 2018 13:12:21 -0400 (EDT) >> Mathieu Desnoyers wrote: >> >> >> > I'm inclined to explicitly declare the tracepoints with their given >> > synchronization me

<    1   2   3   4   5   6   7   8   9   10   >