Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase in several files

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 10:07:14AM +0200, Fabio M. De Francesco wrote: > Remove camelcase in a symbol that is used by several files. What symbol? > --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h > +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h > @@ -203,7 +203,7 @@ struct pwrctrl_pr

Re: [PATCH] staging: rtl8712: removed unnecessary blank line

2021-04-08 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [RFC PATCH 24/37] mm: implement speculative handling in __do_fault()

2021-04-08 Thread Michel Lespinasse
On Thu, Apr 08, 2021 at 08:13:43AM +0100, Matthew Wilcox wrote: > On Thu, Apr 08, 2021 at 09:00:26AM +0200, Peter Zijlstra wrote: > > On Wed, Apr 07, 2021 at 10:27:12PM +0100, Matthew Wilcox wrote: > > > Doing I/O without any lock held already works; it just uses the file > > > refcount. It would

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

2021-04-08 Thread Greg Kroah-Hartman
On Thu, Apr 08, 2021 at 11:28:09AM +0300, Heikki Krogerus wrote: > On Wed, Apr 07, 2021 at 05:15:40PM +0800, Zhen Lei wrote: > > Fixes the following W=1 kernel build warning: > > > > drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined > > but not used [-Wunused-const-variab

Re: [RFC Part1 PATCH 08/13] x86/sev-es: register GHCB memory when SEV-SNP is active

2021-04-08 Thread Borislav Petkov
On Wed, Mar 24, 2021 at 11:44:19AM -0500, Brijesh Singh wrote: > @@ -88,6 +89,13 @@ struct sev_es_runtime_data { >* is currently unsupported in SEV-ES guests. >*/ > unsigned long dr7; > + > + /* > + * SEV-SNP requires that the GHCB must be registered before using it.

Re: [PATCH] staging: rtl8712: remove unused variable from rtl871x_mlme.c

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 10:33:12AM +0200, Sergei Krainov wrote: > Remove unused variable from rtl871x_mlme.c. > > No side effects can be seen locally or in r8712_find_network() > > Signed-off-by: Sergei Krainov > --- > drivers/staging/rtl8712/rtl871x_mlme.c | 9 + > 1 file changed, 1 in

[PATCH] selinux:Delete selinux_xfrm_policy_lookup() useless argument

2021-04-08 Thread  Zhongjun Tan
From: Zhongjun Tan Delete selinux selinux_xfrm_policy_lookup() useless argument. Signed-off-by: Zhongjun Tan --- include/linux/lsm_hook_defs.h | 3 +-- include/linux/security.h| 4 ++-- net/xfrm/xfrm_policy.c | 6 ++ security/security.c | 4 ++-- security/sel

Re: [PATCH v4 08/16] KVM: x86/pmu: Add IA32_DS_AREA MSR emulation to manage guest DS buffer

2021-04-08 Thread Xu, Like
On 2021/4/8 15:52, Peter Zijlstra wrote: On Thu, Apr 08, 2021 at 01:39:49PM +0800, Xu, Like wrote: Hi Peter, Thanks for your detailed comments. If you have more comments for other patches, please let me know. On 2021/4/7 23:39, Peter Zijlstra wrote: On Mon, Mar 29, 2021 at 01:41:29PM +0800,

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

2021-04-08 Thread Heikki Krogerus
On Thu, Apr 08, 2021 at 10:38:15AM +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 08, 2021 at 11:28:09AM +0300, Heikki Krogerus wrote: > > On Wed, Apr 07, 2021 at 05:15:40PM +0800, Zhen Lei wrote: > > > Fixes the following W=1 kernel build warning: > > > > > > drivers/usb/typec/tcpm/tcpm.c:2107:39

[PATCH] drm/panel: panel-dsi-cm: convert sysfs snprint to sysfs_emit

2021-04-08 Thread Carlis
From: Xuezhi Zhang Fix the following coccicheck warning: drivers/gpu/drm//panel/panel-dsi-cm.c:271:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm//panel/panel-dsi-cm.c:251:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Xuezhi Zhang --- drivers/gpu/drm/panel/panel-dsi-cm.c |

Re: [PATCH net-next v9 1/2] net: Add a WWAN subsystem

2021-04-08 Thread Loic Poulain
Hi Dan, On Wed, 7 Apr 2021 at 16:32, Dan Williams wrote: > > On Mon, 2021-04-05 at 11:52 +0200, Loic Poulain wrote: > > This change introduces initial support for a WWAN framework. Given > > the > > complexity and heterogeneity of existing WWAN hardwares and > > interfaces, > > there is no strict

Re: [PATCH v2 1/2] x86/sgx: Do not update sgx_nr_free_pages in sgx_setup_epc_section()

2021-04-08 Thread Jarkko Sakkinen
On Wed, Apr 07, 2021 at 06:18:11PM +0200, Borislav Petkov wrote: > On Wed, Apr 07, 2021 at 07:03:47PM +0300, Jarkko Sakkinen wrote: > > > Which leads to my question: what is sgx_nr_free_pages supposed to denote? > > > > > > Because I understand the callpath > > > > > > sgx_page_cache_init > > > .

Re: [PATCH 3/4] mce/copyin: fix to not SIGBUS when copying from user hits poison

2021-04-08 Thread Borislav Petkov
On Wed, Apr 07, 2021 at 02:43:10PM -0700, Luck, Tony wrote: > On Wed, Apr 07, 2021 at 11:18:16PM +0200, Borislav Petkov wrote: > > On Thu, Mar 25, 2021 at 05:02:34PM -0700, Tony Luck wrote: > > > Andy Lutomirski pointed out that sending SIGBUS to tasks that > > > hit poison in the kernel copying sy

Re: [PATCH v1 2/8] powerpc/mem: Remove address argument to flush_coherent_icache()

2021-04-08 Thread Aneesh Kumar K.V
Christophe Leroy writes: > flush_coherent_icache() can use any valid address as mentionned > by the comment. > > Use PAGE_OFFSET as base address. This allows removing the > user access stuff. > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/mm/mem.c | 13 + > 1 file changed,

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase in several files

2021-04-08 Thread Fabio M. De Francesco
On Thursday, April 8, 2021 10:36:32 AM CEST Greg KH wrote: > On Thu, Apr 08, 2021 at 10:07:14AM +0200, Fabio M. De Francesco wrote: > > Remove camelcase in a symbol that is used by several files. > > What symbol? > I'm not sure I understand what you are asking. You mean that I have to specify th

Re: [PATCH v2 2/2] x86/sgx: Add sgx_nr_{all, free}_pages to the debugfs

2021-04-08 Thread Jarkko Sakkinen
On Wed, Apr 07, 2021 at 06:15:33PM +0200, Borislav Petkov wrote: > On Wed, Apr 07, 2021 at 07:09:11PM +0300, Jarkko Sakkinen wrote: > > I left out "epc" because they are already prefixed with "sgx_". > > Are there any other "page" types which are going to be figurating in > some pseudofs or is "sg

[PATCH] selinux:Delete selinux_xfrm_policy_lookup() useless argument

2021-04-08 Thread  Zhongjun Tan
From: Zhongjun Tan Delete selinux selinux_xfrm_policy_lookup() useless argument. Signed-off-by: Zhongjun Tan --- include/linux/lsm_hook_defs.h | 3 +-- include/linux/security.h| 4 ++-- net/xfrm/xfrm_policy.c | 6 ++ security/security.c | 4 ++-- security/sel

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase in several files

2021-04-08 Thread Julia Lawall
On Thu, 8 Apr 2021, Fabio M. De Francesco wrote: > Remove camelcase in a symbol that is used by several files. In addition to Greg's suggestion about dropping the b, there are some more things you can do to improve the usage of this field. First, I noticed that the type is u8. It can be chan

[PATCH v2] drm/panel: panel-dsi-cm: convert sysfs snprintf to sysfs_emit

2021-04-08 Thread Carlis
From: Xuezhi Zhang Fix the following coccicheck warning: drivers/gpu/drm//panel/panel-dsi-cm.c:271:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm//panel/panel-dsi-cm.c:251:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Xuezhi Zhang --- v2: change snprint to snprintf in subjec

Re: [PATCH 01/10] mm/numa: node demotion data structure and lookup

2021-04-08 Thread Oscar Salvador
On Thu, Apr 01, 2021 at 11:32:18AM -0700, Dave Hansen wrote: > > From: Dave Hansen > > Prepare for the kernel to auto-migrate pages to other memory nodes > with a user defined node migration table. This allows creating single > migration target for each NUMA node to enable the kernel to do NUMA

Re: [PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation

2021-04-08 Thread Oliver Neukum
Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold: > TIOCSSERIAL is a horrid, underspecified, legacy interface which for most > serial devices is only useful for setting the close_delay and > closing_wait parameters. > > The xmit_fifo_size parameter could be used to set the hardware tr

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase in several files

2021-04-08 Thread Julia Lawall
On Thu, 8 Apr 2021, Fabio M. De Francesco wrote: > On Thursday, April 8, 2021 10:36:32 AM CEST Greg KH wrote: > > On Thu, Apr 08, 2021 at 10:07:14AM +0200, Fabio M. De Francesco wrote: > > > Remove camelcase in a symbol that is used by several files. > > > > What symbol? > > > > I'm not sure I

Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 10:35:17AM +0200, Jiri Kosina wrote: > On Thu, 8 Apr 2021, Greg KH wrote: > > > > If there is a driver/subsystem code that can't handle the reverse > > > operation to modprobe, it clearly can't handle error handling during > > > modprobe (which, one would hope, is support

Re: [PATCH v2 1/2] x86/sgx: Do not update sgx_nr_free_pages in sgx_setup_epc_section()

2021-04-08 Thread Borislav Petkov
On Thu, Apr 08, 2021 at 11:48:46AM +0300, Jarkko Sakkinen wrote: > The regression is that the sgx_nr_free_pages is also incremented by > sgx_free_epc_pages(), and thus it ends up having double the number of > pages available. So when you add a new EPC section with sgx_setup_epc_section(), those ne

Re: [PATCH v2 2/2] x86/sgx: Add sgx_nr_{all, free}_pages to the debugfs

2021-04-08 Thread Borislav Petkov
On Thu, Apr 08, 2021 at 11:52:40AM +0300, Jarkko Sakkinen wrote: > I think these attributes are quite useful information to have available so > I'd go actually doing sysfs attributes and create > Documentation/ABI/stable/sysfs-driver-sgx to document them. testing/ This directory document

Re: [PATCH v6 01/27] mm: Introduce struct folio

2021-04-08 Thread Rasmus Villemoes
On 31/03/2021 20.47, Matthew Wilcox (Oracle) wrote: > +static inline void folio_build_bug(void) > +{ > +#define FOLIO_MATCH(pg, fl) \ > +BUILD_BUG_ON(offsetof(struct page, pg) != offsetof(struct folio, fl)); > + > + FOLIO_MATCH(flags, flags); > + FO

Re: [PATCH 1/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU

2021-04-08 Thread Jonathan Cameron
On Wed, 7 Apr 2021 21:40:05 +0100 Will Deacon wrote: > On Wed, Apr 07, 2021 at 05:49:02PM +0800, Qi Liu wrote: > > PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported > > to sample bandwidth, latency, buffer occupation etc. > > > > Each PMU RCiEP device monitors multiple root p

Re: [PATCH v2 1/1] powerpc/iommu: Enable remaining IOMMU Pagesizes present in LoPAR

2021-04-08 Thread Michael Ellerman
Alexey Kardashevskiy writes: > On 08/04/2021 15:37, Michael Ellerman wrote: >> Leonardo Bras writes: >>> According to LoPAR, ibm,query-pe-dma-window output named "IO Page Sizes" >>> will let the OS know all possible pagesizes that can be used for creating a >>> new DDW. >>> >>> Currently Linux wi

Re: [PATCH 2/3] USB: cdc-acm: fix unprivileged TIOCCSERIAL

2021-04-08 Thread Oliver Neukum
Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold: > TIOCSSERIAL is a horrid, underspecified, legacy interface which for most > serial devices is only useful for setting the close_delay and > closing_wait parameters. > > A non-privileged user has only ever been able to set the since lo

[PATCH] scsi: message: fusion: Remove useless variable

2021-04-08 Thread Jiapeng Chong
Fix the following gcc warning: drivers/message/fusion/mptbase.c:3087:9: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/message/fusion/mptbase.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) d

Re: [PATCH v2 1/1] powerpc/iommu: Enable remaining IOMMU Pagesizes present in LoPAR

2021-04-08 Thread Michael Ellerman
Leonardo Bras writes: > On Thu, 2021-04-08 at 03:20 -0300, Leonardo Bras wrote: >> > > +#define QUERY_DDW_PGSIZE_4K 0x01 >> > > +#define QUERY_DDW_PGSIZE_64K0x02 >> > > +#define QUERY_DDW_PGSIZE_16M0x04 >> > > +#define QUERY_DDW_PGSIZE_32M0x08 >> > > +#define QUERY_DDW_PGSIZE_64M

[PATCH] media: imx: imx7-mipi-csis: Fix runtime PM imbalance in mipi_csis_s_stream

2021-04-08 Thread Dinghao Liu
When v4l2_subdev_call() fails, a pairing PM usage counter decrement is needed to keep the counter balanced. It's the same for the following error paths in case 'enable' is on. Signed-off-by: Dinghao Liu --- drivers/staging/media/imx/imx7-mipi-csis.c | 9 +++-- 1 file changed, 7 insertions(+)

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

2021-04-08 Thread Hans de Goede
Hi, On 4/7/21 11:15 AM, Zhen Lei wrote: > Fixes the following W=1 kernel build warning: > > drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined > but not used [-Wunused-const-variable=] > > The reference to the variable 'tcpm_altmode_ops' is deleted by the > commit a07997

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase in several files

2021-04-08 Thread Fabio M. De Francesco
On Thursday, April 8, 2021 10:54:09 AM CEST Julia Lawall wrote: > On Thu, 8 Apr 2021, Fabio M. De Francesco wrote: > > On Thursday, April 8, 2021 10:36:32 AM CEST Greg KH wrote: > > > On Thu, Apr 08, 2021 at 10:07:14AM +0200, Fabio M. De Francesco wrote: > > > > Remove camelcase in a symbol that i

[PATCH 2/2] USB:ehci:fix Kunpeng920 ehci hardware problem

2021-04-08 Thread Longfang Liu
Kunpeng920's EHCI controller does not have SBRN register. Reading the SBRN register when the controller driver is initialized will get 0. When rebooting the EHCI driver, ehci_shutdown() will be called. if the sbrn flag is 0, ehci_shutdown() will return directly. The sbrn flag being 0 will cause th

[PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread Longfang Liu
Some types of EHCI controllers do not have SBRN registers. By comparing the white list, the operation of reading the SBRN registers is skipped. Subsequent EHCI controller types without SBRN registers can be directly added to the white list. The current patch does not affect the drive function. S

[PATCH] USB:ehci:fix ehci hardware problem

2021-04-08 Thread Longfang Liu
When rebooting the EHCI driver, ehci_shutdown() will be called. if the sbrn flag is 0, ehci_shutdown() will return directly. Kunpeng920's EHCI hardware does not define the SBRN register, which cause its value to default to 0. The sbrn flag being 0 will cause the EHCI interrupt signal to not be tur

[PATCH 0/2] USB:ehci:fix the no SRBN register problem

2021-04-08 Thread Longfang Liu
(1) Add a whitelist for EHCI devices without SBRN registers. (2) Add Kunpeng920's EHCI device to the whitelist. Longfang Liu (2): USB:ehci:Add a whitelist for EHCI controllers USB:ehci:fix Kunpeng920 ehci hardware problem drivers/usb/host/ehci-pci.c | 29 + 1 file

Re: [PATCH v2 2/2] x86/sgx: Add sgx_nr_{all, free}_pages to the debugfs

2021-04-08 Thread Jarkko Sakkinen
On Thu, Apr 08, 2021 at 11:52:40AM +0300, Jarkko Sakkinen wrote: > On Wed, Apr 07, 2021 at 06:15:33PM +0200, Borislav Petkov wrote: > > On Wed, Apr 07, 2021 at 07:09:11PM +0300, Jarkko Sakkinen wrote: > > > I left out "epc" because they are already prefixed with "sgx_". > > > > Are there any other

[PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread Longfang Liu
Some types of EHCI controllers do not have SBRN registers. By comparing the white list, the operation of reading the SBRN registers is skipped. Subsequent EHCI controller types without SBRN registers can be directly added to the white list. The current patch does not affect the drive function. S

[PATCH 2/2] USB:ehci:fix Kunpeng920 ehci hardware problem

2021-04-08 Thread Longfang Liu
Kunpeng920's EHCI controller does not have SBRN register. Reading the SBRN register when the controller driver is initialized will get 0. When rebooting the EHCI driver, ehci_shutdown() will be called. if the sbrn flag is 0, ehci_shutdown() will return directly. The sbrn flag being 0 will cause th

[PATCH 0/2] USB:ehci:fix the no SRBN register problem

2021-04-08 Thread Longfang Liu
(1) Add a whitelist for EHCI devices without SBRN registers. (2) Add Kunpeng920's EHCI device to the whitelist. Longfang Liu (2): USB:ehci:Add a whitelist for EHCI controllers USB:ehci:fix Kunpeng920 ehci hardware problem drivers/usb/host/ehci-pci.c | 29 + 1 file

[PATCH] bus: bt1-apb: Eliminate a duplicate header file

2021-04-08 Thread Chen Jiahao
Delete one of two same header files included in drivers/bus/bt1-apb.c Signed-off-by: Chen Jiahao --- drivers/bus/bt1-apb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c index b25ff941e7c7..74b1b712ef3a 100644 --- a/drivers/bus/bt1-apb.c +++ b/

Re: [PATCH 0/2] USB:ehci:fix the no SRBN register problem

2021-04-08 Thread liulongfang
On 2021/4/8 17:09, Longfang Liu wrote: > (1) Add a whitelist for EHCI devices without SBRN registers. > (2) Add Kunpeng920's EHCI device to the whitelist. > > Longfang Liu (2): > USB:ehci:Add a whitelist for EHCI controllers > USB:ehci:fix Kunpeng920 ehci hardware problem > > drivers/usb/hos

sm750fb: Question about dviInit from ddk750_dvi.(c|h)

2021-04-08 Thread Pavle Rohalj
I was working on some checkpatch fixes for ddk750_dvi.h and ddk750_dvi.c when I noticed that dviInit function does not seem to be invoked in any of the files that belong to this driver and can be removed. Am I missing something? Thank you, Pavle

Re: [PATCH v2 00/14] usb: dwc2: Fix Partial Power down issues.

2021-04-08 Thread Artur Petrosyan
Hi Greg, On 4/8/2021 11:28, Artur Petrosyan wrote: > This patch set fixes and improves the Partial Power Down mode for > dwc2 core. > It adds support for the following cases > 1. Entering and exiting partial power down when a port is > suspended, resumed, port reset is asserted. >

[PATCH -next] usb: musb: fix PM reference leak in musb_irq_work()

2021-04-08 Thread Bixuan Cui
pm_runtime_get_sync will increment pm usage counter even it failed. thus a pairing decrement is needed. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Bixuan Cui --- drivers/usb/musb/musb_core.c | 2 +- 1 file changed

[PATCH v1 0/2] drivers: don't select DMA_CMA or CMA

2021-04-08 Thread David Hildenbrand
Trying to set CONFIG_CMA=y with CONFIG_DMA_CMA=n revealed that we have three drivers that select these options. Random drivers should not override user settings of such core knobs. Let's use "imply DMA_CMA" instead, such that user configuration and dependencies are respected. Cc: Joel Stanley Cc:

[PATCH] ide: Remove useless variable

2021-04-08 Thread Jiapeng Chong
Fix the following gcc warning: drivers/ide/ide-proc.c:457:37: warning: ‘ide_media_proc_fops’ defined but not used [-Wunused-const-variable=]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/ide/ide-proc.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/ide/

RE: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Wu, Hao
> On Thu, Apr 08, 2021 at 03:30:15PM +0800, Wu, Hao wrote: > > > > On Mon, 5 Apr 2021, Moritz Fischer wrote: > > > > > > > > > Hi Matthew, > > > > > > > > > > On Mon, Apr 05, 2021 at 04:53:00PM -0700, > > > matthew.gerl...@linux.intel.com wrote: > > > > > > From: Matthew Gerlach > > > > > > > > >

[PATCH v1 1/2] drivers/video/fbdev: don't select DMA_CMA

2021-04-08 Thread David Hildenbrand
Random drivers should not override a user configuration of core knobs (e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect dependencies and manual overrides. "This is similar to "select" as it enforces a lower limit on another symbol except that the "implied" symbol's value may still b

[PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread David Hildenbrand
Random drivers should not override a user configuration of core knobs (e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect dependencies and manual overrides. "This is similar to "select" as it enforces a lower limit on another symbol except that the "implied" symbol's value may still b

Re: [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 05:11:12PM +0800, Longfang Liu wrote: > Some types of EHCI controllers do not have SBRN registers. > By comparing the white list, the operation of reading the SBRN > registers is skipped. > > Subsequent EHCI controller types without SBRN registers can be > directly added to

drivers/soc/samsung/s3c-pm-debug.c:30:2: warning: function 's3c_pm_dbg' might be a candidate for 'gnu_printf' format attribute

2021-04-08 Thread kernel test robot
ago config: arm-randconfig-r023-20210408 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https

Re: [PATCH v2 1/2] x86/sgx: Do not update sgx_nr_free_pages in sgx_setup_epc_section()

2021-04-08 Thread Jarkko Sakkinen
On Thu, Apr 08, 2021 at 10:56:40AM +0200, Borislav Petkov wrote: > On Thu, Apr 08, 2021 at 11:48:46AM +0300, Jarkko Sakkinen wrote: > > The regression is that the sgx_nr_free_pages is also incremented by > > sgx_free_epc_pages(), and thus it ends up having double the number of > > pages available.

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase in several files

2021-04-08 Thread Fabio M. De Francesco
On Thursday, April 8, 2021 10:53:01 AM CEST Julia Lawall wrote: > On Thu, 8 Apr 2021, Fabio M. De Francesco wrote: > > Remove camelcase in a symbol that is used by several files. > > In addition to Greg's suggestion about dropping the b, there are some > more things you can do to improve the usage

Re: [RFC PATCH v3 1/2] KVM: arm64: Move CMOs from user_mem_abort to the fault handlers

2021-04-08 Thread wangyanan (Y)
Hi Alex, On 2021/4/7 23:31, Alexandru Elisei wrote: Hi Yanan, On 3/26/21 3:16 AM, Yanan Wang wrote: We currently uniformly permorm CMOs of D-cache and I-cache in function user_mem_abort before calling the fault handlers. If we get concurrent guest faults(e.g. translation faults, permission fau

[PATCH] staging: rtl8712: remove unused variable from rtl871x_mlme.c

2021-04-08 Thread Sergei Krainov
Remove unused variable from rtl871x_mlme.c. No side effects can be seen locally or in r8712_find_network() Signed-off-by: Sergei Krainov --- Mention in the description that no observable side effects were found drivers/staging/rtl8712/rtl871x_mlme.c | 9 + 1 file changed, 1 insertion(+

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

2021-04-08 Thread Heikki Krogerus
On Thu, Apr 08, 2021 at 11:10:38AM +0200, Hans de Goede wrote: > Hi, > > On 4/7/21 11:15 AM, Zhen Lei wrote: > > Fixes the following W=1 kernel build warning: > > > > drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined > > but not used [-Wunused-const-variable=] > > > > T

[PATCH] spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in zynqmp_qspi_probe

2021-04-08 Thread Dinghao Liu
When platform_get_irq() fails, a pairing PM usage counter increment is needed to keep the counter balanced. It's the same for the following error paths. Signed-off-by: Dinghao Liu --- drivers/spi/spi-zynqmp-gqspi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-zynqmp-gqspi.

[PATCH] staging: rtl8723bs: remove unused variables

2021-04-08 Thread Fabio Aiuto
remove declared and assigned unused variables Reported-by: kernel test robot Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 --- .../staging/rtl8723bs/include/rtw_security.h | 18 - .../staging/rtl8723bs/os_dep/ioctl_linux.c| 26 +++---

[PATCH -next] cifsd: remove unused header

2021-04-08 Thread Ruiqi Gong
Remove the header that is not needed. Reported-by: Hulk Robot Signed-off-by: Ruiqi Gong --- fs/cifsd/mgmt/tree_connect.c | 1 - fs/cifsd/mgmt/user_session.c | 1 - fs/cifsd/mgmt/user_session.h | 1 - 3 files changed, 3 deletions(-) diff --git a/fs/cifsd/mgmt/tree_connect.c b/fs/cifsd/mgmt/tre

[PATCH] x86/sgx: Do not update sgx_nr_free_pages in sgx_setup_epc_section()

2021-04-08 Thread Jarkko Sakkinen
NUMA patches introduced this change to __sgx_sanitize_pages(): - if (!ret) - list_move(&page->list, §ion->page_list); - else + if (!ret) { + /* +* page is now sanitized. Make it available

Re: [PATCH v2 1/2] x86/sgx: Do not update sgx_nr_free_pages in sgx_setup_epc_section()

2021-04-08 Thread Borislav Petkov
On Thu, Apr 08, 2021 at 12:22:56PM +0300, Jarkko Sakkinen wrote: > They are not in the "free_page_list" before sanitization process has put > them to there. So in that way the count is also better in sync with this > fix. This is the bit of information I was looking for. This needs to be in the co

Re: [PATCH] Revert "drm/syncobj: use dma_fence_get_stub"

2021-04-08 Thread David Stevens
On Thu, Apr 8, 2021 at 4:03 PM Christian König wrote: > > Am 08.04.21 um 06:59 schrieb David Stevens: > > From: David Stevens > > > > This reverts commit 86bbd89d5da66fe760049ad3f04adc407ec0c4d6. > > > > Using the singleton stub fence in drm_syncobj_assign_null_handle means > > that all syncobjs

Re: [PATCH 1/2] powerpc: remove set but not used variable 'force_printk_to_btext'

2021-04-08 Thread yukuai (C)
On 2021/04/08 13:01, Christophe Leroy wrote: Le 08/04/2021 à 03:18, Yu Kuai a écrit : Fixes gcc '-Wunused-but-set-variable' warning: arch/powerpc/kernel/btext.c:49:12: error: 'force_printk_to_btext' defined but not used. You don't get this error as it is now. You will get this error only if

Re: [RFC PATCH v3 2/2] KVM: arm64: Distinguish cases of memcache allocations completely

2021-04-08 Thread wangyanan (Y)
On 2021/4/7 23:35, Alexandru Elisei wrote: Hi Yanan, On 3/26/21 3:16 AM, Yanan Wang wrote: With a guest translation fault, the memcache pages are not needed if KVM is only about to install a new leaf entry into the existing page table. And with a guest permission fault, the memcache pages are

[PATCH v4] drm/ast: Fixed CVE for DP501

2021-04-08 Thread KuoHsiang Chou
[Bug][DP501] If ASPEED P2A (PCI to AHB) bridge is disabled and disallowed for CVE_2019_6260 item3, and then the monitor's EDID is unable read through Parade DP501. The reason is the DP501's FW is mapped to BMC addressing space rather than Host addressing space. The resolution is that using "pci_iom

[PATCH -next] sched/topology: Make some symbols static

2021-04-08 Thread Peng Wu
The sparse tool complains as follows: kernel/sched/topology.c:211:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static? kernel/sched/topology.c:212:6: warning: symbol 'sched_energy_update' was not declared. Should it be static? This symbol is not used outside of topolog

Re: [PATCH v2 2/2] x86/sgx: Add sgx_nr_{all, free}_pages to the debugfs

2021-04-08 Thread Borislav Petkov
On Thu, Apr 08, 2021 at 12:13:21PM +0300, Jarkko Sakkinen wrote: > Actually I think read-only sysctl attributes would be a better idea. I still think debugfs is the right *start* for this: you play with them, see what makes sense and what not, tweak them, etc, and then you cast them in stone. Not

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-08 Thread Pierre
Hi, Hi On Wed, Apr 7, 2021 at 10:11 PM Pierre wrote: > > Hi, > > I test the patch, but the overflow still exists. > > In the "sched/fair: Use pd_cache to speed up find_energy_efficient_cpu()" > > I wonder why recompute the cpu util when cpu==dst_cpu in compute_energy(), > > when the dst_cpu'

Re: [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread Oliver Neukum
Am Donnerstag, den 08.04.2021, 17:11 +0800 schrieb Longfang Liu: > Some types of EHCI controllers do not have SBRN registers. > By comparing the white list, the operation of reading the SBRN > registers is skipped. > > Subsequent EHCI controller types without SBRN registers can be > directly added

[PATCH v3] lib/string: Introduce sysfs_streqcase

2021-04-08 Thread Gioh Kim
As the name shows, it checks if strings are equal in case insensitive manner. For example, drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c uses strncasecmp to check that the input via sysfs is "mi". But it would work even-if the input is "min-wrongcommand". I found some more cases using strncasecmp

Re: [PATCH 2/2] powerpc: make 'boot_text_mapped' static

2021-04-08 Thread yukuai (C)
On 2021/04/08 13:04, Christophe Leroy wrote: Le 08/04/2021 à 03:18, Yu Kuai a écrit : The sparse tool complains as follow: arch/powerpc/kernel/btext.c:48:5: warning:   symbol 'boot_text_mapped' was not declared. Should it be static? This symbol is not used outside of btext.c, so this commit

Re: [PATCH 2/3] PCI: dwc: Visoconti: PCIe RC controller driver

2021-04-08 Thread Nobuhiro Iwamatsu
Hi, Thanks for your review. On Wed, Apr 07, 2021 at 09:27:34AM -0500, Rob Herring wrote: > On Wed, Apr 07, 2021 at 12:18:38PM +0900, Nobuhiro Iwamatsu wrote: > > Add support to PCIe RC controller on Toshiba Visconti ARM SoCs. > > PCIe controller is based of Synopsys DesignWare PCIe core. > > > >

[PATCH] agp: Remove useless variable

2021-04-08 Thread Jiapeng Chong
Fix the following gcc warning: drivers/char/agp/via-agp.c:131:28: warning: variable ‘current_size’ set but not used [-Wunused-but-set-variable]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/char/agp/via-agp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/ch

Re: [PATCH] Revert "drm/syncobj: use dma_fence_get_stub"

2021-04-08 Thread Christian König
Am 08.04.21 um 11:30 schrieb David Stevens: On Thu, Apr 8, 2021 at 4:03 PM Christian König wrote: Am 08.04.21 um 06:59 schrieb David Stevens: From: David Stevens This reverts commit 86bbd89d5da66fe760049ad3f04adc407ec0c4d6. Using the singleton stub fence in drm_syncobj_assign_null_handle me

[PATCH] drm/syncobj: use newly allocated stub fences

2021-04-08 Thread David Stevens
From: David Stevens Allocate a new private stub fence in drm_syncobj_assign_null_handle, instead of using a static stub fence. When userspace creates a fence with DRM_SYNCOBJ_CREATE_SIGNALED or when userspace signals a fence via DRM_IOCTL_SYNCOBJ_SIGNAL, the timestamp obtained when the fence is

[PATCH 1/6] PM: runtime: enable wake irq after runtime_suspend hook called

2021-04-08 Thread Chunfeng Yun
When the dedicated wake irq is level trigger, enable it before calling runtime_suspend, will trigger an interrupt. e.g. for a low level trigger type, it's low level at running time (0), and becomes high level when enters suspend (runtime_suspend (1) is called), a wakeup signal at (2) make it becom

[PATCH 4/6] usb: xhci-mtk: add support runtime PM

2021-04-08 Thread Chunfeng Yun
A dedicated wakeup irq will be used to handle runtime suspend/resume, we use dev_pm_set_dedicated_wake_irq API to take care of requesting and attaching wakeup irq, then the suspend/resume framework will help to enable/disable wakeup irq. The runtime PM is default off since some platforms may not s

[PATCH 3/6] dt-bindings: usb: mtk-xhci: add wakeup interrupt

2021-04-08 Thread Chunfeng Yun
Add an interrupt which is EINT usually to support runtime PM, meanwhile add "interrupt-names" property, for backward compatibility, it's optional and used when wakeup interrupt exists Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 13 - 1 file c

[PATCH 5/6] usb: xhci-mtk: use clock bulk to get clocks

2021-04-08 Thread Chunfeng Yun
Use clock bulk helpers to get/enable/disable clocks, meanwhile make sys_ck optional, then will be easier to handle clocks. Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk.c | 109 +++- drivers/usb/host/xhci-mtk.h | 10 ++-- 2 files changed, 24 insertion

[PATCH 6/6] usb: xhci-mtk: remove unused members

2021-04-08 Thread Chunfeng Yun
Now some members about phys and wakeup are not used anymore, remove them. Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/host/xhci-mtk.h b/drivers/usb/host/xhci-mtk.h index 11996edc1967..7940593a3445 100644 --- a/driv

[PATCH 2/6] usb: xhci-mtk: check return value in suspend/resume hooks

2021-04-08 Thread Chunfeng Yun
Return error number if encounter errors during suspend and resume. Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk.c | 37 +++-- 1 file changed, 27 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c ind

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Hans de Goede
Hi, On 4/7/21 9:43 PM, Thomas Weißschuh wrote: > Hi Hans, > > On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: >> Thank you for your new driver and thank you for the quick respin >> addressing Barnabás' request to make it a WMI driver. >> >> The code looks good, so merging this should be a no-b

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

2021-04-08 Thread Hans de Goede
Hi, On 4/8/21 11:25 AM, Heikki Krogerus wrote: > On Thu, Apr 08, 2021 at 11:10:38AM +0200, Hans de Goede wrote: >> Hi, >> >> On 4/7/21 11:15 AM, Zhen Lei wrote: >>> Fixes the following W=1 kernel build warning: >>> >>> drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined >>>

Re: [PATCH] drm/syncobj: use newly allocated stub fences

2021-04-08 Thread David Stevens
Sorry, I forgot to checkpatch this, I'll resend it momentarily. -David On Thu, Apr 8, 2021 at 6:34 PM David Stevens wrote: > > From: David Stevens > > Allocate a new private stub fence in drm_syncobj_assign_null_handle, > instead of using a static stub fence. > > When userspace creates a fence

Re: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-04-08 Thread Jean-Philippe Brucker
On Wed, Apr 07, 2021 at 04:36:54PM -0300, Jason Gunthorpe wrote: > On Wed, Apr 07, 2021 at 08:43:50PM +0200, Jean-Philippe Brucker wrote: > > > * Get a container handle out of /dev/ioasid (or /dev/iommu, really.) > > No operation available since we don't know what the device and IOMMU > > capa

Re: [PATCH v16 1/2] scsi: ufs: Enable power management for wlun

2021-04-08 Thread Adrian Hunter
On 7/04/21 9:08 pm, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU (START_STOP_UNIT) to wlun > during its runtime-suspend. > During the process blk_queue_enter checks if the q

[PATCH -next v3] drm/bridge: lt8912b: Add header file

2021-04-08 Thread Zhang Jianhua
If CONFIG_DRM_LONTIUM_LT8912B=m, the following errors will be seen while compiling lontium-lt8912b.c drivers/gpu/drm/bridge/lontium-lt8912b.c: In function ‘lt8912_hard_power_on’: drivers/gpu/drm/bridge/lontium-lt8912b.c:252:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did

Re: [PATCH] drm/syncobj: use newly allocated stub fences

2021-04-08 Thread Christian König
Am 08.04.21 um 11:34 schrieb David Stevens: From: David Stevens Allocate a new private stub fence in drm_syncobj_assign_null_handle, instead of using a static stub fence. When userspace creates a fence with DRM_SYNCOBJ_CREATE_SIGNALED or when userspace signals a fence via DRM_IOCTL_SYNCOBJ_SIG

Re: [PATCH 2/3] USB: cdc-acm: fix unprivileged TIOCCSERIAL

2021-04-08 Thread Johan Hovold
On Thu, Apr 08, 2021 at 09:48:38AM +0200, Oliver Neukum wrote: > Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold: > > TIOCSSERIAL is a horrid, underspecified, legacy interface which for most > > serial devices is only useful for setting the close_delay and > > closing_wait parameters.

[PATCH v2] drm/syncobj: use newly allocated stub fences

2021-04-08 Thread David Stevens
From: David Stevens Allocate a new private stub fence in drm_syncobj_assign_null_handle, instead of using a static stub fence. When userspace creates a fence with DRM_SYNCOBJ_CREATE_SIGNALED or when userspace signals a fence via DRM_IOCTL_SYNCOBJ_SIGNAL, the timestamp obtained when the fence is

Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller

2021-04-08 Thread Andy Shevchenko
On Thu, Apr 8, 2021 at 10:17 AM Yicong Yang wrote: > On 2021/4/8 7:04, Wolfram Sang wrote: > > > >> Reason for temp variable is for me it's confusing to see statement like > >> "rate_khz = rate_khz / 1000". > > > > Yes. And with this clearer calculation, we can maybe skip the HZ_PER_KHZ > > define

[PATCH v3 00/14] usb: dwc2: Fix Partial Power down issues.

2021-04-08 Thread Artur Petrosyan
This patch set fixes and improves the Partial Power Down mode for dwc2 core. It adds support for the following cases 1. Entering and exiting partial power down when a port is suspended, resumed, port reset is asserted. 2. Exiting the partial power down mode before removing driver.

[PATCH v3 01/14] usb: dwc2: Add device partial power down functions

2021-04-08 Thread Artur Petrosyan
For device mode Partial Power Down entering and exiting separate functions are needed to implement the logic. Earlier the logic was implemented in one function. Which was confusing the readability. Also both host and device implementations were in the same function. - Added device partial power do

Re: [PATCH v1 1/2] iommu/tegra-smmu: Defer attachment of display clients

2021-04-08 Thread Nicolin Chen
On Mon, Mar 29, 2021 at 02:32:55AM +0300, Dmitry Osipenko wrote: > All consumer-grade Android and Chromebook devices show a splash screen > on boot and then display is left enabled when kernel is booted. This > behaviour is unacceptable in a case of implicit IOMMU domains to which > devices are att

[PATCH v3 02/14] usb: dwc2: Add host partial power down functions

2021-04-08 Thread Artur Petrosyan
For host mode Partial Power Down entering and exiting separate functions are needed to implement the logic. Earlier the logic was implemented in one function. Which was confusing the readability. Also both host and device implementations were in the same function. - Added host partial power down f

[PATCH v3 03/14] usb: dwc2: Update enter and exit partial power down functions

2021-04-08 Thread Artur Petrosyan
These are wrapper functions which are calling device or host enter/exit partial power down functions. This change is done because we need to separate device and host partial power down functions as the programming flow has a lot of difference between host and device. With this update during partia

Re: [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread liulongfang
On 2021/4/8 17:33, Oliver Neukum wrote: > Am Donnerstag, den 08.04.2021, 17:11 +0800 schrieb Longfang Liu: >> Some types of EHCI controllers do not have SBRN registers. >> By comparing the white list, the operation of reading the SBRN >> registers is skipped. >> >> Subsequent EHCI controller types

<    1   2   3   4   5   6   7   8   9   10   >