Re: [PATCH] drivers/media/pci/solo6x10/solo6x10-disp.c: check kzalloc() result

2014-07-25 Thread Dan Carpenter
On Fri, Jul 25, 2014 at 09:32:36PM +0300, Andrey Utkin wrote: > Please ignore. I didn't notice that Hans has already posted a patch > fixing that and more. > Heh. I was just about to send my fix for this bug as well. I don't follow linux-media so I didn't realize this driver was getting promote

[linuxtv-media:master 353/499] ERROR: "usb_kill_urb" undefined!

2014-07-25 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: d6740d86deda4acc8dc2cf196ccb9d8eb30bcb9a commit: 77bbb2b049c1c3e935f5bec510bec337d94ae8f8 [353/499] rtl2832_sdr: move from staging to media config: i386-randconfig-j1-07260922 (attached as .config) Note: the linuxtv-media/master HEAD d6740d8

Re: [PATCH] V4L2: fix VIDIOC_CREATE_BUFS 32-bit compatibility mode data copy-back

2014-07-25 Thread Mauro Carvalho Chehab
Em Sat, 31 May 2014 01:36:16 +0200 Laurent Pinchart escreveu: > Hi Guennadi, > > Thank you for the patch. > > On Saturday 31 May 2014 01:26:38 Guennadi Liakhovetski wrote: > > Similar to an earlier patch, > > Could you please mention the commit ID in the commit message ? > > > fixing reading

Re: Ping: [PATCH 0/10] drivers/media/rc/ati_remote.c tweaks

2014-07-25 Thread Mauro Carvalho Chehab
Em 6 Jun 2014 23:26:22 -0400 "George Spelvin" escreveu: > Just a ping... has anyone looked at this? > (David Härdeman added to recipients list.) > > The series can be found in the linux-media archives stating at > > mid:2014051113.14427.qm...@ns.horizon.com > http://www.spinics.net/lists/li

cron job: media_tree daily build: ERRORS

2014-07-25 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Jul 26 04:00:23 CEST 2014 git branch: test git hash: 488046c237f3b78f91046d45662b318cd2415f64 gcc versi

[PATCH] rc-core: don't use dynamic_pr_debug for IR_dprintk()

2014-07-25 Thread Mauro Carvalho Chehab
The hole point of IR_dprintk() is that, once a level is given at debug parameter, all enabled IR parsers will show their debug messages. While converting it to dynamic_printk might be a good idea, right now it just makes very hard to debug the drivers, as one needs to both pass debug=1 or debug=2

Re: [PATCH 46/49] rc-core: use struct rc_event for all rc communication

2014-07-25 Thread Mauro Carvalho Chehab
Em Fri, 04 Apr 2014 01:35:08 +0200 David Härdeman escreveu: > Remove struct ir_raw_event and use struct rc_event in all stages > of IR processing. This should help future flexibility and also > cuts down on the confusing number of structs that are flying > around in rc-*. You should rebase this

Re: [PATCH 45/49] rc-ir-raw: add various rc_events

2014-07-25 Thread Mauro Carvalho Chehab
Em Fri, 04 Apr 2014 01:35:03 +0200 David Härdeman escreveu: > Reporting pulse/space events via the /dev/rc/rcX device node is an > important step towards having feature parity with LIRC. Why to duplicate LIRC? > > Signed-off-by: David Härdeman > --- > drivers/media/rc/rc-ir-raw.c | 11

Re: [PATCH 44/49] rc-core: don't report scancodes via input devices

2014-07-25 Thread Mauro Carvalho Chehab
Em Fri, 04 Apr 2014 01:34:58 +0200 David Härdeman escreveu: > The scancode that is reported via the input device(s) is now incomplete > (missing the protocol) and redundant. Not true yet, and I'm not sure if this is the right direction. Why? Let's discuss it together with the RFC related to the

Re: [PATCH 42/49] rc-ir-raw: atomic reads of protocols

2014-07-25 Thread Mauro Carvalho Chehab
Em Fri, 04 Apr 2014 01:34:48 +0200 David Härdeman escreveu: > Use atomic reads to avoid having to take a mutex when getting > the bitmask of supported protocols. This also belongs to that RCU change series, and doesn't apply. > > Signed-off-by: David Härdeman > --- > drivers/media/rc/rc-core

Re: [PATCH 41/49] rc-core: rename mutex

2014-07-25 Thread Mauro Carvalho Chehab
Em Fri, 04 Apr 2014 01:34:43 +0200 David Härdeman escreveu: > Having a mutex named "lock" is a bit misleading. Please rebase. > > Signed-off-by: David Härdeman > --- > drivers/media/rc/img-ir/img-ir-hw.c |4 ++- > drivers/media/rc/rc-main.c | 42 > ++--

Re: [PATCH 40/49] rc-ir-raw: simplify locking

2014-07-25 Thread Mauro Carvalho Chehab
Em Fri, 04 Apr 2014 01:34:38 +0200 David Härdeman escreveu: > Simplify and improve the locking in rc-ir-raw by making better use of > the existing kfifo functionality and by using RCU where possible. Please rebase. > > Signed-off-by: David Härdeman > --- > drivers/media/rc/rc-core-priv.h |

Re: [PATCH 39/49] rc-core: make IR raw handling a separate module

2014-07-25 Thread Mauro Carvalho Chehab
Em Fri, 04 Apr 2014 01:34:33 +0200 David Härdeman escreveu: > Make drivers/media/rc/rc-ir-raw.c a separate kernel module. > > Drivers which use IR decoding must use these functions: > rc_register_ir_raw_device() > rc_unregister_ir_raw_device() > instead of: > rc_register_device

Re: [PATCH 37/49] rc-core: allow empty keymaps

2014-07-25 Thread Mauro Carvalho Chehab
Em Fri, 04 Apr 2014 01:34:23 +0200 David Härdeman escreveu: > Remove the RC_MAP_EMPTY hack and instead allow for empty keymaps. Doesn't apply anymore, but makes sense. There's just one thing that we need to double check: if a given device is with an empty keytable, it doesn't make sense to star

Re: [PATCH 32/49] rc-core: prepare for multiple keytables

2014-07-25 Thread Mauro Carvalho Chehab
Em Fri, 04 Apr 2014 01:33:57 +0200 David Härdeman escreveu: > Introduce struct rc_keytable which essentially maintains an input device > and a table with scancode,protocol <-> keycode mappings. Move the relevant > members from struct rc_dev into struct rc_keytable. I can't apply this patch (and

Re: [PATCH 31/49] rc-core: split rc-main.c into rc-main.c and rc-keytable.c

2014-07-25 Thread Mauro Carvalho Chehab
Em Fri, 04 Apr 2014 01:33:52 +0200 David Härdeman escreveu: > rc-main.c is getting quite large and contains two distinct parts, one > related to the chardev (fops, sysfs, etc) and one related to all > key functionality. Split off the key functionality to a separate file in > preparation for the c

Re: [PATCH 16/49] rc-core: use an IDA rather than a bitmap

2014-07-25 Thread Mauro Carvalho Chehab
As I commented on a private e-mail, based on the patch descriptions: Patch 17 deserves a bigger explanation. Well, the best is if you could send a separate RFC describing what you have in mind with patches 16-29, for our discussions, explaining what usage are you expecting for a non-LIRC chardev,

Re: [PATCH v4 1/2] media: soc_camera: pxa_camera device-tree support

2014-07-25 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Thanks for a quick test! One question: to test this you also needed a > version of Ben's "soc_camera: add support for dt binding soc_camera > drivers" patch, right? Yes. > Did you use the last version from Ben or my amended version, that I sent > yesterday? Ben'

Re: [PATCH 00/28] IPUv3 prep for video capture

2014-07-25 Thread Steve Longerbeam
On 07/23/2014 06:17 AM, Laurent Pinchart wrote: > Hi Steve, > > On Thursday 17 July 2014 13:44:12 Steve Longerbeam wrote: >> On 07/17/2014 04:10 AM, Hans Verkuil wrote: >>> Hi Steve, >>> >>> I don't know what your plan is, but when you want to mainline this it is >>> the gpu subsystem that needs to

Re: [PATCH v2 0/9] rc: Add IR encode based wakeup filtering

2014-07-25 Thread James Hogan
Hi Mauro, On Wednesday 23 July 2014 16:39:36 Mauro Carvalho Chehab wrote: > Em Fri, 14 Mar 2014 23:04:10 + > > James Hogan escreveu: > > A recent discussion about proposed interfaces for setting up the > > hardware wakeup filter lead to the conclusion that it could help to have > > the gener

Re: em28xx vb2 warnings

2014-07-25 Thread Hans Verkuil
On 07/25/2014 06:20 PM, Frank Schäfer wrote: > Hi Hans, > > I'm getting the following warnings with the em28xx driver on streaming stop: > > [ 7597.346168] WARNING: CPU: 1 PID: 3730 at > drivers/media/v4l2-core/videobuf2-core.c:2126 > __vb2_queue_cancel+0xf5/0x150 [videobuf2_core]() > [ 7597.3461

Re: [PATCH] drivers/media/pci/solo6x10/solo6x10-disp.c: check kzalloc() result

2014-07-25 Thread Andrey Utkin
Please ignore. I didn't notice that Hans has already posted a patch fixing that and more. -- Bluecherry developer. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

[PATCH] drivers/media/pci/solo6x10/solo6x10-disp.c: check kzalloc() result

2014-07-25 Thread Andrey Utkin
Signed-off-by: Andrey Utkin --- drivers/media/pci/solo6x10/solo6x10-disp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/pci/solo6x10/solo6x10-disp.c b/drivers/media/pci/solo6x10/solo6x10-disp.c index ed88ab4..93cbbb1 100644 --- a/drivers/media/pci/solo6x10/solo6x10-disp.c

Re: v4l2-ctrls: negative integer control values broken

2014-07-25 Thread Hans Verkuil
On 07/25/2014 08:25 PM, Frank Schäfer wrote: > Hans, > > sorry for bothering you with another issue on friday evening. :-/ > But it seems that commit 958c7c7e65 ("[media] v4l2-ctrls: fix corner > case in round-to-range code") introduced a regression for controls which > are using a negative intege

v4l2-ctrls: negative integer control values broken

2014-07-25 Thread Frank Schäfer
Hans, sorry for bothering you with another issue on friday evening. :-/ But it seems that commit 958c7c7e65 ("[media] v4l2-ctrls: fix corner case in round-to-range code") introduced a regression for controls which are using a negative integer value range. All negative values are mapped to the maxi

[PATCH] em28xx-v4l: fix disabling ioctl VIDIOC_S_PARM for vbi devices

2014-07-25 Thread Frank Schäfer
Fixes an old copy+paste bug that has survived all recent code changes in this code area. Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28x

[PATCH 0/4] some em28xx-v4l cleanup patches

2014-07-25 Thread Frank Schäfer
This patch series consists of 4 cleanup patches for the em28xx-v4l module. Frank Schäfer (4): em28xx-v4l: simplify some pointers in em28xx_init_camera() em28xx-v4l: get rid of struct em28xx_fh em28xx-v4l: simplify em28xx_v4l2_open() by using v4l2_fh_open() em28xx-v4l: get rid of field "use

[PATCH 1/4] em28xx-v4l: simplify some pointers in em28xx_init_camera()

2014-07-25 Thread Frank Schäfer
Pointer v4l2" can be used instead of "dev->v4l2, which saves some characters. Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-camera.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-camera.c b/drivers/media/usb/em28xx/em2

[PATCH 2/4] em28xx-v4l: get rid of struct em28xx_fh

2014-07-25 Thread Frank Schäfer
struct em28xx_fh isn't needed anymore because the only used field which is left is struct v4l2_fh fh. Use struct v4l2_fh directly and remvove struct em28xx_fh. Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-video.c | 83 - drivers/media/usb/em28

[PATCH 4/4] em28xx-v4l: get rid of field "users" in struct em28xx_v4l2

2014-07-25 Thread Frank Schäfer
Instead of counting the number of opened file handles, use function v4l2_fh_is_singular_file() in em28xx_v4l2_open() and em28xx_v4l2_close() to determine if the file handle is the first/last opened one. Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-video.c | 23 +--

[PATCH 3/4] em28xx-v4l: simplify em28xx_v4l2_open() by using v4l2_fh_open()

2014-07-25 Thread Frank Schäfer
Instead of calling ... struct v4l2_fh *fh = kzalloc(sizeof(*fh), GFP_KERNEL); filp->private_data = fh; v4l2_fh_init(fh, vdev); v4l2_fh_add(fh); ... simply use function v4l2_fh_open() which does all of these calls for us. Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-video.c

em28xx vb2 warnings

2014-07-25 Thread Frank Schäfer
Hi Hans, I'm getting the following warnings with the em28xx driver on streaming stop: [ 7597.346168] WARNING: CPU: 1 PID: 3730 at drivers/media/v4l2-core/videobuf2-core.c:2126 __vb2_queue_cancel+0xf5/0x150 [videobuf2_core]() [ 7597.346171] Modules linked in: em28xx_rc snd_usb_audio ov2640 soc_cam

Re: [PATCH 04/10] [media] s5p-mfc: Don't allocate codec buffers on STREAMON.

2014-07-25 Thread Nicolas Dufresne
Le lundi 19 mai 2014 à 18:03 +0530, Arun Kumar K a écrit : > From: Pawel Osciak > > Currently, we allocate private codec buffers on STREAMON, which may fail > if we are out of memory. We don't check for failure though, which will > make us crash with the codec accessing random memory. > > We sho

[PATCH 06/11] [media] coda: dequeue buffers on streamoff

2014-07-25 Thread Philipp Zabel
This is needed to decrease the q->owned_by_drv_count to zero before __vb2_queue_cancel is called, to avoid the WARN_ON therein. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/platform/coda/coda-

[PATCH 09/11] [media] coda: add an intermediate debug level

2014-07-25 Thread Philipp Zabel
Dumping all register accesses drowns other debugging messages in the log. Add a less verbose debug level. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/coda/coda-common.c

[PATCH 05/11] [media] coda: dequeue buffers if start_streaming fails

2014-07-25 Thread Philipp Zabel
The core warns if we keep queued buffers around in the error case. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 34 +++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/

[PATCH 03/11] [media] coda: Return the real error on platform_get_irq()

2014-07-25 Thread Philipp Zabel
From: Fabio Estevam No need to return a 'fake' return value on platform_get_irq() failure. Propagate the real error instead. Signed-off-by: Fabio Estevam Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH 00/11] CODA Cleanup & fixes

2014-07-25 Thread Philipp Zabel
Hi, the following series applies on top of the previous "Split CODA driver into multiple files" series. It contains various accumulated fixes, including dequeueing of buffers in stop_streaming and after start_streaming failure, a crash fix for the timestamp list handling, better error reporting, a

[PATCH 10/11] [media] coda: improve allocation error messages

2014-07-25 Thread Philipp Zabel
Produce some error messages when internal buffer allocation fails, for example because the CMA region is too small. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-bit.c| 4 +++- drivers/media/platform/coda/coda-common.c | 6 +- 2 files changed, 8 insertions(+), 2 delet

[PATCH 07/11] [media] coda: skip calling coda_find_codec in encoder try_fmt_vid_out

2014-07-25 Thread Philipp Zabel
We know that it will return NULL in this case, so we can just as well skip it altogether. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/coda/coda-common.c b/driver

[PATCH 08/11] [media] coda: increase max vertical frame size to 1088

2014-07-25 Thread Philipp Zabel
This patch increases the maximum vertical frame size reported by enum_fmt and accepted by try_fmt/s_fmt from 1080 to 1088. Since for 16x16-pixel macroblocks 1080p will be rounded up to this anyway, we may as well admit that we support it. Signed-off-by: Philipp Zabel --- drivers/media/platform/c

[PATCH 01/11] [media] coda: remove unnecessary peek at next destination buffer from coda_finish_decode

2014-07-25 Thread Philipp Zabel
The return value of this call to v4l2_m2m_next_dst_buf() is never used. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-bit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c index 1d2716d..cc9

[PATCH 02/11] [media] coda: request BIT processor interrupt by name

2014-07-25 Thread Philipp Zabel
Request the main coda interrupt using its name, "bit", if available. Fall back to requesting the first interrupt for backwards compatibility. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 11/11] [media] coda: fix timestamp list handling

2014-07-25 Thread Philipp Zabel
From: Michael Olbrich Lock modification of the timestamp list with bitstream_mutex and do not try to remove a timestamp element if the list is empty. This can happen if the userspace feeds us garbage or multiple encoded frames in a single buffer. Signed-off-by: Michael Olbrich Signed-off-by: Ph

[PATCH 04/11] [media] coda: Propagate the correct error on devm_request_threaded_irq()

2014-07-25 Thread Philipp Zabel
From: Fabio Estevam If devm_request_threaded_irq() fails, we should better propagate the real error. Also, print out the error code in the dev_err message. Signed-off-by: Fabio Estevam Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 10 ++ 1 file changed,

[PATCH 6/6] media: soc_camera: rcar_vin: Add r8a7794 device support

2014-07-25 Thread Ulrich Hecht
From: Koji Matsuoka Signed-off-by: Koji Matsuoka Cc: linux-media@vger.kernel.org --- drivers/media/platform/soc_camera/rcar_vin.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c index e594230..86d9

[PATCH v3 3/9] s5p-jpeg: return error immediately after get_byte fails

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski When parsing JPEG header s5p_jpeg_parse_hdr function should return immediately in case there was an error while reading a byte. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-jpeg/jpeg-core.c |4 ++-- 1 file changed,

[PATCH v3 1/9] [media] s5p-jpeg: Document sclk-jpeg clock for Exynos3250 SoC

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski JPEG IP on Exynos3250 SoC requires enabling two clock gates for its operation. This patch documents this requirement. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc

[PATCH v3 6/9] s5p-jpeg: Assure proper crop rectangle initialization

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski Assure proper crop_rect initialization in case the user space doesn't call S_SELECTION ioctl. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 15 +++ 1 file changed, 15 insertions(+) diff

[PATCH v3 8/9] s5p-jpeg: add chroma subsampling adjustment for Exynos3250

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski Take into account limitations specific to the Exynos3250 SoC, regarding setting the chroma subsampling control's value. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 59 +--

[PATCH v3 4/9] s5p-jpeg: Adjust jpeg_bound_align_image to Exynos3250 needs

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski The jpeg_bound_align_image function needs to know the context in which it is called, as it needs to align image dimensions in a slight different manner for Exynos3250, which crops pixels for specific values in case the format is RGB. Signed-off-by: Jacek Anaszewski Signed

[PATCH v3 5/9] s5p-jpeg: fix g_selection op

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski V4L2_SEL_TGT_COMPOSE_DEFAULT switch case should select whole available area of the image and V4L2_SEL_TGT_COMPOSE should apply user settings. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 12 +++

[PATCH v3 9/9] ARM: dts: exynos3250: add JPEG codec device node

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski Cc: Kukjin Kim Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos3250.dtsi |9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 3e678fa..4

[PATCH v3 7/9] s5p-jpeg: Prevent erroneous downscaling for Exynos3250 SoC

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski JPEG codec on Exynos3250 SoC produces broken raw image if a JPEG image is decoded to YUV420 format and downscaled by a factor greater than 2. Prevent this by asserting downscale ratio to 2. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- drivers/me

[PATCH v3 2/9] s5p-jpeg: Add support for Exynos3250 SoC

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski This patch adds support for jpeg codec on Exynos3250 SoC to the s5p-jpeg driver. Supported raw formats are: YUYV, YVYU, UYVY, VYUY, RGB565, RGB565X, RGB32, NV12, NV21. The support includes also scaling and cropping features. Signed-off-by: Jacek Anaszewski Signed-off-by:

[PATCH v3 0/9] Support for Exynos3250 SoC in the s5p-jpeg driver

2014-07-25 Thread Sylwester Nawrocki
This patch series adds support for the JPEG codec IP found on the Exynos3250 SoCs. Supported raw formats are: YUYV, YVYU, UYVY, VYUY, RGB565, RGB565X, RGB32, NV12, NV21. Support for the hardware scaling and cropping features is added. Changes since v2 (only patches 1/9, 2/9, 9/9): - the IP functi

Re: [PATCH v2 06/29] [media] coda: Add encoder/decoder support for CODA960

2014-07-25 Thread Fabio Estevam
Hi Robert, On Mon, Jul 21, 2014 at 4:07 AM, Robert Schwebel wrote: > Hi Fabio, > > On Fri, Jul 11, 2014 at 02:33:18PM +0200, Robert Schwebel wrote: >> On Wed, Jul 02, 2014 at 09:16:42PM +0200, Robert Schwebel wrote: >> > > It would be really nice if the firmware was available in the >> > > linux-

Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-25 Thread Ricardo Ribalda Delgado
Hi Hans! > I was thinking of just the sensor driver, not the other components. > That would provide a proper use-case for both the dead pixel array > and multi-selection. > > I assume that the sensor driver is a lot smaller? Does it need fw as well? > We support multiple sensors. The one that req

re: msi2500: move msi3101 out of staging and rename

2014-07-25 Thread Dan Carpenter
Hello Antti Palosaari, The patch fd8b5f502929: "msi2500: move msi3101 out of staging and rename" from Jul 13, 2014, leads to the following static checker warning: drivers/media/usb/msi2500/msi2500.c:887 msi2500_stop_streaming() error: we previously assumed 's->udev' could be null (see li

Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-25 Thread Hans Verkuil
On 07/25/14 14:09, Ricardo Ribalda Delgado wrote: > Hello Hans > > I still need the multiselection support first. Right now it is done by > a modified g/s_selection ioctl. > > I would love to upstream the driver, but maybe it is not the right > moment right now. We are selling a mainly to a coupl

Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-25 Thread Ricardo Ribalda Delgado
Hello Hans I still need the multiselection support first. Right now it is done by a modified g/s_selection ioctl. I would love to upstream the driver, but maybe it is not the right moment right now. We are selling a mainly to a couple of customers and the total size of the drivers is > 16000 line

Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-25 Thread Hans Verkuil
Hi Ricardo, On 07/25/14 13:52, Ricardo Ribalda Delgado wrote: > Hello Hans > > > Guess it is too late, but just so you know. I have successfully uses > this patches to implement a dead pixel array list. > > Tested-by: Ricardo Ribalda > Thanked-by: Ricardo Ribalda :) Nevertheless nice to hea

Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-25 Thread Ricardo Ribalda Delgado
Hello Hans Guess it is too late, but just so you know. I have successfully uses this patches to implement a dead pixel array list. Tested-by: Ricardo Ribalda Thanked-by: Ricardo Ribalda :) Thanks! On Thu, Jul 17, 2014 at 3:56 PM, Ricardo Ribalda Delgado wrote: > Hello Hans > > I am plannin

[PATCH] media/v4l2-ctrl: Support for pixel type

2014-07-25 Thread Ricardo Ribalda Delgado
Now that we have compound controls and support for array of controls it might be a good idea to create a new type to describe individual pixels (points). This types of control can be used to provide the user a list of dead pixels. Please consider this PATCH as an RFC to find out if this kind of c

[PATCH] solo6x10: fix potential null dereference

2014-07-25 Thread Hans Verkuil
drivers/media/pci/solo6x10/solo6x10-disp.c:221 solo_set_motion_block() error: potential null dereference 'buf'. (kzalloc returns null) Also propagate this error up the chain. Signed-off-by: Hans Verkuil Reported-by: kbuild test robot diff --git a/drivers/media/pci/solo6x10/solo6x10-disp.c

[next:master 7707/8903] drivers/media/pci/solo6x10/solo6x10-disp.c:221 solo_set_motion_block() error: potential null dereference 'buf'. (kzalloc returns null)

2014-07-25 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 5a7439efd1c5c416f768fc550048ca130cf4bf99 commit: 28cae868cd245b6bb2f27bce807e9d78afcf8ea2 [7707/8903] [media] solo6x10: move out of staging into drivers/media/pci. drivers/media/pci/solo6x10/solo6x10-disp.c:2

[PATCH v3 3/3] media: atmel-isi: add primary DT support

2014-07-25 Thread Josh Wu
This patch add the DT support for Atmel ISI driver. It use the same v4l2 DT interface that defined in video-interfaces.txt. Signed-off-by: Josh Wu Cc: devicet...@vger.kernel.org Reviewed-by: Laurent Pinchart --- v2 -> v3: add bus-width property support. add error handling when calling atmel_

[PATCH v3 1/3] media: atmel-isi: add v4l2 async probe support

2014-07-25 Thread Josh Wu
Signed-off-by: Josh Wu --- v2 -> v3: no change. drivers/media/platform/soc_camera/atmel-isi.c | 5 + include/media/atmel-isi.h | 4 2 files changed, 9 insertions(+) diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atm

[PATCH v3 2/3] media: atmel-isi: convert the pdata from pointer to structure

2014-07-25 Thread Josh Wu
Now the platform data is initialized by allocation of isi structure. In the future, we use pdata to store the dt parameters. Signed-off-by: Josh Wu --- v2 -> v3: use sizeof(isi->pdata) instead of using sizeof(struct). drivers/media/platform/soc_camera/atmel-isi.c | 22 +++---

[PATCH v3 0/3] media: atmel-isi: Add DT support for Atmel ISI driver

2014-07-25 Thread Josh Wu
This patch series add DT support for atmel ISI driver. It can support the common v4l2 DT interfaces. v2 -> v3: support bus-width property for atmel-isi endpoint. v1 -> v2: modified the device tree binding document to remove an optonal property. Josh Wu (3): atmel-isi: add v4l2 async probe

[PATCH] libv4l-mplane: make it aware of the extended pix_format fields

2014-07-25 Thread Hans Verkuil
The v4l2_pix_format struct has been extended with new fields. Let libv4l-mplane make use of that so that the v4l2_pix_format_mplane 'flags' field can be reported in v4l2_pix_format as well. Signed-off-by: Hans Verkuil diff --git a/lib/libv4l-mplane/libv4l-mplane.c b/lib/libv4l-mplane/libv4l-mp

[GIT PULL 3.17] SDR related build fixes

2014-07-25 Thread Antti Palosaari
The following changes since commit 488046c237f3b78f91046d45662b318cd2415f64: [media] rc: Fix compilation of st_rc and sunxi-cir (2014-07-23 23:04:17 -0300) are available in the git repository at: git://linuxtv.org/anttip/media_tree.git sdr_pull for you to fetch changes up to 833f08be8e86

[PATCH 2/2] Kconfig: rtl2832_sdr must depends on USB

2014-07-25 Thread Antti Palosaari
Fixes error: [next:master 7435/8702] ERROR: "usb_alloc_urb [drivers/media/dvb-frontends/rtl2832_sdr.ko] undefined! rtl2832_sdr driver implements own USB streaming for SDR data. Logically that functionality belongs to USB interface driver, but currently it is implemented here. Reported-by: kbuild

[PATCH 1/2] Kconfig: fix tuners build warnings

2014-07-25 Thread Antti Palosaari
[next:master 7472/8702] warning: (USB_MSI2500) selects MEDIA_TUNER_MSI001 which has unmet direct dependencies ((MEDIA_ANALOG_TV_SUPPORT || ..) && ..) [next:master 7698/8702] warning: (MEDIA_TUNER && ..) selects MEDIA_TUNER_XC5000 which has unmet direct dependencies ((MEDIA_ANALOG_TV_SUPPORT || ..)

Re: [PATCH] vb2: fix multiplanar read() with non-zero data_offset

2014-07-25 Thread Hans Verkuil
On 07/25/14 11:09, Hans Verkuil wrote: > If this is a multiplanar buf_type and the plane we want to read has a > non-zero data_offset, then that data_offset was not taken into account. > > Note that read() or write() for formats with more than one plane is currently > not allowed, hence the use of

[PATCH] vb2: fix multiplanar read() with non-zero data_offset

2014-07-25 Thread Hans Verkuil
If this is a multiplanar buf_type and the plane we want to read has a non-zero data_offset, then that data_offset was not taken into account. Note that read() or write() for formats with more than one plane is currently not allowed, hence the use of 'planes[0]' since this is only relevant for a si

[PATCH] V4L/DVB: dvb-usb-v2: Update firmware and driver for performance of ITEtech IT9135

2014-07-25 Thread Bimow Chen
Fix performance issue of IT9135 AX and BX chip versions. >From 57fe102419e83e73080af15cc3ad3fe241d7f8b4 Mon Sep 17 00:00:00 2001 From: Bimow Chen Date: Thu, 24 Jul 2014 13:23:39 +0800 Subject: [PATCH 1/1] Update firmware and driver for performance of ITEtech IT9135 Fix performance issue of IT9135

Re: [RFC PATCH] Docbook/media: improve data_offset/bytesused documentation

2014-07-25 Thread Hans Verkuil
On 07/21/2014 03:30 PM, Nicolas Dufresne wrote: > Le lundi 21 juillet 2014 à 15:16 +0200, Hans Verkuil a écrit : >> + Note that data_offset is included in >> bytesused. >> + So the size of the image in the plane is >> + >> bytesused-data_offset >> at >> +

Re: [PATCH v6 3/6] rcar_vin: add devicetree support

2014-07-25 Thread Ben Dooks
On 23/07/14 19:23, Guennadi Liakhovetski wrote: > Add support for devicetree probe for the rcar-vin > driver. > > Signed-off-by: Ben Dooks > [g.liakhovet...@gmx.de fix a typo, sort headers alphabetically] > Signed-off-by: Guennadi Liakhovetski > --- > > Ben, is this version ok? >From looking a

[GIT PULL FOR v3.17/18] miro/si4713 RDS enhancements

2014-07-25 Thread Hans Verkuil
Mauro, I leave it to you whether to merge this for 3.17 or 3.18. Note that this pull request includes (and requires) the patches from my earlier pull request: https://patchwork.linuxtv.org/patch/25026/ The patches from that pull request are definitely for 3.17, but the miro and si4713 enhancemen

[GIT PULL FOR v3.17] Two code fixes, two doc fixes

2014-07-25 Thread Hans Verkuil
Two vb2 patches: one fixes outdated comments, one fixes a poll bug w.r.t. output streams (found while adding output streaming support to qv4l2). One v4l2-ctrls enhancement: simplify how controls are set from within the kernel and add a function to set a string controls. One DocBook clarification