[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 469399. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Split off the statistics CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 Files: lldb/include/lldb/API/SBDebugger.

[Lldb-commits] [lldb] 8c7a1f8 - Revert "[lldb] Fix member access in GetExpressionPath"

Author: Jonas Devlieghere Date: 2022-10-20T15:21:59-07:00 New Revision: 8c7a1f87617067bc23c2e0733fe5e3202e1d6e81 URL: https://github.com/llvm/llvm-project/commit/8c7a1f87617067bc23c2e0733fe5e3202e1d6e81 DIFF: https://github.com/llvm/llvm-project/commit/8c7a1f87617067bc23c2e0733fe5e3202e1d6e81.d

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

yinghuitan updated this revision to Diff 469376. yinghuitan added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/ https://reviews.llvm.org/D136295 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldb

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

yinghuitan updated this revision to Diff 469374. yinghuitan added a comment. Directly raise signal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/ https://reviews.llvm.org/D136295 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

This revision was automatically updated to reflect the committed changes. Closed by commit rGba8ded6820fa: [lldb] Don't check environment default char signedness when creating clang type… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] ba8ded6 - [lldb] Don't check environment default char signedness when creating clang type for "char"

Author: Arthur Eubanks Date: 2022-10-20T15:03:36-07:00 New Revision: ba8ded6820fa610c7460fe86cd1f41f1df4bcc6c URL: https://github.com/llvm/llvm-project/commit/ba8ded6820fa610c7460fe86cd1f41f1df4bcc6c DIFF: https://github.com/llvm/llvm-project/commit/ba8ded6820fa610c7460fe86cd1f41f1df4bcc6c.diff

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Improve ParseDeclsForContext time.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1413-1414 if (context.isTranslationUnit()) { -ParseAllNamespacesPlusChildrenOf(llvm::None); +ParseAllTypes(); +ParseAllFunctionsAndNonLocalVars(); return; --

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Improve ParseDeclsForContext time.

zequanwu updated this revision to Diff 469350. zequanwu edited the summary of this revision. zequanwu added a comment. Don't try to complete types in `PdbAstBuilder::ParseDeclsForContext`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136006/new/ h

[Lldb-commits] [PATCH] D136306: [lldb][CPlusPlus] Add abi_tag support to the CPlusPlusNameParser

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. As much as I dislike expanding our hand-rolled parser, this does seem small and important enough to warrant doing it! Comment at: lldb/source/Plugins/Language/CPlusPlus/CP

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

clayborg updated this revision to Diff 469344. clayborg added a comment. Also test on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136207/new/ https://reviews.llvm.org/D136207 Files: lldb/source/Symbol/CompileUnit.cpp lldb/test/API/

[Lldb-commits] [PATCH] D136371: [trace][intel pt] Correctly treat kernel CPUs as individual threads

This revision was automatically updated to reflect the committed changes. Closed by commit rG20c7ec127240: [lldb][trace] Correctly treat kernel CPUs as individual threads (authored by persona0220). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136371

[Lldb-commits] [lldb] 20c7ec1 - [lldb][trace] Correctly treat kernel CPUs as individual threads

Author: Sujin Park Date: 2022-10-20T13:37:08-07:00 New Revision: 20c7ec12724059388e51e9d00f5c63983ad0e146 URL: https://github.com/llvm/llvm-project/commit/20c7ec12724059388e51e9d00f5c63983ad0e146 DIFF: https://github.com/llvm/llvm-project/commit/20c7ec12724059388e51e9d00f5c63983ad0e146.diff LO

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

clayborg updated this revision to Diff 469342. clayborg added a comment. Create a new "resolved_sc" that gets used to resolve the line_entry's address. If the resolving goes to plan, append that symbol context, else append the original one. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D136371: [trace][intel pt] Correctly treat kernel CPUs as individual threads

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice. I expected something as simple as that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136371/new/ https://reviews.llvm.org/D136371 _

[Lldb-commits] [PATCH] D136371: [trace][intel pt] Correctly treat kernel CPUs as individual threads

persona0220 created this revision. persona0220 added reviewers: wallace, jj10306. Herald added a project: All. persona0220 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Resolved a bug in kernel decoding and correctly treat kernel CPUs as

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

zequanwu added a comment. In D136209#3866933 , @rnk wrote: > Right, so `cantFail` must be an assertions-only check. That's not great. With assertion enabled, lldb still silently deserialize member functions as non-member functions. My guess is that `Typ

[Lldb-commits] [PATCH] D136306: [lldb][CPlusPlus] Add abi_tag support to the CPlusPlusNameParser

Michael137 updated this revision to Diff 469282. Michael137 added a comment. - Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136306/new/ https://reviews.llvm.org/D136306 Files: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusNamePa

[Lldb-commits] [PATCH] D136306: [WIP][lldb][CPlusPlus] Add abi_tag support to the CPlusPlusNameParser

Michael137 updated this revision to Diff 469267. Michael137 added a comment. - Support certain special tokens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136306/new/ https://reviews.llvm.org/D136306 Files: lldb/source/Plugins/Language/CPlusPlu

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

JDevlieghere added a comment. Hey, this patch still breaks TestArray.py. Could you please take another look? https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/47748/testReport/lldb-api/commands_frame_diagnose_array/TestArray_py/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a comment. In D134878#3869947 , @mehdi_amini wrote: > From what I saw when you posted the discourse thread initially, I understand > you're targeting user-visible features, and mostly from the "toolchain" side > of the project. > Ho

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D136011#3866854 , @aeubanks wrote: > In D136011#3862150 , @labath wrote: > >> > > Maybe looking for a "ch

[Lldb-commits] [PATCH] D135031: [lldb] [llgs] Move client-server communication into a separate thread (WIP)

labath added a comment. FWIW, I tried the to run the benchmark on an apple machine and got roughly the same results (although I never managed to get it to run to completion). I also don't know how much of a deal that is. I think someone from Apple ought to comment on that. However, I have to s

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Improve ParseDeclsForContext time.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Okay, sounds good then. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1413-1414 if (context.isTranslationUnit()) { -ParseAllNamespacesPlusChil

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

labath added inline comments. Comment at: lldb/source/Symbol/CompileUnit.cpp:336 } else { line_entry.range.GetBaseAddress().CalculateSymbolContext(&sc, resolve_scope); I think this would

[Lldb-commits] [PATCH] D136306: [WIP][lldb][CPlusPlus] Add abi_tag support to the CPlusPlusNameParser

Michael137 planned changes to this revision. Michael137 added a comment. Wonder if we should skip the tags rather than consume them. Depends on what DW_AT_name says. Also I suspect there are cases where we would want to include tags and others where we dont Will need to handle special character

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

labath added a comment. Given what Reid said, would it be possible to make a test case that fails in an asserts build? Or was it maybe failing already there? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136209/new/ https://reviews.llvm.org/D13620

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

labath added a comment. If you're explicitly checking for SIGABRT, then you might as well raise that signal directly (`raise(SIGABRT)`) instead of relying on the runtime to do it (in response to an unhandled exception). Or, if you want this to work on windows, then you'll need to adjust the exp

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1528 +DWARFASTParserClang::GetTemplateParametersString(const DWARFDIE &die) { + if (llvm::StringRef(die.GetName()).contains("<")) +return std::string(); re