[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

MaskRay added a comment. > `For posterity, the tests that fail on main are:` > > `Skipped : 43` > [...] You can remove these from the description. They are flaky tests unrelated to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: mlir/test/Transforms/print-op-graph.mlir:1 // RUN: mlir-opt -allow-unregistered-dialect -mlir-elide-elementsattrs-if-larger=2 -view-op-graph %s -o %t 2>&1

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

erikdesjardins added inline comments. Comment at: mlir/test/Transforms/print-op-graph.mlir:9 // DFG: subgraph {{.*}} { -// DFG: v[[ARG0:.*]] [label = "arg0" -// DFG: v[[CONST10:.*]] [label ={{.*}}10 : i32 +// DFG: v[[ARG0:.*]

[Lldb-commits] [PATCH] D142926: [lldb][RFC] Replace SB swig interfaces with API headers

kastiglione added inline comments. Comment at: lldb/include/lldb/API/SBAddress.h:14-16 +#ifdef SWIG +%include "interface/SBAddressDocstrings.i" +#endif bulbazord wrote: > clayborg wrote: > > bulbazord wrote: > > > clayborg wrote: > > > > Do we want two different

[Lldb-commits] [PATCH] D143236: [lldb] Add a way to get a scripted process implementation from the SBAPI

mib updated this revision to Diff 494485. mib marked an inline comment as done. mib added a comment. Add docstring. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143236/new/ https://reviews.llvm.org/D143236 Files: lldb/bindings/interface/SBProcess.i lldb/bindings/python/python-type

[Lldb-commits] [PATCH] D143236: [lldb] Add a way to get a scripted process implementation from the SBAPI

mib added a comment. In D143236#4101429 , @bulbazord wrote: > This is an interesting idea. > > I suppose I find it a little strange that something from the SB API is > passing a void * back to the caller instead of something more well defined > (like an

[Lldb-commits] [PATCH] D143236: [lldb] Add a way to get a scripted process implementation from the SBAPI

bulbazord added a comment. This is an interesting idea. I suppose I find it a little strange that something from the SB API is passing a void * back to the caller instead of something more well defined (like another SB class or some primitive) but I suppose that's not the worst thing in the wo

[Lldb-commits] [PATCH] D143236: [lldb] Add a way to get a scripted process implementation from the SBAPI

mib created this revision. mib added reviewers: bulbazord, JDevlieghere, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new `GetImplementation` method to the SBProcess class in

[Lldb-commits] [PATCH] D143232: Return an error when the CFA resolves to no known register, instead of segfaulting

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM. I wonder if there's a good way to exercise this with a test? Like maybe we can create some bogus unwind information and see if LLDB falls over when consuming it? Repository: rG

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

MaskRay added inline comments. Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:638 - EXPECT_THAT(Storage.keys(), ElementsAre(testPath("A.cc"), testPath("A.h"))); + EXPECT_THAT(Storage.keys(), ElementsAre(testPath("A.h"), testPath("A.cc"))); // Make

[Lldb-commits] [PATCH] D143232: Return an error when the CFA resolves to no known register, instead of segfaulting

jasonmolenda created this revision. jasonmolenda added a reviewer: bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. I'm working on a bug repo

[Lldb-commits] [PATCH] D142926: [lldb][RFC] Replace SB swig interfaces with API headers

bulbazord added inline comments. Comment at: lldb/include/lldb/API/SBAddress.h:14-16 +#ifdef SWIG +%include "interface/SBAddressDocstrings.i" +#endif clayborg wrote: > bulbazord wrote: > > clayborg wrote: > > > Do we want two different .i files? Right now we have

[Lldb-commits] [PATCH] D142926: [lldb][RFC] Replace SB swig interfaces with API headers

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBAddress.h:14-16 +#ifdef SWIG +%include "interface/SBAddressDocstrings.i" +#endif bulbazord wrote: > clayborg wrote: > > Do we want two different .i files? Right now we have > > both"interface/SB

[Lldb-commits] [PATCH] D143122: [lldb/python] Fix scripted_platform python module creation

This revision was automatically updated to reflect the committed changes. Closed by commit rG35ef899f94eb: [lldb/python] Fix scripted_platform python module creation (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143122/new/ https:

[Lldb-commits] [lldb] 2403fa4 - [lldb] Fix typo in ScriptedProcess python docstrings (NFC)

Author: Med Ismail Bennani Date: 2023-02-02T15:22:52-08:00 New Revision: 2403fa46b9e19b02f17ffd315e49110b7b2ebdea URL: https://github.com/llvm/llvm-project/commit/2403fa46b9e19b02f17ffd315e49110b7b2ebdea DIFF: https://github.com/llvm/llvm-project/commit/2403fa46b9e19b02f17ffd315e49110b7b2ebdea.

[Lldb-commits] [lldb] 35ef899 - [lldb/python] Fix scripted_platform python module creation

Author: Med Ismail Bennani Date: 2023-02-02T15:22:52-08:00 New Revision: 35ef899f94eb3c52b9ba5671be606d755053d90e URL: https://github.com/llvm/llvm-project/commit/35ef899f94eb3c52b9ba5671be606d755053d90e DIFF: https://github.com/llvm/llvm-project/commit/35ef899f94eb3c52b9ba5671be606d755053d90e.

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

jasonmolenda added a comment. tl;dr: watchpoints don't work on things like arm targets with a JTAG gdb stub that doesn't support `qWatchpointSupportInfo:` or `qHostInfo` with the `watchpoint_exceptions_received` key. Nearly all of this patch is mechanical, and IMO the question is whether I sho

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

jasonmolenda updated this revision to Diff 494428. jasonmolenda added a comment. Ah, I wasn't paying close enough attention and got the logic for MIPS/PPC64 watchpoint exceptions backwards in my update to GDBRemoteCommunicationClient::GetWatchpointReportedAfter, update patch for that. Reposito

[Lldb-commits] [lldb] d980860 - Add usage info for backtick to the lldb tutorial.

Author: Jim Ingham Date: 2023-02-02T13:47:12-08:00 New Revision: d98086036a62e4e9c912c3b15bf16893d3df41da URL: https://github.com/llvm/llvm-project/commit/d98086036a62e4e9c912c3b15bf16893d3df41da DIFF: https://github.com/llvm/llvm-project/commit/d98086036a62e4e9c912c3b15bf16893d3df41da.diff LO

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. There are two

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

mib added inline comments. Comment at: lldb/include/lldb/Utility/ProcessInfo.h:90-110 + bool IsScriptedProcess() const { +return !m_scripted_process_class_name.empty(); + } + + std::string GetScriptedProcessClassName() const { +return m_scripted_process_class_name; +

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/ProcessInfo.h:90-110 + bool IsScriptedProcess() const { +return !m_scripted_process_class_name.empty(); + } + + std::string GetScriptedProcessClassName() const { +return m_scripted_process_class_

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

avogelsgesang added a comment. > This change makes me a little nervous, but mostly because I don't quite > understand the design here. > So ASTImporter does not have a check whether src context and dst context are > identical? I am completely with you. I also don't understand the design of `AST

[Lldb-commits] [PATCH] D143213: [lldb/Plugins] Introduce Multiplexer & ScriptedMultiplexer

mib created this revision. mib added reviewers: JDevlieghere, jingham, labath. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new core component to LLDB: Multiplexer. The goal of a mul

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

mib requested review of this revision. mib added inline comments. Comment at: lldb/include/lldb/Utility/ProcessInfo.h:90-110 + bool IsScriptedProcess() const { +return !m_scripted_process_class_name.empty(); + } + + std::string GetScriptedProcessClassName() const { +re

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

aprantl added a comment. This change makes me a little nervous, but mostly because I don't quite understand the design here. So ASTImporter does not have a check whether src context and dst context are identical? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Utility/ProcessInfo.h:90-110 + bool IsScriptedProcess() const { +return !m_scripted_process_class_name.empty(); +

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione updated this revision to Diff 494401. kastiglione edited the summary of this revision. kastiglione added a comment. Add display options to `dwim-print` command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://reviews.ll

[Lldb-commits] [PATCH] D143068: [lldb][SymbolFileDWARF] Support by-name lookup of global variables in inline namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8c9b30eb3e8: [lldb][SymbolFileDWARF] Support by-name lookup of global variables in inline… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] f8c9b30 - [lldb][SymbolFileDWARF] Support by-name lookup of global variables in inline namespaces

Author: Michael Buch Date: 2023-02-02T11:35:29Z New Revision: f8c9b30eb3e8cffc6c7adaa3003c774422643cf7 URL: https://github.com/llvm/llvm-project/commit/f8c9b30eb3e8cffc6c7adaa3003c774422643cf7 DIFF: https://github.com/llvm/llvm-project/commit/f8c9b30eb3e8cffc6c7adaa3003c774422643cf7.diff LOG:

[Lldb-commits] [PATCH] D143022: [lldb][Test] Fix import-std-module and data-formatter tests on older compilers

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3c66729887d6: [lldb][Test] Fix import-std-module and data-formatter tests on older compilers (authored by Michael137). Re

[Lldb-commits] [lldb] 3c66729 - [lldb][Test] Fix import-std-module and data-formatter tests on older compilers

Author: Michael Buch Date: 2023-02-02T11:34:07Z New Revision: 3c66729887d6113068025776994b4c49bd8e45e2 URL: https://github.com/llvm/llvm-project/commit/3c66729887d6113068025776994b4c49bd8e45e2 DIFF: https://github.com/llvm/llvm-project/commit/3c66729887d6113068025776994b4c49bd8e45e2.diff LOG:

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 494223. paperchalice added a comment. - Use `clang::driver::Driver::GetResourcesPath` - Use `ARG` as prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907/new/ https://reviews.llvm.org/D141907 Files

[Lldb-commits] [lldb] 88ac913 - [lldb] Try harder to optimize away a test variable

Author: Pavel Labath Date: 2023-02-02T11:24:47+01:00 New Revision: 88ac9138f4eb7b8c06154dd6e3f801d9882b66d7 URL: https://github.com/llvm/llvm-project/commit/88ac9138f4eb7b8c06154dd6e3f801d9882b66d7 DIFF: https://github.com/llvm/llvm-project/commit/88ac9138f4eb7b8c06154dd6e3f801d9882b66d7.diff

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

phosek added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:17 + + set(oneValueArgs PREFIX SUBDIR) + cmake_parse_arguments(RESOURCE_DIR "" "${oneValueArgs}" "" ${ARGN}) This variable is only used once on the following line, I'd just inline