Re: [Mesa-dev] [v6 2/9] intel: do not create renderbuffers out of planar images

2013-06-03 Thread Chad Versace
On 05/30/2013 01:20 AM, Daniel Vetter wrote: On Thu, May 30, 2013 at 9:49 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Tue, May 28, 2013 at 01:33:18PM -0700, Eric Anholt wrote: Topi Pohjolainen topi.pohjolai...@intel.com writes: Signed-off-by: Topi Pohjolainen

[Mesa-dev] [PATCH] mesa: Prevent possible out-of-bounds read by save_SamplerParameterfv.

2013-06-03 Thread Vinson Lee
Fixes Out-of-bounds access defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/mesa/main/dlist.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index c37b15e..6c26313 100644 ---

Re: [Mesa-dev] [PATCH 1/2] i965/gen7: Add defines for Memory Object Control State

2013-06-03 Thread Kenneth Graunke
On 05/09/2013 04:48 PM, Chad Versace wrote: Tested-by: Matt Turner matts...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_defines.h | 20 1 file changed, 20 insertions(+) diff --git

[Mesa-dev] hw_gl_select branch status

2013-06-03 Thread Siavash Eliasi
Hello dear mesa developers, What is current status of hw_gl_select branch? Is there any reason keeping it back from being merged into the master branch? Best regards, Siavash Eliasi. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/2] glsl: Make a local variable to avoid restating this array lookup.

2013-06-03 Thread Pohjolainen, Topi
On Fri, May 31, 2013 at 12:37:36PM -0700, Eric Anholt wrote: --- src/glsl/link_uniforms.cpp | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index ad63668..54d54cf 100644 ---

[Mesa-dev] [Bug 63404] [wayland egl] intel_do_flush_locked failed: invalid argument, crash

2013-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63404 Ander Conselvan de Oliveira conselv...@gmail.com changed: What|Removed |Added Status|NEW

Re: [Mesa-dev] hw_gl_select branch status

2013-06-03 Thread Alex Deucher
On Mon, Jun 3, 2013 at 3:22 AM, Siavash Eliasi siavashser...@gmail.com wrote: Hello dear mesa developers, What is current status of hw_gl_select branch? Is there any reason keeping it back from being merged into the master branch? IIRC, Brian wanted to review it a bit more, but I guess he

Re: [Mesa-dev] [v6 2/9] intel: do not create renderbuffers out of planar images

2013-06-03 Thread Rob Clark
On Mon, Jun 3, 2013 at 2:21 AM, Chad Versace chad.vers...@linux.intel.com wrote: I'll say it again: I think we should prevent creation of 2D texture targets from dma_buf images, and permit only creation of external textures. yeah, I think the intention was only external textures.. I can't

Re: [Mesa-dev] and a random apitrace/gallium question..

2013-06-03 Thread Jose Fonseca
- Original Message - On Fri, May 31, 2013 at 10:18 AM, José Fonseca jose.r.fons...@gmail.com wrote: I'd support such change. Be it through GL_GREMEDY_string_marker, or ARB_debug_output's glDebugMessageInsertARB(DEBUG_SOURCE_THIRD_PARTY_ARB, ...), or KHR_debug's glPushDebugGroup().

Re: [Mesa-dev] and a random apitrace/gallium question..

2013-06-03 Thread Rob Clark
On Mon, Jun 3, 2013 at 10:41 AM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - On Fri, May 31, 2013 at 10:18 AM, José Fonseca jose.r.fons...@gmail.com wrote: I'd support such change. Be it through GL_GREMEDY_string_marker, or ARB_debug_output's

[Mesa-dev] [Bug 65225] [softpipe] piglit interpolation-none-gl_BackColor-flat-fixed regression

2013-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65225 --- Comment #1 from Zack Rusin za...@vmware.com --- That seems to be passing now, is that right? I think I fixed it in a commit 978d5ed06bfc3d87a4b1ca1981caeeaa88de2790 draw: fix vs/fs input/output mismatches committed right after the one you

[Mesa-dev] [PATCH] softpipe: draw_find_shader_output returns -1 on invalid outputs

2013-06-03 Thread Zack Rusin
It was changed from 0 to allow shader outputs at 0 that are different from position. Signed-off-by: Zack Rusin za...@vmware.com --- src/gallium/drivers/softpipe/sp_state_derived.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] hw_gl_select branch status

2013-06-03 Thread Andreas Boll
I've rebased the patch and fixed up some build failures. If you want to play with it, here is the updated branch: http://cgit.freedesktop.org/~ab/mesa/log/?h=hw_gl_select2 And for more information there is this bug report: https://bugs.freedesktop.org/show_bug.cgi?id=34495 Andreas. 2013/6/3

Re: [Mesa-dev] [PATCH] softpipe: draw_find_shader_output returns -1 on invalid outputs

2013-06-03 Thread Brian Paul
On Thu, May 30, 2013 at 3:03 PM, Zack Rusin za...@vmware.com wrote: It was changed from 0 to allow shader outputs at 0 that are different from position. Signed-off-by: Zack Rusin za...@vmware.com --- src/gallium/drivers/softpipe/sp_state_derived.c |2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] mesa: Prevent possible out-of-bounds read by save_SamplerParameterfv.

2013-06-03 Thread Brian Paul
On Mon, Jun 3, 2013 at 12:24 AM, Vinson Lee v...@freedesktop.org wrote: Fixes Out-of-bounds access defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/mesa/main/dlist.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] hw_gl_select branch status

2013-06-03 Thread Brian Paul
On Mon, Jun 3, 2013 at 7:26 AM, Alex Deucher alexdeuc...@gmail.com wrote: On Mon, Jun 3, 2013 at 3:22 AM, Siavash Eliasi siavashser...@gmail.com wrote: Hello dear mesa developers, What is current status of hw_gl_select branch? Is there any reason keeping it back from being merged into

Re: [Mesa-dev] [PATCH 00/15] Fixes for MSAA GLX visuals, u_blitter cleanups

2013-06-03 Thread Brian Paul
On Sat, Jun 1, 2013 at 8:29 AM, Marek Olšák mar...@gmail.com wrote: This series fixes a lot of issues with MSAA visuals, in particular the management of MSAA front and back buffers in st/dri and CopyPixels in st/mesa. There is a change in st/dri which may improve performance if a DRI2

Re: [Mesa-dev] and a random apitrace/gallium question..

2013-06-03 Thread Jose Fonseca
- Original Message - On Mon, Jun 3, 2013 at 10:41 AM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - On Fri, May 31, 2013 at 10:18 AM, José Fonseca jose.r.fons...@gmail.com wrote: I'd support such change. Be it through GL_GREMEDY_string_marker, or

Re: [Mesa-dev] [v6 2/9] intel: do not create renderbuffers out of planar images

2013-06-03 Thread Eric Anholt
Chad Versace chad.vers...@linux.intel.com writes: On 05/30/2013 01:20 AM, Daniel Vetter wrote: On Thu, May 30, 2013 at 9:49 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Tue, May 28, 2013 at 01:33:18PM -0700, Eric Anholt wrote: Topi Pohjolainen topi.pohjolai...@intel.com writes:

Re: [Mesa-dev] and a random apitrace/gallium question..

2013-06-03 Thread Rob Clark
On Mon, Jun 3, 2013 at 11:56 AM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - On Mon, Jun 3, 2013 at 10:41 AM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - On Fri, May 31, 2013 at 10:18 AM, José Fonseca jose.r.fons...@gmail.com wrote:

Re: [Mesa-dev] [PATCH 08/15] st/mesa: make generic CopyPixels path work with MSAA visuals

2013-06-03 Thread Brian Paul
On Sat, Jun 1, 2013 at 8:29 AM, Marek Olšák mar...@gmail.com wrote: We have to use pipe-blit, not resource_copy_region, so that the read buffer is resolved if it's multisampled. I also removed the CPU-based copying, which just did format conversion (obsoleted by the blit). Also, the

[Mesa-dev] [PATCH] gallium: Document format name conventions

2013-06-03 Thread Adam Jackson
Other things to maybe add: - More detail on FOURCC formats, or at least a link - SSCALED/USCALED? Not sure what they're meant to be really Signed-off-by: Adam Jackson a...@redhat.com --- src/gallium/docs/format.rst | 39 +++ 1 file changed, 39 insertions(+)

Re: [Mesa-dev] [PATCH 1/4] meta: In CopyTexSubImage, use matching format for Z32_FLOAT_X24S8 textures.

2013-06-03 Thread Paul Berry
On 3 June 2013 09:02, Eric Anholt e...@anholt.net wrote: Paul Berry stereotype...@gmail.com writes: The meta path for CopyTexSubImage operates by reading the source image to a temporary buffer using glReadPixels and then uploading it to the texture using TexSubImage. This patch ensures

Re: [Mesa-dev] [PATCH 4/4] intel: Don't try to blorp or blit CopyTexSubImage(1D_ARRAY).

2013-06-03 Thread Eric Anholt
Paul Berry stereotype...@gmail.com writes: Blorp and the hardware blitter can't be used to implement CopyTexSubImage when the image type is 1D_ARRAY, because of a coordinate system mismatch (the Y coordinate in the source image is supposed to be matched up to the Z coordinate in the

Re: [Mesa-dev] [PATCH 15/15] st/dri: if flushing a drawable, don't set reason=SWAPBUFFERS

2013-06-03 Thread Brian Paul
On Sat, Jun 1, 2013 at 8:29 AM, Marek Olšák mar...@gmail.com wrote: 0 means SWAPBUFFERS. --- src/gallium/state_trackers/dri/drm/dri2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/drm/dri2.c

[Mesa-dev] [Bug 65225] [softpipe] piglit interpolation-none-gl_BackColor-flat-fixed regression

2013-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65225 --- Comment #2 from Vinson Lee v...@freedesktop.org --- (In reply to comment #1) That seems to be passing now, is that right? I think I fixed it in a commit 978d5ed06bfc3d87a4b1ca1981caeeaa88de2790 draw: fix vs/fs input/output mismatches

Re: [Mesa-dev] hw_gl_select branch status

2013-06-03 Thread Siavash Eliasi
On 06/03/2013 08:11 PM, Brian Paul wrote: On Mon, Jun 3, 2013 at 7:26 AM, Alex Deucher alexdeuc...@gmail.com mailto:alexdeuc...@gmail.com wrote: On Mon, Jun 3, 2013 at 3:22 AM, Siavash Eliasi siavashser...@gmail.com mailto:siavashser...@gmail.com wrote: Hello dear mesa developers,

[Mesa-dev] [Bug 65225] [softpipe] piglit interpolation-none-gl_BackColor-flat-fixed regression

2013-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65225 --- Comment #3 from Zack Rusin za...@vmware.com --- Thanks Vinson. It should be now fixed with e54c924a0e9b9a504eae1eb68daaf51f21689629 , softpipe: draw_find_shader_output returns -1 on invalid outputs. -- You are receiving this mail because:

Re: [Mesa-dev] and a random apitrace/gallium question..

2013-06-03 Thread José Fonseca
Thanks. That sounds handy. Another potentially very useful improvement along those lines, would be for apitrace to replay GL_KHR_debug's glObjectLabel() calls, and then use those application supplied labels instead of numbers when dumping state (in qapitrace). This would enable the app developer

Re: [Mesa-dev] Do we support front buffer rendering with EGL? Do we want to?

2013-06-03 Thread Chad Versace
On 05/31/2013 03:01 PM, Paul Berry wrote: The EGL 1.4 spec leaves some wiggle room about whether front buffer rendering is allowed, to accommodate window systems that don't permit front buffer rendering. However, since X11 supports front buffer rendering, it seems to me that Mesa-EGL-X11 ought

Re: [Mesa-dev] [PATCH] i965: Fix glColorPointer(GL_FIXED)

2013-06-03 Thread Kenneth Graunke
On 05/31/2013 03:49 PM, Chad Versace wrote: When a gl_client_array is created with glColorPointer, gl_client_array::Normalized is true. This caused the translation from the gl_client_array's type to a BRW_SURFACEFORMAT to assertion fail. Yes, it does set Normalized, and yes, that would cause

[Mesa-dev] [PATCH 1/4] gallivm: (trivial) fix lp_build_concat_n

2013-06-03 Thread sroland
From: Roland Scheidegger srol...@vmware.com The code was designed to handle no-op concat but failed (unless the caller was using same pointer for src and dst). --- src/gallium/auxiliary/gallivm/lp_bld_pack.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/4] gallivm: enhance special sse2 4x4f and 2x8f - 1x16ub conversion

2013-06-03 Thread sroland
From: Roland Scheidegger srol...@vmware.com There's no good reason why it can't handle 2x4f-1x8ub, 1x4f-1x4ub and 1x8f-1x8ub cases, there might be legitimate reasons why we don't have enough input vectors for a full destination vector, and using pack intrinsics should still be much better than

[Mesa-dev] [PATCH 3/4] llvmpipe: cleanup of generate_unswizzled_blend

2013-06-03 Thread sroland
From: Roland Scheidegger srol...@vmware.com Some parameters were used inconsistently, for instance not using block_width/block_height/block_size for deferring number of pixels but rather relying on guesses from the number of fragment shaders etc, so fix this up (no actual change in behavior since

[Mesa-dev] [PATCH 4/4] llvmpipe: reduce alignment requirement for 1d resources from 4x4 to 4x1

2013-06-03 Thread sroland
From: Roland Scheidegger srol...@vmware.com For rendering to buffers, we cannot have any y alignment. So make sure that tile clear commands only clear up to the fb width/height, not more (do this for all resources actually as clearing more seems pointless for other resources too). For the jit fs

[Mesa-dev] [PATCH 2/2] Add test case for recently fixed loop-control underflow bug.

2013-06-03 Thread Carl Worth
To trigger the bug, it suffices to have a line-continuation followed by a newline and then a non-line-continuation backslash. --- ...117-line-continuation-and-non-continuation-backslash.c | 12 ...continuation-and-non-continuation-backslash.c.expected | 13 + 2 files

[Mesa-dev] [PATCH 1/2] glcpp: Fix post-decrement underflow in loop-control variable

2013-06-03 Thread Carl Worth
This loop-control condition with a post-decrement operator would lead to an underflow of collapsed_newlines. This in turn would cause a subsequent execution of the loop to labor inordinately trying to return the loop-control variable to a value of 0 again. Fix this by dis-intertwining the test

Re: [Mesa-dev] [PATCH] i965: Fix glColorPointer(GL_FIXED)

2013-06-03 Thread Eric Anholt
Chad Versace chad.vers...@linux.intel.com writes: When a gl_client_array is created with glColorPointer, gl_client_array::Normalized is true. This caused the translation from the gl_client_array's type to a BRW_SURFACEFORMAT to assertion fail. Fixes the spinning cube's color in Android 4.2's

Re: [Mesa-dev] [PATCH 2/2] Add test case for recently fixed loop-control underflow bug.

2013-06-03 Thread Kenneth Graunke
On 06/03/2013 12:51 PM, Carl Worth wrote: To trigger the bug, it suffices to have a line-continuation followed by a newline and then a non-line-continuation backslash. --- ...117-line-continuation-and-non-continuation-backslash.c | 12

Re: [Mesa-dev] Do we support front buffer rendering with EGL? Do we want to?

2013-06-03 Thread Kenneth Graunke
I don't think we should implement front buffer rendering for EGL unless someone presents a compelling use case. In my mind, front buffer rendering is only something used historically...it has all kinds of caveats about synchronization, doesn't fit well into a world with compositing, and

Re: [Mesa-dev] [PATCH] i965: Fix glColorPointer(GL_FIXED)

2013-06-03 Thread Chad Versace
On 06/03/2013 01:02 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: When a gl_client_array is created with glColorPointer, gl_client_array::Normalized is true. This caused the translation from the gl_client_array's type to a BRW_SURFACEFORMAT to assertion fail. Fixes

[Mesa-dev] [PATCH 1/5] glsl/linker: Use correct array length when linking inter-stage uniforms and varyings.

2013-06-03 Thread Fabian Bieler
Signed-off-by: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/linker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 982fe46..7395ed5 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -1147,7 +1147,7 @@

[Mesa-dev] [PATCH 2/5] glsl: Only call mark_whole_array_access for arrays.

2013-06-03 Thread Fabian Bieler
Otherwise the max_array_access field of scalar variables is set to 0x. This doesn't lead to any errors since that field isn't used for scalar variables but leaving it at zero is probably better. Signed-off-by: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/ast_to_hir.cpp | 8

[Mesa-dev] [PATCH 3/5] glsl: Return error_type instead of NULL if element_type() is called on non array type.

2013-06-03 Thread Fabian Bieler
This matches the behavior of field_type() and other get_*_type() methods. I looked through the calls to element_type() and didn't find a caller that depends on the old behavior. Signed-off-by: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/glsl_types.h | 6 +++--- 1 file changed, 3

[Mesa-dev] [PATCH 4/5] glsl: Don't copy array of sampler parameters when inlining functions.

2013-06-03 Thread Fabian Bieler
Remove The parameter from the list of parameters and replace the derefs in the function body with the deref of the argument. This is the way scalar sampler variables are handled already. Signed-off-by: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/opt_function_inlining.cpp | 4 ++-- 1

[Mesa-dev] [PATCH 5/5] glsl: Update array access tracker of function parameters.

2013-06-03 Thread Fabian Bieler
Uniform arrays are subject to beeing shrunk if higher members were not accessed. Update the max_array_access flag so array members that were only accessed in the function are not optimized away. This fixes Piglit test spec/glsl-1.10/execution/samplers/in-parameter-array.shader_test.

Re: [Mesa-dev] [PATCH 4/4] llvmpipe: reduce alignment requirement for 1d resources from 4x4 to 4x1

2013-06-03 Thread Roland Scheidegger
Jose, I'm actually seeing sort-of-a failure with wgf11rendertargets, but only with vector size 128. After much head scratching, I can guess what might be happening but not sure. What happens it hat wgf11rendertargest terminates (getting the dreaded windows app crash notice, however it does not

Re: [Mesa-dev] [PATCH] intel: Fix copying of separate stencil data in glCopyTexSubImage().

2013-06-03 Thread Eric Anholt
Jordan Justen jljus...@gmail.com writes: On Thu, May 30, 2013 at 3:47 PM, Eric Anholt e...@anholt.net wrote: We were copying the source stencil data onto the destination depth data. Fixes piglit copyteximage other than 1D_ARRAY. --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10

[Mesa-dev] [PATCH] r600g: fix mega_fetch_count

2013-06-03 Thread Grigori Goronzy
According to ISA docs, the range is 1..64, so effectively bytes_to_fetch-1. --- src/gallium/drivers/r600/r600_shader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 81ed3ce..0444579