Re: [Mesa-dev] [PATCH] vbo: Correctly handle attribute offsets in dlist draw.

2016-08-19 Thread Erik Faye-Lund
On Thu, Aug 18, 2016 at 7:50 PM, wrote: > From: Mathias Fröhlich > > Hi, > > I found the below while fixing a similar problem lately in > the immediate mode glBegin/glEnd code path. > > Please review > Thanks > > Mathias > > > > When executing a display list draw with a shader program > using th

Re: [Mesa-dev] [PATCH] vbo: Correctly handle attribute offsets in dlist draw.

2016-08-19 Thread Erik Faye-Lund
On Fri, Aug 19, 2016 at 10:38 AM, Mathias Fröhlich wrote: > On Friday, 19 August 2016 09:20:41 CEST Erik Faye-Lund wrote: >> On Thu, Aug 18, 2016 at 7:50 PM, wrote: >> > From: Mathias Fröhlich >> > >> > Hi, >> > >> > I found the below while

Re: [Mesa-dev] [PATCH] Revert "foo"

2016-09-01 Thread Erik Faye-Lund
On Thu, Sep 1, 2016 at 11:36 AM, Emil Velikov wrote: > This reverts commit 917e906379bc261c65e2cc4942d7bd3d8366f030. Huh? I can't see this commit in mesa.git... ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailm

Re: [Mesa-dev] [PATCH 1/7] EGL: Update eglext.h

2016-09-12 Thread Erik Faye-Lund
An easy-ish way of upgrading a single source file from an upstream and keeping the changes that were done on top, is to branch out from the last update-commit, and update there. Then when merged, git will understand that the changes on top should still be applied when merging. Unfortunately, it bre

Re: [Mesa-dev] [PATCH 03/10] nir: add helpers to check if we can unroll loops

2016-09-16 Thread Erik Faye-Lund
On Thu, Sep 15, 2016 at 9:03 AM, Timothy Arceri wrote: > This will be used by the loop unroll and lcssa passes. > > V2: > - Check instruction count is not too large for unrolling > - Add helper for complex loop unrolling > --- > src/compiler/nir/nir.h | 31 +++ > 1 fil

Re: [Mesa-dev] [PATCH 02/10] nir: Add a loop analysis pass

2016-09-16 Thread Erik Faye-Lund
On Thu, Sep 15, 2016 at 9:03 AM, Timothy Arceri wrote: > + const int bias[] = { -1, 1, 1 }; > + > + for (unsigned i = 0; i < ARRAY_SIZE(bias); i++) { > + iter_int = iter_int + bias[i]; > + > + switch (cond_op) { > + case nir_op_ige: > + case nir_op_ilt: > + case nir_op

Re: [Mesa-dev] [PATCH] st/mesa: only enable MSAA coverage options when we have a MSAA buffer

2016-09-18 Thread Erik Faye-Lund
On Fri, Sep 16, 2016 at 4:42 PM, Brian Paul wrote: > On 09/16/2016 08:07 AM, Marek Olšák wrote: >> >> On Thu, Sep 15, 2016 at 11:20 PM, Brian Paul wrote: >>> >>> Regardless of whether GL_MULTISAMPLE is enabled (it's enabled by default) >>> we should not set the alpha_to_coverage or alpha_to_one f

Re: [Mesa-dev] Expose ES 3.2 symbols in libGLESv2.so?

2016-09-22 Thread Erik Faye-Lund
On Wed, Sep 21, 2016 at 8:57 PM, Kenneth Graunke wrote: > Commit 5921f372c89a68fac6ddefc009442721d9df4db2 exposed GLES 3.1 symbols > in libGLESv2.so. Are we supposed to do the same thing for GLES 3.2? > > I imagine we're supposed to, but I'm not certain what spec actually > defines the ABI or whe

Re: [Mesa-dev] Expose ES 3.2 symbols in libGLESv2.so?

2016-09-22 Thread Erik Faye-Lund
On Thu, Sep 22, 2016 at 5:45 PM, Emil Velikov wrote: > On 22 September 2016 at 08:10, Erik Faye-Lund wrote: >> On Wed, Sep 21, 2016 at 8:57 PM, Kenneth Graunke >> wrote: >>> Commit 5921f372c89a68fac6ddefc009442721d9df4db2 exposed GLES 3.1 symbols >>> in libGLES

[Mesa-dev] [PATCH] docs: correct name for GL_OES_primitive_bounding_box

2016-04-18 Thread Erik Faye-Lund
When this extension was added, an underscore were mistakenly replaced by a space. Let's correct this, so it's a tad easier to grep for this extension. Signed-off-by: Erik Faye-Lund --- Just a tiny nit I noticed while reading docs... docs/GL3.txt | 2 +- 1 file changed, 1 inser

Re: [Mesa-dev] Question about handling RGBA/BGRA in etnaviv driver

2017-02-03 Thread Erik Faye-Lund
On Fri, Feb 3, 2017 at 11:06 AM, Wladimir wrote: > Yes, but it seems suboptimal, incurring overhead on every rendered pixel. Why would this incur overhead? Can't the etnaviv-hardware perform swizzles for free? I'd assume you could just remap writes to gl_FragColor-compoents... > > Another way th

Re: [Mesa-dev] Required-for-rendering internal formats

2016-10-13 Thread Erik Faye-Lund
On Thu, Oct 13, 2016 at 5:35 PM, Nicolai Hähnle wrote: > On 13.10.2016 17:15, Ilia Mirkin wrote: >> >> Anyone else have opinions on this? Should st/mesa be adding >> PIPE_BIND_RENDER_TARGET for all textures of the internal formats >> listed in table 8.12? (Which would, in this case, force RGBA8 to

Re: [Mesa-dev] [PATCH 2/2] spirv: Use a simpler and more correct implementaiton of tanh()

2016-12-10 Thread Erik Faye-Lund
m_float(nb, > 1))); > return; > + } > > case GLSLstd450Asinh: >val->ssa->def = nir_fmul(nb, nir_fsign(nb, src[0]), Otherwise, looks good! Reviewed-by: Erik Faye-Lund ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/7] gallium: add FBFETCH opcode to retrieve the current sample value

2017-01-04 Thread Erik Faye-Lund
On Jan 2, 2017 06:03, "Ilia Mirkin" wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- src/gallium/docs/source/tgsi.rst | 11 +++ src/gallium/include/pipe/p_shader_tokens.h | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff

Re: [Mesa-dev] [PATCH 3/7] gallium: add FBFETCH opcode to retrieve the current sample value

2017-01-04 Thread Erik Faye-Lund
Ah, right. Thanks for the explanation! On Jan 4, 2017 14:02, "Ilia Mirkin" wrote: > On Wed, Jan 4, 2017 at 4:24 AM, Erik Faye-Lund > wrote: > > On Jan 2, 2017 06:03, "Ilia Mirkin" wrote: > > > > Signed-off-by: Ilia Mirkin > > --- &g

Re: [Mesa-dev] [PATCH v2 17/25] spirv: add support for doubles to OpSpecConstant

2017-01-04 Thread Erik Faye-Lund
On Jan 4, 2017 14:45, "Jason Ekstrand" wrote: On Jan 4, 2017 4:54 AM, "Erik Faye-Lund" wrote: On Jan 3, 2017 16:34, "Jason Ekstrand" wrote: On Fri, Dec 16, 2016 at 6:49 AM, Juan A. Suarez Romero wrote: > From: Samuel Iglesias Gonsálvez > > S

Re: [Mesa-dev] [PATCH v3 06/22] spirv: fix SpvOpSpecConstantOp with SpvOpVectorShuffle working with double-based vecs

2017-01-05 Thread Erik Faye-Lund
On Jan 5, 2017 10:20, "Samuel Iglesias Gonsálvez" wrote: We need to pick two 32-bit values per component to perform the right shuffle operation. v2 (Jason): - Add assert to check matching bit sizes (Jason) - Simplify the code to pick components (Jason) Signed-off-by: Samuel Iglesias Gonsálvez

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: > On 11.01.2017 13:17, Marek Olšák wrote: >> >> On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand >> wrote: >>> >>> I'll be honest, I'm not a fan... Given that D3D10 has one defined >>> behavior, >>> D3D9 has another, and GL doesn't specify, I

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 5:32 PM, Marek Olšák wrote: > On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund wrote: >> On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote: >>> On 11.01.2017 13:17, Marek Olšák wrote: >>>> >>>> On Tue, Jan 10, 2

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: > On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand wrote: >> On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 01/11/2017 05:32 PM, Marek Olšák wrote: >&g

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand wrote: > On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund > wrote: >> >> On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote: >> > On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand >> > wrote: >> >>

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 9:22 PM, Samuel Pitoiset wrote: > > > On 01/11/2017 07:34 PM, Erik Faye-Lund wrote: >> >> On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand >> wrote: >>> >>> On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund >>> wrote:

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 9:42 PM, Erik Faye-Lund wrote: > On Wed, Jan 11, 2017 at 9:22 PM, Samuel Pitoiset > wrote: >> >> >> On 01/11/2017 07:34 PM, Erik Faye-Lund wrote: >>> >>> On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand >>> wrote: >>

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-11 Thread Erik Faye-Lund
On Wed, Jan 11, 2017 at 9:49 PM, Erik Faye-Lund wrote: > On Wed, Jan 11, 2017 at 9:42 PM, Erik Faye-Lund wrote: >> On Wed, Jan 11, 2017 at 9:22 PM, Samuel Pitoiset >> wrote: >>> >>> >>> On 01/11/2017 07:34 PM, Erik Faye-Lund wrote: >>>>

Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

2016-07-07 Thread Erik Faye-Lund
On Thu, Jul 7, 2016 at 2:12 AM, Eric Anholt wrote: > This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering > producing some constants that were getting compared. > > total instructions in shared programs: 112276 -> 112198 (-0.07%) > instructions in affected programs: 2239 -

Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

2016-07-07 Thread Erik Faye-Lund
On Thu, Jul 7, 2016 at 7:01 PM, Connor Abbott wrote: > On Thu, Jul 7, 2016 at 12:57 PM, Erik Faye-Lund wrote: >> On Thu, Jul 7, 2016 at 2:12 AM, Eric Anholt wrote: >>> This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering >>> producing some

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Erik Faye-Lund
On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: > On 09.08.2016 15:58, Rob Clark wrote: >> >> tbh, git submodules are more annoying than they need to be, and I'm >> not really terribly excited to use that for something that is a build >> dependency. Maybe just move it into libdrm instead? >

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Erik Faye-Lund
On Tue, Aug 9, 2016 at 7:24 PM, Nicolai Hähnle wrote: > > On 09.08.2016 18:22, Erik Faye-Lund wrote: >> >> On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: >>> >>> On 09.08.2016 15:58, Rob Clark wrote: >>>> >>>> >>>

Re: [Mesa-dev] [PATCH 1/6] nir: Convert ineg(b2i(a)) to a if it's a boolean.

2016-08-10 Thread Erik Faye-Lund
On Wed, Aug 10, 2016 at 4:30 AM, Kenneth Graunke wrote: > On Haswell (GL 3.3): > > total instructions in shared programs: 6211678 -> 6211584 (-0.00%) > instructions in affected programs: 18968 -> 18874 (-0.50%) > helped: 62 > HURT: 0 > LOST: 0 > GAINED: 4 > > On Broadwell (GL 4.4): > > total ins

Re: [Mesa-dev] [PATCH 2/6] nir: Turn bcsel of +/- 1.0 and 0.0 into b2f sequences.

2016-08-10 Thread Erik Faye-Lund
On Wed, Aug 10, 2016 at 4:30 AM, Kenneth Graunke wrote: > On Haswell (GL 3.3): > > total instructions in shared programs: 6208759 -> 6203860 (-0.08%) > instructions in affected programs: 856541 -> 851642 (-0.57%) > helped: 3157 > HURT: 113 > LOST: 7 > GAINED: 15 > > On Broadwell (GL 4.4): > > to

Re: [Mesa-dev] [PATCH 1/6] nir: Convert ineg(b2i(a)) to a if it's a boolean.

2016-08-10 Thread Erik Faye-Lund
On Wed, Aug 10, 2016 at 5:40 PM, Jason Ekstrand wrote: > On Aug 10, 2016 1:00 AM, "Erik Faye-Lund" wrote: >> >> On Wed, Aug 10, 2016 at 4:30 AM, Kenneth Graunke >> wrote: >> > On Haswell (GL 3.3): >> > >> > total instructions in shared

Re: [Mesa-dev] [PATCH 2/6] nir: Turn bcsel of +/- 1.0 and 0.0 into b2f sequences.

2016-08-10 Thread Erik Faye-Lund
On Wed, Aug 10, 2016 at 5:48 PM, Jason Ekstrand wrote: > On Aug 10, 2016 1:02 AM, "Erik Faye-Lund" wrote: >> >> On Wed, Aug 10, 2016 at 4:30 AM, Kenneth Graunke >> wrote: >> > On Haswell (GL 3.3): >> > >> > total instructions in shared

Re: [Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for building ff shader keys.

2016-05-25 Thread Erik Faye-Lund
On Tue, May 24, 2016 at 8:42 AM, wrote: > From: Mathias Fröhlich > > Replaces a loop that iterates all lights and test > which of them is enabled by a loop only iterating over > the bits set in the enabled bitmask. This takes the code from something very obvious and easy to follow to something

Re: [Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for building ff shader keys.

2016-05-27 Thread Erik Faye-Lund
On Fri, May 27, 2016 at 11:59 AM, Mathias Fröhlich wrote: > > Hi, > > On Wednesday, May 25, 2016 12:06:02 you wrote: >> On Tue, May 24, 2016 at 8:42 AM, wrote: >> > From: Mathias Fröhlich >> > >> > Replaces a loop that iterates all lights and test >> > which of them is enabled by a loop only ite

Re: [Mesa-dev] [PATCH 2/2] svga: fix coverity MIXED_ENUMS warning

2016-05-31 Thread Erik Faye-Lund
On Tue, May 31, 2016 at 3:46 PM, Rob Clark wrote: > On Tue, May 31, 2016 at 9:29 AM, Brian Paul wrote: >> On 05/31/2016 07:10 AM, Brian Paul wrote: >>> >>> On 05/29/2016 10:32 AM, Rob Clark wrote: From: Rob Clark Another pipe_resource_usage vs pipe_transfer_usage mixup.

Re: [Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for building ff shader keys.

2016-05-31 Thread Erik Faye-Lund
On Sat, May 28, 2016 at 12:31 PM, Mathias Fröhlich wrote: > So the xor mask handing is non local to the place where we do the > computation of i. > > Brian pointed me to the u_bit_scan function heavily used in gallium. That > definitely > > helps for the basic problem I personally have with this t

Re: [Mesa-dev] [PATCH 2/2] svga: fix coverity MIXED_ENUMS warning

2016-05-31 Thread Erik Faye-Lund
On Tue, May 31, 2016 at 6:14 PM, Roland Scheidegger wrote: > Am 31.05.2016 um 16:33 schrieb Erik Faye-Lund: >> On Tue, May 31, 2016 at 3:46 PM, Rob Clark wrote: >>> On Tue, May 31, 2016 at 9:29 AM, Brian Paul wrote: >>>> On 05/31/2016 07:10 AM, Brian Paul wrote: &

Re: [Mesa-dev] Discussion: C++11 std::future in Mesa

2016-06-01 Thread Erik Faye-Lund
On Wed, Jun 1, 2016 at 3:02 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Wed, Jun 1, 2016 at 2:19 PM, Marek Olšák wrote: >> I'll let you figure it out by yourself. > > Why would you withhold information if you already have it? Are you a > "bad person" or something? The problem has been described

Re: [Mesa-dev] [PATCH V2] meta: Fix indentation in shader code

2016-06-02 Thread Erik Faye-Lund
On Thu, Jun 2, 2016 at 8:25 PM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/common/meta_blit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/common/meta_blit.c > b/src/mesa/drivers/common/meta_blit.c > index 20d3215..d

Re: [Mesa-dev] [PATCH] st/mesa: Remove tautological check (v2)

2016-06-17 Thread Erik Faye-Lund
Now the subject no longer makes any sense. On Thu, Jun 16, 2016 at 7:02 AM, wrote: > From: Francesco Ansanelli > > --- > src/mesa/state_tracker/st_cb_fbo.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_cb_fbo.c > b/src/mesa/state_tracker

Re: [Mesa-dev] [PATCH 0/7] mesa: Enable -fstrict-aliasing

2016-06-28 Thread Erik Faye-Lund
On Mon, Jun 27, 2016 at 11:42 PM, Matt Turner wrote: > Based on work by Davin McCall from last summer. > > The biggest change is to exec_list. Previously, the head and tail sentinels > overlapped, saving the size of a pointer. Unfortunately this is not allowed by > the aliasing rules. > > I have

[Mesa-dev] [PATCH] compiler: avoid warning about redefinition of PYTHON_GEN

2016-10-26 Thread Erik Faye-Lund
PYTHON_GEN is defined to the exact same thing in both Makefile.glsl.am and Makefile.nir.am. This makes automake complain, so let's lift the definition up to Makefile.am, the same way as MKDIR_GEN. Signed-off-by: Erik Faye-Lund --- src/compiler/Makefile.am | 1 + src/com

Re: [Mesa-dev] [PATCH 02/25] anv: remove unused dev_icd.json

2016-04-21 Thread Erik Faye-Lund
On Thu, Apr 21, 2016 at 3:16 PM, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/intel/vulkan/.gitignore | 1 - > src/intel/vulkan/Makefile.am | 1 - > src/intel/vulkan/dev_icd.json.in | 7 --- > 3 files changed, 9 deletions(-) > delete mode 10

Re: [Mesa-dev] [PATCH 03/65] glsl: Add initial functions to implement an on-disk cache

2016-04-30 Thread Erik Faye-Lund
On Fri, Apr 29, 2016 at 3:33 PM, Timothy Arceri wrote: > +/* Create a directory named 'path' if it does not already exist. > + * > + * Returns: 0 if path already exists as a directory or if created. > + * -1 in all other cases. > + */ > +static int > +mkdir_if_needed(char *path) > +{ > +

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-18 Thread Erik Faye-Lund
On Wed, May 18, 2016 at 10:12 AM, Daniel Stone wrote: > Hi, > > On 18 May 2016 at 00:00, Ian Romanick wrote: >> On 05/17/2016 09:59 AM, Ben Widawsky wrote: >>> I think you misstated this. It's not invalid to have any other value. It's >>> invalid to not have one of the 3 values, which I suppose i

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-18 Thread Erik Faye-Lund
On Wed, May 18, 2016 at 1:01 PM, Emil Velikov wrote: > On 18 May 2016 at 09:27, Erik Faye-Lund wrote: >> On Wed, May 18, 2016 at 10:12 AM, Daniel Stone wrote: >>> Hi, >>> >>> On 18 May 2016 at 00:00, Ian Romanick wrote: >>>> On 05/17/2016

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

2017-05-15 Thread Erik Faye-Lund
On Mon, May 15, 2017 at 11:27 AM, Nicolai Hähnle wrote: > Hi all, > > This series aims to simplify how we handle unnamed struct types and fix some > bugs on the way. Some of the patches should be uncontroversial, and all of > them align with my understanding of the GLSL spec, but the spec isn't >

Re: [Mesa-dev] [PATCH 4/9] glcpp: Avoid unnecessary strcmp()

2017-05-22 Thread Erik Faye-Lund
On Sun, May 21, 2017 at 10:49 PM, Thomas Helland wrote: > From: Vladislav Egorov > > strcmp() is slow. Initiate comparison with "__LINE__" or "__FILE__" > only if the identifier starts with '_', which is rare. > > Reviewed-by: Ian Romanick > --- > src/compiler/glsl/glcpp/glcpp-parse.y | 14

Re: [Mesa-dev] [PATCH 01/21] mesa: add vertex_array_vertex_buffers_err() helper

2017-06-01 Thread Erik Faye-Lund
On Jun 1, 2017 15:06, "Samuel Pitoiset" wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/varray.c | 108 -- --- 1 file changed, 61 insertions(+), 47 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index 47528ba2a7..c2

Re: [Mesa-dev] [PATCH 2/2] vc4: Use runtime CPU detection for whether NEON is available.

2017-04-17 Thread Erik Faye-Lund
On Apr 13, 2017 20:59, "Eric Anholt" wrote: This will allow Raspbian's ARMv6 builds to take advantage of the new NEON code, and could prevent problems if vc4 ends up getting used on a v7 CPU without NEON. --- src/gallium/drivers/vc4/vc4_screen.c | 3 +++ src/gallium/drivers/vc4/vc4_tiling.h | 2

Re: [Mesa-dev] [PATCH 2/4] gallium: Enable ARM NEON CPU detection.

2017-05-01 Thread Erik Faye-Lund
On Mon, Apr 24, 2017 at 11:59 PM, Eric Anholt wrote: > I wrote this code with reference to pixman, though I've only decided to > cover Linux (what I'm testing) and Android (seems obvious enough). Linux > has getauxval() as a cleaner interface to the /proc entry, but it's more > glibc-specific and

Re: [Mesa-dev] [PATCH 2/5] glsl: Ban #undefining __LINE__ and friends on GLES2.

2017-05-02 Thread Erik Faye-Lund
On Tue, May 2, 2017 at 7:36 PM, Eric Anholt wrote: > Fixes deqp_gles2 undefine_invalid_object_* failures. > --- > src/compiler/glsl/glcpp/glcpp-parse.y | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y > b/src/compiler/glsl/glcp

Re: [Mesa-dev] [PATCH 2/5] glsl: Ban #undefining __LINE__ and friends on GLES2.

2017-05-02 Thread Erik Faye-Lund
On Wed, May 3, 2017 at 1:23 AM, Eric Anholt wrote: > Erik Faye-Lund writes: > >> On Tue, May 2, 2017 at 7:36 PM, Eric Anholt wrote: >>> Fixes deqp_gles2 undefine_invalid_object_* failures. >>> --- >>> src/compiler/glsl/glcpp/glcpp-parse.y | 7 ++-

[Mesa-dev] [PATCH] meson: add opt-out of libunwind

2017-10-24 Thread Erik Faye-Lund
Libunwind has some issues on some platforms, so let's allow people who have issues to opt-out. This is similar to what we do in automake, and the implementation is modelled after our opt-out for valgrind. Signed-off-by: Erik Faye-Lund --- This fixes a build-problem for me on Arch Linux fo

Re: [Mesa-dev] [PATCH] meson: add opt-out of libunwind

2017-10-25 Thread Erik Faye-Lund
On Wed, Oct 25, 2017 at 8:10 AM, Gert Wollny wrote: > Am Dienstag, den 24.10.2017, 16:44 +0200 schrieb Erik Faye-Lund: >> >> dep_unwind = dependency('libunwind', required : false) >> -if dep_unwind.found() >> +if dep_unwind.found() and with_libunwin

[Mesa-dev] [PATCH] meson: do not search for needless deps

2017-10-25 Thread Erik Faye-Lund
If we don't want to use these deps, there's no good reason to search for them in the first place. This should shave a bit of time for the initial build. --- This would be a way of dealing with Gert's suggestion. Goes on top of the previous patch. Thoughts? meson.build | 20 ++--

Re: [Mesa-dev] [PATCH mesa] meson: be explicit about the version required

2017-10-25 Thread Erik Faye-Lund
On Tue, Oct 24, 2017 at 11:48 PM, Dylan Baker wrote: > Quoting Eric Engestrom (2017-10-24 10:32:36) >> On Tuesday, 2017-10-24 09:40:22 -0700, Dylan Baker wrote: >> > This seems reasonable, could you wrap the hanging indent like >> > meson_options with >> > the closing brace on it's own line and w

Re: [Mesa-dev] [PATCH] meson: do not search for needless deps

2017-10-26 Thread Erik Faye-Lund
On Thu, Oct 26, 2017 at 11:49 AM, Gert Wollny wrote: > > Am Mittwoch, den 25.10.2017, 10:24 +0200 schrieb Erik Faye-Lund: >> If we don't want to use these deps, there's no good reason to search >> for them in the first place. This should shave a bit of t

[Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

2017-10-27 Thread Erik Faye-Lund
This avoids the following build-error when building with emtpy vulkan-drivers and without glx=dri: Meson encountered an error in file src/vulkan/wsi/meson.build, line 30, column 2: Unknown variable "dep_xcb". Signed-off-by: Erik Faye-Lund --- src/meson.build | 4 +++- 1 file

Re: [Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

2017-10-27 Thread Erik Faye-Lund
Yeah, I kinda got that feeling. Your approach seems better. On Oct 27, 2017 19:22, "Dylan Baker" wrote: This just papers over the actual problem, that dep_xcb isn't declared as an empty list with the other glx dependencies. Dylan Quoting Erik Faye-Lund (2017-10-27 04:55:25) &g

Re: [Mesa-dev] [PATCH] meson: declare an empty xcb dependency

2017-10-27 Thread Erik Faye-Lund
On Fri, Oct 27, 2017 at 7:25 PM, Dylan Baker wrote: > This is needed in cases where xcb isn't actually needed as a dependency, > but may still be included somewhere. > > cc: Erik Faye-Lund > cc: Eric Engestrom > Signed-off-by: Dylan Baker Te

[Mesa-dev] [PATCH] meson: use dep_m in libgallium

2017-10-30 Thread Erik Faye-Lund
The u_format_other.c users sqrtf, which on some systems require a math-library. So let's make sure we link with it. Signed-off-by: Erik Faye-Lund --- I noticed this while debugging something else, thought I'd just send it upstream directly. src/gallium/auxiliary/meson.build | 2

[Mesa-dev] [PATCH 2/2] meson: prefer 'auto', 'true', 'false'

2017-10-31 Thread Erik Faye-Lund
This way users don't have to care if these options are boolean or not, as they take the same values (apart from 'auto'). Signed-off-by: Erik Faye-Lund --- I'm not quite sure about this patch. Yes, it cleans up the semantics, but at the same time, it breaks backwards compa

[Mesa-dev] [PATCH 1/2] meson: do not search for needless deps

2017-10-31 Thread Erik Faye-Lund
If we don't want to use these deps, there's no good reason to search for them in the first place. This should shave a bit of time for the initial build. Signed-off-by: Erik Faye-Lund --- meson.build | 20 ++-- meson_options.txt | 14 -- 2 files c

Re: [Mesa-dev] [PATCH] meson: use dep_m in libgallium

2017-10-31 Thread Erik Faye-Lund
On Tue, Oct 31, 2017 at 10:31 AM, Eric Engestrom wrote: > On Monday, 2017-10-30 21:06:25 +0100, Erik Faye-Lund wrote: >> The u_format_other.c users sqrtf, which on some systems require >> a math-library. So let's make sure we link with it. >> >> Signed-off-by:

Re: [Mesa-dev] [PATCH] meson: use dep_m in libgallium

2017-10-31 Thread Erik Faye-Lund
On Tue, Oct 31, 2017 at 11:33 AM, Erik Faye-Lund wrote: > On Tue, Oct 31, 2017 at 10:31 AM, Eric Engestrom > wrote: >> On Monday, 2017-10-30 21:06:25 +0100, Erik Faye-Lund wrote: >>> The u_format_other.c users sqrtf, which on some systems require >>> a math-libra

Re: [Mesa-dev] [PATCH 1/2] meson: do not search for needless deps

2017-10-31 Thread Erik Faye-Lund
On Tue, Oct 31, 2017 at 11:24 AM, Eric Engestrom wrote: > On Tuesday, 2017-10-31 08:29:28 +0100, Erik Faye-Lund wrote: >> If we don't want to use these deps, there's no good reason to search >> for them in the first place. This should shave a bit of time for the >>

Re: [Mesa-dev] [PATCH 1/2] meson: do not search for needless deps

2017-10-31 Thread Erik Faye-Lund
On Tue, Oct 31, 2017 at 12:04 PM, Eric Engestrom wrote: > On Tuesday, 2017-10-31 11:37:25 +0100, Erik Faye-Lund wrote: >> On Tue, Oct 31, 2017 at 11:24 AM, Eric Engestrom >> wrote: >> > On Tuesday, 2017-10-31 08:29:28 +0100, Erik Faye-Lund wrote: >> >> If we d

Re: [Mesa-dev] [PATCH 2/4] st/mesa: use enum types instead of int/unsigned (v3)

2017-11-08 Thread Erik Faye-Lund
On Wed, Nov 8, 2017 at 1:07 AM, Brian Paul wrote: > Use the proper enum types for various variables. Makes life in gdb > a little nicer. Note that the size of enum bitfields must be one > larger so the high bit is always zero (for MSVC). You *could* also do something like this on MSVC to get un

Re: [Mesa-dev] [PATCH 03/22] glformats: Add a mapping for MESA_FORMAT_S_UINT8

2017-08-09 Thread Erik Faye-Lund
On Sat, Aug 5, 2017 at 11:39 AM, Chris Wilson wrote: > Map the user format of GL_DEPTH_COMPONENT, GL_UNSIGNED_BYTE to the > internal format of MESA_FORMAT_S_UINT8. > --- > src/mesa/main/glformats.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/main/glformats.c b/src/mesa/m

Re: [Mesa-dev] [RFC PATCH 2/2] main/format: skip format conversion if src and dst format are equal

2017-08-17 Thread Erik Faye-Lund
On Wed, Aug 16, 2017 at 8:32 PM, Karol Herbst wrote: > Fixes 'KHR-GL45.copy_image.functional' on Nouveau > > Signed-off-by: Karol Herbst > --- > src/mesa/main/format_utils.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/format_utils.c b/src/mesa/main

Re: [Mesa-dev] [PATCH 7/9] spirv: Add vtn_fail and vtn_assert helpers

2017-08-17 Thread Erik Faye-Lund
On Thu, Aug 17, 2017 at 7:22 PM, Jason Ekstrand wrote: > These helpers are much nicer than just using assert because they don't > kill your process. Instead, it longjmps back to spirv_to_nir(), cleans > up all the temporary memory, and nicely returns NULL. While crashing is > completely OK in th

Re: [Mesa-dev] [PATCH 1/3] vbo: simplify vbo_save_NotifyBegin()

2017-07-10 Thread Erik Faye-Lund
Reviewed-by: Erik Faye-Lund On Fri, Jul 7, 2017 at 4:11 PM, Brian Paul wrote: > This function always returned GL_TRUE. Just make it a void function. > Remove unreachable code following the call to vbo_save_NotifyBegin() > in save_Begin() in dlist.c > > There were some stale c

Re: [Mesa-dev] [PATCH 01/15] mesa: Import libtxc_dxtn sources

2017-10-03 Thread Erik Faye-Lund
On Mon, Oct 2, 2017 at 2:57 PM, Emil Velikov wrote: > On 2 October 2017 at 07:59, Matt Turner wrote: >> Straight import of the libtxc_dxtn sources. Will be squashed with next >> commit that reorganizes them into a more familiar form > > The code builds and works like a charm, so I won't bother sq

Re: [Mesa-dev] [PATCH] Replace byte-swapping code with builtins in pack.c

2017-10-06 Thread Erik Faye-Lund
On Thu, Oct 5, 2017 at 8:59 PM, Jochen Rollwagen wrote: > Am 04.10.2017 um 05:59 schrieb Matt Turner: >> >> On Tue, Oct 3, 2017 at 11:01 AM, Jochen Rollwagen >> wrote: >>> >>> From 4cebe50a9bade6717923e104c954f3fad75f71bb Mon Sep 17 00:00:00 2001 >>> From: Jochen Rollwagen >>> Date: Tue, 3 Oct

Re: [Mesa-dev] [PATCH 00/20] meson, gallium edition

2017-10-12 Thread Erik Faye-Lund
On Wed, Oct 11, 2017 at 7:41 PM, Dylan Baker wrote: > This series is somewhat larger than the one to enable classic drivers. I've > made > an effort to split the patches up better this go around, so hopefully that > will > make review easier. > > I have enabled 3 drivers here, which are probably

Re: [Mesa-dev] TGSI 16-bit support

2017-08-24 Thread Erik Faye-Lund
On Wed, Aug 23, 2017 at 6:19 PM, Marek Olšák wrote: > On Wed, Aug 23, 2017 at 3:08 PM, Nicolai Hähnle wrote: >> >> Here's another question: What does "low precision" mean on a texture >> instruction? Are the offsets low precision or is it the output? Maybe we can >> punt on this for now -- at lea

Re: [Mesa-dev] [PATCH 1/2] gallium: Add PIPE_CAP_HALFS

2017-09-02 Thread Erik Faye-Lund
On Sat, Sep 2, 2017 at 2:55 AM, Jan Vesely wrote: > Denotes native half precision float operations capability > > Signed-off-by: Jan Vesely > --- > I can change the spelling to HALVES, but simplified english sounded more > appropriate. > > src/gallium/docs/source/screen.rst | 1 + >

Re: [Mesa-dev] [PATCH 1/2] gallium: Add PIPE_CAP_HALFS

2017-09-04 Thread Erik Faye-Lund
On Mon, Sep 4, 2017 at 4:13 PM, Jan Vesely wrote: > On Sat, 2017-09-02 at 22:21 +0200, Erik Faye-Lund wrote: >> On Sat, Sep 2, 2017 at 2:55 AM, Jan Vesely wrote: >> > Denotes native half precision float operations capability >> > >> > Signed-off-by: Jan Ve

[Mesa-dev] [PATCH 0/3] misc cleanups

2017-03-31 Thread Erik Faye-Lund
Here's a few cleanup-patches I've had in my tree for a while, that I thought I should send upstream soon. Erik Faye-Lund (3): st/mesa: avoid aliasing violation in st_cb_perfmon.c gallium/docs: remove documentation of removed arg glsl: ir_explog_to_explog2 is no more src/ga

[Mesa-dev] [PATCH 1/3] st/mesa: avoid aliasing violation in st_cb_perfmon.c

2017-03-31 Thread Erik Faye-Lund
Signed-off-by: Erik Faye-Lund --- src/mesa/state_tracker/st_cb_perfmon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_perfmon.c b/src/mesa/state_tracker/st_cb_perfmon.c index cd7fdc0..23d32dc 100644 --- a/src/mesa/state_tracker

[Mesa-dev] [PATCH 3/3] glsl: ir_explog_to_explog2 is no more

2017-03-31 Thread Erik Faye-Lund
nt tree if they encounter it. Signed-off-by: Erik Faye-Lund --- src/mesa/program/ir_to_mesa.cpp| 4 +++- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cp

[Mesa-dev] [PATCH 2/3] gallium/docs: remove documentation of removed arg

2017-03-31 Thread Erik Faye-Lund
geom was removed in e968975 ("gallium: remove the geom_flags param from is_format_supported", Tue Mar 8 00:01:58 2011 +0100), but the documentation of it was left over. Let's bring the documentation up to date. Signed-off-by: Erik Faye-Lund --- src/gallium/docs/source/screen.rst

Re: [Mesa-dev] [PATCH 0/3] misc cleanups

2017-04-01 Thread Erik Faye-Lund
Thanks, pushed. On Fri, Mar 31, 2017 at 4:42 PM, Nicolai Hähnle wrote: > Series is > > Reviewed-by: Nicolai Hähnle > > On 31.03.2017 12:57, Erik Faye-Lund wrote: >> >> Here's a few cleanup-patches I've had in my tree for a while, that >> I thought I

Re: [Mesa-dev] [PATCH] glcpp: error on multiple #else directives

2013-10-11 Thread Erik Faye-Lund
On Mon, Sep 23, 2013 at 11:02 PM, Erik Faye-Lund wrote: > On Mon, Sep 23, 2013 at 10:35 PM, Erik Faye-Lund wrote: >> The preprocessor currently eats multiple #else directives >> int the same #if(def) ... #endif block. While I haven't been able >> to find anything th

Re: [Mesa-dev] libGL without X

2013-10-21 Thread Erik Faye-Lund
On Mon, Oct 21, 2013 at 4:05 PM, Chris Healy wrote: > I have a headless platform I need OpenGL to work on that does not have X. > It is x86 with Intel HD 4000 graphics. > > Ultimately, I'm just wanting to use OpenGL to render to memory for encoding > to H.264 and streaming. > > I'm trying to build

Re: [Mesa-dev] libGL without X

2013-10-21 Thread Erik Faye-Lund
On Tue, Oct 22, 2013 at 2:58 AM, Chris Healy wrote: > On Mon, Oct 21, 2013 at 2:03 PM, Erik Faye-Lund wrote: >> On Mon, Oct 21, 2013 at 4:05 PM, Chris Healy wrote: >> > I have a headless platform I need OpenGL to work on that does not have >> > X. >> > I

Re: [Mesa-dev] [PATCH 1/2] glsl: Optimize (not A) or (not B) into not (A and B).

2013-10-24 Thread Erik Faye-Lund
On Thu, Oct 24, 2013 at 2:19 AM, Matt Turner wrote: > A few Serious Sam 3 shaders affected: > > instructions in affected programs: 4384 -> 4344 (-0.91%) > --- > src/glsl/opt_algebraic.cpp | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/glsl/opt_algebraic.cpp b/src/g

Re: [Mesa-dev] [PATCH 2/2] glsl: Optimize (not A) and (not B) into not (A or B).

2013-10-24 Thread Erik Faye-Lund
On Thu, Oct 24, 2013 at 2:19 AM, Matt Turner wrote: > No shader-db changes, but seems like a good idea. > --- > src/glsl/opt_algebraic.cpp | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp > index 3bf0689..1ce9e2d 100644 > --

Re: [Mesa-dev] [PATCH] i965/fs: Drop no-op shifts by 0.

2013-10-24 Thread Erik Faye-Lund
Why is this tagged as i965/fs, when everything seems to happen in the glsl-optimizer? On Thu, Oct 24, 2013 at 5:53 PM, Eric Anholt wrote: > I noticed this in a shader in Unigine Heaven that was spilling. While it > doesn't really reduce register pressure, it shaves a few instructions > anyway (7

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-01 Thread Erik Faye-Lund
On Fri, Nov 1, 2013 at 10:16 AM, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/mesa/main/shaderapi.c | 46 +++--- > 1 file changed, 39 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c > in

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-01 Thread Erik Faye-Lund
On Fri, Nov 1, 2013 at 11:35 AM, Tapani Pälli wrote: > On 11/01/2013 12:21 PM, Erik Faye-Lund wrote: >> >> On Fri, Nov 1, 2013 at 10:16 AM, Tapani Pälli >> wrote: >>> >>> Signed-off-by: Tapani Pälli >&

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-01 Thread Erik Faye-Lund
On Fri, Nov 1, 2013 at 1:08 PM, Tapani Pälli wrote: > On 11/01/2013 12:38 PM, Erik Faye-Lund wrote: >> >> On Fri, Nov 1, 2013 at 11:35 AM, Tapani Pälli >> wrote: >>> >>> On 11/01/2013 12:21 PM, Erik Faye-Lund wrote: >>>> >>>

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-06 Thread Erik Faye-Lund
Sorry for the late reply. On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: > On 11/01/2013 03:31 PM, Erik Faye-Lund wrote: >> >> >> Won't using the git-sha1 as a compatibility-criteria cause issues for >> developers with local changes? I'm not so worried abo

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-06 Thread Erik Faye-Lund
On Wed, Nov 6, 2013 at 7:49 PM, Paul Berry wrote: > On 6 November 2013 09:35, Erik Faye-Lund wrote: >> >> Sorry for the late reply. >> >> On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: >> > On 11/01/2013 03:31 PM, Erik Faye-Lund wrote: >> &g

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-06 Thread Erik Faye-Lund
On Wed, Nov 6, 2013 at 9:19 PM, Paul Berry wrote: > On 6 November 2013 11:24, Erik Faye-Lund wrote: >> >> On Wed, Nov 6, 2013 at 7:49 PM, Paul Berry >> wrote: >> > On 6 November 2013 09:35, Erik Faye-Lund wrote: >> >> >> >> Sorry for the

Re: [Mesa-dev] sampler arrays indexed with non-constant expressions

2013-11-19 Thread Erik Faye-Lund
On Mon, Nov 18, 2013 at 9:04 PM, Paul Berry wrote: > On 17 November 2013 00:24, Victor Luchitz wrote: >> If compiler actually attempted to unroll the loop above, it would notice >> that the does compile correctly. Instead it just emits and error and in my >> opinion, contradicts the comment above

Re: [Mesa-dev] Anybody still need clear_depth_stencil() or clear_render_target()?

2013-12-02 Thread Erik Faye-Lund
On Mon, Dec 2, 2013 at 11:08 PM, Andreas Hartmetz wrote: > Hello, > > I've been lurking for a while, this seems to be my first post. > > While trying to make some "easy" (ha) improvements in radeonsi I looked > around in all the surrounding code to get a good picture of how things > work. So I not

Re: [Mesa-dev] [PATCH] Linking fails when not writing gl_Position.

2014-09-10 Thread Erik Faye-Lund
On Tue, Sep 9, 2014 at 7:30 PM, Ian Romanick wrote: > On 09/08/2014 01:10 AM, Tapani Pälli wrote: >> From: Kalyan Kondapally >> >> According to GLSL-ES Spec(i.e. 1.0, 3.0), gl_Position value is undefined >> after the vertex processing stage if we don't write gl_Position. However, >> GLSL 1.10 Spe

Re: [Mesa-dev] [PATCH] Linking fails when not writing gl_Position.

2014-09-10 Thread Erik Faye-Lund
On Thu, Sep 11, 2014 at 12:32 AM, Ian Romanick wrote: > On 09/10/2014 01:53 PM, Erik Faye-Lund wrote: >> On Tue, Sep 9, 2014 at 7:30 PM, Ian Romanick wrote: >>> On 09/08/2014 01:10 AM, Tapani Pälli wrote: >>>> From: Kalyan Kondapally >>>> &g

  1   2   3   4   5   6   7   8   >