Re: Preview features for JavaFX

2024-02-05 Thread Robert Lichtenberger
Seems like a good idea to me. From an application developer point of view I don't care if new parts are super-stable (they never really are). If they are marked as preview I'll take that as an additional caveat to not rely on API stability, etc. Robert Am 06.02.24 um 04:19 schrieb Michael St

Re: RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-05 Thread Robert Lichtenberger
On Mon, 5 Feb 2024 16:02:46 GMT, Andy Goryachev wrote: > > , in order to "not break things" we would have to introduce an API to users > > to be able to control the number of rows they want to be taken into account. > > I think the UI "breaking itself" is much worse than us changing the (buggy)

Preview features for JavaFX

2024-02-05 Thread Michael Strauß
The discussion around the new Platform Preferences API has brought up a potential area where the API may lack a way to detect whether a particular preference is supported on a particular operating system [0]. Discussions like these will invariably come up when new API is released, and some of the

Re: Platform preferences theme detection

2024-02-05 Thread Christopher Schnick
Alright, if the accent is not supported yet then almost everything is fine I guess. The settings issue is not noticeable as all the updates happen very fast. I want to open my previous question about detecting unsupported colors again here. So I assume that for example accent detection is not

Re: Platform preferences theme detection

2024-02-05 Thread Michael Strauß
Hi Christopher! 1) Accent color detection is not yet implemented for Linux/GTK. I think this is a fairly recent addition for Ubuntu, probably in version 22. 2) I don't see this behavior on my Ubuntu 20.04 system (need to upgrade to 23 and test again). If you have acess to JBS, feel free to open a

Re: RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v3]

2024-02-05 Thread Andy Goryachev
On Fri, 2 Feb 2024 18:43:19 GMT, Martin Fox wrote: >> In the Mac glass code the presence of "marked" text (which is tracked in the >> nsAttrBuffer) signals that an IME is active. In this state the current code >> assumes that when NSTextInputContext handles a `keyDown:` it will either >> gener

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v5]

2024-02-05 Thread Laurent Bourgès
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: improved rendez-vous to collect stderr - Changes: - all: https://git.openjdk.org/jfx/pull/1348/fi

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v2]

2024-02-05 Thread John Hendrikx
On Mon, 5 Feb 2024 22:22:25 GMT, Andy Goryachev wrote: > > need 2 passes, because there already is a method named like that: > > oh yeah, sorry. `getStyleClassesSet()` ? That one is still available yes :) - PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1928279865

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v2]

2024-02-05 Thread Andy Goryachev
On Mon, 5 Feb 2024 22:14:06 GMT, John Hendrikx wrote: > need 2 passes, because there already is a method named like that: oh yeah, sorry. `getStyleClassesSet()` ? - PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1928264474

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v2]

2024-02-05 Thread Andy Goryachev
On Fri, 2 Feb 2024 16:00:28 GMT, Kevin Rushforth wrote: > I think `getClasses` is fine. My second choice would be `getClassNames`. Perhaps it might be `getStyleClasses()` to parallel one in `Node`? (I don't know why Node's method is called `getStyleClass` (singular) when it clearly returns mult

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v2]

2024-02-05 Thread John Hendrikx
On Mon, 5 Feb 2024 17:19:35 GMT, Andy Goryachev wrote: > > I think `getClasses` is fine. My second choice would be `getClassNames`. > > Perhaps it might be `getStyleClasses()` to parallel one in `Node`? (I don't > know why Node's method is called `getStyleClass` (singular) when it clearly > re

Re: RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-05 Thread Andy Goryachev
On Mon, 5 Feb 2024 12:51:15 GMT, Robert Lichtenberger wrote: >> You're right. I tried it out and it seems to work. > > I've tried out an improved version of the patch with > cell.updateTableRow(tableRow) moved out of the loop. However, this makes > overall performance a bit slower. > This patc

Re: RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-05 Thread Laurent Bourgès
On Mon, 5 Feb 2024 09:45:25 GMT, Marius Hanl wrote: > A side comment: the default implementation of resizeColumnToFitContent() is > to iterate over all the rows, and I think this is not right. The UI locks up > if the table has, let's say, 10,000,000 rows. I think in this case it should > inst

TreeTableView / FilteredList momentary incorrect selection bug

2024-02-05 Thread Cormac Redmond
Hi folks, I have noticed an issue when combining TreeTableView and FilteredLists, where a wrong node is "selected" (I believe during some shift selection functionality in TreeTableView). Currently using JavaFX 21-ea+5 on Windows, but occurs in later builds too. First noticed in a much more comple

Re: Can't restart my app with the latest JDK, regression.

2024-02-05 Thread Kevin Rushforth
For others who might be curious, Davide filed a bug via bugreport.java.com and it is now available here: https://bugs.openjdk.org/browse/JDK-8325203 It is almost certainly a bug in jpackage. -- Kevin On 2/5/2024 2:01 AM, Davide Perini wrote: Hi John, thanks for the answer. The problem happ

Re: RFR: 8278021: Fix warnings in macOS glass native code and treat warnings as errors [v5]

2024-02-05 Thread Martin Fox
> Turning on warnings-as-errors for the macOS glass native code. Deprecated > declarations are excluded and still appear as warnings. > > In the code that tries to locate the application's dock icon there were three > instances where `NO` was being passed into a method that required a pointer >

Re: RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-05 Thread Andy Goryachev
On Mon, 5 Feb 2024 09:31:37 GMT, Robert Lichtenberger wrote: > , in order to "not break things" we would have to introduce an API to users > to be able to control the number of rows they want to be taken into account. I think the UI "breaking itself" is much worse than us changing the (buggy)

Re: RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-05 Thread Robert Lichtenberger
On Fri, 2 Feb 2024 10:39:49 GMT, Robert Lichtenberger wrote: >> Well, the `tableRow` is still set (but before the loop), we just update the >> index in this loop. >> It looks like setting the table row in this loop is not needed, just once >> above. I also don't see that `setTableRow` has any

Re: RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-05 Thread John Hendrikx
Hi, just wanted to add my 2 cents, In my opinion, no operation in List/Table/TreeTable should be doing such measurements on all rows or columns (where cells need to be loaded, CSS aplied, etc) -- it just won't scale.  In my application many of my lists contain images, and pre-loading all of th

Re: Can't restart my app with the latest JDK, regression.

2024-02-05 Thread Davide Perini
Hi John, thanks for the answer. The problem happen even with other JDKs like the Azul, corretto... The weird thing is that to reproduce it you need to package the program with jpackage and then execute the program using the generated exe. This is the only code needed to reproduce the issue.

Re: RFR: 8323511 Scrollbar Click jumps inconsistent amount of pixels [v2]

2024-02-05 Thread Marius Hanl
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In

Re: RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-05 Thread Marius Hanl
On Mon, 5 Feb 2024 09:31:37 GMT, Robert Lichtenberger wrote: > A side comment: the default implementation of resizeColumnToFitContent() is > to iterate over all the rows, and I think this is not right. The UI locks up > if the table has, let's say, 10,000,000 rows. I think in this case it shou

Re: RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-05 Thread Robert Lichtenberger
On Fri, 2 Feb 2024 16:15:43 GMT, Andy Goryachev wrote: > I see it working right in macOS 14.2.1, by double-clicking on the column > divider in the table header. > > Question to @effad : could you provide the measurements for this fix > (before/after) please? Applying the patch improves perfor