Re: [osv-dev] [PATCH V2] Make OSv boot without ACPI present

2019-02-24 Thread Nadav Har'El
On Fri, Feb 22, 2019 at 4:13 PM Waldemar Kozaczuk wrote: > This patch makes OSv boot without requiring ACPI > to be present which for example is the case on firecracker. > > We simply treat failure to find ACPI root pointer > as an indicator that ACPI is not available and > mark it off as such. A

Re: [osv-dev] Build failed in Jenkins: osv-build #1456

2019-02-24 Thread Nadav Har'El
On Mon, Feb 25, 2019 at 4:49 AM wrote: > See < > http://jenkins.cloudius-systems.com:8080/job/osv-build/1456/display/redirect?page=changes > > > > wget -c -O upstream/java-1.8.0-openjdk-headless-.x86_64.rpm > http://mirrors.kernel.org/fedora/development/rawhide/Everything/x86_64/os/Packages/j/jav

Re: [osv-dev] [PATCH V2] Add python script to run OSv on fireracker

2019-02-26 Thread Nadav Har&#x27;El
Does this depend on the "Make OSv bootable as a Linux 64-bit ELF" patch which I now see I haven't reviewed yet? Do you have any other patches waiting for review (sorry about that...)? -- Nadav Har'El n...@scylladb.com On Fri, Feb 22, 2019 at 4:15 PM Waldemar Kozaczuk wrote

Re: [osv-dev] Executing Golang pie apps built with --buildmode=pie

2019-02-27 Thread Nadav Har&#x27;El
On Wed, Feb 27, 2019 at 1:28 AM Waldek Kozaczuk wrote: > Recently I had a chance to explore if we can run Golang pie apps built > with --buildmode=pie options. I have actually added two examples of it - > https://github.com/cloudius-systems/osv-apps/tree/master/golang-pie-example > and > https://

Re: [osv-dev] [PATCH V2] Add python script to run OSv on fireracker

2019-03-03 Thread Nadav Har&#x27;El
On Fri, Feb 22, 2019 at 4:15 PM Waldemar Kozaczuk wrote: > This patch adds simple Python script that allows > booting OSv loader.elf on firecracker. > > It also automates process of downloading and installing > firecracker. Evenntually it might be incorporated > into scripts/run.py > I committed

Re: [osv-dev] [PATCH] Make OSv bootable as a Linux 64-bit ELF

2019-03-03 Thread Nadav Har&#x27;El
On Wed, Feb 20, 2019 at 4:31 PM Waldemar Kozaczuk wrote: > This patch makes all necessary changes to OSv boot logic > to make it bootable on firecracker. > > Please note that until we add virtio-mmio support > we can only boot ramfs images on firecracker like so: > > ./scripts/build fs=ramfs imag

Re: [osv-dev] Re: Build failed in Jenkins: osv-build-nightly #1765

2019-03-03 Thread Nadav Har&#x27;El
On Mon, Mar 4, 2019 at 12:28 AM Waldek Kozaczuk wrote: > Weird. It built all fine on my machine. > Yes, it also builds fine on my bachine! > I believe the problem is in the macro setup_64bit_long_mode which is now > used from 2 places - boot.S (32 bit section) and vmlinux-boot.S (64-bit > sect

Re: [osv-dev] [PATCH] Add virtio mmio implementation

2019-03-05 Thread Nadav Har&#x27;El
On Sat, Mar 2, 2019 at 8:28 AM Waldemar Kozaczuk wrote: > Adds implementation of virtio mmio devices > needed to support block and networking devices > on firecracker. > > Signed-off-by: Waldemar Kozaczuk > --- > Makefile | 1 + > arch/x64/arch-setup.cc | 5 + > drivers/virtio

Re: [osv-dev] Re: [PATCH] Enhance SMP logic to parse MP table

2019-03-05 Thread Nadav Har&#x27;El
On Tue, Mar 5, 2019 at 2:33 PM Waldek Kozaczuk wrote: > Nadav, > > Thanks for reviewing the other patches > Thank you, for doing this work! > . It looks like we are down to this single one to have full support of OSv > on firecracker. > I committed this patch too, but something appears to hav

Re: [osv-dev] [PATCH V2] Add virtio mmio implementation

2019-03-05 Thread Nadav Har&#x27;El
Hmm, I think I have accidentally committed an older version of this patch... Can you please check and incrementally commit the differences between the versions? Sorry about that. -- Nadav Har'El n...@scylladb.com On Mon, Mar 4, 2019 at 12:15 AM Waldemar Kozaczuk wrote: > Adds implem

Re: [osv-dev] [PATCH V2] Add virtio mmio implementation

2019-03-05 Thread Nadav Har&#x27;El
On Tue, Mar 5, 2019 at 2:57 PM Nadav Har'El wrote: > Hmm, I think I have accidentally committed an older version of this > patch... Can you please check and incrementally commit the differences > between the versions? Sorry about that. > I'm even more confused than that

Re: [osv-dev] OSv fully and officially supported on Firecracker !!!

2019-03-06 Thread Nadav Har&#x27;El
On Wed, Mar 6, 2019 at 6:24 AM Waldek Kozaczuk wrote: > With couple of last patches applied yesterday we finally made OSv properly > and fully run on Firecracker. This includes ability to run arbitrary images > (zfs, rofs or ramfs) with networking and SMP supported as well. > Very nice! I tried

Re: [osv-dev] Re: [PATCH] Enhance SMP logic to parse MP table

2019-03-06 Thread Nadav Har&#x27;El
On Tue, Mar 5, 2019 at 5:37 PM Waldek Kozaczuk wrote: > > 2019-03-05T14:47:40.839064594 [anonymous-instance:WARN:vmm/src/lib.rs:1080] >> Guest-boot-time = 62091 us 62 ms, 69244 CPU us 69 CPU ms >> *root=/dev/vda: No such file or directory* >> program exited with status 1 >> VFS: unmounting /dev

[osv-dev] Re: Build failed in Jenkins: osv-build #1462

2019-03-07 Thread Nadav Har&#x27;El
I can reproduce this with: scripts/build -j4 image=openjdk8-fedora,java-tests scripts/test.py --name 'java.*' It doesn't happen with the "default" Java (not the one fetched from Fedora). I'll take a look at it. -- Nadav Har'El n...@scylladb.com On Fri, Ma

[osv-dev] Re: Build failed in Jenkins: osv-build #1462

2019-03-07 Thread Nadav Har&#x27;El
On Fri, Mar 8, 2019 at 9:50 AM Nadav Har'El wrote: > I can reproduce this with: > > scripts/build -j4 image=openjdk8-fedora,java-tests > scripts/test.py --name 'java.*' > Instead of test.py, can also run directly and see the same error: scripts/run.py -e 

Re: [osv-dev] [COMMIT osv master] elf: support PT_GNU_PROPERTY segment type

2019-03-08 Thread Nadav Har&#x27;El
On Fri, Mar 8, 2019 at 10:57 AM Pekka Enberg wrote: > On Fri, Mar 8, 2019 at 10:42 AM Commit Bot > wrote: > >> From: Nadav Har'El >> Committer: Nadav Har'El >> Branch: master >> >> elf: support PT_GNU_PROPERTY segment type >> >&

Re: [osv-dev] [PATCH 2/9] update 0001-configure-web-admin-user.patch

2019-03-10 Thread Nadav Har&#x27;El
On Sat, Mar 9, 2019 at 3:02 AM geraldo netto wrote: > update the patch 0001-configure-web-admin-user.patch in order to work on > tomcat 9 > the change only adds a new user with manager-gui on second-last line > instead of removing the past lines and then add the user > I'm afraid I'm lost as to

Re: [osv-dev] [PATCH 3/9] add admin-gui permission

2019-03-10 Thread Nadav Har&#x27;El
On Sat, Mar 9, 2019 at 3:02 AM geraldo netto wrote: > Signed-off-by: geraldo netto > --- > .../0003-assign-admin-gui-role-to-tomcat-user.patch| 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git > a/tomcat/patches/perf/0003-assign-admin-gui-role-to-tomcat-user.p

Re: [osv-dev] [PATCH 3/9] add admin-gui permission

2019-03-10 Thread Nadav Har&#x27;El
On Sun, Mar 10, 2019 at 4:21 PM Nadav Har'El wrote: > On Sat, Mar 9, 2019 at 3:02 AM geraldo netto > wrote: > >> >> +@@ -41,5 +41,5 @@ >> + > roles="tomcat,role1"/> >> + >> > > I understood from your patch's title th

Re: [osv-dev] [PATCH 2/9] update 0001-configure-web-admin-user.patch

2019-03-10 Thread Nadav Har&#x27;El
On Sat, Mar 9, 2019 at 3:02 AM geraldo netto wrote: > update the patch 0001-configure-web-admin-user.patch in order to work on > tomcat 9 > the change only adds a new user with manager-gui on second-last line > instead of removing the past lines and then add the user > > in any case, the changes

Re: [osv-dev] [PATCH 4/9] add manager-script permission

2019-03-10 Thread Nadav Har&#x27;El
On Sat, Mar 9, 2019 at 3:02 AM geraldo netto wrote: > Signed-off-by: geraldo netto > --- > ...0006-Add-script-managment-role-to-tomcat-user.patch | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git > a/tomcat/patches/perf/0006-Add-script-managment-role-to-tomcat-us

Re: [osv-dev] [PATCH 0/9] upgrade from tomcat 8 to tomcat 9

2019-03-10 Thread Nadav Har&#x27;El
n a way it can't run on the antique Java (version 7) we supply by default? Is this a new Tomcat requirement, that it only runs on Java 8? If it is, we need to have tomcat "require" Java 8, not just any java (which today is Java 7). Anyway, I wonder how it worked for you? -- Nadav

Re: [osv-dev] [PATCH 0/9] upgrade from tomcat 8 to tomcat 9

2019-03-10 Thread Nadav Har&#x27;El
; let me do another patch with it > Do you prefer me to make a single patch or would you prefer me to make > a new set and also fix some comment? > > > Kind Regards, > > Geraldo Netto > Sapere Aude => Non dvcor, dvco > http://exdev.sf.net/ > > On Sun, 10 Mar 20

Re: [osv-dev] [PATCH 0/9] upgrade from tomcat 8 to tomcat 9

2019-03-10 Thread Nadav Har&#x27;El
api.require('java8') >> File "/home/netto/Desktop/osv/scripts/osv/modules/resolve.py", line >> 152, in require >> raise Exception("Module not found: %s. Please check configuration: >> %s" % (module_name, get_config_path())) >> Exception: Mod

Re: [osv-dev] [PATCH] tomcat: require java8

2019-03-10 Thread Nadav Har&#x27;El
On Sun, Mar 10, 2019 at 7:56 PM geraldo netto wrote: > Signed-off-by: geraldo netto > --- > tomcat/module.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tomcat/module.py b/tomcat/module.py > index cbe6872..a9584db 100644 > --- a/tomcat/module.py > +++ b/tomcat/module.py > @@ -1,5

Re: [osv-dev] [PATCH] add and explicit java8 alias

2019-03-10 Thread Nadav Har&#x27;El
On Sun, Mar 10, 2019 at 6:31 PM geraldo netto wrote: > this alias was already declared in some modules like akka-example, > apache-derby, elasticsearch, ratpack-example > and for some reason it was not picking up jdk8 properly > > just for reference, we have the following modules declared as prov

Re: [osv-dev] [COMMIT osv master] Lowered default ZFS qcow2 image size from 10GB to to 256MB

2019-03-12 Thread Nadav Har&#x27;El
On Tue, Mar 12, 2019 at 4:43 AM Commit Bot wrote: > From: Waldemar Kozaczuk > Committer: Waldemar Kozaczuk > Branch: master > > Lowered default ZFS qcow2 image size from 10GB to to 256MB > This parameter is not very discoverable. I think we need to document scripts/build.py, even if not as a

Re: [osv-dev] page cache used in OSv with ZFS

2019-03-13 Thread Nadav Har&#x27;El
On Sun, Mar 10, 2019 at 7:35 PM zhiting zhu wrote: > Hey, > > Not sure whether this is the right place to ask question. Is there a > description on how page cache is used in OSv with ZFS? The only place I can > find that references pagecache is vfs map_page. Does it mean only mmap > interects wit

Re: [osv-dev] [COMMIT osv master] Lowered default ZFS qcow2 image size from 10GB to to 256MB

2019-03-14 Thread Nadav Har&#x27;El
On Thu, Mar 14, 2019 at 5:09 AM Waldek Kozaczuk wrote: > > > On Tuesday, March 12, 2019 at 7:26:45 AM UTC-4, Nadav Har'El wrote: >> >> >> On Tue, Mar 12, 2019 at 4:43 AM Commit Bot >> wrote: >> >>> From: Waldemar Kozaczuk >>> Co

[osv-dev] [PATCH] build: don't fail build if pathname has space

2019-03-14 Thread Nadav Har&#x27;El
.g., Java) still don't build properly in this case and should be fixed separately. Signed-off-by: Nadav Har'El --- scripts/imgedit.py | 7 +-- scripts/upload_manifest.py | 2 +- Makefile | 10 +- scripts/build | 22 +++--

Re: [osv-dev] Build failed in Jenkins: osv-build #1470

2019-03-18 Thread Nadav Har&#x27;El
On Mon, Mar 18, 2019 at 8:51 AM wrote: > See < > http://jenkins.cloudius-systems.com:8080/job/osv-build/1470/display/redirect?page=changes > > > > Changes: > > [Nadav Har'El] build: don't fail build if pathname has space > > [Nadav Har

Re: [osv-dev] Re: AWS EC2 ARM instance support?

2019-03-24 Thread Nadav Har&#x27;El
On Sat, Mar 23, 2019 at 6:35 PM Rick Payne wrote: > > > So I'm not actually using hardware for now. I'm using qemu-system- > aarch64 as shown on the wiki page: > > qemu-system-aarch64 -S -s -nographic -machine virt -kernel > build/release.aarch64/loader.img -cpu cortex-a57 -m 1024M -append " >

Re: [osv-dev] Re: AWS EC2 ARM instance support?

2019-03-24 Thread Nadav Har&#x27;El
On Sun, Mar 24, 2019 at 5:30 PM Rick Payne wrote: > Hi Nadav, > > On Sun, 2019-03-24 at 12:11 +0200, Nadav Har'El wrote: > > > > Why the "-S"? It causes the machine not really to start. > > Oh sorry, I was using the debugger as it just crashes everyt

Re: [osv-dev] Re: AWS EC2 ARM instance support?

2019-03-24 Thread Nadav Har&#x27;El
On Sun, Mar 24, 2019 at 6:03 PM Rick Payne wrote: > On Sun, 2019-03-24 at 17:36 +0200, Nadav Har'El wrote: > > $ aarch64-linux-gnu-gcc --version > > aarch64-linux-gnu-gcc (GCC) 8.1.1 20180626 (Red Hat Cross 8.1.1-3) > > I tried this version: > > aarch64-linu

Re: [osv-dev] Updating http://osv.io/

2019-03-25 Thread Nadav Har&#x27;El
On Mon, Mar 25, 2019 at 8:38 AM Tzach Livyatan wrote: > > On Mon, Mar 25, 2019 at 8:17 AM Dor Laor wrote: > >> Waldek, I added you to the blog as admin, a Firecracked blog will be >> awesome. >> I failed to locate the main site itself, Tzach, Pekka, do you remember? >> > > This is the repo for t

Re: [osv-dev] Modernizing and cleaning build system

2019-03-31 Thread Nadav Har&#x27;El
n Sun, Mar 31, 2019 at 5:58 PM Waldek Kozaczuk wrote: > Here is a list of things we should try to do: > I think there are two very different issues involved here, that don't really need the same solution: The OSv kernel's makefile, and the "apps" build system. >- Propose and define model a

Re: [osv-dev] OSv Linux compatibility

2019-04-10 Thread Nadav Har&#x27;El
On Wed, Apr 10, 2019 at 10:38 PM Waldek Kozaczuk wrote: > Given that: > >- https://github.com/cloudius-systems/osv/issues/213 > > > (closed)

Re: [osv-dev] Running Java (pie) from host without wrapper

2019-04-14 Thread Nadav Har&#x27;El
On Sun, Apr 14, 2019 at 11:21 PM Waldek Kozaczuk wrote: > As I was researching OSv ability to run unmodified Linux pie as is from > host I did quick experiment with Java 8. > > I created an app that took all java 8 artifacts as is from host (so no > wrapper): > cat usr.manifest > /usr/lib/jvm/jav

Re: [osv-dev] Re: Build failed in Jenkins: osv-build-nightly #1806

2019-04-24 Thread Nadav Har&#x27;El
On Tue, Apr 23, 2019 at 6:55 PM Waldek Kozaczuk wrote: > Hi, > > Could someone clean build tree on the build machine - './scripts/build > clean'? > I'll clean it to solve the problem this time, but since this is a script you're familiar with, can you please fix it? (see below my notes on what ne

Re: [osv-dev] Improving Capstan

2019-04-25 Thread Nadav Har&#x27;El
On Wed, Apr 24, 2019 at 3:16 PM Waldek Kozaczuk wrote: > Now that we have full control of Capstan let us try to improve it a > little. Here is my wish list or things I would like to do in short-term: > >- Add ability to pull kernel and mpm packages from github >- Add diagnostic option to

Re: [osv-dev] Re: [PATCH] Update nbd_client.py to do newstyle handshake

2019-04-28 Thread Nadav Har&#x27;El
On Sun, Apr 28, 2019 at 6:13 AM Waldek Kozaczuk wrote: > Please disregard this patch. It makes nbd_client.py work with version > 3.1.5 but breaks with 2.11. Need to make it detect which version of > handshake to use. > That would be great. Should be fairly easy because of the different magic num

Re: [osv-dev] [PATCH] Add GNU libc extension function error()

2019-04-28 Thread Nadav Har&#x27;El
On Sun, Apr 28, 2019 at 7:07 AM Waldemar Kozaczuk wrote: > This patch adds GNU libc extension function error() > as specified at https://linux.die.net/man/3/error. > This function is used by core utils programs on Linux. > Looks good, so I committed it. Thanks. If you want to be 100% conformant

Re: [osv-dev] [PATCH] Add GNU libc extension variables __progname and __progname_full

2019-04-28 Thread Nadav Har&#x27;El
On Sun, Apr 28, 2019 at 7:44 AM Waldemar Kozaczuk wrote: > This patch adds GNU libc extension variables __progname and __progname_full > used by coreutils. These seem to come from BSD as 'BSD' paragraph > explains - https://rosettacode.org/wiki/Program_name#C. > What glibc does is weak_alias (_

Re: [osv-dev] Next (0.54.0 and onwards) OSv releases roadmap proposal

2019-04-28 Thread Nadav Har&#x27;El
Thanks for writing this! My minor comments below. On Sat, Apr 27, 2019 at 6:47 AM Waldek Kozaczuk wrote: > MORE IMPORTANT > >- Make OSv easier to use > - Improve build system - > https://groups.google.com/forum/#!topic/osv-dev/1LmL3c89JRg > - Improve Capstan - > https

Re: [osv-dev] Build failed in Jenkins: osv-build #1474

2019-04-29 Thread Nadav Har&#x27;El
It's the "wget -c" problem again :-( We need to either drop the "-c", or, if we want to keep it, use it on the filename *with* the version and not the generic name -- Nadav Har'El n...@scylladb.com On Mon, Apr 29, 2019 at 11:17 PM wrote: > See < &g

Re: [osv-dev] Running Java (pie) from host without wrapper

2019-05-10 Thread Nadav Har&#x27;El
On Fri, May 10, 2019 at 8:37 PM Waldek Kozaczuk wrote: > > > On Sunday, April 14, 2019 at 8:16:04 PM UTC-4, Waldek Kozaczuk wrote: >> >> > libjli.so is needed by jre/lib/amd64/libinstrument.so. On my host >> (Fedora 29), >> > >> > >> > $ ldd /usr/lib/jvm/java-1.8.0-openjdk/jre/lib/amd64/libinstru

Re: [osv-dev] [PATCH] Fix fopen to return EFAULT when filename is NULL

2019-05-11 Thread Nadav Har&#x27;El
On Sat, May 11, 2019 at 2:40 PM Waldemar Kozaczuk wrote: > Signed-off-by: Waldemar Kozaczuk > --- > libc/stdio/fopen.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libc/stdio/fopen.c b/libc/stdio/fopen.c > index 83452407..c6053c21 100644 > --- a/libc/stdio/fopen.c > +++ b/libc/

Re: [osv-dev] [PATCH] Fix fopen to return EFAULT when filename is NULL

2019-05-11 Thread Nadav Har&#x27;El
pplication bug that it passes bad pointers to system calls. But if you found cases it matters, we can easily fix it for the case of a null pointer (for other cases of bad pointers, this a bigger mess to fix, and I wouldn't do it before we find a need). > Sent from my iPhone > > On

Re: [osv-dev] [PATCH] Simplify building images out of artifacts found on host filesystem

2019-05-11 Thread Nadav Har&#x27;El
Hi, thanks. I did not review in detail the code below, but since it's a separate tool, which obviously you will care about and continue to improve as you discover bugs, I don't mind committing it as-is and letting you send followup patches later. So I'll commit it now. --

Re: [osv-dev] [PATCH 2/2] Enhance getopt family of functions to work with PIEs

2019-05-12 Thread Nadav Har&#x27;El
On Wed, May 1, 2019 at 6:49 AM Waldemar Kozaczuk wrote: > This patch enhances implementation of getopt() and > getopt_long() functions to work with PIEs. > > Newer GCC compiler optimizes PIEs by emitting machine code > with so called copy relocations and affects how > caller (PIEs) and callee (OS

Re: [osv-dev] Re: [PATCH] Support local-exec TLS access

2019-05-12 Thread Nadav Har&#x27;El
On Sat, May 11, 2019 at 3:04 PM Waldek Kozaczuk wrote: > Even though the test app, golang and node apps (which use local TLS) work > fine with this patch, the rust programs built as pies do not. Rust uses > thread local heavily so one has to bump up the size of the TLS reservation > in loader.ld.

Re: [osv-dev] [PATCH 2/2] Enhance getopt family of functions to work with PIEs

2019-05-12 Thread Nadav Har&#x27;El
On Sun, May 12, 2019 at 4:20 PM Waldek Kozaczuk wrote: > > > Sent from my iPhone > > On May 12, 2019, at 04:58, Nadav Har'El wrote: > // This is a simple RAII class for retreiving the caller's copy of the > global opt* variables > // on initialization, and re

Re: [osv-dev] [PATCH 2/2 V2] Enhance getopt family of functions to work with PIEs

2019-05-12 Thread Nadav Har&#x27;El
Thanks, looks mostly good. I just have a couple of nitpicks below. On Mon, May 13, 2019 at 6:37 AM Waldemar Kozaczuk wrote: > This patch enhances implementation of getopt() and > getopt_long() functions to work with PIEs. > > Newer GCC compiler optimizes PIEs by emitting machine code > with so c

Re: [osv-dev] Re: [PATCH] iperf: fix compile on gcc 6.3

2019-05-19 Thread Nadav Har&#x27;El
On Sat, May 18, 2019 at 10:25 PM wrote: > Hi Here, > > I still noticing this issue. Could anyone please give me clue? > This is the OSv mailing list, not the iperf mailing list (I don't know if there is one). The workaround we used in OSv to get iperf-2.0.5 to compile on modern compilers was th

Re: [osv-dev] gcc 9 warnings

2019-05-19 Thread Nadav Har&#x27;El
On Sat, May 18, 2019 at 8:02 PM Waldek Kozaczuk wrote: > When building with newest gcc 9 on Fedora 30 one can see following > warnings: > Thanks for looking into this. For some weird reason I haven't yet been able to upgrade my desktop to Fedora 30 (some weird dependency problems), so I can't ye

Re: [osv-dev] [PATCH] Enhanced __fxstata to handle AT_SYMLINK_NOFOLLOW

2019-05-19 Thread Nadav Har&#x27;El
On Sat, May 18, 2019 at 6:41 AM Waldemar Kozaczuk wrote: > Signed-off-by: Waldemar Kozaczuk > --- > fs/vfs/main.cc | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/fs/vfs/main.cc b/fs/vfs/main.cc > index 889aa268..876ae2ba 100644 > --- a/fs/vfs/main.cc > +++

Re: [osv-dev] [COMMIT osv master] Tweak open() and sys_open() to return EFAULT error when pathname null

2019-05-19 Thread Nadav Har&#x27;El
On Fri, May 17, 2019 at 5:00 AM Commit Bot wrote: > From: Waldemar Kozaczuk > Committer: Waldemar Kozaczuk > Branch: master > > Tweak open() and sys_open() to return EFAULT error when pathname null > This patch is fine, and I see you already committed it, but I wonder if that was the best plac

Re: [osv-dev] [PATCH] Added option suffix "!" to force termination of remaining application threads

2019-05-19 Thread Nadav Har&#x27;El
Looks good. I have just one nitpick on the _post_main() thing: On Sat, May 18, 2019 at 3:26 AM Waldemar Kozaczuk wrote: > Some applications like JVM leave other threads running after > main threads terminates. OSv is pedantic about it and likes to keep > application running and prevents regular

Re: [osv-dev] [PATCH] elf: handle new DT_RUNPATH

2019-05-19 Thread Nadav Har&#x27;El
Thanks. Good catch. -- Nadav Har'El n...@scylladb.com On Sat, May 18, 2019 at 1:02 AM Waldemar Kozaczuk wrote: > This patch enhances dynamic linker to resolve dependent > objects that rely on DT_RUNPATH entry to specify directories to search for. > > Some ELFs have bo

Re: [osv-dev] gcc 9 warnings

2019-05-19 Thread Nadav Har&#x27;El
I finally managed to upgrade to Fedora 30. I'll try to prepare patches for this myself. -- Nadav Har'El n...@scylladb.com On Sun, May 19, 2019 at 11:15 AM Nadav Har'El wrote: > > On Sat, May 18, 2019 at 8:02 PM Waldek Kozaczuk > wrote: > >> When building w

[osv-dev] [PATCH 2/4] sched: fix gcc 9 warning

2019-05-19 Thread Nadav Har&#x27;El
gcc 9.1.1 warns about strncpy() which can lead to a missing null at the end of the destination. Let's use strlcpy(), which doesn't have this problem. Signed-off-by: Nadav Har'El --- include/osv/sched.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include

[osv-dev] [PATCH 4/4] acpi: ignore new gcc 9 warning

2019-05-19 Thread Nadav Har&#x27;El
x27;s just turn of this warning for the ACPI files. We're not going to fix problems in that library (and I'm not even sure it is a real problem, I don't know if "OemId" is really guaranteed to be null terminated). Signed-off-by: Nadav Har'El --- Makefile | 2 +-

[osv-dev] [PATCH 1/4] tracepoints: fix for compiling on gcc 9

2019-05-19 Thread Nadav Har&#x27;El
. The easiest workaround is to use the old-style __attribute__((cold)) instead of the more modern syntax [[gnu::cold]]. The old-style syntax isn't bound by the C++ standard, and its behavior hasn't changed in gcc 9.1.1. Signed-off-by: Nadav Har'El --- arch/x64/arch-trace.hh | 2 +-

[osv-dev] [PATCH 3/4] libc: avoid weak_alias() warnings from gcc 9.

2019-05-19 Thread Nadav Har&#x27;El
f.c). Signed-off-by: Nadav Har'El --- Makefile | 2 +- libc/stdio/sscanf.c | 19 +++ libc/stdio/vsscanf.c | 4 3 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 libc/stdio/sscanf.c diff --git a/Makefile b/Makefile index 2ef75600..03041

Re: [osv-dev] gcc 9 warnings

2019-05-19 Thread Nadav Har&#x27;El
On Sat, May 18, 2019 at 8:02 PM Waldek Kozaczuk wrote: > > Also at the very end we get an error when running mkfs > Running mkfs... > /tools/cpiod.so: failed looking up symbol > _ZNK5boost15program_options22error_with_option_name4whatEv (bo > ost::program_options::error_with_option_name::what() c

[osv-dev] [PATCH] imgedit.py: do not open a port to the entire world

2019-05-19 Thread Nadav Har&#x27;El
- qemu-nbd should only listen to the 127.0.0.1 interface (see issue #709). And in turn, imgedit.py should contact 127.0.0.1 and not rely on the alias "localhost" working for ipv4 (see issue #534). Signed-off-by: Nadav Har'El --- scripts/imgedit.py | 4 ++-- 1 file changed, 2 i

Re: [osv-dev] gcc 9 warnings

2019-05-19 Thread Nadav Har&#x27;El
On Sun, May 19, 2019 at 3:40 PM Nadav Har'El wrote: > > On Sat, May 18, 2019 at 8:02 PM Waldek Kozaczuk > wrote: > >> >> Also at the very end we get an error when running mkfs >> Running mkfs... >>

Re: [osv-dev] Re: Memory problem with Java multithreading application in OSv

2019-05-20 Thread Nadav Har&#x27;El
On Mon, May 20, 2019 at 5:35 PM Waldek Kozaczuk wrote: > > > On Sunday, May 19, 2019 at 12:19:59 PM UTC-4, robertob wrote: >> >> Hi everybody, >> >> I have built an OSv image that run with QEMU and KVM acceleration. It >> executes a mine Java multi threading application. >> >> This is the command

Re: [osv-dev] Modernizing and cleaning build system

2019-05-20 Thread Nadav Har&#x27;El
On Mon, May 20, 2019 at 6:48 PM Waldek Kozaczuk wrote: > In the next couple of weeks I will be trying to work on some of those > issues. I think that eliminating external and fixing "openssl 1.0" issue > are probably most pressing ones. I feel like we have gotten to the point > where are some of

Re: [osv-dev] Re: [PATCH] imgedit.py: do not open a port to the entire world

2019-05-27 Thread Nadav Har&#x27;El
ckets. Which is why I thought of leaving it. Do you think it will be clearer to close 709 and open a new one instead? #534 I already closed. > Waldek > > On Sunday, May 19, 2019 at 11:58:51 AM UTC-4, Nadav Har'El wrote: >> >> Since commit 464f4e0, imgedit.py opens runs qe

Re: [osv-dev] Re: Memory problem with Java multithreading application in OSv

2019-05-28 Thread Nadav Har&#x27;El
On Wed, May 29, 2019 at 7:43 AM robertob wrote: > Setting "-Xss228k" solved the memory consumption problem. I think the > problem was Java setting so...OSv works fine! > Great we got to the root of this issue (thanks Waldek!), but OSv is not completely off the hook, OSv is somewhat to blame that

Re: [osv-dev] [PATCH] Provide full implementation of epoll_pwait

2019-06-02 Thread Nadav Har&#x27;El
On Sun, Jun 2, 2019 at 6:26 AM Waldemar Kozaczuk wrote: > This patch provides full implementation of epoll_pwait > and exposes it as a public function which is needed > by Node.JS 10. > > The implementation is modeled after pselect/select. > Thanks. I committed this, because it is indeed identic

Re: [osv-dev] [PATCH] Start using memory below kernel

2019-06-11 Thread Nadav Har&#x27;El
On Wed, Jun 5, 2019 at 7:33 AM Waldemar Kozaczuk wrote: > This patch improves memory utilization by > making OSv use area below where kernel is loaded. > > This normally saves only 1M + 640K (low memory) > howewer makes bigger difference when kernel_base in > Makefile is bumped higher. So if one

Re: [osv-dev] Build failed in Jenkins: osv-build-nightly #1836

2019-06-12 Thread Nadav Har&#x27;El
On Wed, Jun 12, 2019 at 6:16 PM wrote: > See < > https://jenkins.scylladb.com/job/osv-build-nightly/1836/display/redirect?page=changes > > > > Changes: > > [jwkozaczuk] Start using memory below kernel > > make[1]: Entering directory '< > https://jenkins.scylladb.com/job/osv-build-nightly/ws/apps/

Re: [osv-dev] [PATCH] Start using memory below kernel

2019-06-13 Thread Nadav Har&#x27;El
t; On Tuesday, June 11, 2019 at 1:12:04 PM UTC-4, Nadav Har'El wrote: >> >> >> On Wed, Jun 5, 2019 at 7:33 AM Waldemar Kozaczuk >> wrote: >> >>> This patch improves memory utilization by >>> making OSv use area below where kernel is loaded. >>&g

Re: [osv-dev] [PATCH] Move kernel to 0x40200000 address (1 GiB higher) in virtual memory

2019-06-16 Thread Nadav Har&#x27;El
On Sun, Jun 16, 2019 at 8:05 AM Waldemar Kozaczuk wrote: > This patch provides all necessary changes to move OSv kernel by 1 GiB > higher > in virtual memory space to start at 0x4020. Most changes involve adding > or substracting 0x4000 (OSV_KERNEL_VM_SHIFT) in all relevant places. > Plea

Re: [osv-dev] [PATCH] Move kernel to 0x40200000 address (1 GiB higher) in virtual memory

2019-06-16 Thread Nadav Har&#x27;El
On Sun, Jun 16, 2019 at 3:22 PM Waldek Kozaczuk wrote: > > > On Sunday, June 16, 2019 at 5:40:46 AM UTC-4, Nadav Har'El wrote: >> >> On Sun, Jun 16, 2019 at 8:05 AM Waldemar Kozaczuk >> wrote: >> >>> This patch provides all necessary changes to mov

Re: [osv-dev] [PATCH] Move kernel to 0x40200000 address (1 GiB higher) in virtual memory

2019-06-16 Thread Nadav Har&#x27;El
On Sun, Jun 16, 2019 at 3:24 PM Waldek Kozaczuk wrote: > > > On Sunday, June 16, 2019 at 8:22:03 AM UTC-4, Waldek Kozaczuk wrote: >> >> >> >> On Sunday, June 16, 2019 at 5:40:46 AM UTC-4, Nadav Har'El wrote: >>> >>> On Sun, Jun 16, 201

Re: [osv-dev] [PATCH] Move kernel to 0x40200000 address (1 GiB higher) in virtual memory

2019-06-16 Thread Nadav Har&#x27;El
On Sun, Jun 16, 2019 at 4:37 PM Waldek Kozaczuk wrote: > > +# virtual address space 1 GiB at a time > +# The very 1st entry maps 1st GiB 1:1 by pointing to ident_pt_l2 > table > +# that specifies addresses of every one of 512 2MiB slots of > physical memory > +

Re: [osv-dev] [PATCH] Make rebuilding loader.elf automatic and more efficient when changing kernel_base

2019-06-18 Thread Nadav Har&#x27;El
Waldek, this patch looks good, but is it still relevant? Now that you can move the kernel's VM address separately from its physical address, do you ever want to move its physical address? Some additional minor thoughts below. On Sat, Jun 8, 2019 at 9:27 PM Waldemar Kozaczuk wrote: > When one ch

Re: [osv-dev] [PATCH] Move kernel to 0x40200000 address (1 GiB higher) in virtual memory

2019-06-19 Thread Nadav Har&#x27;El
382f9e077d4daafd5bac/arch/x86/xen/enlighten_pvh.c#L26-L40 >> - >> Linux passes physical address or hypercall page. When we do it it breaks. >> >> Overall I am not sure I understand what exact mode of Xen virtualization >> OSv is coded to work under - HVM and/or PV (

Re: [osv-dev] [PATCH V2] Move kernel to 0x40200000 address (1 GiB higher) in virtual memory

2019-06-20 Thread Nadav Har&#x27;El
irtual address. In fact, isn't this what we already do - set up the mapping before jumping into the kernel's ordinary C code? -- Nadav Har'El n...@scylladb.com On Thu, Jun 20, 2019 at 7:07 AM Waldemar Kozaczuk wrote: > This patch provides all necessary changes to move OSv k

Re: [osv-dev] [PATCH V2] Allow running non-PIE executables that do not collide with kernel

2019-06-20 Thread Nadav Har&#x27;El
On Thu, Jun 20, 2019 at 3:21 PM Waldemar Kozaczuk wrote: > This patch provides necessary changes to OSv dynamic linker > to allow running non-PIEs (= Position Dependant Executables) > as long as they do not collide in virtual memory with kernel. > Thanks. Nice progress in making OSv run these st

Re: [osv-dev] [PATCH V2] Allow running non-PIE executables that do not collide with kernel

2019-06-20 Thread Nadav Har&#x27;El
On Thu, Jun 20, 2019 at 9:33 PM Waldek Kozaczuk wrote: > > > On Thursday, June 20, 2019 at 1:15:29 PM UTC-4, Nadav Har'El wrote: >> >> -// We currently only support running ET_DYN objects (shared library >> or >> >>> -// position-in

Re: [osv-dev] [PATCH V2] Move kernel to 0x40200000 address (1 GiB higher) in virtual memory

2019-06-23 Thread Nadav Har&#x27;El
ble-looking vmlinux at least with my version of the tools. As you observe, GNU ld behaviour in this area tends to be rather patchily specified, buggy or both. That does argue in favour of reusing the same techniques already used for other arches, though. > Regards, > Waldek > &

Re: [osv-dev] [PATCH V2] Move kernel to 0x40200000 address (1 GiB higher) in virtual memory

2019-06-23 Thread Nadav Har&#x27;El
On Sun, Jun 23, 2019 at 3:12 PM Waldek Kozaczuk wrote: > > > On Sun, Jun 23, 2019 at 07:19 Nadav Har'El wrote: > >> I dug around Linux's git and found (via heavy archaeology) the following >> patch which introduced this "

Re: [osv-dev] [PATCH] hpet: Support 32-bit counter

2019-06-26 Thread Nadav Har&#x27;El
On Thu, Jun 27, 2019 at 7:30 AM Waldemar Kozaczuk wrote: > This patch adds very limited support of hpets > with 32-bit main counter. It also refactors > the hpet code to allow for future refinements > of both 32-bit and 64-bit implementations > independently. > Can you please give here, and/or i

Re: [osv-dev] Resurrecting ARM support

2019-06-27 Thread Nadav Har&#x27;El
On Thu, Jun 27, 2019 at 3:25 PM Waldek Kozaczuk wrote: > Hi, > > Hopefully, soon I will be cutting new release of OSv. But thinking about > what next, I was wondering if anyone is interested in collaborating on > getting OSv to run on ARM. > > It is my understanding that OSv at least builds for a

Re: [osv-dev] [PATCH] hpet: Enhance 64-bit hpet clock to handle non-monotonic reads of the main counter

2019-06-30 Thread Nadav Har&#x27;El
On Fri, Jun 28, 2019 at 7:04 AM Waldemar Kozaczuk wrote: > This patch hardens the implementation of hpet clock with 64-bit counter > by enforcing that every read of the main counter is NOT less than > the previous value. > > Fixes #382 > Hi, While one of the ideas raised in #382 was that indeed

Re: [osv-dev] [PATCH] hpet: handle wrap-around with 32-bit counter

2019-06-30 Thread Nadav Har&#x27;El
On Fri, Jun 28, 2019 at 4:36 PM Waldemar Kozaczuk wrote: > This patch enhances the hpet clock with 32-bit main > counter to handle wrap-arounds. It does it by maintaining > separate upper 32-bit counter and incrementing it > when wrap around is detected. > > Signed-off-by: Waldemar Kozaczuk > --

Re: [osv-dev] [PATCH] procfs: populate maps file with i-node numbers

2019-06-30 Thread Nadav Har&#x27;El
Looks good to me, but I wonder, together with the inode, shouldn't we also save the device id, so we can print that too (that is the 00:00 we print now)? -- Nadav Har'El n...@scylladb.com On Sun, Jun 30, 2019 at 7:14 AM Waldemar Kozaczuk wrote: > This patch refines the impl

Re: [osv-dev] [PATCH] mprotect: page-align len parameter instead of returning error

2019-06-30 Thread Nadav Har&#x27;El
Hi, thanks, I committed this patch because indeed the mprotect manual pages, in both Linux and posix, both talk about (possible) errors if addr is not aligned, but keep suspiciously silent about len. But I'm curious, how did you find this issue? Did it break actual code that tried to use unaligned

Re: [osv-dev] OSv and C applications

2019-07-01 Thread Nadav Har&#x27;El
On Mon, Jul 1, 2019 at 4:01 PM DOR Nelly wrote: > Hello, > > I'm trying to use OSv with non-included C programs, so I naturally tried > running OSv with one of the applications that are present in the OSv bundle > first (eg groonga, cassandra, the java hello example, etc). To see a really minim

Re: [osv-dev] [PATCH] procfs: populate maps file with i-node numbers

2019-07-01 Thread Nadav Har&#x27;El
unique in a single device, but not necessarily across different devices (e.g., two disk drives), so the inode number alone is not enough. >> Sent from my iPhone >> >> On Jun 30, 2019, at 04:34, Nadav Har'El wrote: >> >> Looks good to me, but I wonder, together

Re: [osv-dev] [PATCH] hpet: Enhance 64-bit hpet clock to handle non-monotonic reads of the main counter

2019-07-02 Thread Nadav Har&#x27;El
On Tue, Jul 2, 2019 at 6:35 AM Waldek Kozaczuk wrote: > No, I have never been able to reproduce this issue for a year or so. I > would typically happen in a nested virtualization scenario. > > My understanding was that for some reason the hypervisor (in this case > qemu without KVM) would violate

Re: [osv-dev] [PATCH] procfs: populate maps file with i-node numbers

2019-07-02 Thread Nadav Har&#x27;El
). * The 8-bit fs type must be put in the low bits of fsid[1] * because that's where other Solaris filesystems put it. */ I'm not sure how any of this is supposed to correspond to major and minor numbers. I'm not sure it even matters, really, as long as the st_

Re: [osv-dev] [PATCH] syscall: provide limited implementation of tgkil

2019-07-02 Thread Nadav Har&#x27;El
On Tue, Jul 2, 2019 at 3:03 PM Waldemar Kozaczuk wrote: > This patch provides very limited implementation of the Linux > specific system call tgkill(). For now it only handles SIGINT > which is interpreted as a request to shutdown the app and OSv. > You could make it a little less hacky if inste

Re: [osv-dev] runtime.cc:confstr() bug

2019-07-03 Thread Nadav Har&#x27;El
On Wed, Jul 3, 2019 at 8:24 AM Waldek Kozaczuk wrote: > I think that according to this - https://linux.die.net/man/3/confstr - we > have a bug in this code: > > size_t confstr(int name, char* buf, size_t len) > { > char tmp[1]; > if (!buf) { > buf = tmp; > len = 1; > }

Re: [osv-dev] [PATCH] syscall: provide limited implementation of tgkil

2019-07-03 Thread Nadav Har&#x27;El
maybe I'm misremembering something. > > On Linux when I press "Ctr-C" the app exists nicely. I want to achieve > same things on OSv. > So the curious thing to understand is what are the different things that need to happen correctly before the application exits. I think that

Re: [osv-dev] [PATCH] Make OSv boot as vmlinuz

2019-07-03 Thread Nadav Har&#x27;El
On Fri, Jun 28, 2019 at 6:43 AM Waldemar Kozaczuk wrote: > This patch adds new type of build artifact - vmlinuz.bin - that allows > OSv boot as vmlinuz image. Essentialy the vmlinuz.bin wraps > the uncompressed version of OSv loader.elf by prepending it > with 1K-long vmlinuz header and 1K-long 3

  1   2   3   4   5   6   7   8   9   10   >