Rather than copy/paste everywhere, introduce helpers to control
testpmd runs.
Rely on --stats-period (which outputs port stats every n seconds) so that
testpmd keeps running without expecting any user input.
Signed-off-by: David Marchand
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
; > if hitting more issues.
>
> Hi David,
>
> It seems appropriate to mark this as deffered in patchwork,
> so I have done so.
Ok for me.
I'll send a new revision if needed, or change the status to NEW in
patchwork otherwise.
>
> Patch looks find to me.
&g
unner/work/ovs/ovs/dpdk-dir/include/rte_spinlock.h, ...):
/usr/lib/gcc/x86_64-linux-gnu/9//include/ia32intrin.h:114:10: error:
undefined identifier '__builtin_ia32_rdtsc'
Provide an empty implementation of __builtin_ia32_rdtsc() builtin.
Signed-off-by: David Marchand
---
Note: I a
On Wed, Aug 30, 2023 at 6:17 PM David Marchand
wrote:
>
> On Wed, Aug 30, 2023 at 6:09 PM Ilya Maximets wrote:
> >
> > On 8/30/23 18:02, David Marchand wrote:
> > > On Wed, Aug 30, 2023 at 1:45 PM Ilya Maximets wrote:
> > >>> +# Fake a veth by creati
On Wed, Aug 30, 2023 at 6:09 PM Ilya Maximets wrote:
>
> On 8/30/23 18:02, David Marchand wrote:
> > On Wed, Aug 30, 2023 at 1:45 PM Ilya Maximets wrote:
> >>> +# Fake a veth by creating a tap on kernel side and plug it in OVS using
> >>> the
> >>
h netdev-dpdk only ports should also be closer to
deployments of ovs-dpdk, rather than a mix of kernel netdev and dpdk
ports with the userspace datapath.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Aug 30, 2023 at 11:03 AM Robin Jarry wrote:
>
> David Marchand, Aug 30, 2023 at 10:16:
> > Tests using mfex_fuzzy.py will fail on systems lacking the Python
> > cryptography library.
> > cryptography is not required, it is only imported in mfex_fuzzy.py to
> &
Align system-dpdk existing helpers to other common OVS helpers so they
can accept some optional arguments.
Introduce a OVS_DPDK_STOP_VSWITCHD wrapper around OVS_VSWITCHD_STOP to
catch dpdk related logs in a centralised fashion.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
tests
hread usage.
This means that a net/tap port n_rxq must be set to numa_count + 1.
Signed-off-by: David Marchand
---
Changes since v3:
- reverted --dummy-numa and opted for configuring a number of rxqs
relevant to the number of NUMA sockets,
Changes since v2:
- added ADD_VETH_IGNORE_LOGS and
: David Marchand
Acked-by: Eelco Chaudron
Acked-by: Aaron Conole
---
tests/system-common-macros.at| 12
tests/system-offloads-traffic.at | 6 +++---
tests/system-traffic.at | 32
3 files changed, 31 insertions(+), 19 deletions(-)
diff
alone for OVS main and PMD
threads).
Signed-off-by: David Marchand
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
---
Changes since v1:
- rebased after DPDK build has been moved out of linux-build.sh,
- restored running "normal" checks in the DPDK jobs,
---
.ci/dpdk-build.sh
check on hugetlbfs presence.
Signed-off-by: David Marchand
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
---
tests/system-dpdk-macros.at | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at
index e1e91f2972..c149b
Rather than copy/paste everywhere, introduce helpers to control
testpmd runs.
Rely on --stats-period (which outputs port stats every n seconds) so that
testpmd keeps running without expecting any user input.
Signed-off-by: David Marchand
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
As reported by Ales when doing some OVN integration tests with OVS 3.2,
net/tap has broken L4 checksum offloads.
Fixes are pending on DPDK side.
Until they get in a LTS release used by OVS, disable those Tx offloads.
Acked-by: Eelco Chaudron
Signed-off-by: David Marchand
---
Changes since v1
ation warnings.")
Signed-off-by: David Marchand
---
tests/mfex_fuzzy.py | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/tests/mfex_fuzzy.py b/tests/mfex_fuzzy.py
index 30028ba7a0..50b9870641 100755
--- a/tests/mfex_fuzzy.py
+++ b/tests/mfex_fuzzy.py
@@ -3,12 +3,15
On Tue, Aug 29, 2023 at 6:18 PM David Marchand
wrote:
> - faked a mono numa/mono core so that OVS requests at max 2 txqs on
> the net/tap port,
Mm, still no good, as I had missed the implications of using ADD_VETH
in system-dpdk.
A v4 will be needed.
--
David Ma
inity_dump() is unavailable.
Signed-off-by: David Marchand
---
Changes since v2:
- added ADD_VETH_IGNORE_LOGS and moved ignored error logs to
OVS_TRAFFIC_VSWITCHD_STOP,
- added --no-pci to DPDK options to avoid failing the tests when
running in a vm with a virtio-net device,
- faked a mono numa
Align system-dpdk existing helpers to other common OVS helpers so they
can accept some optional arguments.
Introduce a OVS_DPDK_STOP_VSWITCHD wrapper around OVS_VSWITCHD_STOP to
catch dpdk related logs in a centralised fashion.
Signed-off-by: David Marchand
Acked-by: Eelco Chaudron
---
tests
: David Marchand
Acked-by: Eelco Chaudron
Acked-by: Aaron Conole
---
tests/system-common-macros.at| 12
tests/system-offloads-traffic.at | 6 +++---
tests/system-traffic.at | 32
3 files changed, 31 insertions(+), 19 deletions(-)
diff
alone for OVS main and PMD
threads).
Signed-off-by: David Marchand
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
---
Changes since v1:
- rebased after DPDK build has been moved out of linux-build.sh,
- restored running "normal" checks in the DPDK jobs,
---
.ci/dpdk-build.sh
check on hugetlbfs presence.
Signed-off-by: David Marchand
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
---
tests/system-dpdk-macros.at | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at
index e1e91f2972..c149b
Rather than copy/paste everywhere, introduce helpers to control
testpmd runs.
Rely on --stats-period (which outputs port stats every n seconds) so that
testpmd keeps running without expecting any user input.
Signed-off-by: David Marchand
Acked-by: Aaron Conole
Acked-by: Eelco Chaudron
As reported by Ales when doing some OVN integration tests with OVS 3.2,
net/tap has broken L4 checksum offloads.
Fixes are pending on DPDK side.
Until they get in a LTS release used by OVS, disable those Tx offloads.
Acked-by: Eelco Chaudron
Signed-off-by: David Marchand
---
Changes since v1
On Fri, Aug 25, 2023 at 3:46 PM Ilya Maximets wrote:
>
> On 8/24/23 17:19, David Marchand wrote:
> > As reported by Ales when doing some OVN integration tests with OVS 3.2,
> > net/tap has broken L4 checksum offloads.
> >
> > Fixes are pending on DPDK side.
>
(like net/iavf) which then reads
zero'd l2_len and l3_len and ends up dropping the packet.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2231081
Fixes: 5d11c47d3ebe ("userspace: Enable IP checksum offloading by default.")
Signed-off-by: David Marchand
Acked-by: Mike Pat
On Thu, Aug 24, 2023 at 2:04 PM Ilya Maximets wrote:
>
> On 8/22/23 10:11, David Marchand wrote:
> > OVS current sets RTE_MBUF_F_TX_IPV[46] flags in early stages of the
> > packet reception and keeps track of the IP packet type as the packet
> > goes through OVS pipeline.
On Fri, Aug 25, 2023 at 1:40 PM Eelco Chaudron wrote:
> On 23 Aug 2023, at 17:34, David Marchand wrote:
>
> > As reported by Ales, net/tap has broken support for checksum offloading.
> > Fixes have been sent to the DPDK side, but waiting for the fixes, simply
> > disab
On Wed, Aug 23, 2023 at 5:35 PM David Marchand
wrote:
> diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at
> index a72133fae1..de126946a0 100644
> --- a/tests/system-dpdk-macros.at
> +++ b/tests/system-dpdk-macros.at
> @@ -87,7 +87,13 @@ $1";/does not exi
On Thu, Aug 24, 2023 at 7:52 PM Ilya Maximets wrote:
>
> On 8/24/23 17:22, Aaron Conole wrote:
> > David Marchand writes:
> >
> >> On Wed, Aug 23, 2023 at 5:35 PM David Marchand
> >> wrote:
> >>>
> >>> Integrate system-traffic.at
e, I just never found an
> > explicit need for it and it had some drawback in one usecase (multiple
> > ports for a single pci device), maybe I could send a rfc.
>
> See above, as it’s a false alarm and we do not need to make this work ;)
Ah.. too ba
on macro.
Passing --no-pci in the tests that wants to probe one pci device is not doable.
What I think instead is that having DPDK probes all devices by default
is not desirable, though it has been working like this since OVS
integrated DPDK.
I have a patch in store for a lo
As reported by Ales when doing some OVN integration tests with OVS 3.2,
net/tap has broken L4 checksum offloads.
Fixes are pending on DPDK side.
Until they get in a LTS release used by OVS, disable those Tx offloads.
Signed-off-by: David Marchand
---
lib/netdev-dpdk.c | 8
1 file
On Thu, Aug 24, 2023 at 2:24 PM Ilya Maximets wrote:
> On 8/22/23 12:26, Eelco Chaudron wrote:
> > On 22 Aug 2023, at 11:28, David Marchand wrote:
> >
> >> Following support of L3 and L4 checksum offloading, some bugs have been
> >> raised in different DPDK driv
On Wed, Aug 23, 2023 at 5:35 PM David Marchand
wrote:
>
> Integrate system-traffic.at tests as part of check-dpdk.
CI (thinking of Intel robot) other than GHA might not be too happy
about this change.
It is hard to tell what fails in the report I received.
A safer approach is probably to
As reported by Ales, net/tap has broken support for checksum offloading.
Fixes have been sent to the DPDK side, but waiting for the fixes, simply
disable all conntrack related tests and some IPv6 tunnel tests.
Signed-off-by: David Marchand
---
tests/system-dpdk-macros.at | 9 +
1 file
ectly
polled by OVS.
Signed-off-by: David Marchand
---
tests/system-dpdk-macros.at| 85 +-
tests/system-dpdk-testsuite.at | 2 +
tests/system-dpdk.at | 3 --
3 files changed, 86 insertions(+), 4 deletions(-)
diff --git a/tests/system-dpdk-macros.at b/
Align system-dpdk existing helpers to other common OVS helpers so they
can accept some optional arguments.
Introduce a OVS_DPDK_STOP_VSWITCHD wrapper around OVS_VSWITCHD_STOP to
catch dpdk related logs in a centralised fashion.
Signed-off-by: David Marchand
---
tests/system-dpdk-macros.at
: David Marchand
---
tests/system-common-macros.at| 12
tests/system-offloads-traffic.at | 6 +++---
tests/system-traffic.at | 32
3 files changed, 31 insertions(+), 19 deletions(-)
diff --git a/tests/system-common-macros.at b/tests
check on hugetlbfs presence.
Signed-off-by: David Marchand
Acked-by: Aaron Conole
---
tests/system-dpdk-macros.at | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at
index 665ca5c2f0..01346fe6ec 100644
--- a/tests/s
alone for OVS main and PMD
threads).
Signed-off-by: David Marchand
Acked-by: Aaron Conole
---
Changes since v1:
- rebased after DPDK build has been moved out of linux-build.sh,
- restored running "normal" checks in the DPDK jobs,
---
.ci/dpdk-build.sh| 8
Rather than copy/paste everywhere, introduce helpers to control
testpmd runs.
Rely on --stats-period (which outputs port stats every n seconds) so that
testpmd keeps running without expecting any user input.
Signed-off-by: David Marchand
Acked-by: Aaron Conole
---
Changes since v1:
- fixed
me Tx offloads.
Link:
https://patchwork.dpdk.org/project/dpdk/patch/20230818090351.2402519-1-david.march...@redhat.com/
Link:
https://patchwork.dpdk.org/project/dpdk/patch/20230822073244.3751885-1-david.march...@redhat.com/
Signed-off-by: David Marchand
---
lib/netdev-provider.h | 5 ++-
lib/net
Fixes: 5d11c47d3ebe ("userspace: Enable IP checksum offloading by default.")
Signed-off-by: David Marchand
---
Some note:
- I submitted a fix on the DPDK side for net/iavf. But to be on the safe
side, this OVS patch here is a proposal to avoid hitting bugs in some
other drivers,
---
lib/ne
On Tue, Aug 8, 2023 at 3:14 PM Ilya Maximets wrote:
>
> On 8/8/23 09:17, David Marchand wrote:
> > On Thu, Jul 13, 2023 at 11:02 AM Viacheslav Galaktionov via dev
> > wrote:
> >>
> >> The set_error function is now used regardless of whether experimental APIs
eering configuration.")
> Signed-off-by: Viacheslav Galaktionov
> Acked-by: Ivan Malov
Can we merge the dpdk-latest patch for checking experimental API
compilation in the master branch?
I am referring to:
https://github.com/openvswitch/ovs/commit/561e15fabd43613cb9c8a2d996c1da
On Mon, Aug 7, 2023 at 2:28 PM Ilya Maximets wrote:
>
> 13.2 was released in April and 13.1 images no longer able
> to update packages:
> pkg: repository FreeBSD contains packages for wrong OS version
>
> Fix that by updating to FreeBSD 13.2.
>
> Reported-by: David M
nd that breaks the build.
>
> Fixes: 6cb2f5a630e3 ("github: Add GitHub Actions workflow.")
> Signed-off-by: Ilya Maximets
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
virtio features (and disabling TSO for this
vhost port).
Acked-by: Mike Pattrick
Acked-by: Simon Horman
Signed-off-by: David Marchand
---
Changelog since v5:
- fixed coding style,
Changelog since v4:
- I kept acks as the logic behind the state machine did not change much,
- fixed indent of
On Wed, Jun 21, 2023 at 11:26 AM Kevin Traynor wrote:
>
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jun 21, 2023 at 11:26 AM Kevin Traynor wrote:
>
> Add unit tests for new per pmd options of pmd-sleep-max.
>
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswit
t; core max sleep request values.
>
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
I have some nits below which can be fixed when applying.
But I am ok too if we go with the current patch.
> diff --git a/Documentation/topics/dpdk/pmd.rst
> b/Documentation/topics/dpdk/p
expanded when future
> additions are added.
>
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jun 21, 2023 at 11:26 AM Kevin Traynor wrote:
>
> This is just cosmetic. There is no change to the tests.
>
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswit
ptions or command can follow
> the 'pmd-sleep-xyz' pattern.
>
> Signed-off-by: Kevin Traynor
I don't have a strong opinion against this name change.
Having a clear prefix for this feature params and using this same
prefix for appctl commands (later in this series) se
something
is wrong on the TSO side.
With announcing that TSO is off for both sides of this vhost port, I
think we have more chances a user would search in OVS documentation
and find out about the "userspace-tso" status field.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
virtio features (and disabling TSO for this
vhost port).
Acked-by: Mike Pattrick
Acked-by: Simon Horman
Signed-off-by: David Marchand
---
Changelog since v4:
- I kept acks as the logic behind the state machine did not change much,
- fixed indent of enumeration in documentation,
- used status: in
On Thu, Jun 29, 2023 at 9:43 PM Ilya Maximets wrote:
>
> On 6/20/23 13:26, David Marchand wrote:
> > At some point in OVS history, some virtio features were announced as
> > supported (ECN and UFO virtio features).
> >
> > The userspace TSO code, which has been
ut I think
it is ok to update the param name now for the reason Kevin gave in the
commitlog.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Jun 26, 2023 at 4:05 PM David Marchand
wrote:
>
> On Mon, Jun 26, 2023 at 3:19 PM Ilya Maximets wrote:
> > > - if the UFO feature is "restored" in the master branch, OVS can't
> > > expose CSUM if the guest negotiated UFO.
> >
> > Yep.
>> cases. 'y' will only be possible for new/restarted VMs.
> >>
> >> Does that make sense?
> >
> > I think you covered all cases.
I have been thinking about it again.
From a guest pov, is it important to support checksum offloading if
TSO is not workin
On Mon, Jun 26, 2023 at 11:37 AM David Marchand
wrote:
> > Currently possible configurations:
> >
> > 1. CSUM + TSO + ___ + ___ OVS 3.1 with userspace-tso=true
> > 2. + TSO + ECN + ___ OVS 3.1 with userspace-tso=false
> > 3. + ___ + ECN + UFO O
y want:
>
> x. CSUM + TSO + ___ + ___
> y. CSUM + ___ + ___ + ___
>
>
> Logic can be:
>
> 1. Try 'a/x' if userspace-tso=true
> 2. Try 'y' if userspace-tso=false
> 3. Try 'c' if above failed
>
> As far as I understand we can advertise new features, but we can't remove
> already acked ones. So, the configuration 'c' is a catch-all for broken
> cases. 'y' will only be possible for new/restarted VMs.
>
> Does that make sense?
I think you covered all cases.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Jun 23, 2023 at 5:14 PM Ilya Maximets wrote:
> On 6/23/23 15:16, David Marchand wrote:
> > On Wed, Jun 21, 2023 at 12:13 AM Ilya Maximets wrote:
> >>
> >> On 6/14/23 21:03, Mike Pattrick wrote:
> >>> The netdev receiving packets is supposed to provi
RTIO_NET_F_MQ
Unknown feature bit: 26
VIRTIO_F_ANY_LAYOUT
VIRTIO_RING_F_INDIRECT_DESC
VIRTIO_RING_F_EVENT_IDX
! VHOST_USER_F_PROTOCOL_FEATURES
VIRTIO_F_VERSION_1
VIRTIO_F_RING_PACKED
VIRTIO_F_IN_ORDER
And.. so qemu sets VHOST_USER_SET_FEATURES:
$ ./features.sh 6176171906
VIRTIO_NET_F_GUEST_CSUM
VIRTIO_NET_F_GUEST_TSO4
VIRTIO_NET_F_GUEST_TSO6
VIRTIO_NET_F_GUEST_ECN
VIRTIO_NET_F_GUEST_UFO
VIRTIO_NET_F_HOST_ECN
VIRTIO_NET_F_HOST_UFO
VIRTIO_NET_F_MRG_RXBUF
VIRTIO_NET_F_GUEST_ANNOUNCE
VIRTIO_RING_F_INDIRECT_DESC
VIRTIO_RING_F_EVENT_IDX
! VHOST_USER_F_PROTOCOL_FEATURES
VIRTIO_F_VERSION_1
As a conclusion, we may have to handle both incorrect setting of UFO
and ECN :-(.
We probably missed this issue during validation as people are not
testing upgrades from 2.11 to current master.
Did I miss any other concern of yours?
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
virtio features (and disabling TSO for this
vhost port).
Signed-off-by: David Marchand
Acked-by: Mike Pattrick
---
Note: resending this v4 for CI (I added Mike ack).
Changelog since v3:
- updated documentation now that the interface offloads status is reported
in ovsdb,
- fixed one coding style
0, 3, dpif_netdev_pmd_info,
> + (void *)&sleep_aux);
> unixctl_command_register("dpif-netdev/pmd-perf-show",
> "[-nh] [-it iter-history-len]"
> diff --git a/tests/pmd.at b/tests/pmd.at
> index 64d8f6e2b..a158d0753 100644
> --- a/tests/pmd.at
> +++ b/tests/pmd.at
> @@ -1278,8 +1278,17 @@ dnl Check default
> CHECK_DP_SLEEP_MAX([0], [disabled], [])
>
> +AT_CHECK([ovs-appctl dpif-netdev/pmd-sleep-show], [0], [dnl
> +PMD max sleep request is 0 usecs.
> +PMD load based sleeps are disabled.
> +])
> +
Functionnally, we are checking the same thing than CHECK_DP_SLEEP_MAX().
I would check the pmd-sleep-show command output in a single helper.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
S_WAIT_UNTIL([tail ovs-vswitchd.log | grep "PMD load based sleeps are
> disabled."])
> +CHECK_DP_SLEEP_MAX([0], [disabled], [])
>
> dnl Check low value max sleep
> get_log_next_line_num
Not directly related to this patch.
I did not realise before when those tests wer
virtio features (and disabling TSO for this
vhost port).
Signed-off-by: David Marchand
---
Note: this series depends on Mike series and won't apply cleanly
without it.
Changelog since v3:
- updated documentation now that the interface offloads status is reported
in ovsdb,
- fixed one coding
ario deleting vxlan ports, flushing flows
manually and I saw nothing broken.
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
in use by 'p0'. See
> ovs-vswitchd log for details.
> ovs-vsctl: The default log directory is "/var/log/openvswitch".
Ok, got it thanks.
It seems a bit strange to remove and re-add the PF port, but cleaning
up those flows makes sense on the principle.
>
> I can rebase and rephrase the commit msg.
Maybe rephrase yes, otherwise the fix works and lgtm.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Fixes: b366fa2f4947 ("dpif-netdev: Call cpuid for x86 isa availability.")
Signed-off-by: David Marchand
---
lib/cpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/cpu.c b/lib/cpu.c
index 0292f715ec..fbbea40053 100644
--- a/lib/cpu.c
+++ b/lib/cpu.c
@@ -
On Wed, May 31, 2023 at 3:22 PM David Marchand
wrote:
>
> Caught while reviewing code.
>
> Fixes: aca2f8a8a6b6 ("netdev-offload-dpdk: Implement HW miss packet recover
> for vport.")
> Fixes: b6cabb8f8f80 ("netdev: Split up netdev offloading to separate module.&q
Caught while reviewing code.
Fixes: aca2f8a8a6b6 ("netdev-offload-dpdk: Implement HW miss packet recover for
vport.")
Fixes: b6cabb8f8f80 ("netdev: Split up netdev offloading to separate module.")
Signed-off-by: David Marchand
---
lib/netdev-offload-dpdk.c | 2 +-
lib/netde
al is
simple so I am ok with it.
If you send a v2, feel free to add:
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
sages.")
Signed-off-by: David Marchand
---
lib/netdev-offload-dpdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 7c91f8a799..14bc877719 100644
--- a/lib/netdev-offload-dpdk.c
+++ b/lib/netdev-offload-dpdk.c
@
On Fri, May 26, 2023 at 4:35 PM David Marchand
wrote:
>
> Hello Eli,
>
> On Mon, Sep 5, 2022 at 4:46 PM Eli Britstein via dev
> wrote:
> >
> > Vport's offloads are done on the tracked orig-in-port, but the flow itself
> > is associated in the vport's m
Fixes: adbd4301a249 ("netdev-offload-dpdk: Use per-netdev offload metadata.")
> Reported-by: 15895987278
> Signed-off-by: Eli Britstein
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
e
> value and log.
>
> Reported-at: https://bugzilla.redhat.com/2119876
> Signed-off-by: Kevin Traynor
Lgtm.
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
;
> Suggested-by: Ilya Maximets
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
&dev->requested_txq_size);
> -
> new_devargs = smap_get(args, "dpdk-devargs");
>
> @@ -2073,4 +2099,9 @@ netdev_dpdk_set_config(struct netdev *netdev, const
> struct smap *args,
> }
>
> +ret = rte_eth_dev_info_get(dev->port_id, &info);
> +
> +dpdk_process_queue_size(netdev, args, !ret ? &info : NULL, true);
> +dpdk_process_queue_size(netdev, args, !ret ? &info : NULL, false);
> +
> out:
> ovs_mutex_unlock(&dev->mutex);
> --
> 2.40.1
>
HTH.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
lding DPDK does not depend on how we will link OVS against it, so we
can use a single cache entry regardless of DPDK_SHARED option,
Reviewed-by: Simon Horman
Signed-off-by: David Marchand
---
Changes since v3:
- fixed git log trace,
- set DPDK_GIT explicitly in yml,
Changes since v2:
- re
x27; .ci/dpdk-* > dpdk-ci-signature
> > +grep -rwE 'DPDK_GIT|DPDK_VER' .github/ >> dpdk-ci-signature
> > +if [ "${DPDK_VER##refs/*/}" != "${DPDK_VER}" ]; then
> > +git ls-remote --heads $DPDK_GIT $DPDK_VER &g
On Fri, Apr 28, 2023 at 2:26 PM David Marchand
wrote:
>
> On Fri, Apr 28, 2023 at 11:36 AM David Marchand
> wrote:
> > > > +- name: create ci signature file for the dpdk cache key
> > > > + # This will collect most of DPDK related lines, s
lding DPDK does not depend on how we will link OVS against it, so we
can use a single cache entry regardless of DPDK_SHARED option,
Reviewed-by: Simon Horman
Signed-off-by: David Marchand
---
Changes since v2:
- removed unneeded checks when the cache is hit,
- exposed the cache key computed i
On Fri, Apr 28, 2023 at 11:36 AM David Marchand
wrote:
> > > +- name: create ci signature file for the dpdk cache key
> > > + # This will collect most of DPDK related lines, so hash will be
> > > different
> > > + # if something changed in
ding DPDK including
> > DPDK_VER.
> > + # This also allows us to use cache from any branch as long as version
> > + # and a way we're building DPDK stays the same.
> > + run: |
> > + grep -irE 'RTE_|DPDK|meson|ninja' .ci/dpdk-* > dp
#15 0x40ba5a in bridge_reconfigure vswitchd/bridge.c:885
> #16 0x41f1a9 in bridge_run vswitchd/bridge.c:3313
> #17 0x42d4fb in main vswitchd/ovs-vswitchd.c:132
> #18 0x7fe09cc03c86 in __libc_start_main (/usr/lib64/libc.so.6+0x25c86)
>
> Fixes: b841e3cd4a28 ("dpif-ne
e
> value and log.
>
> Reported-at: https://bugzilla.redhat.com/2119876
> Signed-off-by: Kevin Traynor
Thanks for the added log.
Overall, this looks good to me.
I have a comment on how the limits are taken into account (see below).
But in any case this patch is ok as is for me:
Reviewed-
onned it initially when enabling ASan:
https://mail.openvswitch.org/pipermail/ovs-dev/2021-February/380467.html
More recently, Eelco mentionned it:
https://mail.openvswitch.org/pipermail/ovs-dev/2022-September/397476.html
I also see it every once in a while in GHA.
--
David Marchand
transact() makes it possible for a
caller to simply ignore the reply from the kernel by passing both
'reply' and 'bufp' as NULL.
- In the specific call to dpif_netlink_dp_transact() (line 398) in
dpif_netlink_open(), the 'dp&#
ag for your patch.
I just sent a new patch, and marked this current one as Rejected.
Thanks Simon and sorry for the confusion.
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Caught during some code review.
SUPPORT_TC_INGRESS_PPS has been replaced with CHECK_TC_INGRESS_PPS().
Fixes: 5f0fdf5e2c2e ("test: Move check for tc ingress pps support to test
script.")
Signed-off-by: David Marchand
---
tests/system-offloads-traffic.at | 2 +-
1 file changed, 1 inser
request.user_features |= OVS_DP_F_VPORT_PIDS;
dp_request.user_features |= OVS_DP_F_UNSUPPORTED;
-error = dpif_netlink_dp_transact(&dp_request, &dp, &buf);
+error = dpif_netlink_dp_transact(&dp_request, NULL, NULL);
if (error) {
/* The Open vSwitch kernel modul
On Tue, Apr 18, 2023 at 10:20 AM Simon Horman wrote:
>
> On Mon, Apr 17, 2023 at 06:28:13PM +0200, David Marchand wrote:
> > Caught during some code review.
> > The incriminated commit had put an unneeded check on tc ingress support
> > for the meter offlo
60b89a309d ("dpif-netlink: Offloading meter to tc police action")
Signed-off-by: David Marchand
---
tests/system-offloads-traffic.at | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/system-offloads-traffic.at b/tests/system-offloads-traffic.at
index da18597cd8..df43caa9e5 10064
lding DPDK does not depend on how we will link OVS against it, so we
can use a single cache entry regardless of DPDK_SHARED option,
Signed-off-by: David Marchand
---
Changes since v1:
- filtered dpdk build job dependencies: it only needs gcc, ninja and
libnuma-dev,
- removed matrix configuratio
Hello Ilya,
On Tue, Apr 4, 2023 at 8:01 PM Ilya Maximets wrote:
>
> On 3/30/23 11:24, David Marchand wrote:
> > Let's separate DPDK compilation from the rest of OVS build:
> > - this avoids multiple jobs building DPDK in parallel, which especially
> > affects bui
> We may switch to quay.io if that will ever become a problem
> in the future.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
et a working container.
I would go with ubuntu-latest.
> +container: fedora:37
> +timeout-minutes: 30
> +
> +strategy:
> + fail-fast: false
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Mar 30, 2023 at 11:24 AM David Marchand
wrote:
>
> Let's separate DPDK compilation from the rest of OVS build:
> - this avoids multiple jobs building DPDK in parallel, which especially
> affects builds in the dpdk-latest branch,
Err, this patch actually breaks dpdk
201 - 300 of 1011 matches
Mail list logo
