Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

It does not give any error with standard QtWebkit. On Wed, May 10, 2017 at 12:25 PM, Dave Page wrote: > Hi > > What happens on a standard QtWebKit if we try to trigger > QWebPage::ToggleVideoFullscreen > + 1? Does it error, or get silently ignored? > > -- > Dave Page > Blog: http://pgsnake.blog

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Cool :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 10 May 2017, at 08:01, Neel Patel wrote: > > It does not give any error with standard QtWebkit. > >> On Wed, May 10, 2017 at 12:25 PM,

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Should I ask Akshay to review and commit ? On Wed, May 10, 2017 at 12:34 PM, Dave Page wrote: > Cool :-) > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK:http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On 10 May 2017, at 08:01, Ne

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Yes please. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 10 May 2017, at 08:24, Neel Patel wrote: > > Should I ask Akshay to review and commit ? > >> On Wed, May 10, 2017 at 12:34 PM, Dave

[pgadmin-hackers] security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes

good day! i fixed tiny errors (html-escaping) , but it has security effects. see file "0001-escape-label-of-node-of-tree-when-events-add-remove-.patch" [ https://github.com/postgres-impulsm/pgadmin4/commit/f993513d148fc6dd7e0196261f847e668d5e2c6c ] -- Андрей Антонов, инженер-программист

[pgadmin-hackers] pgAdmin 4 commit: HTML escape the label, when setting the collection no

HTML escape the label, when setting the collection node count along with the label of the tree-nodes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cbf2de6c27760669a7c7e48f6bfc47c6053309f8 Author: Andrei Antonov Modified Files -

Re: [pgadmin-hackers] security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes

Thanks. Committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* 2017-05-10 1:06 GMT+05:30 Andrei Antonov : > good day! > > i fixed tiny error

Re: [pgadmin-hackers] security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes

On Wed, May 10, 2017 at 8:56 AM, Ashesh Vashi wrote: > Thanks. > Committed! > I agree with the change from a preventative/safety perspective, though I'm struggling to classify it as a security issue, given that collections are always named by the code and not from user input. Am I missing somet

Re: [pgadmin-hackers] security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes

On Wed, May 10, 2017 at 1:29 PM, Dave Page wrote: > > > On Wed, May 10, 2017 at 8:56 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Thanks. >> Committed! >> > > I agree with the change from a preventative/safety perspective, though I'm > struggling to classify it as a security is

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #217

See Changes: [Ashesh Vashi] HTML escape the label, when setting the collection node count along with -- [...truncated 293.23 KB...] copying images... [ 34%] imag

[pgadmin-hackers] pgAdmin 4 commit: 1) Fixed compilation issue with QT4.

1) Fixed compilation issue with QT4. 2) Make trigger action 'RequestClose' backword compatible with annulen webkit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3ed00d3be75ee56169882dfedf12b5207f832b51 Author: Neel Patel Modified Files ---

Re: [pgadmin-hackers] security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes

On Wed, May 10, 2017 at 9:00 AM, Ashesh Vashi wrote: > On Wed, May 10, 2017 at 1:29 PM, Dave Page wrote: > >> >> >> On Wed, May 10, 2017 at 8:56 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Thanks. >>> Committed! >>> >> >> I agree with the change from a preventative/safety

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #101

See Changes: [Ashesh Vashi] HTML escape the label, when setting the collection node count along with -- [...truncated 287.10 KB...] copying images... [ 28%] imag

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #99

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 1.5 release plan

Hi Whilst I wasn't originally planning to cut pgAdmin 1.5 for the moment, I've decided to do so on Monday as we've accumulated a number of bug fixes, as well as some initial changes for PostgreSQL 10.0 support, the first beta of which this will coincide with. So, expect tarballs etc. on Monday 15

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python36 #101

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes

BTW; Ashesh, can you please ensure there's an RM ticket for this, as it's obviously of interest to users. Thanks. On Wed, May 10, 2017 at 9:06 AM, Dave Page wrote: > > > On Wed, May 10, 2017 at 9:00 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, May 10, 2017 at 1:29 PM,

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Any chance we can get this wrapped up today Surinder? On Tue, May 9, 2017 at 11:29 AM, Dave Page wrote: > > > On Tue, May 9, 2017 at 11:03 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Mon, May 8, 2017 at 4:37 PM, Dave Page wrote: >> >>> >>> >>> On Mon, M

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi Dave, On Wed, May 10, 2017 at 2:06 PM, Dave Page wrote: > Any chance we can get this wrapped up today Surinder? > ​I have fixed RM case, I am currently writing its feature test cases which is taking some time. Should I send patch for RM case only?​ I will try to complete test cases by today e

[pgadmin-hackers] pgAdmin 4 commit: Allow creation of tables with pure numeric names. Fix

Allow creation of tables with pure numeric names. Fixes #2284 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9452e0699e69ece872346d941fdc6033bbe0fbd2 Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/table

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python35 #99

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

On Wed, May 10, 2017 at 9:39 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, May 10, 2017 at 2:06 PM, Dave Page wrote: > >> Any chance we can get this wrapped up today Surinder? >> > ​I have fixed RM case, I am currently writing its feature test cases which > i

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python33 #102

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes

Sure - I will create one. On May 10, 2017 14:05, "Dave Page" wrote: > BTW; Ashesh, can you please ensure there's an RM ticket for this, as it's > obviously of interest to users. > > Thanks. > > On Wed, May 10, 2017 at 9:06 AM, Dave Page wrote: > >> >> >> On Wed, May 10, 2017 at 9:00 AM, Ashesh

[pgadmin-hackers] pgAdmin 4 commit: Don't change the trigger icon back to "enabled" when

Don't change the trigger icon back to "enabled" when the trigger is updated when it's disabled. Fixes #2271 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94cbd70370c4578b8e3311ccd76f5b8b5b40454d Author: Murtuza Zabuawala Modified Files ---

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the of issue in Trigger node

Thanks, patch applied. On Wed, May 10, 2017 at 6:42 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find minor patch to fix the issue in trigger node where user tries > to update name/comments on the trigger which is set to disable, it changes > the icon of the

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi Dave, Please find attached patch for RM only. *Changes:* - All formatters now handles both [null] and [default] values - the cell values are validated on server side as in pgAdmin3. - added light grey color for cells with [null] and [default] placeholders. On Wed, May 10, 2017 at 2:12 P

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #103

See Changes: [Dave Page] Allow creation of tables with pure numeric names. Fixes #2284 [Dave Page] Don't change the trigger icon back to "enabled" when the trigger is --

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python26 #218

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python27 #108

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Install of pgadmin4 from package fails ...

Hi, On Mon, 2017-05-08 at 10:20 -0700, Josh Berkus wrote: > > > > > Devrim, where is the source for this rpm build? > > > > https://yum.postgresql.org/srpms/testing/10/redhat/rhel-7-x86_64/repoview/p > > gadmin4-v1.html > > No, I mean the rpm template files, not the source of the software. Th

[pgadmin-hackers] Table OIDs are fixed values?

Hi, I'm building an application that needs to internally store a table ID for each of the tables that have been loaded into it. I found that the pg_class catalog table contains the oid column that is an unique identifier for each table. NOTICE that I'm not talking about the oid metacolumn that can

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Akshay! Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our tests pass. Thanks! João & Sarah On Wed, May 10, 2017 at 2:29 AM, Akshay Joshi wrote: > Hi Sarah > > On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear wrote: > >> Hi Akshay! >> >> >>> Some test file names ended with

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi Dave, Please find attached patch for Feature test cases for RM_2257 *Implementation detail:* - Added a test_data.json file which contains Insert and Update test related input data - First of all, we create three tables such as a) defaults_text b) defaults_boolean c) defaults

Re: [pgadmin-hackers] Install of pgadmin4 from package fails ...

On 05/10/2017 02:32 AM, Devrim Gündüz wrote: > > Hi, > > On Mon, 2017-05-08 at 10:20 -0700, Josh Berkus wrote: >>> Devrim, where is the source for this rpm build? >>> >>> https://yum.postgresql.org/srpms/testing/10/redhat/rhel-7-x86_64/repoview/p >>> gadmin4-v1.html >> >> No, I mean the rpm

Re: [pgadmin-hackers] Install of pgadmin4 from package fails ...

On 05/10/2017 09:39 AM, Josh Berkus wrote: > On 05/10/2017 02:32 AM, Devrim Gündüz wrote: >> >> Hi, >> >> On Mon, 2017-05-08 at 10:20 -0700, Josh Berkus wrote: > Devrim, where is the source for this rpm build? https://yum.postgresql.org/srpms/testing/10/redhat/rhel-7-x86_64/repov

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

On May 10, 2017 19:07, "Sarah McAlear" wrote: Hi Akshay! Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our tests pass. On both 9.6 and 10.0. Query returned 0 rows which is compared against 1 in assert statement. Thanks! João & Sarah On Wed, May 10, 2017 at 2:29 AM, A

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Ashkay! TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with > below error: > .\test_role_dependencies_sql.py\", line 41, in assertions\n > self.assertEqual(1, > len(fetch_result))\nAssertionError: 1 != 0 We experienced a similar problem when we started developing

[pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PG Data-types in Query Tool

Hi, As we have been facing many issues with different data-type display in Query Tool output, Dave suggested to write the feature test for the same. I have started with some basic set of data-type values and will add more. Please find the attached initial patch for the same. Thanks, Khushboo di

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Sarah On Thu, May 11, 2017 at 2:30 AM, Sarah McAlear wrote: > Hi Ashkay! > > TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with >> below error: >> .\test_role_dependencies_sql.py\", line 41, in assertions\n >> self.assertEqual(1, len(fetch_result))\nAssertionErro

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

> On 11 May 2017, at 07:11, Akshay Joshi wrote: > > Hi Sarah > >> On Thu, May 11, 2017 at 2:30 AM, Sarah McAlear wrote: >> Hi Ashkay! >> >>> TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with >>> below error: >>> .\test_role_dependencies_sql.py\", line 41, in as