Re: [HACKERS] New trigger option of pg_standby

2009-04-12 Thread Fujii Masao
Hi, On Sat, Apr 11, 2009 at 1:31 AM, Simon Riggs wrote: > > Fujii-san, > > I like the new patch using the content of the file to determine the > mode. Much easier to use at failover time. > > On Fri, 2009-04-10 at 12:47 +0900, Fujii Masao wrote: > >> > One problem with this patch is that in smart

Re: [HACKERS] New trigger option of pg_standby

2009-04-12 Thread Fujii Masao
Hi, On Fri, Apr 10, 2009 at 6:31 PM, Guillaume Smet wrote: > On Fri, Apr 10, 2009 at 5:47 AM, Fujii Masao wrote: >> One idea to solve this problem is to tell pg_standby as a >> command-line argument about whether the trigger file can be >> removed. That parameter value can be set to 'true' when

[HACKERS] [PATCH] Add a test for pg_get_functiondef()

2009-04-12 Thread Abhijit Menon-Sen
From: Abhijit Menon-Sen Thanks to Andrew Gierth for writing the function used in the test. --- src/test/regress/expected/defs.out | 43 src/test/regress/parallel_schedule |2 +- src/test/regress/serial_schedule |1 + src/test/regress/sql/defs.sql

Re: [HACKERS] pg_restore dependencies

2009-04-12 Thread Josh Berkus
Andrew, Tom, I just did a test run using Andrew's patch with a database with over 400 objects. I didn't see any locks waiting during the entire run. So the patch logic appears to work. Note that it also shows up that some CONSTRAINT declarations really shouldn't require an exclusive lock.

Re: [HACKERS] pg_restore dependencies

2009-04-12 Thread Andrew Dunstan
Josh Berkus wrote: Andrew, Do we have a final version of this patch yet? I have to do an upgrade test run today, so it would be a good time to test it. I'm working on an updated patch right now. But it is only cosmetically different from the one I posted before. Functionally it's identi

Re: [HACKERS] Closing some 8.4 open items

2009-04-12 Thread Dimitri Fontaine
Hi, Reacting somewhat late, but maybe not too late? Le 11 avr. 09 à 17:13, Tom Lane a écrit : My own take on it is that actually I'd prefer one command for all of these. If I say "\df sum" it would be good if the output included the sum() aggregates; the reason being that I might be wondering

Re: [HACKERS] [pgtranslation-translators] on gettext plural support

2009-04-12 Thread Peter Eisentraut
On Sunday 12 April 2009 18:06:48 Tom Lane wrote: > Peter Eisentraut writes: > > I don't think there is much you can do here. Either leave it out, or > > write "CANNOT HAPPEN", or just translate normally. > > But Alvaro's complaint that the current coding is incorrect for English > still stands, n

Re: [HACKERS] pg_restore dependencies

2009-04-12 Thread Josh Berkus
Andrew, Do we have a final version of this patch yet? I have to do an upgrade test run today, so it would be a good time to test it. -- Josh Berkus PostgreSQL Experts Inc. www.pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscri

Re: [HACKERS] [pgtranslation-translators] on gettext plural support

2009-04-12 Thread Tom Lane
Peter Eisentraut writes: > I don't think there is much you can do here. Either leave it out, or write > "CANNOT HAPPEN", or just translate normally. But Alvaro's complaint that the current coding is incorrect for English still stands, no? Or does ngettext choose the second string for n = 0?

Re: [HACKERS] [pgtranslation-translators] on gettext plural support

2009-04-12 Thread Peter Eisentraut
On Sunday 12 April 2009 04:10:07 Alvaro Herrera wrote: > So it turns out that for the string above it doesn't make any sense to > have the %d being exactly 1: the code is > So ntups is either 0, or it's greater than 1 -- the first message does > not really make sense to me ... > > I'm not really s

Re: [HACKERS] Path separator

2009-04-12 Thread Magnus Hagander
Tom Lane wrote: > Magnus Hagander writes: >>> Answering myself here: the filesize for the "frontend only" part is >>> about 2k on this system. > >> Long meeting, time for coding.. :-) Here's a rough patch. Is this about >> what you had in mind? > > Hm, this seems to make the namespace pollution