Re: Review Request: Tooltip show the thumbnail not correctly centered

2008-12-14 Thread Loic Marteau
On 2008-12-13 16:57:49, Aaron Seigo wrote: i don't think the checkSize from prepareShowing should be removed; it's ok to add it to showEvent, though. i do wonder, however: does layout()-activate() work as well in showEvent()? it *should* have the right size there, but maybe just not

sorting favorites

2008-12-14 Thread András Kéri
Hi, I've found no bug report against it, but the sort actions in favorites tab don't work, as the slots missing from the favoritesmodel. See the patch. Regards, Andras Index: applets/kickoff/core/favoritesmodel.cpp === ---

Re: sorting favorites

2008-12-14 Thread Alex Merry
On Sunday 14 December 2008 14:50:33 András Kéri wrote: Hi, I've found no bug report against it, but the sort actions in favorites tab don't work, as the slots missing from the favoritesmodel. See the patch. Good catch. You able to commit this? Alex signature.asc Description: This is a

Re: autoscroll in kickoff

2008-12-14 Thread Alex Merry
On Saturday 13 December 2008 17:40:41 András Kéri wrote: Hi, I'm relatively new to KDE, and I would like to contribute, if I could. As a first try I made a patch which allows automatic scroll in application tab of kickoff, because it's really hard to navigate in long lists without a mouse

Re: sorting favorites

2008-12-14 Thread András Kéri
Alex Merry wrote: On Sunday 14 December 2008 14:50:33 András Kéri wrote: Hi, I've found no bug report against it, but the sort actions in favorites tab don't work, as the slots missing from the favoritesmodel. See the patch. Good catch. You able to commit this? I think no, as I'm using

Re: Review Request: Make folderview follow some guidelines

2008-12-14 Thread Artur Souza (MoRpHeUz)
Hey! On Sun, Dec 14, 2008 at 12:00 PM, Fredrik Höglund fred...@kde.org wrote: The warning that the desktop folder will be created when the user selects Show Desktop folder in the config dialog was carefully worked out in coordination with our usability experts, so I thank you for not removing

Re: Review Request: Add tooltips to show current song when nowplaying is in the panel

2008-12-14 Thread Tony Murray
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/309/ --- (Updated 2008-12-14 08:37:50.083043) Review request for Plasma and Alex

Re: Review Request: Add tooltips to show current song when nowplaying is in the panel

2008-12-14 Thread Tony Murray
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/309/ --- (Updated 2008-12-14 09:09:14.580208) Review request for Plasma and Alex

Re: Review Request: Add tooltips to show current song when nowplaying is in the panel

2008-12-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/309/#review296 --- Ship it! Apart from the comments below, it looks good to me.

Re: Review Request: Add tooltips to show current song when nowplaying is in the panel

2008-12-14 Thread Tony Murray
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/309/ --- (Updated 2008-12-14 09:11:59.449832) Review request for Plasma and Alex

Re: Review Request: Make folderview follow some guidelines

2008-12-14 Thread Fredrik Höglund
On Sunday 14 December 2008 16:34, Artur Souza (MoRpHeUz) wrote: Hey! On Sun, Dec 14, 2008 at 12:00 PM, Fredrik Höglund fred...@kde.org wrote: The warning that the desktop folder will be created when the user selects Show Desktop folder in the config dialog was carefully worked out in

Re: Review Request: Add tooltips to show current song when nowplaying is in the panel

2008-12-14 Thread Tony Murray
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/309/ --- (Updated 2008-12-14 09:52:34.949310) Review request for Plasma and Alex

Re: Review Request: Add tooltips to show current song when nowplaying is in the panel

2008-12-14 Thread Tony Murray
On 2008-12-14 09:10:47, Alex Merry wrote: /trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.cpp, lines 280-294 http://reviewboard.vidsolbach.de/r/309/diff/2/?file=1627#file1627line280 What happens if you Feeling Good by Michael Bublé playing, then the next song is Muse's

Help figuring out theming problem

2008-12-14 Thread Jamboarder
I've been working on updating Aya for the 4.2 release. However, I've been running into a few problems that I'm having trouble figuring out. Below are some screenshot links showing my problems (click on image to show full size). http://img505.imageshack.us/my.php?image=ayacorrectej4.png shows

Re: Review Request: Make folderview follow some guidelines

2008-12-14 Thread Fredrik Höglund
On Sunday 14 December 2008 17:09, Celeste Lyn Paul wrote: On Sunday 14 December 2008 10:34:22 Artur Souza (MoRpHeUz) wrote: Hey! On Sun, Dec 14, 2008 at 12:00 PM, Fredrik Höglund fred...@kde.org wrote: The warning that the desktop folder will be created when the user selects Show

Re: sorting favorites

2008-12-14 Thread Jesse L. Zamora
On Sunday 14 December 2008 09:50:33 András Kéri wrote: Hi, I've found no bug report against it, but the sort actions in favorites tab don't work, as the slots missing from the favoritesmodel. See the patch. Regards, Andras Yikes, sorry about that, I guess that code got lost when aseigo

FrameSvg and masks

2008-12-14 Thread Marco Martin
Hi all, speaking with fredrikh about speed with window masks some things have emerged: returning a qbitmap is a bit wrong, since it will have to be converted to a qregion each time, so.. should the framesvg mask function return a qregion? this would of course break the api, so quite of a problem

Review Request: Scrollbars for the comic applet

2008-12-14 Thread Matthias Fuchs
Hi, Here is a patch -- I lost my reviewboard pw and there is no link for that case ;) -- that adds scrollbars to the comic applet if the comic strips are shown at their original size but the applet was not assigned enough space. I'm not sure if my implemention is any good, so I hope that

A usable plasma desktop

2008-12-14 Thread Steven
A few usability bugs (okay, maybe only one, but I like exaggeration as much as the next guy) have been popping up recently regarding how to deal with the Desktop folder. Users and applications alike are used to using it as a dumping ground for files, launchers and downloads. Most solutions have to

Re: Review Request: Make folderview follow some guidelines

2008-12-14 Thread Aaron J. Seigo
On Sunday 14 December 2008, Fredrik Höglund wrote: On Sunday 14 December 2008 17:09, Celeste Lyn Paul wrote: On Sunday 14 December 2008 10:34:22 Artur Souza (MoRpHeUz) wrote: Hey! On Sun, Dec 14, 2008 at 12:00 PM, Fredrik Höglund fred...@kde.org wrote: The warning that the desktop

Re: Review Request: Add tooltips to show current song when nowplaying is in the panel

2008-12-14 Thread Aaron J. Seigo
On Sunday 14 December 2008, Tony Murray wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/309/ --- Review request for Plasma

Re: Help figuring out theming problem

2008-12-14 Thread Jamboarder
From: Marco Martin notm...@gmail.com On Sunday 14 December 2008, Jamboarder wrote: I've been working on updating Aya for the 4.2 release. However, I've been running into a few problems that I'm having trouble figuring out. Below are some screenshot links showing my problems (click on

Re: Review Request: Make folderview follow some guidelines

2008-12-14 Thread Steven
2008/12/14 Aaron J. Seigo ase...@kde.org On Sunday 14 December 2008, Fredrik Höglund wrote: On Sunday 14 December 2008 17:09, Celeste Lyn Paul wrote: On Sunday 14 December 2008 10:34:22 Artur Souza (MoRpHeUz) wrote: Hey! On Sun, Dec 14, 2008 at 12:00 PM, Fredrik Höglund

Re: A usable plasma desktop

2008-12-14 Thread Steven
I think you may have taken offense to the title. This was not intended as an insult. Let me explain why I chose it, and I'm sorry if any offense was taken. I am all for the concepts behind Plasma. I like the idea of organizing files, programs, and tools needed for a task in an activity for easy

Re: A usable plasma desktop

2008-12-14 Thread Steven
Shoot! The title's supposed to be Committing to a usable plasma desktop! I am very sorry. On Sun, Dec 14, 2008 at 11:42 PM, Steven steven...@gmail.com wrote: I think you may have taken offense to the title. This was not intended as an insult. Let me explain why I chose it, and I'm sorry if

Re: A usable plasma desktop

2008-12-14 Thread Chani
If I'm way off, that I ask that you suggest something else, as, at the moment, there are unresolved useability bugs that need attention, as evidenced by the number of people looking forward to the folder view desktop as an alternative to the plasma desktop. yes, you are way off... because

Re: A usable plasma desktop

2008-12-14 Thread Aaron J. Seigo
On Sunday 14 December 2008, Steven wrote: constructive discussion, I chose not to. Please try to do the same yourself, and not alienate your users. this list is not for users, any more than a room for engineering cars is for drivers. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint:

Re: A usable plasma desktop

2008-12-14 Thread Aaron J. Seigo
On Sunday 14 December 2008, Steven wrote: place or the other. If folder views could reduce their reliance on the file system, then setting this up could become a lot easier. nepomuk, for files, and for everything beyond such a literal represtenting going beyond those concepts by doing like

Re: Review Request: Make folderview follow some guidelines

2008-12-14 Thread Aaron J. Seigo
On Sunday 14 December 2008, Steven wrote: The problem is, it isn't just Firefox, its lots of programs. Until the does anyone have a list of the significant ones? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer

Re: autoscroll in kickoff

2008-12-14 Thread Anne-Marie Mahfouf
How about having a place in the KDE trunk where you have all code for the next release that didn't make it into KDE 4.2? Just an idea... Xtreme Kommander We (the KDE devels) already agreed to open trunk at some point before 4.2 release, see release team for that. In the meantime, the way to