Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-22 Thread Vishesh Handa
On Wed, Oct 22, 2014 at 11:47 AM, Ivan Čukić wrote: > > > Does this mean that baloo does not search file names at all? >> >> >> I'm confused about your question. You'd initially asked "if baloo skips >> indexing a file that is in an indexable folder - does it store any >> > > So, I have a genome

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
ey are frequent the don't consume any space, and are automatically deleted if the user starts using more space. Anyway, we probably should not discussing btrfs stuff. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
On Tue, Oct 21, 2014 at 10:48 PM, Vishesh Handa wrote: > > So basically a filter on top of the global list of recently used >> documents? >> > > Yes - it was suggested a few times to subdivide Recent > Documents into content type groups like text documents > and

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
nd it seems to make sense. > I'm not sure how this would work - How would kamd know about when an application has been created? Would it be getting notified by the package manager or monitoring all of /usr/ itself? Maybe Ivan can chime in since he probably had an implementation in mind w

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
On Tue, Oct 21, 2014 at 9:58 PM, Eike Hein wrote: > > > On 10/21/2014 07:27 PM, Vishesh Handa wrote: > >> Who else? >> > > Kicker. Ivan also has his Lancelot launcher in develop- > ment as I understand it. > > > Could you perhaps talk about possible wo

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
rom my POV, one use-case would be applications that open different things > like KDevelop having sessions and files. So a mimetype could be used to > filter out what exactly they want to show etc. > So basically a filter on top of the global list of recently used documents? > > >> > Application Launching Interface (ALI) search history. >> >> * You mean like the krunner search history that was there in KDE4? >> > > For example. > Would this need to be a part of kactivities or can we just add this in krunner? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
not the other way around. Unless we maintain our own mapping. But maybe I'm wrong. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120623: LocationRunner: Convert case insensitive path to a proper one

2014-10-21 Thread Vishesh Handa
/ Testing --- Bug fixed. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
, we can possibly create a new service just to do this. We can potentially start thinking of solutions based on inode number + disk id, though that has drawbacks as well. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
e used? > Application Launching Interface (ALI) search history. * You mean like the krunner search history that was there in KDE4? > Grouping things together by analysing the statistics (more advanced - API does not need to cover it). > Recently used contacts > Frequ

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
ul here. * Silently failing is not always a good idea * Making file Indexing mandatory for statistics also seems a little bit risky. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-20 Thread Vishesh Handa
the result, and that score doesn't degrade over time. This seems like something nice to replace it with, if we can make it super fast that is. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120623: LocationRunner: Convert case insensitive path to a proper one

2014-10-20 Thread Vishesh Handa
--- Bug fixed. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Baloo - Not Indexing everything by default

2014-10-17 Thread Vishesh Handa
b. About gibberish. It's hard to figure out what gibberish is. I think I'll add some code that we only index the first 20 characters of each word. That should help to a certain extent. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Baloo - Not Indexing everything by default

2014-10-17 Thread Vishesh Handa
dvanced users. I've added a TODO about this to todo.kde.org. Hopefully, we can get a more advanced new comer to try and hack on this. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120623: LocationRunner: Convert case insensitive path to a proper one

2014-10-17 Thread Vishesh Handa
ply, visit: https://git.reviewboard.kde.org/r/120623/#review68617 ------- On Oct. 17, 2014, 3:32 p.m., Vishesh Handa wrote: > > --- > This is an automatically gen

Review Request 120623: LocationRunner: Convert case insensitive path to a proper one

2014-10-17 Thread Vishesh Handa
/show_bug.cgi?id=95 Repository: plasma-workspace Description --- See bug report Diffs - runners/locations/locationrunner.cpp 13035a9 Diff: https://git.reviewboard.kde.org/r/120623/diff/ Testing --- Bug fixed. Thanks, Vishesh Handa

Baloo - Not Indexing everything by default

2014-10-16 Thread Vishesh Handa
s and Music. All of these are xdg user directories. Gnome Tracker actually does something quite similar. Comments? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-14 Thread Vishesh Handa
tps://git.reviewboard.kde.org/r/120550/#comment47668> Strange indentation. - Vishesh Handa On Oct. 13, 2014, 5:54 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-14 Thread Vishesh Handa
> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: > > src/quickaddons/managedtexturenode.h, line 52 > > > > > > even if will always remain just this member, just to me sure, it should > > be in a dpointer > > A

Re: Review Request 120524: Let Search Folder Updater's name match by X-KDE-DBus-ModuleName and desktop file name

2014-10-08 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120524/#review68075 --- Ship it! Ship It! - Vishesh Handa On Oct. 7, 2014, 6:39

Re: Collecting new/improved stuff in 5.1 for promo

2014-10-01 Thread Vishesh Handa
le indexer and will listen to changes on xattr for files. This means any application can set the tags/ratings by just setting the xattr of the file. Applications no longer need to talk to Baloo. * Overall speed improvements * Many more tests in the File Indexers -- Vis

Re: Review Request 120419: [ksmserver] Get rid of KDELibs4Support...

2014-09-29 Thread Vishesh Handa
d the loading of KDELibs4Support was making a difference. - Vishesh Handa On Sept. 29, 2014, 10:50 a.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Moving kde:muon repository to kde/workspaces

2014-09-26 Thread Vishesh Handa
+1 -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120235: restore ResizeOrigin

2014-09-18 Thread Vishesh Handa
like this patch. Feel free to commit it. I'll try it out later. - Vishesh Handa On Sept. 17, 2014, 4:53 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
ich in turn checks resizeOrigin? It doesn't seem like it. src/plasmaquick/dialog.cpp <https://git.reviewboard.kde.org/r/120235/#comment46562> ditto - Vishesh Handa On Sept. 17, 2014, 4:03 p.m., Marco Martin wrote: > > ---

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
> On Sept. 17, 2014, 2:54 p.m., Vishesh Handa wrote: > > src/plasmaquick/dialog.cpp, line 301 > > <https://git.reviewboard.kde.org/r/120235/diff/2/?file=312805#file312805line301> > > > > Would this actually do anything? > > > > resiz

Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Vishesh Handa
> deprecated > would clash) > Just to confirm - With this, the package class in plasma-framework will now be deprecated? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
lasmaquick/dialog.cpp <https://git.reviewboard.kde.org/r/120235/#comment46534> Oh. I didn't realize we had cases when the mainItem could be 0. Could you please add an assert in syncToMainItemSize for checking the mainItem. - Vishesh Handa On Sept. 17, 2014, 2:32 p.m., Marc

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
nts. It would be nice to have code paths which we can easily follow. - Vishesh Handa On Sept. 16, 2014, 3:52 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 120235: restore ResizeOrigin

2014-09-16 Thread Vishesh Handa
> On Sept. 16, 2014, 4:08 p.m., Vishesh Handa wrote: > > We currently have the following ways of changing the dialog size > > > > 1. By changing the mainItem size > > 2. By actually changing the size of the dialog via QML > > 3. Window Managers > > >

Re: Review Request 120235: restore ResizeOrigin

2014-09-16 Thread Vishesh Handa
: 200 } } What do you think should be happening in this case? It's not obvious. I propose we make the mainItem responsible for the dialog size. The 'width' and 'height' properties of the Dialog can be made read only. - Vishesh Handa On Sept. 16, 2014,

Re: Review Request 119945: Dialog: Simplify handling of min/max width/height changed

2014-08-28 Thread Vishesh Handa
c/plasmaquick/dialog.h f207f88 src/plasmaquick/dialog.cpp 02271e4 Diff: https://git.reviewboard.kde.org/r/119945/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119945: Dialog: Simplify handling of min/max width/height changed

2014-08-26 Thread Vishesh Handa
.reviewboard.kde.org/r/119945/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Re: OSD above fullscreen windows

2014-08-12 Thread Vishesh Handa
Notification" type for Notifications instead of a "dock type". This is something that should be done regardless of the discussion. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Minutes Monday Plasma Hangout

2014-08-11 Thread Vishesh Handa
On Mon, Aug 11, 2014 at 12:40 PM, Sebastian Kügler wrote: > Antonis: > - finished port of PA's widget explorer and containment > - New resource indexer based on Baloo merged > Could someone please elaborate on this? I'm not sure what a "resource indexer&q

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

2014-08-05 Thread Vishesh Handa
> On Aug. 5, 2014, 12:29 p.m., Marco Martin wrote: > > components/baloodatamodel/baloodatamodel.cpp, line 116 > > <https://git.reviewboard.kde.org/r/119617/diff/1/?file=296386#file296386line116> > > > > maybe this should be done in a thread? > > Vishes

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

2014-08-05 Thread Vishesh Handa
> On Aug. 5, 2014, 2:17 p.m., Vishesh Handa wrote: > > I think the Baloo repo might a better place for code. It's not really > > Plasma specific. > > Marco Martin wrote: > import org.kde.baloo in the baloo repo with this class and eventually > others?

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

2014-08-05 Thread Vishesh Handa
x27;s not really Plasma specific. - Vishesh Handa On Aug. 5, 2014, 12:22 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 119602: support config dialog with current krunner config dialog

2014-08-05 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119602/#review63860 --- Ship it! - Vishesh Handa On Aug. 5, 2014, 10:50 a.m

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

2014-08-05 Thread Vishesh Handa
> On Aug. 5, 2014, 12:29 p.m., Marco Martin wrote: > > two things: > > * perhaps the query should still be executed in a thread > > * maybe the syntax from qml would be nicer if the query is in a sub object > > to have something like: > > > > BalooModel { > > query { > > type: "File

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

2014-08-05 Thread Vishesh Handa
> On Aug. 5, 2014, 12:29 p.m., Marco Martin wrote: > > components/baloodatamodel/baloodatamodel.cpp, line 116 > > > > > > maybe this should be done in a thread? I named the method exec so that it was clear it mi

Re: Review Request 119602: support config dialog with current krunner config dialog

2014-08-05 Thread Vishesh Handa
> On Aug. 5, 2014, 9:44 a.m., Vishesh Handa wrote: > > kcms/runners/kcm.cpp, line 60 > > <https://git.reviewboard.kde.org/r/119602/diff/3/?file=295947#file295947line60> > > > > I'm fairly certain this is going to look bad on my hidpi screen. >

Re: Review Request 119602: support config dialog with current krunner config dialog

2014-08-05 Thread Vishesh Handa
/r/119602/#comment44516> Why the 1.2? - Vishesh Handa On Aug. 5, 2014, 9:24 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 119602: support config dialog with current krunner config dialog

2014-08-04 Thread Vishesh Handa
required. kcms/runners/kcm.cpp <https://git.reviewboard.kde.org/r/119602/#comment44469> Please use !isEmpty() instead - Vishesh Handa On Aug. 4, 2014, 5:02 p.m., Marco Martin wrote: > > --- > This is an

Re: Review Request 119602: support config dialog with current krunner config dialog

2014-08-04 Thread Vishesh Handa
> On Aug. 4, 2014, 2:37 p.m., Vishesh Handa wrote: > > It would be nice if you could upload a screenshot. > > Marco Martin wrote: > done. and yep, i know it looks completely screwed at the moment :) (not > exactly sure why the button is so much off center vertically) &

Re: Review Request 119557: use kpluginselector for enabling runners

2014-08-04 Thread Vishesh Handa
> On Aug. 1, 2014, 4:28 p.m., Vishesh Handa wrote: > > Nope. > > > > You're now listing plugins instead of listing categories. > > Marco Martin wrote: > ook, but this gives a couple of problems > Only giving possibility of enabling and disabling

Re: Review Request 119602: support config dialog with current krunner config dialog

2014-08-04 Thread Vishesh Handa
kcm.cpp <https://git.reviewboard.kde.org/r/119602/#comment8> Please use a proper enum. - Vishesh Handa On Aug. 4, 2014, 12:26 p.m., Marco Martin wrote: > > --- > This is an automatically

Re: Review Request 119557: use kpluginselector for enabling runners

2014-08-01 Thread Vishesh Handa
sting categories. - Vishesh Handa On Aug. 1, 2014, 1 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Reviews

2014-07-29 Thread Vishesh Handa
t no longer relevant. If > someone from PMC pings me I can help go through and discard outdated > things. > > David > Hey guys How about we get a separate group for PMC? It's is a separate mature project after all. The review request emails can still continue coming on the plasm

Re: Review Request 107881: Rename krunner plugin konsolesessions to konsoleprofiles

2014-07-29 Thread Vishesh Handa
suggested? - Vishesh Handa On Dec. 31, 2012, 6:58 p.m., Jekyll Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2014-07-29 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/#review63408 --- Jekyll, ping? - Vishesh Handa On Dec. 31, 2012, 7:12 p.m

Re: Review Request 107869: Add a real konquerorsessions plugin for krunner

2014-07-29 Thread Vishesh Handa
Attachment: the patch - 0002-Add-a-real-konquerorsessions-plugin_1.patch <https://git.reviewboard.kde.org//r/107869/#fcomment230> I don't really understand the whole "kate" comment. - Vishesh Handa On Dec. 23, 2012, 12:27

Re: Minutes Monday Plasma Hangout

2014-07-14 Thread Vishesh Handa
On Jul 14, 2014 1:02 PM, "Sebastian Kügler" wrote: > Sebastian: > - last bits of work on release promo, join #kde-promo to help out > - long video: https://www.youtube.com/watch?v=4n2dthDSGkc > - short video: https://www.youtube.com/watch?v=c8JYt_xkJuY > - release notes at: https://notes.kde.org/p

Re: Review Request 119199: RFC: Debugging tool for plasma

2014-07-10 Thread Vishesh Handa
tps://git.reviewboard.kde.org/r/119199/#comment43179> The coding style is different over here src/plasma/private/timetracker.cpp <https://git.reviewboard.kde.org/r/119199/#comment43182> Sorry, but there isn't enough space between the >= - Vishesh Handa On July 9, 2014,

Re: Copying over kxmlrpcclient into plasma-workspace

2014-07-08 Thread Vishesh Handa
gt; http://paste.ubuntu.com/7765528/ > > Would be awesome if I could get a ship it. > > Cheers > Rohan Garg > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > -- Vi

Re: Review Request 119176: Update kickoff when user's name or face image changed

2014-07-08 Thread Vishesh Handa
viewboard.kde.org/r/119176/#comment43095> You'll be returning "invalid image". Why not just an empty string? - Vishesh Handa On July 8, 2014, 12:49 p.m., Sebastian Kügler wrote: > > --- > This is an aut

Re: Review Request 119155: Make the desktop containment respect minimum sizes

2014-07-07 Thread Vishesh Handa
esult in a warning in line 264 and 265. containments/desktop/package/contents/ui/main.qml <https://git.reviewboard.kde.org/r/119155/#comment43026> ? - Vishesh Handa On July 7, 2014, 12:51 p.m., Marco Martin wrote: > > --- &g

Re: Moving parts of kde-baseapps to plasma-workspace

2014-07-07 Thread Vishesh Handa
On Thu, Jul 3, 2014 at 3:10 PM, Vishesh Handa wrote: > > On Tue, Jul 1, 2014 at 6:36 PM, Vishesh Handa wrote: > >> 1. kdepasswd - Contains the KCM for changing the real name and picture. >> This name is used by kickoff and is prominently displayed. It also contains >

Re: Review Request 119104: Add a "Search" category under "Workspace"

2014-07-07 Thread Vishesh Handa
gories/settings-workspace-search.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119104/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119116: KRunner: Show a "Configure" button on the side

2014-07-04 Thread Vishesh Handa
/119116/diff/ Testing --- File Attachments krunner_withconfig.png https://git.reviewboard.kde.org/media/uploaded/files/2014/07/04/32a97211-153a-4f42-b5bf-9ed4560acb34__krunner_withconfig.png Thanks, Vishesh Handa ___ Plasma

Review Request 119116: KRunner: Show a "Configure" button on the side

2014-07-04 Thread Vishesh Handa
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/04/32a97211-153a-4f42-b5bf-9ed4560acb34__krunner_withconfig.png Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [kde-packager] Re: [kde-packager] Plasma 5 RC

2014-07-04 Thread Vishesh Handa
On Fri, Jul 4, 2014 at 11:13 AM, Vishesh Handa wrote: > I would really like the tarballs to have the same name. Also, baloo4 and 5 > are not really co-installable. They both ship executables with the same > name. > Just to clarify. All the libraries and plugins are co-instalable. I

Re: Review Request 119104: Add a "Search" category under "Workspace"

2014-07-04 Thread Vishesh Handa
iewboard.kde.org/r/119104/#review61556 --- On July 3, 2014, 1:35 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 119105: PlasmaShell: Disable Session Management

2014-07-04 Thread Vishesh Handa
clears up the booting process to a certain extent, as plasmashell will now not be started twice (once via session restore, and once via autostart) Diffs - shell/main.cpp 0b96674 Diff: https://git.reviewboard.kde.org/r/119105/diff/ Testing --- Thanks, Vishesh Handa

Re: Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES

2014-07-04 Thread Vishesh Handa
/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118977: KSMServer: Do not autostart files

2014-07-04 Thread Vishesh Handa
Diff: https://git.reviewboard.kde.org/r/118977/diff/ Testing --- Applications are now only started once. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [kde-packager] Re: [kde-packager] Plasma 5 RC

2014-07-04 Thread Vishesh Handa
On Fri, Jul 4, 2014 at 10:59 AM, Jonathan Riddell wrote: > On Fri, Jul 04, 2014 at 12:54:22AM +0200, Vishesh Handa wrote: > >On Thu, Jul 3, 2014 at 11:05 PM, Jonathan Riddell > wrote: > > > > d58af08286e9d85ea6afa77831692c02efba9ba8ddebf57fd342854062425d39 &

Re: Plasma 5 RC

2014-07-03 Thread Vishesh Handa
On Thu, Jul 3, 2014 at 6:29 PM, Jonathan Riddell wrote: > > Please check for sanity and let me know what's broken. Announce expected on > Tuesday. I've noticed that a number of packages (baloo, milou, kfilemetadata) have empty doc folders. I'm not sure if it is a prob

Re: [kde-packager] Plasma 5 RC

2014-07-03 Thread Vishesh Handa
have 5 appended to them? baloo5, kfilemetadata5, and milou5? Others seem to be missing the 5. Please either add the 5 everywhere or remove it from those 3. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119105: PlasmaShell: Disable Session Management

2014-07-03 Thread Vishesh Handa
twice (once via session restore, and once via autostart) Diffs - shell/main.cpp 0b96674 Diff: https://git.reviewboard.kde.org/r/119105/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES

2014-07-03 Thread Vishesh Handa
> On July 3, 2014, 11:41 a.m., Aleix Pol Gonzalez wrote: > > Don't we still need to pass the language somehow? or now it will be enough > > with $LANG? > > Vishesh Handa wrote: > KLocale languages had a list of languages. The first one being the main > one

Review Request 119104: Add a "Search" category under "Workspace"

2014-07-03 Thread Vishesh Handa
g/r/119104/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Moving parts of kde-baseapps to plasma-workspace

2014-07-03 Thread Vishesh Handa
On Tue, Jul 1, 2014 at 6:36 PM, Vishesh Handa wrote: > 1. kdepasswd - Contains the KCM for changing the real name and picture. > This name is used by kickoff and is prominently displayed. It also contains > an app called 'kpasswd' which doesn't really work. Let's mo

Re: Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES

2014-07-03 Thread Vishesh Handa
ated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119103/#review61543 --- On July 3, 2014, 11:25 a.m., Vishesh Handa wrote: > > --- > This is an automaticall

Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES

2014-07-03 Thread Vishesh Handa
- startkde/kstartupconfig/CMakeLists.txt 6920fe5 startkde/kstartupconfig/kdostartupconfig.cpp d545f4f startkde/startkde.cmake 40e3377 Diff: https://git.reviewboard.kde.org/r/119103/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma

Re: Review Request 118977: KSMServer: Do not autostart files

2014-07-02 Thread Vishesh Handa
Diff: https://git.reviewboard.kde.org/r/118977/diff/ Testing --- Applications are now only started once. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The "Social Desktop" KCM

2014-07-02 Thread Vishesh Handa
Removed - commit e6e1948c49b455ef1865dd76d4ffccaa43970880 Author: Vishesh Handa Date: Wed Jul 2 14:56:32 2014 +0200 Remove the attica-kde aka "The Social Desktop" KCM This KCM was only used for providing credentials for loging into opendesktop.org (or other mythical

The "Social Desktop" KCM

2014-07-02 Thread Vishesh Handa
thing for me. * We have the option of adding a provider. What is that? It may be best if we do not ship the KCM from now on. Specially since the openDesktop.org is proprietary. Opinions? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Moving parts of kde-baseapps to plasma-workspace

2014-07-01 Thread Vishesh Handa
On Tue, Jul 1, 2014 at 6:49 PM, Eike Hein wrote: > Yeah, this can die. Folder now lives in plasma-desktop. kde-baseapps/plasma has been removed http://commits.kde.org/kde-baseapps/df78336e6974996dffbc13c77a0d28061ba283d2 -- Vishesh Ha

Re: new systemsettings categorization landed

2014-07-01 Thread Vishesh Handa
an be applied to other modules like file associations, > paths, and launch feedback. > If the reasoning can be applied to multiple places perhaps it's a valid concern and should not be dismissed? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Moving parts of kde-baseapps to plasma-workspace

2014-07-01 Thread Vishesh Handa
on this, right? We additionally seem to have a copy of libkonq in plasma-desktop. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: new systemsettings categorization landed

2014-07-01 Thread Vishesh Handa
al category. Perhaps we should continue this conversation on the forums? I prefer email, but I understand that these kind of "design" decisions are made in the forums. I commented over there as well [1] [1] http://forum.kde.org/viewtopic.php?f=285&t=121053&p=314382#p314382 -- V

Re: Review Request 118977: KSMServer: Do not autostart files

2014-07-01 Thread Vishesh Handa
tch > > Marco Martin wrote: > is the rest up to date? now krunner should be started with autostart as > the rest > > Vishesh Handa wrote: > It seems that KRunner was started twice cause it being restored by the > session manager and being started. I'll change

Re: Review Request 118977: KSMServer: Do not autostart files

2014-07-01 Thread Vishesh Handa
sting --- Applications are now only started once. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: new systemsettings categorization landed

2014-07-01 Thread Vishesh Handa
gt; > Cheers, > -- > sebas > > http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118974: UserAccount KCM: Change the name using the AccountManager

2014-07-01 Thread Vishesh Handa
> On July 1, 2014, 10:08 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 77275f50241eb2f4e38051152074c379fa96fe84 by Vishesh Handa to branch > > frameworks. Alex gave me a ship i

Re: Review Request 118974: UserAccount KCM: Change the name using the AccountManager

2014-07-01 Thread Vishesh Handa
Diff: https://git.reviewboard.kde.org/r/118974/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118974: UserAccount KCM: Change the name using the AccountManager

2014-07-01 Thread Vishesh Handa
ard.kde.org/r/118974/#review61084 --- On June 30, 2014, 1:16 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Runners KCM

2014-06-30 Thread Vishesh Handa
ably not possible now due to > string freeze?). > Yes. I had been thinking along the same lines. > - Ability to configure the shortcut to activate it. > I'm on it. > - List of plugins to enable/disable. > I'm confused. Isn't that exactly what the screenshot provides? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118974: UserAccount KCM: Change the name using the AccountManager

2014-06-30 Thread Vishesh Handa
sting --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118977: KSMServer: Do not autostart files

2014-06-27 Thread Vishesh Handa
sit: https://git.reviewboard.kde.org/r/118977/#review61099 --- On June 27, 2014, 2:59 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Review Request 118977: KSMServer: Do not autostart files

2014-06-27 Thread Vishesh Handa
once. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118975: Shell: Show an OSD for the keyboard brightness

2014-06-27 Thread Vishesh Handa
/118975/diff/ Testing --- Yup. Works! Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118975: Shell: Show an OSD for the keyboard brightness

2014-06-27 Thread Vishesh Handa
-workspace Description --- I have corresponding patches in powerdevil to hook it up and show it. Diffs - shell/osd.h 134d9f5 shell/osd.cpp a3fbedc Diff: https://git.reviewboard.kde.org/r/118975/diff/ Testing --- Yup. Works! Thanks, Vishesh Handa

Runners KCM

2014-06-27 Thread Vishesh Handa
x27;ve been in touch with the VDG group. The idea is to call the KCM - "Plasma Search", and rename the Baloo one to "Search Backend". It's not perfect, but it works. This will result in a minor break in string freeze. -- Vishes

Review Request 118974: UserAccount KCM: Change the name using the AccountManager

2014-06-27 Thread Vishesh Handa
rd in memory. Diffs - kdepasswd/kcm/CMakeLists.txt ddb2ed6 kdepasswd/kcm/chfnprocess.h 9f962e2 kdepasswd/kcm/chfnprocess.cpp fca8e25 kdepasswd/kcm/main.cpp 25f9001 Diff: https://git.reviewboard.kde.org/r/118974/diff/ Testing --- Thanks, Vishesh

Re: Review Request 118937: DesktopView: Launch krunner on typing

2014-06-26 Thread Vishesh Handa
shell/desktopview.cpp a0e08ad Diff: https://git.reviewboard.kde.org/r/118937/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118933: PlasmaShell: Do not start krunner

2014-06-26 Thread Vishesh Handa
time plasma is restarted since krunner is already running and executing it then gives it focus. BUG: 336002 This patch depends on another patch in plasma-workspace/krunner which adds the krunner.desktop file - commit 1b570623b1e8df93f20940654e160b35570172ac Author: Vishesh Handa Date

Re: Review Request 118933: PlasmaShell: Do not start krunner

2014-06-25 Thread Vishesh Handa
ing again on autostart files it forces krunner on every shell, having a > > process that may not be used at all. > > > > Vishesh Handa wrote: > I do not understand your comment about "having a process which may not be > used at all". Without this patch, k

<    1   2   3   4   >