Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36523726
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,16 @@ public void pop()
}
}
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/48#issuecomment-128714379
Hi Bozo, sorry for the delay getting back to you, I was a bit
tunnel-visioned trying (and failing :/) to get 0.10 out the door this week.
I like the recent
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36522686
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,16 @@ public void pop()
}
}
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36522483
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,16 @@ public void pop()
}
}
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36521660
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/EventType.java ---
@@ -0,0 +1,42 @@
+/*
+ *
+ * Licensed to the Apache Softwar
Github user boo commented on the pull request:
https://github.com/apache/qpid-proton/pull/48#issuecomment-128358421
@gemmellr I think I have managed to eliminate almost all casts by
delegating half of the dispatch to the handler -- the handler already knows
it's type, no need for
Github user boo commented on the pull request:
https://github.com/apache/qpid-proton/pull/48#issuecomment-127776872
@gemmellr thanks for the review! I think I addressed all the things you
pointed out.
---
If your project is set up for it, you can reply to this email and have your
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/48#issuecomment-127622789
> I'm not sure how this would work, because it's easy (and I think
necessary) to mix and create a tangle > of handlers of different descent in a
tree (or even DAG)
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36189359
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -217,6 +101,19 @@ public void dispatch(Handler handler)
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36188924
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -68,12 +69,19 @@ void clear()
}
@Overri
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36188742
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,13 @@ public void pop()
}
}
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36186389
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -68,12 +69,19 @@ void clear()
}
@Overrid
Github user boo commented on the pull request:
https://github.com/apache/qpid-proton/pull/48#issuecomment-127597879
> Could we use generics to enforce the correct type of handler is supplied
for dispatch and avoid some instanceof checks? (e.g BuiltinEventTypeImpl.java)
I'm
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36182863
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,13 @@ public void pop()
}
}
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36181543
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -68,12 +69,19 @@ void clear()
}
@Overri
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36181146
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -217,6 +101,19 @@ public void dispatch(Handler handler)
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36180425
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,13 @@ public void pop()
}
}
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36180258
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -68,12 +69,19 @@ void clear()
}
@Overrid
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36180019
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -53,9 +54,9 @@
this.type = null;
}
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36179971
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,13 @@ public void pop()
}
}
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36179765
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/BuiltinEventTypeImpl.java
---
@@ -0,0 +1,144 @@
+package org.apache.qpid.proton.
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36179723
--- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/Event.java
---
@@ -80,15 +83,46 @@
SELECTABLE_WRITABLE,
SELECTAB
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36179361
--- Diff:
proton-j/src/test/java/org/apache/qpid/proton/engine/EventExtensibilityTest.java
---
@@ -0,0 +1,381 @@
+package org.apache.qpid.proton.eng
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36179236
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,13 @@ public void pop()
}
}
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36179169
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/BuiltinEventTypeImpl.java
---
@@ -0,0 +1,144 @@
+package org.apache.qpid.proton.e
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36179005
--- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/Record.java
---
@@ -29,6 +29,10 @@
public interface Record
{
+publi
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36178995
--- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/Event.java
---
@@ -80,15 +83,46 @@
SELECTABLE_WRITABLE,
SELECTABL
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36178745
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/BuiltinHandler.java ---
@@ -0,0 +1,71 @@
+/*
+ *
+ * Licensed to the Apache Sof
Github user boo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36178479
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/BuiltinHandler.java ---
@@ -0,0 +1,71 @@
+/*
+ *
+ * Licensed to the Apache Sof
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36177270
--- Diff:
proton-j/src/test/java/org/apache/qpid/proton/engine/EventExtensibilityTest.java
---
@@ -0,0 +1,381 @@
+package org.apache.qpid.proton.eng
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36177254
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/BuiltinEventTypeImpl.java
---
@@ -0,0 +1,144 @@
+package org.apache.qpid.proton.
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/48#issuecomment-127559169
I've commented on the code, but one final random thought:
Could we use generics to enforce the correct type of handler is supplied
for dispatch and avoid so
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36174549
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -217,6 +101,19 @@ public void dispatch(Handler handler)
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36174338
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -53,9 +54,9 @@
this.type = null;
}
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36174376
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -68,12 +69,19 @@ void clear()
}
@Overri
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36174299
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,13 @@ public void pop()
}
}
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36174204
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,13 @@ public void pop()
}
}
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36174093
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/BuiltinEventTypeImpl.java
---
@@ -0,0 +1,144 @@
+package org.apache.qpid.proton.
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36173790
--- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/Record.java
---
@@ -29,6 +29,10 @@
public interface Record
{
+publ
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36173420
--- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/Event.java
---
@@ -80,15 +83,46 @@
SELECTABLE_WRITABLE,
SELECTAB
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36173162
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/BuiltinHandler.java ---
@@ -0,0 +1,71 @@
+/*
+ *
+ * Licensed to the Apache So
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36173016
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/BuiltinHandler.java ---
@@ -0,0 +1,71 @@
+/*
+ *
+ * Licensed to the Apache So
If there are no objections to this, I'll commit this tomorrow
Bozzo
On 29. 07. 15 15.07, boo wrote:
> GitHub user boo opened a pull request:
>
> https://github.com/apache/qpid-proton/pull/48
>
> PROTON-964: Proton-J extensible event types
>
>
>
> You can merge this pull reque
GitHub user boo opened a pull request:
https://github.com/apache/qpid-proton/pull/48
PROTON-964: Proton-J extensible event types
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/boo/qpid-proton proton-964
Alternatively yo
45 matches
Mail list logo
