FieldStorage callback only works with FileType objects in 3.2.7

2006-02-19 Thread Mike Looijmans
There is still trouble with the FieldStorage class. Looks like this one is not really fixed: http://issues.apache.org/jira/browse/MODPYTHON-40 See for a counter example: http://modpython.org/pipermail/mod_python/2006-February/020248.html (remove the "import fmt") It fails with the following trac

Re: How mod_python treats apache.OK/apache.DECLINED response fromhandlers.

2006-02-19 Thread Graham Dumpleton
Jim Gallacher wrote .. > I don't have alot more to say on these last 2 emails. I think you are on > the right path here. Okay, I think I have a good plan now. To summarise the whole issue, the way Apache treats multiple handlers in a single phase for non content handler phases is as follows: P

Re: mod_python 3.2.8 available for testing

2006-02-19 Thread Barry Pederson
+1 FreeBSD 6.0, apache 2.0.55 mpm-prefork, python 2.4.2

Re: Maually adding notes about commits to JIRA.

2006-02-19 Thread Jim Gallacher
Graham Dumpleton wrote: Jim Gallacher wrote .. All very interesting, except that JIRA does record the svn commit info, and with great detail. It just doesn't treat the commit as a comment. For example: http://issues.apache.org/jira/browse/MODPYTHON-124?page=all Personally I think the Subversi

Re: JIRA Housekeeping

2006-02-19 Thread Jim Gallacher
BTW, are we going to put up your developer guidelines anywhere for viewing? http://www.modpython.org/pipermail/mod_python/2005-December/019712.html Until it finds a permanent home the best place to look is here: http://people.apache.org/~jgallacher/mod_python/website-test/developers.html And

Re: Maually adding notes about commits to JIRA.

2006-02-19 Thread Graham Dumpleton
Jim Gallacher wrote .. > All very interesting, except that JIRA does record the svn commit info, > and with great detail. It just doesn't treat the commit as a comment. > > For example: > http://issues.apache.org/jira/browse/MODPYTHON-124?page=all > > Personally I think the Subversion commit info

Re: JIRA Housekeeping

2006-02-19 Thread Graham Dumpleton
Jim Gallacher wrote .. > >>Other JIRA thoughts: > >> > >>Should we have a "unit test" component for bugs in the actual unit test > >>code? > >> > >>Since we plan on having 3.2.x bugfix releases, should create new JIRA > >>versions starting with 3.2.7? > > > > > > No harm in doing so. Probably wou

Re: Maually adding notes about commits to JIRA.

2006-02-19 Thread Jim Gallacher
Graham Dumpleton wrote: Jim Gallacher wrote .. Graham, I don't think it's necessary to add an additional JIRA comment when you commit some code. JIRA will pickup the svn commit as long as the issue number is mentioned in the svn commit message. People can subscribe to python-cvs if they want n

Re: JIRA Housekeeping

2006-02-19 Thread Jim Gallacher
Graham Dumpleton wrote: Jim Gallacher wrote .. Jim Gallacher wrote: Now that 3.2.7 is out, should we be changing the status resolved issues to closed in JIRA. If that is what closed implies. Is there somewhere which states what we should interprete the different status as meaning? I don't

Re: JIRA Housekeeping

2006-02-19 Thread Graham Dumpleton
Jim Gallacher wrote .. > Jim Gallacher wrote: > > Now that 3.2.7 is out, should we be changing the status resolved issues > > to closed in JIRA. If that is what closed implies. Is there somewhere which states what we should interprete the different status as meaning? I don't recollect seeing anyth

Maually adding notes about commits to JIRA.

2006-02-19 Thread Graham Dumpleton
Jim Gallacher wrote .. > Graham, > > I don't think it's necessary to add an additional JIRA comment when you > commit some code. JIRA will pickup the svn commit as long as the issue > number is mentioned in the svn commit message. People can subscribe to > python-cvs if they want notification of t

Re: mod_python 3.2.8 available for testing

2006-02-19 Thread Jim Gallacher
+1 Debian sid, apache 2.0.55 mpm-prefork, python 2.3.5

mod_python 3.2.8 available for testing

2006-02-19 Thread Jim Gallacher
Mod_python 3.2.8 tarball is available for test. This is a security release to fix http://issues.apache.org/jira/browse/MODPYTHON-135. This is a fairly minor change, so we are not going to have an extended testing period. Here are the rules: In order for a file to be officially announced, it

Re: What is test_req_get_basic_auth_pw meant to test.

2006-02-19 Thread Graham Dumpleton
I already fixed the test and checked it in. :-) On 20/02/2006, at 5:15 AM, Jim Gallacher wrote: Yes, this test seems to be broken. I'll create a JIRA issue for it. We need unit tests for the unit tests. :) Jim For my WTF moment, have a look at test_req_get_basic_auth_pw in the test suite. I

Re: JIRA Housekeeping

2006-02-19 Thread Jim Gallacher
Jim Gallacher wrote: Now that 3.2.7 is out, should we be changing the status resolved issues to closed in JIRA. Other JIRA thoughts: Should we have a "unit test" component for bugs in the actual unit test code? Since we plan on having 3.2.x bugfix releases, should create new JIRA versions

JIRA Housekeeping

2006-02-19 Thread Jim Gallacher
Now that 3.2.7 is out, should we be changing the status resolved issues to closed in JIRA. Jim

Re: What is test_req_get_basic_auth_pw meant to test.

2006-02-19 Thread Jim Gallacher
Yes, this test seems to be broken. I'll create a JIRA issue for it. We need unit tests for the unit tests. :) Jim For my WTF moment, have a look at test_req_get_basic_auth_pw in the test suite. I guess it is supposed to be test req.get_basic_auth_pw (), but that function isn't even mentioned a

Re: How mod_python treats apache.OK/apache.DECLINED response from handlers.

2006-02-19 Thread Jim Gallacher
Graham Dumpleton wrote: On 19/02/2006, at 3:24 PM, Graham Dumpleton wrote: Thus depending on what you are doing, you need one or the other. To make it obvious, should perhaps use a distinct method name to add handlers as stacked handlers against the current handler list. Thus: def all(r

mod_python license

2006-02-19 Thread Jim Gallacher
I just notice that a few files still say that mod_python uses Apache License 1.1 (eg htdocs/tests.py, src/psp_string.c). Can I assume this is an error and that *everything* should be version 2.0? Jim

Re: [jira] Commented: (MODPYTHON-124) Improvements associated with the req.ap_auth_type attribute.

2006-02-19 Thread Jim Gallacher
Graham, I don't think it's necessary to add an additional JIRA comment when you commit some code. JIRA will pickup the svn commit as long as the issue number is mentioned in the svn commit message. People can subscribe to python-cvs if they want notification of the commits. This should save

[jira] Commented: (MODPYTHON-124) Improvements associated with the req.ap_auth_type attribute.

2006-02-19 Thread Graham Dumpleton (JIRA)
[ http://issues.apache.org/jira/browse/MODPYTHON-124?page=comments#action_12366957 ] Graham Dumpleton commented on MODPYTHON-124: Changes to add req.auth_name(), req.auth_type() and make req.ap_auth_type writable commited into mod_python SVN tr